summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete/keyword_provider.h
Commit message (Collapse)AuthorAgeFilesLines
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-211-3/+4
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8612007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
* Move NotificationObserver, NotificationSource, and NotificationDetails to ↵jam@chromium.org2011-10-191-7/+7
| | | | | | | | | | | content/public/browser. This patch got way bigger than I wanted, but once I moved NotificationDetails, I figured I might as well mvoe the others since they're in the same files. In hindsight, I should have converted a subset of files at a time by leaving a using statement in the header. BUG=98716 TBR=joi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106196 0039d316-1c4b-4281-b951-d872f2087c98
* Add a URL param to indicate group selection in Instant field trial.sreeram@chromium.org2011-08-161-0/+1
| | | | | | | | | | | | | | | | | Currently, if the user is chosen into an Instant field trial group, this information is not indicated in the suggest or search request URLs. Such a URL param will allow us to analyze experiment metrics from server logs. Most of the changes here are because we need to pass the Profile information through to the Instant field trial code. BUG=91536 TEST=Observe ix=c or ix=e showing up in the URLs sent for suggest/search. Review URL: http://codereview.chromium.org/7558014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96954 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-101-1/+1
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Changes TemplateURLModel into TemplateURLService. Changes all access points ↵erg@google.com2011-06-071-7/+7
| | | | | | | | | | | | | | to go through the newly made ProfileKeyedServiceFactory subclass. In addition, makes further modifications to the unit testing stuff because the TemplateURL tests change the active TemplateURLService on a profile during the test. BUG=77155 TEST=unit tests R=mirandac Review URL: http://codereview.chromium.org/7056056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@88153 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-081-3/+3
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Always allow exact match non-substituting keywords.suzhe@google.com2011-01-261-5/+5
| | | | | | | | | BUG=70807 TEST=See bug report. Review URL: http://codereview.chromium.org/6334017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72586 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from autocomplete.avi@chromium.org2011-01-251-11/+11
| | | | | | | | | | | Recommit of r72380. BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6306011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72492 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 72380 - Remove wstring from autocomplete.avi@chromium.org2011-01-241-11/+11
| | | | | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6256010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72385 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstring from autocomplete.avi@chromium.org2011-01-241-11/+11
| | | | | | | | | BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6258015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72380 0039d316-1c4b-4281-b951-d872f2087c98
* Fix several omnibox issues related to keyword mode and IME support.suzhe@google.com2011-01-131-2/+9
| | | | | | | | | | | | | | | | | | | | | | | This CL contains following changes to omnibox code: 1. Make sure |keyword_ui_state_| is always updated correctly, i.e. it should always be KEYWORD when keyword UI is visible. 2. Make sure |keyword_ui_state_| will never be changed during IME composition. 3. Make sure OnInlineAutocompleteTextMaybeChanged() will only be called when inline autocomplete suggest is changed. This CL fixes following bugs. Old fix for bug 2720 and 3798 has been removed. BUG=2720 BUG=3798 BUG=39947 BUG=62426 TEST=See bug reports. Review URL: http://codereview.chromium.org/6131005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71268 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-081-3/+3
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow exact keyword matches for most uses of the autocomplete ↵pkasting@chromium.org2010-11-101-1/+4
| | | | | | | | | | classifier. Patch by Naoki Takano (see http://codereview.chromium.org/4142006 ), r=me. BUG=60059 TEST=Change a search engine keyword to "a", highlight text beginning with "a" in a webpage (e.g. "a movie"), right-click and select "Search Google for a movie". The result should be a Google search page, not a result page for whatever search engine has the keyword "a". Review URL: http://codereview.chromium.org/4717001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65706 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Continue fixing nits found by my automated source scanner.erg@google.com2010-10-051-1/+1
| | | | | | | | | | | (~1.3 megs off Debug linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Header cleanup in chrome/common part 2. The majority of the changed filesjhawkins@chromium.org2010-08-201-0/+1
| | | | | | | | | | | just added notification_observer.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/3120021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56824 0039d316-1c4b-4281-b951-d872f2087c98
* Disable autocomplete for search keywords.isherman@chromium.org2010-08-171-1/+1
| | | | | | | | | | | We have custom UI for search keywords anyway, so in practice a user would never see the autocompleted url. But, we had been computing the index incorrectly in some cases, as we trim off "http://" and "www." to compute the keyword. Since we don't use it anyway, simplify the logic and get rid of it :) BUG=none TEST=none Review URL: http://codereview.chromium.org/3151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56445 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Fix some presubmit errors.tfarina@chromium.org2010-07-281-3/+2
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3026031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54020 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for omnibox.onInputStarted and onInputCancelled.mpcomplete@chromium.org2010-07-021-2/+12
| | | | | | | | | | | | Also fix a bug where we'd keep an extension's old keyword even if it changed on upgrade/reload. BUG=46475 BUG=48091 Review URL: http://codereview.chromium.org/2807033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51540 0039d316-1c4b-4281-b951-d872f2087c98
* Use DISALLOW_COPY_AND_ASSIGN instead of DISALLOW_EVIL_CONSTRUCTORS in chrome ↵tfarina@chromium.org2010-06-061-1/+1
| | | | | | | | | | | directory. BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2657003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49024 0039d316-1c4b-4281-b951-d872f2087c98
* First pass at experimental omnibox API. There are plenty of rough edges and ↵mpcomplete@chromium.org2010-05-281-3/+28
| | | | | | | | | | | | | | | features to work on, but it's in a usable state. When an extension is installed that specifies an omnibox keyword in its manifest, we add that keyword to the user's list of Search Engines. The user can then edit this keyword later. I'm leveraging most of the original search engine keyword code. An extension keyword has a special URL that identifies it as an extension keyword. There is some special case code to treat these keywords slightly differently throughout the omnibox code. BUG=38884 Review URL: http://codereview.chromium.org/2078021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48503 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-061-0/+2
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-061-2/+0
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-0/+2
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/361025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the omnibox show past searches and suggestions for keywords.sky@chromium.org2009-04-141-1/+18
| | | | | | | | | | | | | | | We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Review URL: http://codereview.chromium.org/66073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13668 0039d316-1c4b-4281-b951-d872f2087c98
* Misc formatting / cleanup in the autocomplete code.deanm@chromium.org2009-02-271-16/+9
| | | | | | | | | | | | | | - Reformat / reword some comments. - Update include guards to the new style. - Remove trailing blank lines from end of files. - Clean up some includes. - Pull the CompareQuality functor into the implementation. - Pull kQueryDelayMs into the implementation. Review URL: http://codereview.chromium.org/27206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10603 0039d316-1c4b-4281-b951-d872f2087c98
* Move |result_| and |latest_result_| to the autocomplete controller.pkasting@chromium.org2008-10-091-2/+1
| | | | | | | This purposefully does not change the communication interface between the edit and the popup; that's coming in a subsequent pass. As a result, right now the popup isn't really much simpler. That should eventually change. Review URL: http://codereview.chromium.org/6596 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3113 0039d316-1c4b-4281-b951-d872f2087c98
* This file was supposed to get committed during my last refactoring chunk but ↵pkasting@chromium.org2008-10-081-3/+4
| | | | | | | | got left out by mistake. Review URL: http://codereview.chromium.org/5659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3061 0039d316-1c4b-4281-b951-d872f2087c98
* Use a more compact license header in source files.license.bot2008-08-241-28/+4
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98
* Add chrome to the repository.initial.commit2008-07-261-0/+132
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 07:09:28 +0000