summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Update result formatting for the search provider for the Omnibox2 popup.ben@chromium.org2009-06-091-19/+70
| | | | | | | | | | | I've kept the old style in there now too since we have --disable-omnibox2 for a short while so QA can compare if necessary. http://crbug.com/13647 TEST=suggestion completions should be bolded in the omnibox2 dropdown. the first "Search Google For" item should now read "<query> - Search Google" (or whatever your default search engine is). Review URL: http://codereview.chromium.org/119341 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17997 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where hitting enter in the Omnibox would ignore recent editing.pkasting@chromium.org2009-06-084-17/+29
| | | | | | | | | | Sadly, the only way I could find to fix this was a latest_result() accessor, because when the user hits enter, we really do need to use the very latest results. This just highlights how more of this stuff should move to the AutocompleteController. BUG=13428 TEST=Type "food.c" and wait for the popup to stabilize. Then _very_ quickly type "om" and hit enter. You should navigate to food.com instead of searching for "food.c". Review URL: http://codereview.chromium.org/118398 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17891 0039d316-1c4b-4281-b951-d872f2087c98
* Hack around klipper / glipper clipboard races.deanm@chromium.org2009-06-082-1/+19
| | | | | | | | | | | | | | | | | | | | | | | I don't completely understand the problem, but I hacked up glipper to dump what was going on. It watches the primary clipboard ownership changes, then waits for the clipboard contents. There are some races there and then it eats our selection. The solution, which isn't great, is to disable the primary selection around setting up the inline autocomplete selection. This means that the primary selection is the full text and not just the inlined portion, but I don't see a huge case for using the autocompleted portion as the primary selection anyway. The other clipboard (ctrl-c / ctrl-v) should work the same as before. BUG=11956 TEST=That inline autocomplete works correctly like it did before. It should now also work correctly with glipper / klipper running. Review URL: http://codereview.chromium.org/119170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17851 0039d316-1c4b-4281-b951-d872f2087c98
* Completely miscellaneous minor cleanup. Remove some unneeded class ↵pkasting@chromium.org2009-06-051-4/+3
| | | | | | | | declarations, modify or add a couple comments, change a function name in hopes of greater accuracy. Review URL: http://codereview.chromium.org/119264 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17798 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flicker that happened when hitting ctrl while in FORCED_QUERY mode. We ↵pkasting@chromium.org2009-06-051-4/+10
| | | | | | | | | | were comparing an input that had the "?" stripped off to one which didn't and thus never setting |minimal_changes| = true. BUG=13295 TEST=Type "?foo" into the omnibox. Then hit the ctrl key. The box should not flicker at all when pressing and releasing ctrl. Review URL: http://codereview.chromium.org/118325 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17774 0039d316-1c4b-4281-b951-d872f2087c98
* Better behavior for ctrl-k: If we're already in forced_query mode, re-select ↵pkasting@chromium.org2009-06-056-1/+37
| | | | | | | | | | the query text instead of clearing the box. BUG=6985 TEST=Press ctrl-k, type "foo", press ctrl-k again. The omnibox should show "?foo" with "foo" selected. Review URL: http://codereview.chromium.org/119135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17757 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore selections where the user dragged off the popup.shess@chromium.org2009-06-051-3/+11
| | | | | | | | | http://crbug.com/13107 TEST=Start typing in omnibox. Click in the popup and drag mouse off before releasing. Shouldn't crash. Review URL: http://codereview.chromium.org/112097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17741 0039d316-1c4b-4281-b951-d872f2087c98
* Don't update our text from toolbar if the toolbar's text doesn'tshess@chromium.org2009-06-041-5/+13
| | | | | | | | | | | | | | | | | visibly differ from the model's text. In most cases, this doesn't come up, because focus is usually not in the field (so there wouldn't be local changes), but when opening NTP you can type between when the tab opens in the browser and when the renderer finishes loading it. In that case, the model and toolbar both have "" as the url text, so this case is hit. http://crbug.com/13109 TEST=Browse to www.google.com. Command-t for new tab and type http as fast as you can. Before this fix, you sometimes got "tp" or something of the sort. Review URL: http://codereview.chromium.org/119125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17662 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a ctrl-enter change for Omnibox, it made inline autocomplete totally ↵deanm@chromium.org2009-06-041-10/+1
| | | | | | | | | | | | | | | | | | | | | | | crazy. For example, pressing ctrl while you have an inline autocomplete toggles the autocomplete on and off, etc. commit 51b37c5ce628836b22f68aa94ad871ce8cb1f66b Author: estade@chromium.org <estade@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> Date: Mon Jun 1 21:38:11 2009 +0000 GTK: respect control key for setting TLD=com. BUG=13096 Review URL: http://codereview.chromium.org/118086 git-svn-id: svn://chrome-svn/chrome/trunk/src@17356 0039d316-1c4b-4281-b951-d872f2087c98 Review URL: http://codereview.chromium.org/119169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17628 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash due to AutocompletePopup trying to draw the old results when they ↵pkasting@chromium.org2009-06-034-15/+19
| | | | | | | | were no longer available.I introduced this regression when moving |result_| to the AutocompleteController; the specific problem was the "result_.CopyFrom(latest_result_);" line I added when handling the synchronous messages being available. This was done so the popup could get at the new results to update the edit with them.Instead, go back to the old method (of not updating the results until the first coalesced update came in), and pass the appropriate result set as a Details<> in the notification, so the popup can get at it without having to know how the controller works under-the-hood.BUG=11742 Review URL: http://codereview.chromium.org/119116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17562 0039d316-1c4b-4281-b951-d872f2087c98
* Some previous refactoring I did of the accelerator code had introduced ↵jcampan@chromium.org2009-06-032-8/+44
| | | | | | | | regressions (pressing ESC would close the dialog instead of closing an opened combo-box, pressing enter on a dialog with a focused link would not open the link).Looking at fixing these I realized the method View::OvverideAccelerator was not needed anymore as View::SkipDefaultKeyEventProcessing supersedes it.So I removed View::OvverideAccelerator. As a result I also ended up moving some Windows specific code from LocationbarView to AutocompleteEditViewWin.BUG=6900TEST=Open the option dialog, click on a combo-box to open the drop-down list. Press ESC, the drop-down list should be closed. Move the focus to a link (by pressing Tab). Press Enter, the link should be opened and the option dialog should not be closed. Make sure that accelerators (ESC, tab, key up/down...) still work ok in the omnibox) Review URL: http://codereview.chromium.org/119016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17544 0039d316-1c4b-4281-b951-d872f2087c98
* Port 2 more unit tests. Just small differences between platforms.tc@google.com2009-06-031-0/+5
| | | | | | | | | | This allows password_form_manager_unittest.cc and search_provider_unittest.cc to run on linux/mac. Review URL: http://codereview.chromium.org/118137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17497 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-037-13/+12
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Flip omnibox2 popup on by default for more testing.ben@chromium.org2009-06-011-5/+4
| | | | | | Review URL: http://codereview.chromium.org/115980 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17363 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: respect control key for setting TLD=com.estade@chromium.org2009-06-011-1/+10
| | | | | | | BUG=13096 Review URL: http://codereview.chromium.org/118086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17356 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-291-2/+12
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore the insert key so we don't switch into overtype mode (which surprises ↵pkasting@chromium.org2009-05-291-0/+5
| | | | | | | | | | users since there's no indicator of it). BUG=6856 TEST=In Omnibox or in a native textfield (e.g. the "Add a site" URL field for the Options dialog's "Open these sites at startup" pref), type text, set cursor at beginning, hit insert, and type. Your text should prepend to the existing text instead of replacing it. Review URL: http://codereview.chromium.org/115934 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17231 0039d316-1c4b-4281-b951-d872f2087c98
* Hoist TrimHttpPrefix() so we only have one copy, not one per provider.pkasting@chromium.org2009-05-298-55/+37
| | | | | | | | | Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately. BUG=10558 Review URL: http://codereview.chromium.org/115885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17145 0039d316-1c4b-4281-b951-d872f2087c98
* Treat alt-(arrows/pgup/pgdn) like alt was not pressed. There's no reason to ↵pkasting@chromium.org2009-05-291-1/+2
| | | | | | | | | | ignore these keypresses. BUG=6992 TEST=Type a letter so the omnibox dropdown shows. Press alt-down. If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear). If you used the standalone arrow keys, the selection should move down one row. Review URL: http://codereview.chromium.org/115891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17144 0039d316-1c4b-4281-b951-d872f2087c98
* Don't make |field_| first responder in SetSelectedRange() unless |model_| ↵shess@chromium.org2009-05-232-19/+30
| | | | | | | | | | | | has_focus already. http://crbug.com/11920 TEST=Browser to www.google.com, focus is in search field, bring up new tab, click back to first tab, focus should be in search field. TEST=Select messages in gmail, focus should NOT go to autocomplete field (omnibox, url bar). Review URL: http://codereview.chromium.org/113751 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16823 0039d316-1c4b-4281-b951-d872f2087c98
* Overhaul omnibox focus detection on Mac.shess@chromium.org2009-05-222-28/+87
| | | | | | | | | | | | | | | | | | | | | Rather than aiming to detect acquisition and loss of focus in |field_|, just acknowledge that there are cases where |field_| has focus but |model_| doesn't know. If |field_| has focus but no editing has been done, then |model_| will take no action, so this is reasonable. Window resigning key just closes the popup, and doesn't affect |model_| focus. Thus, there is no need to deal with acquiring focus when the window becomes key again, and we can live fine within the constraints of -*DidBeginEditing: and -*ShouldEndEditing:. Added checks for |field_| being focussed in all the relevant places. http://crbug.com/12338 Review URL: http://codereview.chromium.org/113746 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16776 0039d316-1c4b-4281-b951-d872f2087c98
* Shows Unicode IDN instead of Punycode in the followings:brettw@google.com2009-05-222-8/+5
| | | | | | | | | | | | | | | | | | | - Bookmark Manager - Edit Bookmark dialog opened by Bookmark Manager - Edit Bookmark dialog opened by the star on the left of the address bar Introduces new function, net::FormatUrl(), which has the following parameters in addition to gfx::GetCleanStringFromUrl(). - bool omit_username_password - bool unescape and moves gfx::GetClienStringFromUrl() to net:: namespace, and removed the last two parameters. BUG=3991 Checked in for tkent Original review = http://codereview.chromium.org/115346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16761 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Fix so the omnibox popup doesn't show all tiny first time.shess@chromium.org2009-05-221-9/+8
| | | | | | | | | | | Also improve the code which sizes the popup. http://crbug.com/12324 TEST=In previous release, start typing in omnibox. Should see a 6-pixel-tall or so popup which is quickly replaced with the real popup. With this fix, should not see the incorrect version. Review URL: http://codereview.chromium.org/113644 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16758 0039d316-1c4b-4281-b951-d872f2087c98
* Gets LocationBarView to compile on linux. PageInfoWindow is nearlysky@chromium.org2009-05-211-2/+2
| | | | | | | | | | | there too, but needs Separator to actually completely compile. BUG=none TEST=none Review URL: http://codereview.chromium.org/113720 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16660 0039d316-1c4b-4281-b951-d872f2087c98
* mac_util::SetOverrideAppBundle() are handled in class ChromeTestSuite.jrg@chromium.org2009-05-201-10/+0
| | | | | | | | | They should not be modified here (and especially should not be undone in TearDown since it breaks things for following unit tests). Review URL: http://codereview.chromium.org/115554 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16530 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Modify Omnibox to notice when the window loses key, too.shess@chromium.org2009-05-202-2/+34
| | | | | | | | | http://crbug.com/12252 TEST=Type "word" in omnibox. Click on some other window. Popup should dissappear. Review URL: http://codereview.chromium.org/115573 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16488 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make sure the popup is closed when losing focus in omnibox.shess@chromium.org2009-05-201-1/+7
| | | | | | | | | | | | | Moved detection from -controlTextDidEndEditing: to -control:textShouldEditEditing: in case any of the code depends on still having focus when this happens. http://crbug.com/12252 TEST=Type "word" in omnibox. Click on page. Popup should dissappear. Review URL: http://codereview.chromium.org/116006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16441 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at forcing the foreground and background color of thetc@google.com2009-05-192-1/+14
| | | | | | | | | | | | | | omnibox text. I used a static for the black text tag, but we need a separate instance per omnibox (one per browser window). BUG=11450 Review URL: http://codereview.chromium.org/115521 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16393 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Force the foreground and background color of the omnibox text."tc@google.com2009-05-191-14/+1
| | | | | | | | | | | | | This reverts commit r16383. Session restore fails with this change. TBR=willchan Review URL: http://codereview.chromium.org/115519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16387 0039d316-1c4b-4281-b951-d872f2087c98
* Force the foreground and background color of the omnibox text.tc@google.com2009-05-191-1/+14
| | | | | | | | | | | I didn't bother messing with the selection color or cursor color. BUG=11450 Review URL: http://codereview.chromium.org/115496 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16383 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an index over bookmark titles for fast look up.sky@chromium.org2009-05-191-2/+2
| | | | | | | | | | | | | The index is currently built on the main thread (because that's where we do the decoding now), but I'll change that after landing this. BUG=6646 TEST=There are tests to cover this, but make sure the omnibox still suggests bookmark titles. Review URL: http://codereview.chromium.org/115403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16357 0039d316-1c4b-4281-b951-d872f2087c98
* Force the font size in the omnibox, tabs, find bar, and download shelftc@google.com2009-05-182-1/+6
| | | | | | | | | | | | | so we don't get layout overflow issues. Ideally, we would have vector graphics for buttons and stuff so this wouldn't be an issue, but for now, this will have to do. BUG=11128 Review URL: http://codereview.chromium.org/113546 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16327 0039d316-1c4b-4281-b951-d872f2087c98
* Allow IPv6 literals to be typed directly into the address bar, withoutabarth@chromium.org2009-05-182-1/+9
| | | | | | | | | | | | | | | | | | requiring a preceding http://. The square brackets are still needed, though. Fix some of the style problems in url_fixer_upper.cc: - Multi-line if should have {}s - "using namespace" is bad. Patch by pmarks@google.com. R=abarth TEST=New unit tests. http://codereview.chromium.org/113509 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16267 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Style the omnibox URL.shess@chromium.org2009-05-152-61/+139
| | | | | | | | | | | | | | | | | | | | | Cribbed this mostly from GTK, including taking their colors pretty directly. The hostname in the URL is a stronger color than the rest of the URL to call it out. The https: scheme is also called out specially. The background color changes when secure. Also cleaned up the selection-setting so that there are distinct code paths for updating the field and setting the selection. Also fixed saving of selection across popup navigation via arrow keys. Also sprinkled some const jimmies while I was in there. http://crbug.com/10939 TEST=Type an URL, does the hostname highlight versus the rest? Do secure URLS look different? Review URL: http://codereview.chromium.org/113479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16201 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 11683.hbono@chromium.org2009-05-151-0/+9
| | | | | | | | | | I noticed this issue is caused by the IMF_AUTOKEYBOARD option of a RichEdit control, an option that allows a RichEdit control to automatically change the input language with a selection. (An omnibox changes a selection to display a styled text.) A RichEdit control automatically turns on the IMF_AUTOKEYBOARD option when we input an RTL character and start changing the input language with a selection. So, this change checks the IMF_AUTOKEYBOARD option and disable it before decorating a text to prevent it from changing the input language while decorating a text. BUG=11683 "RTL: IME changes when writing a Hebrew character inside an English string in the omnibox" TEST=Change the input language to English, type "abcd" in an omnibox, change the input language to Hebrew, type an 'a' key, and verify the input language is Hebrew. Review URL: http://codereview.chromium.org/113394 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16154 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeCanvas->gfx::Canvasben@chromium.org2009-05-155-8/+8
| | | | | | | | | | | Rename files too. TBR=brettw http://crbug.com/11387 Review URL: http://codereview.chromium.org/113443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16148 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFont->gfx::Fontbeng@google.com2009-05-156-22/+22
| | | | | | | | | | Does not rename the files yet. http://crbug.com/11387 Review URL: http://codereview.chromium.org/113441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98
* Use the Mac omnibox field's font as the basis for the fonts used in the ↵shess@chromium.org2009-05-144-51/+77
| | | | | | | | | | | | | field and popup. NSAttributedString has fixed default font, unless overridden, this basically makes the font used consistent with the field size. Theming will most likely change this again, but we can be prettier in the meanwhile. Review URL: http://codereview.chromium.org/115334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16112 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors menus so that I can create a MenuGtk implementation, and moves it intosky@chromium.org2009-05-142-3/+3
| | | | | | | | | | | | the namespace views. BUG=none TEST=make sure I haven't broken any menus. This impacts all menus in Chrome, except bookmark ones. Review URL: http://codereview.chromium.org/113410 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16100 0039d316-1c4b-4281-b951-d872f2087c98
* Provide one set of mac common app name defines for things that need the name ↵thomasvl@chromium.org2009-05-141-2/+3
| | | | | | | | | of mac app on disk. Update a used of names to use those new common ones. Review URL: http://codereview.chromium.org/115359 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16074 0039d316-1c4b-4281-b951-d872f2087c98
* Clean-up of the accelerator code.jcampan@chromium.org2009-05-141-2/+2
| | | | | | | | | | | | | | | The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing. This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators. Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused. BUG=11538 TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus. Also test that tab traversal still work as expected in the browser and in the option dialog. Review URL: http://codereview.chromium.org/113307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Address Mike's last complaint about Issue 114017.shess@chromium.org2009-05-121-3/+5
| | | | | | | | | | http://codereview.chromium.org/114017 Add comment about operation of PropertyAccessor<> instance. Review URL: http://codereview.chromium.org/113275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15867 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome facilities for omnibox state save and restore on Mac.shess@chromium.org2009-05-112-21/+120
| | | | | | | | | | | | | | | | | TabContents has a facility for storing a bag of stuff across current-tab changes. Wire up AutocompleteEditViewMac to use that facility. Unfork some code in Browser::TabSelectedAt() so that the new code gets used, and straighten up the Mac code along the code path between there and AutocompleteEditViewMac. This overall change also exposed a couple bugs/mis-features in the AutocompleteEditViewMac code. TEST=Text field maintains contents and selection across tab changes, even when edited. Review URL: http://codereview.chromium.org/114017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where exact-match URLs could fail to be promoted when longer ↵pkasting@chromium.org2009-05-113-31/+53
| | | | | | | | | | | URLs were typed more. We should alwys look up whether we have an exact match, regardless of the input type, and use it if we have it. My change to not add the "exact match" entry for UNKNOWN input should have only affected the case where that match doesn't, in fact, exist. BUG=1844093 Review URL: http://codereview.chromium.org/113223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15786 0039d316-1c4b-4281-b951-d872f2087c98
* Style the omnibox results for v2.shess@chromium.org2009-05-113-12/+535
| | | | | | | | | | The style is based on the gtk code (autocomplete_popup_view_gtk.cc), with some local tweaks. I broke this off from the rest of the review so I could experiment with making it nail omnibox-v2, but eventually realized that I don't have enough data for that. This at least makes things look nicer, and I believe it provides all of the function that will be needed (the remainder is precisely defining fonts and colors and possibly minor highlighting variations). Summary: I want something concrete so that complaints about v2 wrongness can be specific. Review URL: http://codereview.chromium.org/99312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15777 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-081-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-083-3/+3
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-084-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Move pgup/dn special casing to browser window gtk.estade@chromium.org2009-05-071-19/+0
| | | | | | Review URL: http://codereview.chromium.org/112006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15586 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-15 12:42:18 +0000