summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Moves TabStripModelObserver/Delegate into their own headers.sky@chromium.org2010-09-161-0/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3425009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of match preview tweaks:sky@chromium.org2010-09-142-7/+5
| | | | | | | | | | | | | | | | . Makes MatchPreview owned by Browser rather than each TabContents. . Makes MatchPreview dismiss when the omnibox closes. . Supports the ability to send script to the page rather than reloading on every keystroke. . Supports receiving results from the page that drives the suggest text in the omnbox. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3332022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for the location bar to show suggested text. There aresky@chromium.org2010-09-114-2/+76
| | | | | | | | | | | still a couple of rough edges, but this is a good start. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3333027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59192 0039d316-1c4b-4281-b951-d872f2087c98
* Handle FocusSearch() when in forced search mode with leading whitespace.isherman@chromium.org2010-09-119-8/+146
| | | | | | | | | BUG=29593 TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.FocusSearch Review URL: http://codereview.chromium.org/3280012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59183 0039d316-1c4b-4281-b951-d872f2087c98
* Step 3 integrating the HistoryQuickProvider: Implement searching and ↵mrossetti@chromium.org2010-09-091-5/+2
| | | | | | | | | | | production of search results in the InMemoryURLIndex. Unit test the production of results. Minor change in URLHistoryProvuder unit test setup. BUG=None TEST=None (unit tests added) Review URL: http://codereview.chromium.org/3364004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58955 0039d316-1c4b-4281-b951-d872f2087c98
* Fix spacing for extension omnibox keyword icons.mpcomplete@chromium.org2010-09-081-1/+1
| | | | | | | | | BUG=51981 TEST=no Review URL: http://codereview.chromium.org/3266015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58872 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 8)thestig@chromium.org2010-09-081-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3232003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58794 0039d316-1c4b-4281-b951-d872f2087c98
* Update the Preconnect logic to use the new HttpStreamFactory formbelshe@chromium.org2010-09-031-2/+2
| | | | | | | | | | | | | | | | creating connections rather than doing it manually. With this update, I believe we no longer need to avoid preconnects through proxies. The new logic can handle that case. Also updated the predictor_api slightly for the next wave of work. BUG=none TEST=existing Review URL: http://codereview.chromium.org/3226011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58464 0039d316-1c4b-4281-b951-d872f2087c98
* Re-lands 58186:bryeung@chromium.org2010-09-032-41/+41
| | | | | | | | | | | | | | | | | | | | Original message: """ Move the keyboard files from base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 """ TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3354005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58438 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from ↵akalin@chromium.org2010-09-022-41/+41
| | | | | | | | | | | | | | | | | | | | | base/ to app/. Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 TBR=bryeung@chromium.org Review URL: http://codereview.chromium.org/3337006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58390 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58215 - Revert 58186 - Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-022-41/+41
| | | | | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/3361003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58388 0039d316-1c4b-4281-b951-d872f2087c98
* OS X: Clicking on search keyword autocomplete result should update the omniboxisherman@chromium.org2010-09-012-1/+9
| | | | | | | | | BUG=54052 TEST=none Review URL: http://codereview.chromium.org/3300004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58264 0039d316-1c4b-4281-b951-d872f2087c98
* Handle ctrl press when arrowing to a search keywordisherman@chromium.org2010-09-011-2/+3
| | | | | | | | | BUG=44591,18431 TEST=none Review URL: http://codereview.chromium.org/3322001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58263 0039d316-1c4b-4281-b951-d872f2087c98
* Don't treat input with a scheme that's not "http" or "https" as a potential ↵pkasting@chromium.org2010-09-012-5/+12
| | | | | | | | | | keyword search. BUG=27038 TEST=Type in "site:yahoo.com foo". You should not go into keyword search mode. Review URL: http://codereview.chromium.org/3259010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58248 0039d316-1c4b-4281-b951-d872f2087c98
* Make history provider ranking stable for "visited but untyped" intranet URLs.pkasting@chromium.org2010-09-011-1/+12
| | | | | | | | BUG=6905 TEST=Start with a clean profile; open a test file with a link to an intranet site (e.g. "http://m/"); click the link; type "m" in the address bar and watch the dropdown to ensure the default match doesn't change as results come in. Review URL: http://codereview.chromium.org/3284009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58233 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 58186 - Move the keyboard files from base/ to app/.phajdan.jr@chromium.org2010-09-012-41/+41
| | | | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 TBR=bryeung@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58215 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Move more ctors/dtors from headers to implementation.erg@google.com2010-09-014-19/+30
| | | | | | | | | | | | | | | | | - Adding/Moving dtors of objects that have CancelableRequestConsumers shaves three megs off browser.a. - Adding/Moving dtors of objects that have ScopedRunnableMethodFactories only shaved 100k off browser.a/renderer.a. - Adding/Moving dtors of objects that used some form of base::*Timer<> was negligible; there were only a few classes that had a Timer but had a ctor/dtor in the header after the previous cleanups. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3278006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58192 0039d316-1c4b-4281-b951-d872f2087c98
* Move the keyboard files from base/ to app/.bryeung@chromium.org2010-09-012-41/+41
| | | | | | | | | | | Also moves the associated classes/enums from base:: to app::. TEST=try bots compile BUG=NONE Review URL: http://codereview.chromium.org/3165064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58186 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some additional AutocompleteEditController methods. They aresky@chromium.org2010-09-015-5/+45
| | | | | | | | | | | currently views only, but that will change once everything is working. BUG=none TEST=none Review URL: http://codereview.chromium.org/3272009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58180 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the number of files that recompile when changing template_url.h or ↵levin@chromium.org2010-08-313-4/+5
| | | | | | | | | | | | | | | | | | template_url_model.h. Separated out the TemplateURL::IDType which is now TemplateURLId into its own file, since this was a primary reason for including template_url.h in another header. Similarly separate out the TemplateURLModelObserver from template_url_model.h to reduce how often that file is included. BUG=None TEST=Compiling. Review URL: http://codereview.chromium.org/3270011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58080 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring FormatUrl() functions (and convert remaining users to the ↵viettrungluu@chromium.org2010-08-312-11/+11
| | | | | | | | | | | | | string16 verison). Still to do: Actually convert the code underlying FormatUrl(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3263005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57968 0039d316-1c4b-4281-b951-d872f2087c98
* Move Google-specific code under browser/ into browser/google/.evan@chromium.org2010-08-302-2/+2
| | | | | | | | | BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3280008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57922 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the wstring TreeModelNode::GetTitle() and rename GetTitleAsString16() ↵viettrungluu@chromium.org2010-08-301-1/+2
| | | | | | | | | | | to GetTitle(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3279005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57834 0039d316-1c4b-4281-b951-d872f2087c98
* Don't inline autocomplete when the selected text is not the previously ↵isherman@chromium.org2010-08-265-4/+10
| | | | | | | | | | | inline autocompleted text. BUG=7894 TEST=none Review URL: http://codereview.chromium.org/3136036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57592 0039d316-1c4b-4281-b951-d872f2087c98
* Move prefs-related files under chrome/browser/ into a prefs/ subdir.evan@chromium.org2010-08-263-3/+3
| | | | | | | | | | | | Rename includes, resort header include order in places where the rename changed the order. BUG=50548 TEST=compiles Review URL: http://codereview.chromium.org/3203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
* Ctrl-based actions should take precedence over ctrl-enterisherman@chromium.org2010-08-255-12/+67
| | | | | | | | | | | | | When the user presses ctrl, prefer (keeping) inline autocomplete matches to (new, surprising) exact matches that include the desired TLD. BUG=52566 TEST=none Review URL: http://codereview.chromium.org/3152029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57293 0039d316-1c4b-4281-b951-d872f2087c98
* chromeos: Update autocomplete popup colors.derat@chromium.org2010-08-251-19/+8
| | | | | | | | | | | | This fetches them from GTK using the same logic as is used in the GTK port. BUG=chromium-os:3916 TEST=built and ran it for GTK and Chrome OS Views Review URL: http://codereview.chromium.org/3198013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57271 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ui_test_utils::SendAndWaitForKeyPress and converts callers (wheresky@chromium.org2010-08-231-4/+3
| | | | | | | | | | | | appropriate) to use it. Hopefully this will help isolate why tests are failing on bot. BUG=none TEST=none; test only change. Review URL: http://codereview.chromium.org/3117030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57064 0039d316-1c4b-4281-b951-d872f2087c98
* History provider: style cleanupisherman@chromium.org2010-08-215-23/+143
| | | | | | | | | | | BUG=none TEST=it compiles Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56939 Review URL: http://codereview.chromium.org/3177020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56981 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land r56742 now with correct database filesbrettw@chromium.org2010-08-214-7/+14
| | | | | | | | | | | | | | | | A new field to describe the sources of history urls(visits) is added. This field is recorded in visit_database. So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries. In the future, history extension API may allow queries to combinate with this criterion. BUG=none TEST=Unit tests are already included. Please test the web browser with history from previous versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the sources added to the visit_source table in hitory database are correct. Original review: http://codereview.chromium.org/2906004/show Patch by weili@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56971 0039d316-1c4b-4281-b951-d872f2087c98
* Marked OmniboxApiTest.Basic and AutocompleteBrowserTest.Autocomplete flaky ↵zelidrag@chromium.org2010-08-211-1/+10
| | | | | | | | | | | on ChromeOS. Both test fail consistently in autotest runs while manual run with --gfilter_test seems to be OK. BUG=52928,52929 TEST=make sure these two test don't cause autotest to fail anymore Review URL: http://codereview.chromium.org/3150027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56952 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56939 - History provider: style cleanupthestig@chromium.org2010-08-205-151/+24
| | | | | | | | | | | | BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/3177020 TBR=isherman@chromium.org Review URL: http://codereview.chromium.org/3192006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56943 0039d316-1c4b-4281-b951-d872f2087c98
* History provider: style cleanupisherman@chromium.org2010-08-205-24/+151
| | | | | | | | | BUG=none TEST=it compiles Review URL: http://codereview.chromium.org/3177020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56939 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Header cleanup in chrome/common part 2. The majority of the changed filesjhawkins@chromium.org2010-08-204-0/+4
| | | | | | | | | | | just added notification_observer.h. BUG=none TEST=none Review URL: http://codereview.chromium.org/3120021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56824 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r56483 - Monitor network change in GoogleURLTrackerukai@chromium.org2010-08-201-0/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | It changes to fetch https://www.google.com/searchdomaincheck?format=domain&type=chrome instead of checking http://www.google.com/ redirection. Also show infobar if google domain has been changed to new domain and ask user to switch new domain. Fix Win IO Perf regressions: - GoogleURLTracker::RequestServerCheck() is not called in headless mode (CHROME_HEADLESS=1) nor in Chrome Frame (--chrome-frame). Fix leaks in TestingProfile::CreateRequestContext(): 52562 - Add TestURLFetcher::set_request_context() do nothing, because TestURLFetcher might miss to release core_->request_context_getter_. Fix GoogleURLTracker observer removal DCHECK: 52608 - call RemoveAll(), instead of calling Remove()s BUG=48688,15141,52477,52562,52608 TEST=unit_tests passes Review URL: http://codereview.chromium.org/3171019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56811 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 56742 - A new field to describe the sources of history urls(visits) ↵brettw@chromium.org2010-08-194-14/+7
| | | | | | | | | | | | | | | | | | | is added. This field is recorded in visit_database. So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries. In the future, history extension API may allow queries to combinate with this criterion. BUG=none TEST=Unit tests are already included. Please test the web browser with history from previous versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the sources added to the visit_source table in hitory database are correct. Original review=http://codereview.chromium.org/2906004/show Patch by weili@google.com TBR=brettw@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56754 0039d316-1c4b-4281-b951-d872f2087c98
* A new field to describe the sources of history urls(visits) is added. This ↵brettw@chromium.org2010-08-194-7/+14
| | | | | | | | | | | | | | | | | field is recorded in visit_database. So far, it can tell imported, synchronized, entension added or other(mainly testing) entries from user browsed entries. In the future, history extension API may allow queries to combinate with this criterion. BUG=none TEST=Unit tests are already included. Please test the web browser with history from previous versions to make sure the migration could be done properly. Also try to import or sync some history and inspect the sources added to the visit_source table in hitory database are correct. Original review=http://codereview.chromium.org/2906004/show Patch by weili@google.com git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56742 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove unneeded headers from base/ (part 6)thestig@chromium.org2010-08-191-1/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3093013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56641 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove a few SkBitmap instances (and other headers that were next to ↵erg@google.com2010-08-181-1/+3
| | | | | | | | | | | them). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3161027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56590 0039d316-1c4b-4281-b951-d872f2087c98
* Win IO Perf Regressionsthomasvl@chromium.org2010-08-181-11/+0
| | | | | | | | | | | | | | | | http://build.chromium.org/buildbot/perf/xp-release-dual-core/moz/report.html?history=150&rev=-1&graph=total_byte_b Revert 56483 - Monitor network change in GoogleURLTracker BUG=48688,15141 TEST=GoogleURLTrackerTest.MonitorNetworkChange passes Review URL: http://codereview.chromium.org/3034018 TBR=ukai@chromium.org Review URL: http://codereview.chromium.org/3176017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56544 0039d316-1c4b-4281-b951-d872f2087c98
* Convert strings in bookmarks, part 2.viettrungluu@chromium.org2010-08-181-2/+2
| | | | | | | | | | | | | This eliminates the wstring version of BookmarkModel::GetBookmarksWithTitleMatchingTerm(). It also converts a pile of wide strings in bookmark_model_unittest.cc. BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3141024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56533 0039d316-1c4b-4281-b951-d872f2087c98
* Remove wstrings from bookmarks, part 1 (of many).viettrungluu@chromium.org2010-08-182-3/+5
| | | | | | | | | | | | Start by removing wstring versions of BookmarkModel::AddURLWithCreationTime() and BookmarkModel::SetURLStarred(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3111012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56488 0039d316-1c4b-4281-b951-d872f2087c98
* Monitor network change in GoogleURLTrackerukai@chromium.org2010-08-181-0/+11
| | | | | | | | | BUG=48688,15141 TEST=GoogleURLTrackerTest.MonitorNetworkChange passes Review URL: http://codereview.chromium.org/3034018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56483 0039d316-1c4b-4281-b951-d872f2087c98
* Disable autocomplete for search keywords.isherman@chromium.org2010-08-172-5/+8
| | | | | | | | | | | We have custom UI for search keywords anyway, so in practice a user would never see the autocompleted url. But, we had been computing the index incorrectly in some cases, as we trim off "http://" and "www." to compute the keyword. Since we don't use it anyway, simplify the logic and get rid of it :) BUG=none TEST=none Review URL: http://codereview.chromium.org/3151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56445 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show accidental search infobar for bookmark keywords.isherman@chromium.org2010-08-171-1/+2
| | | | | | | | | BUG=6854 TEST=none Review URL: http://codereview.chromium.org/3119007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56413 0039d316-1c4b-4281-b951-d872f2087c98
* Include ICU headers in a way that will also work with use_system_icu=1phajdan.jr@chromium.org2010-08-171-1/+2
| | | | | | | | | TEST=none BUG=28294 Review URL: http://codereview.chromium.org/3145014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56396 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring DictionaryValue ↵viettrungluu@chromium.org2010-08-172-2/+4
| | | | | | | | | | | Get{Boolean,Integer,Real,Binary,Dictionary,List}(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3187004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56302 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring Get(As)String() methods from Value, etc.viettrungluu@chromium.org2010-08-161-10/+14
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove "obviously" unneeded standard C++ library #includes.viettrungluu@chromium.org2010-08-151-1/+0
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3179017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Forward declare everything possible in testing_profile.herg@google.com2010-08-132-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3129007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56053 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-30 08:19:00 +0000