summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Merge 124282 - Disable storing cookies from URLFetchers that run with a ↵jochen@chromium.org2012-03-051-0/+2
| | | | | | | | | | | | | | profile's cookie jar. BUG=116253 TEST=none Review URL: https://chromiumcodereview.appspot.com/9545005 TBR=jochen@chromium.org Review URL: https://chromiumcodereview.appspot.com/9600012 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@124928 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 120346 - Fine-tune HQP Candidate Result Scoringlaforge@chromium.org2012-02-151-42/+127
| | | | | | | | | | | BUG=111792 TEST=Adjusted and ran unit tests. Added new tests. Review URL: https://chromiumcodereview.appspot.com/9317011 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/9359056 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@122008 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 121589 - Adjust scoring of shortcuts based on the percentage of ↵georgey@chromium.org2012-02-143-41/+49
| | | | | | | | | | | | | | | | | | | | | | | | | entered data from linear to quadratic. Right now we base score of the result on three factors: firstly, the score is dependent on the time passed since last click on the shortcut, secondly the score is dependent on the number of usages of the shortcut, and thirdly it dependent on the what percentage of the string is entered by the user. First two dependencies are logarithmic, the third one is currently linear. This changelist changes it to quadratic. For example, here are changes in scoring for 10 letter term, depending on how many letters user entered (percentage is relative to score achieved based on first two factors): 1 letter entered - 10% using old scoring / 31% using new scoring, 2 letters - 20% / 44%, 3 letters - 30% / 54%, 4 letters - 40% / 63%, 5 - 50% / 71%, 6 - 60% / 77%, 7 - 70% / 84%, 8 - 80% / 89%. 9 - 90% / 95%, 10 (whole term) - 100% / 100%. As you see the score becomes "significant" quicker. BUG=none TEST=unit-test Review URL: http://codereview.chromium.org/9252030 TBR=georgey@chromium.org Review URL: https://chromiumcodereview.appspot.com/9398007 git-svn-id: svn://svn.chromium.org/chrome/branches/1025/src@121973 0039d316-1c4b-4281-b951-d872f2087c98
* Use proper FormatUrl() call so correct format_types is applied.mrossetti@chromium.org2012-01-311-1/+2
| | | | | | | | | BUG=None TEST=None TBR=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/9303023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119838 0039d316-1c4b-4281-b951-d872f2087c98
* When UMA logs omnibox events, record omnibox modification time.mpearson@chromium.org2012-01-314-20/+67
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Precisely, keep track of the time that the user first began modifying text in the omnibox. When the UMA finally selects an omnibox suggestion and this selection is logged (for opted-in / UMA users), record in this log entry the elapsed time since the user began modifying the omnibox. This will be useful to measure changes to the omnibox. In general, omnibox changes should result in less time spent typing in the omnibox / reviewing proferred suggestions. This code works as you'd expect with two caveats: * If the current tab/window loses focus at some point (e.g., the user types, switches tabs, switches back, and types more), the elapsed time only starts from the beginning of the second series of modifications. Nuance to this rule: if a user types in the omnibox, clicks somewhere on the page in a way that doesn't navigate to a new page (but this click will have the effect of closing the omnibox dropdown), then returns to the omnibox and types more, the elapsed time counts from the beginning of the first modification. (Basically, this type of action, where the current tab still remains in focus even if the omnibox itself has gone in and out of focus, calculates elapsed time in a way that makes sense.) * If a user enters text in the omnibox, switches tabs/windows, and then returns to this tab and presses enter without typing more, thereby navigating to the inline suggestion that was originally offered, no omnibox transition event is currently logged. This changelist does not alter this policy. The omnibox event is only logged if the omnibox suggestion dropdown is open with the transition happens. In this case, when the user leaves the tab, the dropdown closes. When the user returns, the dropdown doesn't re-open unless the user types something new. I believe this changelist is fine/useful as-is. I don't like the first caveat mentioned above but I'm inclined to submit this as-is and fix that special case in a later changelist (if I decided it's worth bothering). I prevent not to postpone this changelist on this subtlety. Regarding the second caveat, that's orthogonal to this changelist and should be fixed in a different change (if indeed we desire to fix it--I'll have to look at everyone who is observing omnibox transition events). I will submit this changelist only *after* the server processing UMA uploads is running code that can handle the XML format with this new attribute. Chrome privacy folks have okayed this change. Tested by hand (on linux). I looked at normal use and tested in particular: * Startup. The initial blank window with an empty omnibox doesn't start the timing until the user types something into the box. * Highlight all in omnibox. Then type. The timer starts only when you begin typing, not at the highlight stage. * Start typing. Press escape (which reverts omnibox to the current page's URL), then type more. The timer starts when the second series of typing begins. * Type in omnibox. Click on a link on the page (this causes a page transition and the omnibox to display the new page's URL). Modify the omnibox. The timer starts when the second series of typing begins; the first modification does not count. * Alt-enter (to open an omnibox suggestion in a new foreground tab) gets emitted as normal, with appropriate timing. * If you go back to the tab that you used to open the background tab, its omnibox shows the current page's URL. If you start typing here, the starting time is from this second set of typing, not the first use in this tab that ended with opening a suggestion in a new tab. * Open a new tab. The timer only starts when you start typing in the omnibox, not when the tab gets opened. * Middle-click (to open an omnibox suggestion in a new background tab) gets emitted as normal, with appropriate timing. * After you middle-click a result, the omnibox dropdown stays open on the current tab. If you select something new here, the timing is from the beginning of when you originally started typing. That is, both the results opened from this list of suggestions have the same start time. * After you middle-click a result, you type more (and thus get new suggestions), the timing still starts from the time you originally began modifying the omnibox (i.e., before you opened a new tab in the background). I saw some behavior we may want to change later. These are described in the caveats section above. * Highlight all and press delete. Then type. The timer starts when you press delete, not at the first real character you type. * Type in the omnibox. Switch tabs/windows/whatever. Return and type more. The timing starts from this second batch of typing. I'd think it should start from the first. * If you middle-click a result, then switch windows (i.e., this window or this tab loses focus), the omnibox disappears. If you return to the omnibox and hit return to select whatever inline autocompletion is already in the omnibox, no notify event is emitted. * Likewise, if you type in the omnibox, switch windows or tabs, then return and hit return (the omnibox is closed but populated with original inline suggestion), no notify event is emitted. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9241020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119832 0039d316-1c4b-4281-b951-d872f2087c98
* Create a field trial for making omnibox autocomplete HistoryURL more aggressive.mpearson@chromium.org2012-01-313-2/+140
| | | | | | | | | | | | This new class AutocompleteFieldTrial is meant to handle one or more field trials at once. I'll add another field trial to it (that makes HistoryQuickProvider more aggressive) soon. BUG= TEST= Review URL: http://codereview.chromium.org/9113037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119798 0039d316-1c4b-4281-b951-d872f2087c98
* Properly calculate inline autocomplete offset.mrossetti@chromium.org2012-01-303-25/+55
| | | | | | | | | | The calculation of the inline_autocomplete_offset_ was incorrect. Eliminated unnecessary function parameter. BUG=110892 TEST=1) Visit an URL such as "www.amazon.com". 2) Now type 'ama' into the omnibox. 3) Verify that the presentation is "ama[zon.com]" where the bracketted section is the to-be-autocompleted portion. Also enhanced the HistoryQuickProviderTest unit tests. Review URL: https://chromiumcodereview.appspot.com/9298017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119730 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 119699 - Cancel prerenders from Omnibox if we navigate to a different ↵dominich@google.com2012-01-301-11/+1
| | | | | | | | | | | | | | | | URL than predicted. I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const. BUG=110799,111350 Review URL: http://codereview.chromium.org/9226037 TBR=dominich@chromium.org Review URL: https://chromiumcodereview.appspot.com/9301012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119720 0039d316-1c4b-4281-b951-d872f2087c98
* Cancel prerenders from Omnibox if we navigate to a different URL than predicted.dominich@chromium.org2012-01-301-1/+11
| | | | | | | | | | | I also took the opportunity to align the order of methods in prerender_manager.cc to that of the header (as it should be) and make a couple of methods const. BUG=110799,111350 Review URL: http://codereview.chromium.org/9226037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119699 0039d316-1c4b-4281-b951-d872f2087c98
* Make about:flag for HistoryURL aggressiveness a three way choice: auto, on, off.mpearson@chromium.org2012-01-271-3/+21
| | | | | | | | | | | | | This will be handy in preperation for a field trial of turning this flag on. (Automatic will be the group that gets put in the field trial.) BUG= TEST= Review URL: http://codereview.chromium.org/9235071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119492 0039d316-1c4b-4281-b951-d872f2087c98
* Toward an android build of sync_unit_tests: OWNERS=skyjrg@chromium.org2012-01-271-2/+2
| | | | | | | | | | BUG=None TEST= Review URL: http://codereview.chromium.org/9235045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@119399 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix uninitialized member variables.kmadhusu@chromium.org2012-01-241-1/+3
| | | | | | | | | | CID=102647, 102333, 102332, 102303, 102302, 102299, 102297, 102296, 102048, 102032, 102031, 102030, 102029, 102028, 102010, 101681, 101657, 101655, 101438 BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9005031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118848 0039d316-1c4b-4281-b951-d872f2087c98
* Initial draft of chrome://omnibox/ page.mpearson@chromium.org2012-01-241-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | Takes input text and display information about autocomplete suggestions. There is an abbreviated mode and a detailed mode. There is a mode to show all intermediate autocomplete updates and a mode to show only the final suggestions. This page is listed in chrome://about This page is not internationalized. Because it's only for debug purposes, I don't think it needs to be. There are a lot of ways to improve this. We can display more information. We can make the URL save-as-able. (Right now if you do save-as, you see the empty page, not page with any content.) There are lots of things that can be done, but I think this is good enough as is that it's worth checking in. BUG=79883 TEST= Review URL: http://codereview.chromium.org/8888030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118772 0039d316-1c4b-4281-b951-d872f2087c98
* Profiles: Add a --dump-profile-graph option when !NDEBUG.erg@chromium.org2012-01-241-2/+3
| | | | | | | | | | | | | --dump-profile-graph will create a text file in the profile directory in graphviz format. The graph is the dumped dependency graph. BUG=none R=mirandac TBR=jhawkins,sky,abodenha,tim Review URL: http://codereview.chromium.org/9200017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118765 0039d316-1c4b-4281-b951-d872f2087c98
* Towards compiling unit_tests for Android. Split off from main CL for OWNERS ↵jrg@chromium.org2012-01-212-4/+14
| | | | | | | | | | | | issues. BUG=None TEST= Review URL: http://codereview.chromium.org/9226013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118579 0039d316-1c4b-4281-b951-d872f2087c98
* More fine grained understanding of Omnibox navigation counts.dominich@chromium.org2012-01-111-4/+8
| | | | | | Review URL: http://codereview.chromium.org/9153004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117318 0039d316-1c4b-4281-b951-d872f2087c98
* Allow prerendering of search results from Omnibox.dominich@chromium.org2012-01-102-13/+2
| | | | | | | | | | BUG=109680 TEST= Review URL: http://codereview.chromium.org/9152021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@117101 0039d316-1c4b-4281-b951-d872f2087c98
* Remove all but the Exact Full Omnibox Prerender algorithm.dominich@chromium.org2012-01-063-35/+6
| | | | | | | | | BUG=106427 Review URL: http://codereview.chromium.org/8801017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116696 0039d316-1c4b-4281-b951-d872f2087c98
* Adding about:network_action_predictor to show state of ↵dominich@chromium.org2012-01-052-2/+11
| | | | | | | | NetworkActionPredictor database. Review URL: http://codereview.chromium.org/8969004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116556 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the remaining trivial tab_contents.h includes in chrome to use ↵jam@chromium.org2012-01-051-1/+0
| | | | | | | | | web_contents.h BUG=98716 Review URL: http://codereview.chromium.org/9113020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116548 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some more tab_contents.h includes from Chrome.jam@chromium.org2012-01-051-2/+4
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/9030035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116422 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-041-2/+2
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::render_view_host() to GetRenderViewHost and put it into ↵jam@chromium.org2011-12-201-1/+1
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9007026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
* Enable UMA logging of tab IDs for omnibox interactions.mpearson@chromium.org2011-12-192-1/+18
| | | | | | | | | | | | | | | Useful to know how users use omnibox. Testing: There are no tests for autocomplete logging. Rather than add tests in this changelist (they're outside the scope of this), I tested this changelist by hand. It works; the tab_ids are getting set and used as desired. Contributed by mpearson@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/8599009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114982 0039d316-1c4b-4281-b951-d872f2087c98
* Improve HistoryURL scoring by making it more aggressive.mpearson@chromium.org2011-12-163-42/+60
| | | | | | | | | | | | | | | | | | | Score the first pass (roughly) as usual. Something may become an INLINE_AUTOCOMPLETE match or an UNVISITED_INTRANET match or simply a URL_WHAT_YOU_TYPED match. All the results we add in the second pass are given decreasing scores starting with whatever the highest score we've assigned thus far. For instance, if there is an INLINE_AUTOCOMPLETE match (scores around 1410), all other history matches will have scores around 1410 (instead of the previous 900 or so). As another example, if no match qualifies as INLINE_AUTOCOMPLETE or UNVISITED_INTRANET, and the highest match we get from the first pass is the URL_WHAT_YOU_TYPED match (scores around 1210), then all history URL results if there are any will get similar scores (rather than the earlier 900). There may not be any history URL results; I imagine it's rare that history URL has results but none qualify as INLINE_AUTOCOMPLETE. This is a temporary changelist for feedback. I have not touched the unittests. BUG= TEST= Review URL: http://codereview.chromium.org/8757006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114800 0039d316-1c4b-4281-b951-d872f2087c98
* Split UserMetrics into API vs. implementation. Move API to content/public.joi@chromium.org2011-12-141-3/+5
| | | | | | | | | TBR=davemoore@chromium.org BUG=98716 Review URL: http://codereview.chromium.org/8919017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114416 0039d316-1c4b-4281-b951-d872f2087c98
* Adding tracking of accuracy vs confidence.dominich@chromium.org2011-12-142-0/+20
| | | | | | | | | BUG=107365 Review URL: http://codereview.chromium.org/8895028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114315 0039d316-1c4b-4281-b951-d872f2087c98
* Track confidence calculations better. Reduce minimum user text length.dominich@chromium.org2011-12-123-23/+26
| | | | | | | | | | | | Database sizes are low so it is safe to reduce the minimum user text length. This should increase coverage. To help track potential coverage increases, it is good to remove trivial 0 confidences from the histogram of confidences. BUG=107212,107213 Review URL: http://codereview.chromium.org/8870006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114091 0039d316-1c4b-4281-b951-d872f2087c98
* Profiles: Move NetworkActionPredictor to the ProfileKeyedService framework.erg@chromium.org2011-12-126-5/+87
| | | | | | | | | BUG=77155, 103574 TEST=none Review URL: http://codereview.chromium.org/8872036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114067 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up TCW, make it solely a hub for 1:1 observer/helper objects.avi@chromium.org2011-12-121-0/+1
| | | | | | | | | BUG=105872 TEST=no functional change Review URL: http://codereview.chromium.org/8892011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114017 0039d316-1c4b-4281-b951-d872f2087c98
* Removing MessageLoop::QuitTask() from chrome/dcheng@chromium.org2011-12-101-1/+1
| | | | | | | | | | | | base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Review URL: http://codereview.chromium.org/8873032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113896 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113071 - Revert 113047 - Make ExtensionService use ExtensionSet.yoz@chromium.org2011-12-061-2/+2
| | | | | | | | | | | | | | | | | | | ExtensionManagementApiBrowserTest.LaunchApp fixed by r113141. Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8789018 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8822021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113233 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113047 - Make ExtensionService use ExtensionSet.yoz@chromium.org2011-12-061-2/+2
| | | | | | | | | | | | | | | | It broke ExtensionManagementApiBrowserTest.LaunchApp. Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8789018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113071 0039d316-1c4b-4281-b951-d872f2087c98
* Make ExtensionService use ExtensionSet.yoz@chromium.org2011-12-051-2/+2
| | | | | | | | | | | Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113047 0039d316-1c4b-4281-b951-d872f2087c98
* Strip invalid characters (line breaks, tabs), javascript:schemes from the ↵ncj674@motorola.com2011-12-041-0/+3
| | | | | | | | | | | | | | copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703 TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8702002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112923 0039d316-1c4b-4281-b951-d872f2087c98
* Removing history-based omnibox prerender heuristics.dominich@chromium.org2011-12-022-112/+65
| | | | | | | | | BUG=105763 Review URL: http://codereview.chromium.org/8735004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reference to potentially NULL TabContentsWrapper.dominich@chromium.org2011-12-021-4/+11
| | | | | | | | | BUG=105689 Review URL: http://codereview.chromium.org/8745016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112705 0039d316-1c4b-4281-b951-d872f2087c98
* Improve Autocomplete Matches and Handling of Large Results Setsmrossetti@chromium.org2011-12-011-10/+1
| | | | | | | | | | | | | | Do not call FixupUserInput as it was prepending unexpected prefixes (such as file://) to the search string and bypassing valid results. Move the search string decomposition operation from the HQP into the IMUI. In the final substring filtering use whitespace delineated terms rather than words. Instead of bailing if we get a large results set (>500) filter it down to 500 by sorting by typed-count/visit-count/last-visit. This means it's no longer necessary to bypass the HQP if there is only one character in the search term so get rid of the ExpandedInMemoryURLIndexTest.ShortCircuit unit test. BUG=101301,103575 TEST=Added unit tests. Review URL: http://codereview.chromium.org/8526010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112527 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to IWYU for files that previously were getting a bunch ofjoi@chromium.org2011-12-011-0/+1
| | | | | | | | | | | header files via io_thread.h or browser_thread.h TBR=owners (previously approved on codereview 8477004) BUG=98716 Review URL: http://codereview.chromium.org/8746023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Convert ASCIIToUTF16("") to string16().jhawkins@chromium.org2011-11-281-2/+3
| | | | | | | | | | | | | Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111548 - Broke OmniboxViewTest.AcceptKeywordBySpace on Linuxrsleevi@chromium.org2011-11-241-3/+0
| | | | | | | | | | | | | | | | Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703. TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 TBR=ncj674@motorola.com Review URL: http://codereview.chromium.org/8690006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111558 0039d316-1c4b-4281-b951-d872f2087c98
* Strip invalid characters (line breaks, tabs), javascript:schemes from the ↵ncj674@motorola.com2011-11-241-0/+3
| | | | | | | | | | | | | copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703. TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111548 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111378 - HQP Refactoring (in Preparation for SQLite Cache)zmo@google.com2011-11-244-11/+8
| | | | | | | | | | | | | | | | | | | | (See crbug.com/105340 for reverting reason and how to reproduce the issue locally) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8662035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111482 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting based on discussions on #chromium with shess and rsleevijamiewalch@google.com2011-11-231-3/+1
| | | | | | | | | | | | | | | | | | | | Revert 111386 - Add a field trial for using lower sqlite cache sizes. There are a few relevant histograms that I annotated with the field trial name, and I added a new AddPage histogram. TEST=none BUG=none Review URL: http://codereview.chromium.org/8379009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8677025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111433 0039d316-1c4b-4281-b951-d872f2087c98
* Add a field trial for using lower sqlite cache sizes.brettw@chromium.org2011-11-231-1/+3
| | | | | | | | | | | | | There are a few relevant histograms that I annotated with the field trial name, and I added a new AddPage histogram. TEST=none BUG=none Review URL: http://codereview.chromium.org/8379009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111386 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-234-8/+11
| | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111378 0039d316-1c4b-4281-b951-d872f2087c98
* Adding histograms for better Omnibox prerender performance tracking.dominich@chromium.org2011-11-221-0/+3
| | | | | | Review URL: http://codereview.chromium.org/8602005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111207 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a fourth omnibox prerender experiment.dominich@chromium.org2011-11-213-45/+160
| | | | | | | | | | | | | This adds or updates entries in the database for the entire chain of text the user typed. For example, if the user types 'goog' and navigates to google.com, this will add or update database entries for 'go' -> google.com, 'goo' -> google.com and 'goog' -> google.com. BUG= TEST= Review URL: http://codereview.chromium.org/8600004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111005 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-214-6/+8
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8612007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
* Force navigation to non-numeric hostnames with ports (e.g. "abc:81"). This ↵pkasting@chromium.org2011-11-192-13/+10
| | | | | | | | | | restores the pre-Chrome-15 behavior for these inputs. BUG=103598 TEST=Typing "abcdefg:123" in the address bar should attempt to navigate, not search, by default. Review URL: http://codereview.chromium.org/8510024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110821 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 03:36:14 +0000