summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Move app/gfx/canvas and app/gfx/font to gfx/.ben@chromium.org2010-03-235-5/+5
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1132006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42312 0039d316-1c4b-4281-b951-d872f2087c98
* Make various types of input work better with ctrl-enter. If we detected ↵pkasting@chromium.org2010-03-222-2/+33
| | | | | | | | | | that the hostname without adding the TLD was illegal, we'd sometimes fail to allow the TLD to be added. BUG=38605 TEST=Should be able to hit ctrl-enter on "401k" and "999999999999" to open them with www. and .com attached. Review URL: http://codereview.chromium.org/1088004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42246 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-202-3/+4
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* Move text_elider from app/gfx to app/ben@chromium.org2010-03-192-2/+2
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42090 0039d316-1c4b-4281-b951-d872f2087c98
* Honor select-all on tab-away when omnibar is empty (gtk)tony@chromium.org2010-03-192-5/+26
| | | | | | | | | | | | | | | | | Also added a browser test for this case. The bug is an ordering error, possibly because the programmer was unaware that GetStateForTabSwitch can actually mutate the selection state, for the odd case outlined in bug 38385. BUG=38385 TEST=Delete URL from omnibar. Create tab, delete tab. URL should be reverted and selected. Patch by Matthew Willis <appamatto@gmail.com> Review URL: http://codereview.chromium.org/1047004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42085 0039d316-1c4b-4281-b951-d872f2087c98
* Move more files to toplevel gfx.ben@chromium.org2010-03-191-1/+1
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-173-3/+3
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
* This patch strips out the http auth credentials before storing it in History DB.inferno@chromium.org2010-03-161-4/+1
| | | | | | | | BUG=20318 TEST=Visit a url having auth credentials. Check history db to see url stored without credentials. Review URL: http://codereview.chromium.org/1012001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41773 0039d316-1c4b-4281-b951-d872f2087c98
* Move base/gfx contents to gfx/ben@chromium.org2010-03-144-4/+4
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98
* Pick up a GTM roll and update the apis that changed in this roll.thomasvl@chromium.org2010-03-111-1/+2
| | | | | | | | BUG=none TEST=everything still works Review URL: http://codereview.chromium.org/793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41295 0039d316-1c4b-4281-b951-d872f2087c98
* win: string_util.h -> utf_string_conversions.h fix.jhawkins@google.com2010-03-111-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/830002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41292 0039d316-1c4b-4281-b951-d872f2087c98
* mac: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-102-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/745003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41100 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 2: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-085-7/+11
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/672007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40945 0039d316-1c4b-4281-b951-d872f2087c98
* chrome 1: string_util.h -> utf_string_conversions.h fix.jhawkins@chromium.org2010-03-081-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/672001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40937 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: disable "edit search engines" and "paste and go" in location bar view ↵estade@chromium.org2010-03-048-5/+28
| | | | | | | | | | | when appropriate. BUG=29089 TEST=see bug Review URL: http://codereview.chromium.org/667009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40596 0039d316-1c4b-4281-b951-d872f2087c98
* GTK/Mac: show security warning on correct part of url.estade@chromium.org2010-03-042-18/+19
| | | | | | | | | | | | | Where "security warning" means "diagonal red line". This change just copies the relevant code from Windows; my suspicion is that when the windows code was updated, mac and linux had already copied the old, incorrect code, but the bug didn't become apparent until the security UI was implemented on those platforms. BUG=26280 TEST=manual Review URL: http://codereview.chromium.org/668016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40595 0039d316-1c4b-4281-b951-d872f2087c98
* Next part of bad dependency removal (chrome/common -> chrome/browser)phajdan.jr@chromium.org2010-03-022-2/+2
| | | | | | | | | | | This change introduces one more dependency on chrome/browser, but it seems simpler to move gtk_util first and then fix it. TEST=none BUG=none Review URL: http://codereview.chromium.org/661271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40369 0039d316-1c4b-4281-b951-d872f2087c98
* Move skia_utils_gtk.cc/.h to app/gfx/. Original patch by Thiago Farina (see ↵pkasting@chromium.org2010-02-261-3/+3
| | | | | | | | | http://codereview.chromium.org/660063 ), r=me. BUG=22853 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40083 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux]Fix text justification of find bar.suzhe@chromium.org2010-02-231-2/+2
| | | | | | | | | BUG=34724 Text in omnibox and find bar is not right justified correct under RTL locale. TEST=Run chrome with LTR locale, the text in find bar should always be left justified, regardless of the text's direction. With RTL locale, the text should always be right justified. It matches the behavior of windows version. Review URL: http://codereview.chromium.org/652105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39702 0039d316-1c4b-4281-b951-d872f2087c98
* Move pref_{member,service} and important_file_writer from chrome/commonphajdan.jr@chromium.org2010-02-193-3/+3
| | | | | | | | | | | | | to chrome/browser. This is a part of an effort to remove bad dependency of chrome/common on chrome/browser. TEST=unit_tests and ui_tests, just moving code BUG=none Review URL: http://codereview.chromium.org/621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
* Pulled out Callback code into base/callback.h. This is the first step ↵akalin@chromium.org2010-02-192-0/+2
| | | | | | | | | | | | | towards redoing the Callback interfaces. Added and removed includes as needed. BUG=35223 TEST=trybots Review URL: http://codereview.chromium.org/646061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39419 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Chrome crash caused in a ChromeFrame instance while displaying the ↵ananta@chromium.org2010-02-192-12/+10
| | | | | | | | | | | | | | | | | | | inspector window. The inspector window uses the browser view which instantiates the whole view including the ToolBar, which in turn instantiates the Autocomplete edit bar which uses Richedit on Windows. The auto complete edit bar dynamically loads and unloads the richedit control and it uses ATL to superclass the richedit control. If the rich edit dll loads at a different base address it causes a crash in Chrome while creating the window as ATL caches the wndproc address for a class. Fix is to setup an implicit dependency on the riched20.dll and not load and free it all the time. To achieve this we use #pragma comment for the riched20.lib and a dummy call to the CreateTextServices function exported by the dll to ensure that the linker does not discard the import. Fixes bug http://code.google.com/p/chromium/issues/detail?id=33308 Bug=33308 Review URL: http://codereview.chromium.org/646043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39415 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor omnibox popup to fix click-drag display.shess@chromium.org2010-02-192-111/+82
| | | | | | | | | | | | | | | | | | | | | | | | | | Fix the confusion between highlighted and selected cells by overriding |-mouseDown:| and directly implementing the desired behaviors. Which are: - while mouse is down in the view, the item under the mouse looks selected, like it would if you used the arrow keys to move it around (rather than highlighted). - dragging off with mouse down reverts to previous selection (the one matching the field's contents). - releasing while mouse is off-view reverts to previous selection. - dragging back with mouse still down selects the cell under the mouse. Additionally, refactor to remove useless utility object. The custom matrix now just messages the C++ object directly. BUG=25435 TEST=See bug. Review URL: http://codereview.chromium.org/646063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39411 0039d316-1c4b-4281-b951-d872f2087c98
* Make Esc in Omnibox *not* stop loading if it has reverted editing.viettrungluu@chromium.org2010-02-171-1/+1
| | | | | | | | | BUG=none TEST=Begin loading a slow-loading web page. While it's loading, begin editing in the Omnibox. While it's still loading, press Esc. The text should revert to the original URL and be all selected, but the page should continue loading. A second Esc at this point should stop loading. Review URL: http://codereview.chromium.org/628005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39295 0039d316-1c4b-4281-b951-d872f2087c98
* Format the "?" match like our other search matches. This never got changed ↵pkasting@chromium.org2010-02-111-10/+9
| | | | | | | | | | over during the Omnibox 2 changes. BUG=none TEST=Entering "?" in the address bar should show "<enter query> - Google Search" Review URL: http://codereview.chromium.org/598076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38821 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux]Fix text justification of omnibox.suzhe@chromium.org2010-02-112-5/+90
| | | | | | | | | | | | | | | | | | | Without this CL, the omnibox inherits the default behavior of GtkTextView on handling text direction and justification, that is: 1. If the justification is set to left justification, then the content will be left justified if the content's text direction is LTR, otherwise it'll be right justified. 2. If the justification is set to right justification, then the content will be right justified if the content's text direction is LTR, otherwise it'll be left justified. And if the content doesn't have a strong text direction, the keymap's direction will be used. If the keymap doesn't have a strong text direction either, the widget's direction (UI language direction) will be used. This behavior is different than Chrome windows. On windows, if the UI language direction is LTR, then the content is always left justified, otherwise it's always right justified. To achieve the same behavior, this CL adjust the justification automatically according to the content's (or keymap's) text direction and the widget direction, to make sure the justification is always in sync with the UI language direction. BUG=34724 Text in omnibox and find bar is not right justified correct under RTL locale. TEST=Run chrome with LTR locale, the text in omnibox should always be left justified, regardless of the text's direction. With RTL locale, the text should always be right justified. It matches the behavior of windows version. Review URL: http://codereview.chromium.org/595021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38737 0039d316-1c4b-4281-b951-d872f2087c98
* Remove redundant casts in g_signal_connect() throughout all gtk code we have.erg@chromium.org2010-02-101-4/+4
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/600033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38629 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't let omnibox popup text tighten while resizing.shess@chromium.org2010-02-051-0/+1
| | | | | | | | | | | | | | | Sets the tightening factor to 0.0 so that the popup text doesn't tighten then rebound after being elided. BUG=24296 TEST=Get the omnibox popup up, resize the window smaller, all the left-hand-side text which stays should be rendered in a stable position (right-hand-side text may shift as LHS text is elided, but the spacing between characters should stay the same). Review URL: http://codereview.chromium.org/577029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38280 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-051-5/+5
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Set fixed maximum line height in Omnibox.viettrungluu@chromium.org2010-02-052-1/+22
| | | | | | | | | | | (Otherwise, e.g., Arabic text can make the line shift downwards.) BUG=31115 TEST=Make sure Omnibox works/looks/feels normal (and that normal text is displayed in it correctly). Then paste in something containing appropriate Arabic characters (see bug report for some samples); make sure text doesn't shift down. Review URL: http://codereview.chromium.org/573002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38163 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some goofiness when arrowing around the popup with control down by ↵pkasting@chromium.org2010-02-051-1/+18
| | | | | | | | | | canceling control-enter once the user starts moving around the popup. BUG=32547 TEST=Type something in the omnibox, hold control, arrow down to a different entry, release control, press enter. You should visit the entry that's selected, not something else. Review URL: http://codereview.chromium.org/577008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38159 0039d316-1c4b-4281-b951-d872f2087c98
* Copy percent-escaped URL when copying all the text from the address bar (Mac)kinuko@chromium.org2010-02-032-0/+31
| | | | | | | | | | | | | | | | | | | | BUG=31104 TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地. Paste the copied text into Safari's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". Paste the copied text into TextEdit and check if the pasted text isn't garbled and correctly contains 上地. Check if the link in TextEdit is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0). TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=上地". TEST=Copy "上地" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded. Review URL: http://codereview.chromium.org/549172 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37955 0039d316-1c4b-4281-b951-d872f2087c98
* Make pressing <esc> while dragging in the omnibox correctly cancel dragging. ↵pkasting@chromium.org2010-02-014-2/+12
| | | | | | | | | Original patch by Philippe Beaudoin (see http://codereview.chromium.org/554143 ), r=me, tweaked. BUG=33460 TEST=Write goog in the omnibox, drag around, while pressing the left mouse button hit ESC. The selection should return to the first entry and not move as you continue to drag. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37724 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: chrome/app and chrome/browser ifdef cleaningpvalchev@google.com2010-02-012-6/+4
| | | | | | Review URL: http://codereview.chromium.org/548203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
* Always percent-escape the copied URL when all the text in the address bar is ↵kinuko@chromium.org2010-02-011-0/+38
| | | | | | | | | | | | | | | | | | | | selected. BUG=29397 TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as gedit and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 上地. Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. TEST=Visit http://www.google.com/search?ie=UTF-8&q=上地 again and select "q=上地" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=上地". TEST=Copy "上地" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into other apps such as gedit. Then check if the pasted text is NOT encoded. TEST=Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 上地. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". TEST=Steps described in http://codereview.chromium.org/173098. Review URL: http://codereview.chromium.org/465053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37686 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Update PRIMARY selection on Ctrl-X in omnibox.derat@chromium.org2010-01-272-4/+11
| | | | | | | | | | | | We already do this when copying text; I forgot to do the same for cutting. BUG=33230 TEST=checked that both PRIMARY and CLIPBOARD get updated on Ctrl-X and Ctrl-C now (and cut via context menu) Review URL: http://codereview.chromium.org/555135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37299 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Hook up AutocompleteEditViewMac delegate calls properly.rohitrao@chromium.org2010-01-271-0/+2
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/546107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37290 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutocompleteEditViewTest::EnterToSearch flaky.tyoshino@google.com2010-01-071-1/+1
| | | | | | | | | | | | | interactive_ui_tests is flaky since http://build.chromium.org/buildbot/waterfall/builders/Interactive%20Tests%20(dbg)/builds/19495 due to EnterToSearch. BUG=31732 TBR=japhet,lzheng Review URL: http://codereview.chromium.org/518055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35696 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Improve LocationBarViewGtk.suzhe@chromium.org2010-01-062-3/+16
| | | | | | | | | | | | | | This CL improves LocationBarViewGtk: 1. Add type to search hint. 2. Show/hide selected keyword, keyword hint and type to search hint automatically when resizing the browser window. 3. Use weak gray to display hint text, instead of black. BUG=11258 TEST=Resize the browser window when one of selected keyword, keyword hint and type to search hint is visible, to see if the hint can be shown or hidden automatically. Review URL: http://codereview.chromium.org/508008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35606 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly enable the Copy item on the popup window omnibox context menu. ↵pkasting@chromium.org2010-01-041-1/+1
| | | | | | | | | Original patch by Thiago Farina (see http://codereview.chromium.org/522031), r=finnur,me. BUG=29092 TEST=Select some text in a popup window omnibox, then right-click it. "Copy" should be enabled. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35492 0039d316-1c4b-4281-b951-d872f2087c98
* Add a keyboard shortcut on Escape that emits the IDC_STOP command.thakis@chromium.org2009-12-181-2/+1
| | | | | | | | | | BUG=20916 TEST=Load something big (http://cnn.com/) and hit escape. Page load will stop. Review URL: http://codereview.chromium.org/491023 Patch from Jochen Eisinger. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34942 0039d316-1c4b-4281-b951-d872f2087c98
* Use KF_ALTDOWN flag instead of GetKeyState(VK_MENU)xiyuan@chromium.org2009-12-171-1/+1
| | | | | | | | | | | | | KF_ALTDOWN is more accurate than GetKeyState(VK_MENU). When usre presses RightShift+RightAlt, the fake VK_CONTROL generated carries KF_ALTDOWN in its flags but GetKeyState(VK_MENU) is clear. BUG=30244 TEST=Verify RightAlt+RightShift does not change to RTL and issue 24888 does not regress. However, RightShift+RightAlt still changes RTL as this is the behavior of richedit. Review URL: http://codereview.chromium.org/505026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34850 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-164-3/+12
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Make a shared app menu model and update win and mac to use it. Remove the ↵pinkerton@chromium.org2009-12-152-2/+1
| | | | | | | | | | NSMenu from Toolbar.xib. BUG=22646 TEST=the app menu works as it used to. Review URL: http://codereview.chromium.org/482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 30244xiyuan@chromium.org2009-12-141-2/+3
| | | | | | | | | | | | Ensure Alt is clear for our Ctrl+Shift/Shift+Ctrl logic so that Hebrew IME generated Shift+Ctrl does not pass through and triggers RTL. BUG=30244 TEST=Verify fix for 30244 and issue 24888 does not regress. Review URL: http://codereview.chromium.org/497010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34497 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my r4300 and re-fixes Issue 3156 and 13500.hbono@chromium.org2009-12-092-23/+16
| | | | | | | | | | | | | | | | | | My r4300, which is a fix Issue 3156, has been causing regressions (Issue 9596, Issue 13500, Issue 29290, etc.) Every time when this change caused regressions, we added more code to Chromium and made Chromium code more complicated. So, I think it is better to revert this change once and find another solution for Issue 3156 rather than to add another workaround for Issue 29290. To look into Issue 3156 more deeply, it is caused by a recursive message-handler call. When SetWindowText() is called while an IME is composing text, the IME calls SendMessage() to send a WM_IME_COMPOSITION message. When we receive this WM_IME_COMPOSITION message, it updates the omnibox and calls SetWindowText()... This recursive call caused not only Issue 3156 but also caused some other IME issues, such as Issue 13500. BUG=3156,13500,29290 TEST=On XP, open a new tab, set the IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate and show the popup URL without a crash. TEST=Open Gmail, compose a new e-mail (without using a tear-off window), set the IME to Hiragana, type 'c' in its message body, and wait for the draft auto-saving. The browser should show the 'c' character. Review URL: http://codereview.chromium.org/467015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34145 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement "Search the Web..." (Opt-Cmd-F).viettrungluu@chromium.org2009-12-072-1/+14
| | | | | | | | | | | | | | This focuses the Omnibox with '?' in the contents with the text insertion point immediately after (and no selection), unless the Omnibox already has something beginning with '?' in which case it selects the text after the '?'. This is what Ctrl-K does on other platforms. On the Mac, we get a menu item (under Edit -> Find), and the Mac-standard shortcut of Opt-Cmd-F (users can set Cmd-K as a short cut in System Preferences if they really want). Changes to MainMenu.xib: added ^IDS_EDIT_SEARCH_WEB_MAC menu item ("Search the Web...", tag 39002, Opt-Cmd-F as keyboard shortcut, sending -commandDispatch: to first responder) as first item in Find submenu, followed by a separator. BUG=29501 TEST=Check that this feature has the behaviour described above (using both the menu item and using Opt-Cmd-F), with (1) nothing in the Omnibox to begin with, (2) a random URL in the Omnibox, and (3) "?<some search term(s)>". Check that the Omnibox is properly focused (so set focus to various places, and make sure that the Omnibox gets focused). Review URL: http://codereview.chromium.org/460111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33971 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Route edit-state messages via observer rather than delegate.shess@chromium.org2009-12-042-270/+125
| | | | | | | | | | | | | | | | | | | AutocompleteTextField routes messages to AutocompleteEditViewMac via a Cocoa-style delegate and also a C++ observer class. The Cocoa-style delegate has been gradually being pruned down in favor of the observer, this CL completes the transformation. The noted bugs occur because some bit of Cocoa code was sending spurious delegate notifications. Since this code no longer depends on those notifications, the spurious notifications are no longer a problem for this case. BUG=19116, 17803 TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox). Review URL: http://codereview.chromium.org/391025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33853 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-042-7/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 22:00:38 +0000