summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Merge 146650 - Disable HQP new scoring field trial.mpearson@chromium.org2012-07-161-2/+2
| | | | | | | | | | | | | | | By setting the percent of the population in the field trial group to 0. BUG=137255 TEST= Review URL: https://chromiumcodereview.appspot.com/10689195 TBR=mpearson@chromium.org Review URL: https://chromiumcodereview.appspot.com/10781020 git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@146828 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 144334 - HiDPI assets for omnibox icons.thakis@chromium.org2012-07-031-0/+1
| | | | | | | | | | | | | | | | | | Remove pdf files on Mac and use 2x pngs in the omnibox. Side effect: The default favicon is now an empty page instead of a globe. BUG=134372,111101 TEST=icons in omnibox are hidpi and generally match the look on non-mac platforms. TBR=avi Review URL: https://chromiumcodereview.appspot.com/10660021 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@145343 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 143064 - Allow nonzero verbatim relevance with no other SearchProvider ↵msw@chromium.org2012-06-202-21/+26
| | | | | | | | | | | | | | | | | | | | | | | | | | matches. Only ignore suggestions to suppres verbatim with no other matches. My previous CL is too restrictive of suggested verbatim relevances. (r142922 - Only use verbatimrelevance with other suggestions available) ignores suggested verbatim relevance if there are no other matches. Instead, it should only ignore suggestions to suppres verbatim. Note: Top scores are still clamped >= the calculated verbatim score. (see SearchProvider::ConvertResultsToAutocompleteMatches() line 776) I've also made this check applicable to verbatim matches themselves. BUG=125871,132942 TEST=Updated tests, manual. Review URL: https://chromiumcodereview.appspot.com/10559060 TBR=msw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10581045 git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@143244 0039d316-1c4b-4281-b951-d872f2087c98
* Merge 142922 - Only use verbatimrelevance with other suggestions available.msw@chromium.org2012-06-202-1/+18
| | | | | | | | | | | | | | | | PROBLEM: The suggest server may (and in some cases does) return no matches and verbatimrelevance:0, which instructs the SearchProvider to produce no matches whatsoever... This is problematic as it may leave the user unable to search from the omnibox. This may also occur if all the older results are trimmed for being unable to inline autocomplete newer input (given valid results and verbatimrelevance:0 from an older query). SOLUTION: Only respect verbatimrelevance:0 (suppression of search-what-you-typed) if there are other search or navigation results upon match generation. BUG=125871,132942 TEST=Updated unit test; manual. Review URL: https://chromiumcodereview.appspot.com/10559053 TBR=msw@chromium.org Review URL: https://chromiumcodereview.appspot.com/10577041 git-svn-id: svn://svn.chromium.org/chrome/branches/1180/src@143243 0039d316-1c4b-4281-b951-d872f2087c98
* Removing usage of profile_->GetHistory() from the codebase in order to ↵rlp@chromium.org2012-06-1913-19/+44
| | | | | | | | | | | remove that function. BUG=97804 TEST=existing unittests Review URL: https://chromiumcodereview.appspot.com/10557021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142866 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce SearchProvider navigational top matches for URL input.msw@chromium.org2012-06-162-26/+207
| | | | | | | | | | | | Problem: Some URL-like input yields highly-scored search/verbatim matches. Solution: First just revert search&verbatim server-suggested relevance scores (keep any highly suggested scores for inlineable NAVIGATION suggestions). The second match generation pass will revert navigational scores if the top match is not inlineable (reverting to classic scoring). BUG=125871,132032 TEST=New SearchProviderTests; manual URL input testing with experiments. Review URL: https://chromiumcodereview.appspot.com/10542171 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142618 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Create HistoryQuickProvider new scoring field trial.mpearson@chromium.org2012-06-152-0/+49
| | | | | | | | | | | | | | | And add a beacon to the histograms to allow identification of users in it. isherman: for field trial and histogram stuff (all files) sky: for OWNERs approval history stuff BUG= TEST=by hand, changed probabilities of field trial, looked at omnibox behavior and histogram behavior Review URL: https://chromiumcodereview.appspot.com/10532149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142451 0039d316-1c4b-4281-b951-d872f2087c98
* Move guid generation from chrome/common/ to base/.marja@chromium.org2012-06-141-1/+0
| | | | | | | | | | | | It will be needed in webkit/dom_storage/. BUG=NONE TEST=Existing tests. Review URL: https://chromiumcodereview.appspot.com/10540003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@142142 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Add histogram to count omnibox eventsmpearson@chromium.org2012-06-131-0/+1
| | | | | | | | | | | | Adds a non-UMA histogram for the number of omnibox events. This should be the number of events recorded in OmniboxEventProto (in the proto buffer logging pipeline) or as the UI Element Event of type autocomplete (in the old XML logging pipeline). BUG= TEST=about:histograms Review URL: https://chromiumcodereview.appspot.com/10540143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141978 0039d316-1c4b-4281-b951-d872f2087c98
* Misc. tiny cleanupspkasting@chromium.org2012-06-134-20/+14
| | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10544131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141911 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: In UMA logs, record typed_count of URLS.mpearson@chromium.org2012-06-124-0/+12
| | | | | | | | | | | | | | For UMA opted-in users, record the typed_counts of users that show up as omnibox suggestions. This has been approved by the privacy folks. BUG= TEST=using VLOG in the appropriate place in metrics_base.cc Review URL: https://chromiumcodereview.appspot.com/10544114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141787 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the omnibox to recognize as URLs inputs that have a host component ↵pkasting@chromium.org2012-06-121-2/+4
| | | | | | | | | | that ends with a hyphen. BUG=123732 TEST=Type in "kline-.github.com/NAMS" in the address bar and check that the default action is to navigate. Review URL: https://chromiumcodereview.appspot.com/10533102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141621 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate the "clock" icon in the omnibox dropdown. The distinction between ↵pkasting@chromium.org2012-06-121-3/+3
| | | | | | | | | | this and the globe was never clear to users, so let's just simplify. BUG=124450 TEST=A dropdown result that comes from matching the user's typing against the page title should have a globe icon. Review URL: https://chromiumcodereview.appspot.com/10535126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141614 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bogus svn:executable propspkasting@chromium.org2012-06-122-0/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141588 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutocompleteClassifier a ProfileKeyedService.pkasting@chromium.org2012-06-129-15/+134
| | | | | | | | | | This also cleans up some usage of TemplateURLServiceFactory, especially in order to remove knowledge of TemplateURLService[Factory] from TestingProfile. The changes for this parallel some implementation details for the AutocompleteClassifierFactory. BUG=112557 TEST=none Review URL: https://chromiumcodereview.appspot.com/10532096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141580 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a RunAllPending to shortcuts_provider_unittest to fix heapcheck leaks ↵rlp@chromium.org2012-06-111-0/+3
| | | | | | | | | | | | | in ShortcutsProviderTest in the case where threads are still holding on to the meassage loop. BUG=131668 TEST=heapcheck TBR=nico@chromium.org Review URL: https://chromiumcodereview.appspot.com/10539077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141540 0039d316-1c4b-4281-b951-d872f2087c98
* Add a top URL_WHAT_YOU_TYPED match to SearchProvider as needed.msw@chromium.org2012-06-115-77/+105
| | | | | | | | | | | | | | | | PROBLEM: (see Issue 131731): Input "microsoft" with top experimental suggestion "microsoft" (ranked 1310) stomps the CTRL-key-generated URL_WHAT_YOU_TYPED result for "www.microsoft.com" (ranked ~1203); this breaks CTRL+ENTER functionality when suggestion=input. So instead of navigating to www.microsoft.com; the user is taken to a search for "microsoft". (changed example from "orbitz" along with recent suggest/relevance changes). SOLUTION: Peter's suggested client-side fix; have SearchProvider also generate a URL_WHAT_YOU_TYPED result as needed, ranked higher than all other matches. Make HistoryURLProvider::SuggestExactInput public and static with a provider param. Remove relevance calculation from SuggestExactInput; callers must set this. BUG=125871,131731 TEST=Given single-word, non-URL-like input with a 'verbatim' top match adds a "www.<input>.com" top match with the control key pressed. Review URL: https://chromiumcodereview.appspot.com/10541092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141496 0039d316-1c4b-4281-b951-d872f2087c98
* Don't cancel instant if renderer is clicked during IME composition.falken@chromium.org2012-06-111-1/+6
| | | | | | | | | | | | | | | This fixes the bug on Linux and Windows, but not on Mac. BUG=95397 TEST=enable instant. compose in an IME but don't commit, wait for instant to run, then click a link in the results. verify the link is navigated to as expected. Review URL: https://chromiumcodereview.appspot.com/10540046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141392 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 4.avi@chromium.org2012-06-083-8/+7
| | | | | | | | | | | | Autocomplete. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10533046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141137 0039d316-1c4b-4281-b951-d872f2087c98
* If we promote a shorter match above a longer one, and the longer one was ↵pkasting@chromium.org2012-06-073-87/+141
| | | | | | | | | | inline autocompletable, make sure the shorter one is too. BUG=6798 TEST=none Review URL: https://chromiumcodereview.appspot.com/10543047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141088 0039d316-1c4b-4281-b951-d872f2087c98
* Gets suggested text to work with aura.sky@chromium.org2012-06-071-0/+3
| | | | | | | | | | BUG=none TEST=none R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10545059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141068 0039d316-1c4b-4281-b951-d872f2087c98
* Move ScoredHistoryMatch into Its Own Set of Filesmrossetti@chromium.org2012-06-072-0/+5
| | | | | | | | | | | Created scored_history_match.h/cc and moved the ScoredHistoryMatch struct therein. Moved all scoring functions into that struct. Created scored_history_match_unittest.cc and moved scoring tests therein. BUG=None TEST=All unit tests pass. Review URL: https://chromiumcodereview.appspot.com/10541045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141004 0039d316-1c4b-4281-b951-d872f2087c98
* Guard Against Bad Classificationsmrossetti@chromium.org2012-06-061-2/+7
| | | | | | | | | | | | | | Added safety valve so that there will be no attempt to set an attribute on an string beyond its end. Also, be consistent in using NSInteger by carrying around |nextOffset| as one. Enhanced the diagnostic output for the AutocompleteMatch::ValidateClassifications function so that the underlying perpetrator of the problem can more easily be identified. NOTE: This is a partial fix in that the true underlying cause of the bad classification range has not yet been addressed. So this bug will be left open. BUG=121703 TEST=Visit http://www.hurriyet.com.tr/. Bring up a new tab. Type 's' into the omnibox. No crash means success. Review URL: https://chromiumcodereview.appspot.com/10537010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140747 0039d316-1c4b-4281-b951-d872f2087c98
* Enforce a minimum score for the top SearchProvider match.msw@chromium.org2012-06-063-72/+128
| | | | | | | | | | | | | | Disregard suggested verbatimrelevance if top score < SWYT. SWYT: the classically calculated verbatim relevance. Update SearchProviderTest.SuggestRelevanceExperiment. Rename CalculateRelevanceForVerbatim, add GetVerbatimRelevance. BUG=125871 TEST=SearchProviderTest.SuggestRelevanceExperiment; manual. Review URL: https://chromiumcodereview.appspot.com/10544017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140713 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 1.avi@chromium.org2012-06-051-1/+2
| | | | | | | | | BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10528002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140523 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox SearchProvider Experiment Client Implementation.msw@chromium.org2012-06-056-49/+270
| | | | | | | | | | | | | | | | | | | See http://goto/omnibox-v20-experiment and http://b/6426178 *Accept suggestion and verbatim relevance scores extensions. *Keep inline autocompletable matches between URL requests. -Only accept suggested relevances if Instant is disabled. -Reject scores that make the top match non-inlinable. -Make BestURLPrefix perform case-insensitive comparison. TODO: Limit # of suggestions parsed or clamp their scores? BUG=125871 TEST=SearchProviderTest.SuggestRelevanceExperiment & manual. Review URL: https://chromiumcodereview.appspot.com/10274023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140512 0039d316-1c4b-4281-b951-d872f2087c98
* Move the rest of the content\test headers that are used by embedders to ↵jam@chromium.org2012-06-041-1/+1
| | | | | | | | | | content\public\test. This way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10483003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140287 0039d316-1c4b-4281-b951-d872f2087c98
* Move test_browser_thread.h from content\test to content\public\test. This ↵jam@chromium.org2012-06-045-5/+5
| | | | | | | | | | way we can enforce that internal content headers don't leak to embedders. BUG=98716 TBR=phajdan.jr Review URL: https://chromiumcodereview.appspot.com/10500016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140254 0039d316-1c4b-4281-b951-d872f2087c98
* Add SearchProvider nav result inline autocompletion.msw@chromium.org2012-06-019-93/+348
| | | | | | | | | | | | | | | | | | | SearchProvider::NavigationToMatch authored by PKasting. Consolidate URLPrefix code; add many unit test cases. Trim |contents| and |fill_into_edit|'s http scheme if: -the input does not contain "http:" -and the input is not a leading substring of "http:". TODO: Add file and chrome schemes as inlineable prefixes? TBR=sky (chrome/browser/history OWNERS) BUG=125871 TEST=Automated; manual with upcoming suggest experiments. Review URL: https://chromiumcodereview.appspot.com/10396002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139964 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a SearchProvider parsing regression; etc.msw@chromium.org2012-06-013-76/+112
| | | | | | | | | | | | | | | | | | | | | | SearchProvider match ranking regressed in r135984. Parsing in reverse only considered the 3 worst results :( Luckily, there are rarely/never more than 3 results :) Restore ranking (with a subtle change for < 3 results): Rank X+2[,X+1][,X+0] not [X+2,][X+1,]X+0 for base score X. Use min_element for AddNavigationResultsToMatches. Simplify ParseSuggestResults; return if results were updated. Allow navigation results without descriptions / titles. Add a unit test and fixup SearchProviderTest.Navsuggest. Fix a subtle keyword input bug via have_suggest_results_. BUG=128257 TEST=New SearchProviderTest.SuggestRelevance Review URL: https://chromiumcodereview.appspot.com/10432008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139963 0039d316-1c4b-4281-b951-d872f2087c98
* Don't cache tab_contents.sreeram@chromium.org2012-05-291-12/+5
| | | | | | | | | | | | | I think it's safer to always ask for the current tab_contents from the Browser, to avoid any potential issues with accessing a dangling tab_contents_ (and to avoid having to think deeply and reason about these cases). BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10454047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139364 0039d316-1c4b-4281-b951-d872f2087c98
* Pass command line arguments onto platform apps which provide the right intent.benwells@chromium.org2012-05-261-1/+1
| | | | | | | | | | | | | Any command line arguments which are file names are passed through in launchData.intent BUG=None TEST=New tests added Review URL: https://chromiumcodereview.appspot.com/10332071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139195 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded scoped_ptr.h includes from chrome/browser.thestig@chromium.org2012-05-261-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=owners Review URL: https://chromiumcodereview.appspot.com/10386221 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139172 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Make providers respect FORCED_QUERYmpearson@chromium.org2012-05-253-3/+6
| | | | | | | | | | | The HistoryContentsProvider, ExtensionProvider, and ShortcutsProvider are erroneously returning results for FORCED_QUERY omnibox inputs such as ?fac. This means URLs show up as suggestions when they shouldn't. This fixes it. BUG= TEST=type ?fac in the omnibox Review URL: https://chromiumcodereview.appspot.com/10443012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139094 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Instant field trials.sreeram@chromium.org2012-05-251-4/+1
| | | | | | | | | | | | | This unlaunches the SILENT mode, but only for a little while. After the rest of the refactoring is done, I'll put back the SILENT mode, along with appropriate browser tests for all modes. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10453011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@139057 0039d316-1c4b-4281-b951-d872f2087c98
* Extension/App Omnibox provider cleanupmihaip@chromium.org2012-05-254-70/+158
| | | | | | | | | | | | | | | | | - Allow platform apps to be launched (they don't really have a launch URL) - Don't display launch URLs for platform apps or packaged apps (they're chrome-extension:// URLs that we don't show in the omnibox once loaded) - Move LaunchAppFromOmnibox from omnibox_api.cc to extension_app_provider.cc since it's related to the Omnibox API, but is used on matches given by the provider. BUG=129494 R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10436014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138946 0039d316-1c4b-4281-b951-d872f2087c98
* In keyword search mode the SearchProvider won't provide a "what you typed" ↵pkasting@chromium.org2012-05-241-2/+3
| | | | | | | | | | result, so don't add a slot for it. BUG=none TEST=Type "google.com <search query>" and ensure you get at most one navsuggest and two search suggest results in addition to the default "what you typed" keyword search result. Review URL: https://chromiumcodereview.appspot.com/10426003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138881 0039d316-1c4b-4281-b951-d872f2087c98
* Change WaitForHistoryToLoad to Take a HistoryService...mrossetti@chromium.org2012-05-241-2/+4
| | | | | | | | | | ...instead of a Browser. This makes the function more general and will allow me to call it directly from some new unit tests that don't actually have a Browser, but do have a HistoryService. BUG=NONE TEST=Existing tests pass. Review URL: https://chromiumcodereview.appspot.com/10332316 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138832 0039d316-1c4b-4281-b951-d872f2087c98
* Change most content::URLFetcher references to net::URLFetcherakalin@chromium.org2012-05-231-2/+2
| | | | | | | | | | | | | | | | The only remaining use of content::URLFetcher is content::URLFetcher::Create. Make content::URLFetcher not inherit from net::URLFetcher. Also make code that directly create URLFetcherImpl instead call content::URLFetcher::Create. BUG=118220 TEST= TBR=mnissler@chromium.org,sky@chromium.org,mal@chromium.org,sail@chromium.org Review URL: https://chromiumcodereview.appspot.com/10412050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138443 0039d316-1c4b-4281-b951-d872f2087c98
* Remove content::URLFetcherDelegateakalin@chromium.org2012-05-222-7/+11
| | | | | | | | | | | | | | | | | Change all references to net::URLFetcherDelegate. Change some instances of content::URLFetcher to net::URLFetcher as needed. Remove unused files auth_response_handler.*. BUG=118220 TEST= TBR=sky@chromium.org,joi@chromium.org,mnissler@chromium.org,rlp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10392192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138384 0039d316-1c4b-4281-b951-d872f2087c98
* Fix possible crash in FinalizeInstantQuery() if AddMatchToMap() fails.pkasting@chromium.org2012-05-211-3/+8
| | | | | | | | | | It's not clear to me why this is happening frequently. This should only fail if there is no default provider, but if that's true how are we doing instant? ...Whatever. BUG=128575 TEST=none Review URL: https://chromiumcodereview.appspot.com/10392184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138135 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension into extensions namespaceaa@chromium.org2012-05-211-2/+2
| | | | | | | | | BUG=117262 TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/10375021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: search provider: fix timing histogrammpearson@chromium.org2012-05-181-6/+12
| | | | | | | | | | | | | | The current implementation of the timing histogram causes a DCHECK when search provider suggest requests switch from success to failure or vice versa. This fixes the problem. I cannot test this to see if it works. I think it should. (The only machine I have configured to build chrome on is remote, so I cannot play with whether its network is enabled or not lest I lose my connection to it permanently.) BUG=128613 TEST= Review URL: https://chromiumcodereview.appspot.com/10382224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137943 0039d316-1c4b-4281-b951-d872f2087c98
* Adds per-provider information to omnibox UMA logs.mpearson@chromium.org2012-05-155-3/+82
| | | | | | | | | | | Adds a fairly general structure to omnibox logs that can be used to pass information (that's not per-result information) from providers to the UMA logs. Right now it's only used to pass whether the asynchronous pass of a provider has finished, but it will probably be used for other things in the future. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10380007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137288 0039d316-1c4b-4281-b951-d872f2087c98
* Add SearchProvider's most relevant NavigationResult to |matches_|.msw@chromium.org2012-05-152-11/+14
| | | | | | | | | | | | | | | This fixes a regression from http://crrev.com/135984. The reversed result parsing unintentionally left the nav results unsorted. Suggest results are unaffected, as they're all added to map and sorted. Subsequent CLs should help make this whole process cleaner. BUG=125871 TEST=Automated. Also, the *first* NAVIGATION result from suggest JSON is used as a SearchProvider match. Review URL: https://chromiumcodereview.appspot.com/10381121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137080 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Move the tabs directory into ui.tfarina@chromium.org2012-05-111-1/+1
| | | | | | | | | | BUG=127798 R=ben@chromium.org TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10332124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136669 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcherDelegate to net/ and split URLFetcher between net/ and content/akalin@chromium.org2012-05-112-3/+3
| | | | | | | | | | | | | | | | | | | | | Temporarily make a shim content::URLFetcherDelegate class. A future CL will replace all instances of content::URLFetcherDelegate with net::URLFetcherDelegate and remove that class. Move most URLFetcher methods to net::URLFetcher, except for the static methods (which will be handled in a future CL) and AssociateWithRenderView, which is content-specific. Replace all instances of content::URLFetcher* in the URLFetcherDelegate callbacks with net::URLFetcher* (except for rlz, which required its own special hack). BUG=118220 TEST= TBR=mnissler@chromium.org,jhawkins@chromium.org,cpu@chromium.org,estade@chromium.org,sky@chromium.org,joth@chromium.org,satish@chromium.org Review URL: https://chromiumcodereview.appspot.com/10386063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136514 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring AutocompleteActionPredictor Database.shishir@chromium.org2012-05-101-1/+4
| | | | | | | | | | BUG= TEST=Same as before Review URL: https://chromiumcodereview.appspot.com/10380041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136439 0039d316-1c4b-4281-b951-d872f2087c98
* Change name of location_entry accessor in LocationBar to GetLocationEntry to ↵dominich@chromium.org2012-05-102-58/+48
| | | | | | | | | | | | match accepted style. BUG=NONE TEST=NONE Review URL: https://chromiumcodereview.appspot.com/10387044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136386 0039d316-1c4b-4281-b951-d872f2087c98
* Rename *ExperimentID API methods to *VariationID.stevet@chromium.org2012-05-091-2/+2
| | | | | | | | | | BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10383068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@136118 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-11-25 21:59:08 +0000