summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Clean-up of the accelerator code.jcampan@chromium.org2009-05-141-2/+2
| | | | | | | | | | | | | | | The View::CanProcessTabKeyEvents and View::ShouldLookUpAccelerator have both been replaced with a new method, SkipDefaultKeyEventProcessing. This new method provides for a view that has focus a way to prevent a key event from being processed for tab traversal or accelerators. Also, fixed a regression where the Ctrl-Tab accelerator was not working anymore when the omnibox was focused. BUG=11538 TEST=Thoroughly test accelerators, making sure they work when the page, the omnibox and the find-bar text-field have focus. Also test that tab traversal still work as expected in the browser and in the option dialog. Review URL: http://codereview.chromium.org/113307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16037 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Address Mike's last complaint about Issue 114017.shess@chromium.org2009-05-121-3/+5
| | | | | | | | | | http://codereview.chromium.org/114017 Add comment about operation of PropertyAccessor<> instance. Review URL: http://codereview.chromium.org/113275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15867 0039d316-1c4b-4281-b951-d872f2087c98
* Use Chrome facilities for omnibox state save and restore on Mac.shess@chromium.org2009-05-112-21/+120
| | | | | | | | | | | | | | | | | TabContents has a facility for storing a bag of stuff across current-tab changes. Wire up AutocompleteEditViewMac to use that facility. Unfork some code in Browser::TabSelectedAt() so that the new code gets used, and straighten up the Mac code along the code path between there and AutocompleteEditViewMac. This overall change also exposed a couple bugs/mis-features in the AutocompleteEditViewMac code. TEST=Text field maintains contents and selection across tab changes, even when edited. Review URL: http://codereview.chromium.org/114017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression where exact-match URLs could fail to be promoted when longer ↵pkasting@chromium.org2009-05-113-31/+53
| | | | | | | | | | | URLs were typed more. We should alwys look up whether we have an exact match, regardless of the input type, and use it if we have it. My change to not add the "exact match" entry for UNKNOWN input should have only affected the case where that match doesn't, in fact, exist. BUG=1844093 Review URL: http://codereview.chromium.org/113223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15786 0039d316-1c4b-4281-b951-d872f2087c98
* Style the omnibox results for v2.shess@chromium.org2009-05-113-12/+535
| | | | | | | | | | The style is based on the gtk code (autocomplete_popup_view_gtk.cc), with some local tweaks. I broke this off from the rest of the review so I could experiment with making it nail omnibox-v2, but eventually realized that I don't have enough data for that. This at least makes things look nicer, and I believe it provides all of the function that will be needed (the remainder is precisely defining fonts and colors and possibly minor highlighting variations). Summary: I want something concrete so that complaints about v2 wrongness can be specific. Review URL: http://codereview.chromium.org/99312 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15777 0039d316-1c4b-4281-b951-d872f2087c98
* Move win_util.h from common to app.ben@chromium.org2009-05-081-1/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Move color_utils, text_elider, drag_utils, accessibility_types, ↵ben@chromium.org2009-05-083-3/+3
| | | | | | | | | standard_layout to new locations in app/ and views/ http://crbug.com/11387 Review URL: http://codereview.chromium.org/113143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15687 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-084-5/+5
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Move pgup/dn special casing to browser window gtk.estade@chromium.org2009-05-071-19/+0
| | | | | | Review URL: http://codereview.chromium.org/112006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15586 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Handle some accelerators after the focused widget has had a chance to ↵estade@chromium.org2009-05-071-0/+19
| | | | | | | | | | | | | | | handle the keypress. Also, don't try to give the browser commands that are disabled. ---- (this description may need to be re-written) BUG=11526 Review URL: http://codereview.chromium.org/113050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15570 0039d316-1c4b-4281-b951-d872f2087c98
* Move: drag_drop_types, favicon_size, icon_util, insets, path, ↵ben@chromium.org2009-05-061-1/+1
| | | | | | | | | message_box_flags, os_exchange_data to src/app http://crbug.com/11387 Review URL: http://codereview.chromium.org/115012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15371 0039d316-1c4b-4281-b951-d872f2087c98
* move chrome_font to app/gfxben@chromium.org2009-05-064-4/+4
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/115010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15367 0039d316-1c4b-4281-b951-d872f2087c98
* Move chrome_canvas to app/gfxben@chromium.org2009-05-062-2/+2
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15361 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-056-7/+7
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Convert autocomplete to use a custom matrix and button cell.shess@chromium.org2009-05-052-130/+221
| | | | | | | | | | | | | | | On the user-visible side this change enables mouse hover (the item under the mouse is highlighted), and lays out the text omnibox v2 style. Only hover really needed the control change, but I have another change queued up to style the popup text. It uses different colors and shades, and really looked horrible with the NSTableView highlighting. [Which is why this part of the CL is coming first.] TEST=Omnibox popup works and shows highlighting under the mouse in addition to the keyboard-selected item. Review URL: http://codereview.chromium.org/99310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15321 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of the ClipboardService class and header... it is nothing but a ↵ben@chromium.org2009-05-051-3/+2
| | | | | | | | | | shell around base::Clipboard now. http://crbug.com/11387 Review URL: http://codereview.chromium.org/105011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15274 0039d316-1c4b-4281-b951-d872f2087c98
* Adds toplevel app/ directory and moves ResourceBundle into it.ben@chromium.org2009-05-052-6/+6
| | | | | | | | | | | No changes to resource bundle yet, just the move to keep this CL as compact as possible. Adds new vcproj and gyp file for app dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100354 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15264 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in search provider. It wasn't setting template_url andsky@chromium.org2009-05-042-0/+11
| | | | | | | | | | | correct fill_into_edit for keywords. BUG=11416 TEST=see bug Review URL: http://codereview.chromium.org/100350 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15245 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some recently small size / position regressions in Linux Omnibox.deanm@chromium.org2009-05-041-1/+1
| | | | | | | Review URL: http://codereview.chromium.org/100343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15204 0039d316-1c4b-4281-b951-d872f2087c98
* roll back r15177ben@chromium.org2009-05-041-1/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15191 0039d316-1c4b-4281-b951-d872f2087c98
* Extract all views resources into:ben@chromium.org2009-05-041-0/+1
| | | | | | | | | | | | | views_strings.[grd,vcproj] views_resources.[grd,vcproj] Moves views images (.png files) from app/theme to views/resources dir. http://crbug.com/11387 Review URL: http://codereview.chromium.org/100317 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15177 0039d316-1c4b-4281-b951-d872f2087c98
* Remove StopAutocomplete() helper from AutocompletePopupViewMac.shess@chromium.org2009-05-013-6/+2
| | | | | | | | When the code was originally written, GetModel() was not required by AutocompletePopupView, now it's easy enough to use that instead. Review URL: http://codereview.chromium.org/99278 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15094 0039d316-1c4b-4281-b951-d872f2087c98
* Release the autocomplete popup panel when not visible.shess@chromium.org2009-05-011-0/+8
| | | | | | Review URL: http://codereview.chromium.org/100260 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15061 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a small undercalculation of the space available a result description.deanm@chromium.org2009-05-011-3/+3
| | | | | | | | | Calculate from the actual text width, not the allocated text width. Review URL: http://codereview.chromium.org/99222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15042 0039d316-1c4b-4281-b951-d872f2087c98
* Patch for accelerator clean-up from Hamaji.jcampan@chromium.org2009-04-301-0/+2
| | | | | | | | | | See http://codereview.chromium.org/99161 TBR=hamami Review URL: http://codereview.chromium.org/99228 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14982 0039d316-1c4b-4281-b951-d872f2087c98
* Add a dark selected icon set for the Omnibox results.deanm@chromium.org2009-04-301-5/+7
| | | | | | | | | This is used for Linux, where we're currently not doing inverse selection. Review URL: http://codereview.chromium.org/100207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14944 0039d316-1c4b-4281-b951-d872f2087c98
* The "size-request" event is run-first, clean up the Omnibox handler.deanm@chromium.org2009-04-302-9/+8
| | | | | | | | | | | This wasn't actually a bug in that everything worked fine. It just meant we were calling the default handler twice, and returning from what should have been a void function. Review URL: http://codereview.chromium.org/99218 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14943 0039d316-1c4b-4281-b951-d872f2087c98
* Use the new selected icons in Linux Omnibox.deanm@chromium.org2009-04-301-7/+12
| | | | | | | Review URL: http://codereview.chromium.org/100200 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14942 0039d316-1c4b-4281-b951-d872f2087c98
* Unref the GC so it's destroy after we create it.deanm@chromium.org2009-04-291-0/+2
| | | | | | | Review URL: http://codereview.chromium.org/99190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14848 0039d316-1c4b-4281-b951-d872f2087c98
* Back to creating a new GC for each expose.deanm@chromium.org2009-04-291-2/+1
| | | | | | | | | | | The style (or at least the GCs) are shared across widgets, so they shouldn't be modified, or should be restored. Creating a GC should be cheap enough, I was overthinking this. Review URL: http://codereview.chromium.org/100161 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14845 0039d316-1c4b-4281-b951-d872f2087c98
* Support PgUp/PgDn in Omnibox for "first entry/last entry"ukai@chromium.org2009-04-294-17/+32
| | | | | | | BUG=6857 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14827 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork some code who's dependency has landed on Mac.shess@chromium.org2009-04-271-6/+0
| | | | | | | | | I believe that this was originally commented out due to fonts not being quite wired in. Review URL: http://codereview.chromium.org/92142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14667 0039d316-1c4b-4281-b951-d872f2087c98
* Update selected line in model before accepting input when the user clicks in ↵shess@chromium.org2009-04-272-5/+6
| | | | | | | | | | the popup. BUG=10932 Review URL: http://codereview.chromium.org/93130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14659 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up construction of LocationBarViewMac objects.shess@chromium.org2009-04-274-24/+14
| | | | | | | | | | | This removes the need for SetField() accessors on AutocompleteEditViewMac and AutocompletePopupViewMac, and also removes the Init() wart on LocationBarViewMac. Now everything is wired up in the constructor. Review URL: http://codereview.chromium.org/92136 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14641 0039d316-1c4b-4281-b951-d872f2087c98
* Remove svn:executable and set svn:eol-style to LF.tc@google.com2009-04-274-0/+0
| | | | | | | TBR=dean Review URL: http://codereview.chromium.org/99060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14611 0039d316-1c4b-4281-b951-d872f2087c98
* Searching by keyword now generates a visit against the site with asky@chromium.org2009-04-272-3/+3
| | | | | | | | | | | | | | | | transition type of TAB_TO_SEARCH. This visit increments the typed count and ensures if you use TAB_TO_SEARCH you still get autocompleted to the site. I'll add some tests for this, but want to make sure we're ok with it before I do that. BUG=3633 TEST=will be covered by unit tests. Review URL: http://codereview.chromium.org/93087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14609 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Omnibox results improvements:deanm@chromium.org2009-04-272-92/+92
| | | | | | | | | | | | | - Honor the damage rect when painting result lines. - Move some code from GdkRectangle to gfx::Rect. - Drop GC creation and just use one from the widget's style. - Fix a bug in content/description width allocation. - Factor out the icon loading and switch into IconForMatch(). Review URL: http://codereview.chromium.org/99050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14605 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutocompletePopupPositioner for the Linux Omnibox.deanm@chromium.org2009-04-274-29/+18
| | | | | | | | | | | Now a few less magic numbers in exchange for a lot more plumbing. BUG=10966 Review URL: http://codereview.chromium.org/92127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14592 0039d316-1c4b-4281-b951-d872f2087c98
* Linux Omnibox mouse support.deanm@chromium.org2009-04-272-4/+103
| | | | | | | | | | | | - Paint both concepts of hovered and selected lines. - Track mouse movements and button up/down. TEST=Select, drag, and click entries in the Omnibox results. Should behave just like Windows. Review URL: http://codereview.chromium.org/92124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14591 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14489.jcampan@chromium.org2009-04-241-7/+0
| | | | | | Review URL: http://codereview.chromium.org/99004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14492 0039d316-1c4b-4281-b951-d872f2087c98
* This CL makes sure we unregister our Windows window classes when shut-down.jcampan@chromium.org2009-04-241-0/+7
| | | | | | | | | | | | It also balances-out an OLE initialization performed by the CRichEditCTRL. This is necessary for allowing to reload chrome.dll in a process, which is what the browser tests will do. BUG=None TEST=None Review URL: http://codereview.chromium.org/93026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14489 0039d316-1c4b-4281-b951-d872f2087c98
* Fix DCHECK when typing certain kinds of input on certain profiles.pkasting@chromium.org2009-04-241-1/+3
| | | | | | | | | This is actually a very old bug that some of my recent changes exposed more widely. In PromoteOrCreateShorterSuggestion(), we could create a totally bogus search base, which, if added to the history matches, would then break. In the old code, we'd create this match, but usually not add it to the history match set because we'd already have a What You Typed match; in my new code that's frequently no longer the case. BUG=10926 Review URL: http://codereview.chromium.org/92154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14470 0039d316-1c4b-4281-b951-d872f2087c98
* The accidental search infobar was almost never appearing. Fix that ↵pkasting@chromium.org2009-04-246-103/+87
| | | | | | | | | | | regression. Now we don't rely on the presence of a "what you typed" match in the result set; instead the AutocompleteResult determines the alternate nav URL directly. To do this I refactored some of the code from the history URL provider over to AutocompleteInput. BUG=10808 Review URL: http://codereview.chromium.org/92140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14463 0039d316-1c4b-4281-b951-d872f2087c98
* Override GtkTextView's size request width in the Linux Omnibox.deanm@chromium.org2009-04-242-0/+21
| | | | | | | | | | | GtkTextView requests enough space to fit all of the text. It turns out if you weren't doing something to restrict the window size (like using a tiling manager) long text in the edit would push the window to fit the text. Review URL: http://codereview.chromium.org/93127 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14449 0039d316-1c4b-4281-b951-d872f2087c98
* A basic search provider unit test. This tests asserts a handful of things:sky@chromium.org2009-04-233-10/+287
| | | | | | | | | | | | | | | | | | . The default/keyword suggest providers are queried appropriately. . History results are asked for default/keyword providers. More assertions can be added over time, but we have to start some where. This uncovered one bug in SearchProvider, we were never marking the provider as properly done. BUG=3636 TEST=none Review URL: http://codereview.chromium.org/87062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14315 0039d316-1c4b-4281-b951-d872f2087c98
* Move the positioner code into autocompletepopupview.h so that linux can use ↵ben@chromium.org2009-04-231-2/+13
| | | | | | | | it too. Review URL: http://codereview.chromium.org/87007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14284 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fixes xji@chromium.org2009-04-211-13/+36
| | | | | | | | | | | | | | | | | issue 6125 - [edit search engines] after hitting right ctrl+shift, can't change insertion point with the mouse and issue 8686 - RTL: Can't select RTL text from Chrome UI boxes The problem is cursor positioning and cursor selection in CRichEditCtrl in RTL layout. (cursor positioning is fine even for RTL characters in LTR layout, but cursor positioning is not working even for LTR characters in RTL layout). The fix is correctly calculation of input boundary in ClipXCoordToVisibleText(), and the fix is mostly part of Nick Carter's un-committed fix in https://svn.corp.google.com/review/chrome/desc/cb/ncarter/rtl_richedit_fixes@50605 BUG=6125 BUG=8686 Review URL: http://codereview.chromium.org/86003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14158 0039d316-1c4b-4281-b951-d872f2087c98
* Better omnibox handling of numeric input. Now we search based on the user's ↵pkasting@chromium.org2009-04-213-11/+46
| | | | | | | | | | original input instead of a transformed dotted quad when typing numeric hostnames; this should help noticeably in countries like China where such hostnames ("56.com") are popular. Original patch by Fumitoshi Ukai (see http://codereview.chromium.org/88011 ), r=me. BUG=10054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14156 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix issue 2674 - search engine name containing parenthesis is not ↵xji@chromium.org2009-04-212-3/+4
| | | | | | | | | | | | | | displayed correctly in Omnibox NavSuggest drop-down list. The fix is to adjust the search engine name according to locale direction so that the search engine name containing parenthesis are marked with RLE-PDF to be displayed correctly in RTL UI. BUG=2674 Review URL: http://codereview.chromium.org/79005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14119 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-19 15:24:20 +0000