summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Linux: Update PRIMARY selection on omnibox copy-to-clipboard.derat@chromium.org2009-08-182-0/+21
| | | | | | | | | | | | | | | | | | | | | | | | | This brings us in line with Firefox's behavior. Ctrl-L highlights the URL but doesn't update the PRIMARY selection, so Ctrl-C is a common* way to get the current location into PRIMARY so you can middle-click somewhere else to paste it. * I use it and a user mentioned that they do too. :-P Tested as follows: - highlight some text on the page to make it PRIMARY - hit Ctrl-L and confirm that text on page is still PRIMARY - hit Ctrl-C and confirm that location is now PRIMARY - repeat, but this time hit the right arrow key between Ctrl-L and Ctrl-C to unhighlight the text first. the text on the page should remain the PRIMARY selection BUG=18403 TESTED=see above Review URL: http://codereview.chromium.org/164539 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23596 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-1/+2
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Match Windows and GtkEntry move cursor with selection behavior.deanm@chromium.org2009-08-141-7/+18
| | | | | | | Review URL: http://codereview.chromium.org/170002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23451 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Add view ids to our widgets. These will be used for testing.estade@chromium.org2009-08-131-0/+3
| | | | | | | | | | Also add unit test to test test infrastructure. BUG=19214 Review URL: http://codereview.chromium.org/164519 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23392 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression caused by CL 16142suzhe@chromium.org2009-08-132-11/+123
| | | | | | | | | | | | | This CL fixes regression caused by CL 16142: Improve key event handling of AutocompleteEditViewGtk. BUG=19193: omnibox blocks ctrl-* commands BUG=19199: omnibox ignores history, automatically searchs TEST=Open chrome, move cursor into omnibox then press ctrl-t to see if a new tab is opened. TEST=Open chrome, input something in omnibox and make sure an url is matched and some text is highlighted in omnibox, then press Enter to see if the url is opened. Review URL: http://codereview.chromium.org/165457 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23388 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Omnibox popup metrics.shess@chromium.org2009-08-132-9/+31
| | | | | | | | | | | | | | | | | Use en-dash instead of em-dash to separate match and description. Popup font a little smaller than field font. Make cell taller, and no gap between cells. Use BaseFont from ResourceBundle instead of field's default font (this is what Windows uses, I think). http://crbug.com/19184 Review URL: http://codereview.chromium.org/164418 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23273 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: autocomplete popup size and shape mirrors star/go buttons.shess@chromium.org2009-08-121-3/+86
| | | | | | | | | | Also line up image and title columns under star and field. http://crbug.com/19182 Review URL: http://codereview.chromium.org/164415 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23253 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-121-8/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Make autocomplete popup track autocomplete field resizes.shess@chromium.org2009-08-121-0/+26
| | | | | | | | | http://crbug.com/17402 TEST=Enter text in the omnibox and resize the window. Popup size should follow. Review URL: http://codereview.chromium.org/165332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23225 0039d316-1c4b-4281-b951-d872f2087c98
* Improve key event handling of AutocompleteEditViewGtk.suzhe@chromium.org2009-08-122-64/+120
| | | | | | | | | | | | | | | | | | | This CL improves key event handling of AutocompleteEditViewGtk class, following changes have been made: 1. Avoid accessing private data member of GtkTextView object, including im_context, need_im_reset etc. 2. Always send key events to the default handler of GtkTextView before handling them by ourselves, to make sure the behavior of IME and GtkTextView are always correct. This fixes the issue of moving focus from omnibox to webpage by pressing Tab key when using XIM im module. 3. Intercept "insert-text" signal of GtkTextBuffer object to prevent any unwanted characters from being inserted into omnibox. 4. Intercept "backspace" signal of GtkTextView object to fix issue 19068: [Linux] Search keywords: Backspace should exit out of search mode BUG=18393: AutocompleteEditViewGtk should not access private members of GtkTextView BUG=19068: [Linux] Search keywords: Backspace should exit out of search mode TEST=Starts a XIM input method, such as scim then open chrome with GTK_IM_MODULE=xim. Opens a webpage and press tab and shift-tab in omnibox to see if focus can be moved to/from webpage correctly. TEST=Copy & paste some text with new line characters to omnibox to see if new line characters are filtered. TEST=Turn on keyword search mode, press backspace to see if it can exit keyword search mode. TEST= Turn on keyword search mode, input some text then press backspace to delete a character, to see if it still in keyword search mode. Then move the cursor to the beginning of the text and press backspace, to see if it exits keyword search mode correctly. Review URL: http://codereview.chromium.org/164142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23184 0039d316-1c4b-4281-b951-d872f2087c98
* Add a first attempt at a compact location bar and a status bar. The status barbrettw@chromium.org2009-08-112-11/+9
| | | | | | | | contains a clock, an application menu, and a non-working battery indicator. The compact location bar can be toggled by COMPACT_NAV_BAR in browser_window_gtk.cc Review URL: http://codereview.chromium.org/165272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23070 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: handle Escape in omnibox when numlock/scrolllock/caps lock is on.estade@chromium.org2009-08-061-1/+2
| | | | | | | | | BUG=18643 TEST=turn on num lock. Escape in omnibox resets the address. Review URL: http://codereview.chromium.org/165079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22659 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds accelerators to the Linux toolkit views.jcampan@chromium.org2009-07-311-2/+2
| | | | | | | | | | | The MessageLoop had to be modified to support Dispatchers on Linux. BUG=None TEST=On Windows and Linux, make sure the accelerators still work as expected. On Linux toolkit views, build and run the unit-tests. Review URL: http://codereview.chromium.org/159046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22210 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding r22155 (GTK Themes: Use theme colors in the text view in the ↵erg@google.com2009-07-312-21/+100
| | | | | | | | | | | | location bar.) Fixed build issues with Ben's help. Original Review URL: http://codereview.chromium.org/159671 Review URL: http://codereview.chromium.org/160466 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22181 0039d316-1c4b-4281-b951-d872f2087c98
* Make TOOLKIT_VIEWS port use views-based Autocomplete popup.ben@chromium.org2009-07-3113-985/+89
| | | | | | | | | | | | The popups now interact with the edit via AutocompleteEditView rather than the platform-specific types. Note this also removes the old omnibox popup code. It hasn't been active for some time. BUG=none TEST=none Review URL: http://codereview.chromium.org/160378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22168 0039d316-1c4b-4281-b951-d872f2087c98
* I give up. Reverting all attempts at fixing the gtk-view bustage.erg@google.com2009-07-312-77/+21
| | | | | | | | Reverts r22161,r22159,r22155 Review URL: http://codereview.chromium.org/159719 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22163 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Use theme colors in the text view in the location bar.erg@google.com2009-07-312-21/+77
| | | | | | | | Tested with a bunch of light and dark themes. Review URL: http://codereview.chromium.org/159671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22155 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert classes GtkUtil/GtkTreeUtil back to namespaces ↵mdm@chromium.org2009-07-311-3/+3
| | | | | | | | | | | gtk_util/gtk_tree_util. BUG=none TEST=none Review URL: http://codereview.chromium.org/160417 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22130 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement omnibox DnD destination behavior.estade@chromium.org2009-07-302-0/+40
| | | | | | | | BUG=18025 Review URL: http://codereview.chromium.org/160369 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22102 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: convert namespace gtk_util to class GtkUtil to meet style guidelines.mdm@chromium.org2009-07-301-3/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/160371 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22036 0039d316-1c4b-4281-b951-d872f2087c98
* Implement location only display mode (used by popup windows).tc@google.com2009-07-242-4/+11
| | | | | | | | | | | | This matches the pixel sizes on Windows. The location bar is a couple pixels shorter and the font is a little smaller. BUG=17580 Review URL: http://codereview.chromium.org/159303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21578 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Select omnibox text on button release instead of press.agl@chromium.org2009-07-232-26/+62
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We also don't select all of the text if the user dragged to highlight some text before releasing the button. Tested by repeating the scenarios from: http://codereview.chromium.org/151006 http://codereview.chromium.org/159185 plus checking that the following cases behave as expected: 1. Type some text into the omnibox. Click in Webkit to give it the focus. Click once in the omnibox. All of its text should be highlighted, and middle-clicking in another window should show that the primary selection was updated. 2. Click in the omnibox to clear its highlighted text and click in Webkit again. Click in the omnibox again, but this time drag to highlight some text before letting go of the button. The highlighted text should be preserved on button release, and the primary selection should be updated. 3. Repeat step 2. Click a few times in the omnibox and confirm that we don't select all of its text (that should only happen at the end of the initial click that focuses the omnibox). (Patch from Dan Erat) http://codereview.chromium.org/155971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21410 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Prevent omnibox autocomplete from stealing the primary X selection.estade@chromium.org2009-07-222-31/+75
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is mostly accomplished by decoupling autocomplete (and the auto-select-all when first clicking in the omnibox to focus it) from GTK's clipboard code. Before we update the selection marks, I unregister the clipboard and block the signal from reaching my handler. Afterwards, I restore things. This creates the possibly-odd effect that text can be highlighted both in the omnibox and in Webkit, assuming that the omnibox text isn't actually the primary selection. I think that this is reasonable, but let me know if you can think of a better way that it should be handled. To test, I confirmed that all of the cases listed in http://codereview.chromium.org/151006's description still work, along with the following new ones: 1. Highlight text in an xterm to make it the primary selection. Start typing an autocomplete-able URL into Chrome's omnibox. Middle-click in the xterm and check that the xterm's text, rather than the autocompleted text from the omnibox, is pasted. 2. Now switch to a different tab and middle-click in the xterm again. The xterm's text should still be pasted. 3. Switch to the original tab and check that the xterm's text is still the primary selection. 4. Highlight text in an xterm. Click in Webkit to make sure that the omnibox doesn't have the focus. Left-click in the omnibox. Its text should be highlighted but not made the primary selection (middle-clicking in the xterm should still paste the xterm's text). EDIT: I've changed this behavior -- clicking in the omnibox to focus it now sets its text as the primary selection. 5. Now triple-left-click in the omnibox to highlight all of its text. This time, the URL should become the primary selection. EDIT: This is no longer relevant. I noticed the following annoying behavior, but it's also present in the official build without this change, so I don't think it's a regression (there's probably something going on in GTK that I don't understand): Highlight some text in the omnibox to make it the primary selection. Now double-left-click to highlight a word in an xterm. The word flashes in the xterm, but Chrome automatically grabs the selection again. Double-clicking in the xterm again lets it hang on to the selection. Patch by Dan Erat <derat [at] google> original review url: <http://codereview.chromium.org/159185> Review URL: http://codereview.chromium.org/159230 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21329 0039d316-1c4b-4281-b951-d872f2087c98
* Try and improve result coalescing/display in the omnibox popup.pkasting@chromium.org2009-07-222-40/+11
| | | | | | | | | | | | | | | | | | | | | | | | This eliminates the delay timer in the popup view, and also eliminates the coalesce timer in the controller. Instead, we simply coalesce until we're done, we have at least as many results as we're already showing, or the "maximum delay timeout" (300 ms) fires, indicating we've gone too long without updating. Additionally, in order to be more responsive when typing rapidly, the controller updates observers immediately with the available results from a previous query if one is still running when a new query is started. While in theory this seems like it might produce flicker, in practice _not_ having it also results in flicker (just less-predictable flicker) since the 300 ms timeout starts kicking in at random times relative to when new keys are pressed. I also fixed a few small problems with leaving 1-pixel high white rows at the bottom of the popup during rapid typing (which weren't visible before this change since the popup would never shrink during rapid typing). After eliminating the timeout in the popup view, I was able to refactor the code to be shorter since a few members and helper functions could all be inlined. Then I added some long comments and made things not much shorter after all :/. I also changed two other (self-contained) unrelated spots in the popup to be shorter. Please patch this in locally and try how it feels. Things to test with this change vs. the old code vs. the old, old (original omnibox) code: * Type one letter at a time with long pauses in between; see how flickery the popup is * Type one letter (e.g. "a") and then type rapidly for a while; see how responsive the popup is * Type words like "amazon", "compusa" and "comcast" at various different speeds and observe the flicker vs. responsiveness tradeoff * Type or paste some long series of letters (that default to searching), then rapidly press and release the ctrl key My hope is that this hits a good balance (it's very difficult to be both flicker-free and responsive, I view the previous two sets of code as being off first one side of the scale and then the other). Possible tweaks include the animation tweening mechanism and timing (I experimented with various different speeds and linear tweening, nothing felt significantly better to me but my machine sucks w.r.t. animation quality) and tweaking the controller "max timeout" value and notification behavior upon starting a new query (I tried notifying only if two keys had been typed since the last notification, it didn't feel better). BUG=none TEST=see above Review URL: http://codereview.chromium.org/149659 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21322 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't handle up/down-arrow unless popup is visible.shess@chromium.org2009-07-222-8/+18
| | | | | | | | | | http://crbug.com/17013 TEST=Browse to www.google.com. Click in the field. Up-arrow should go to beginning of line, down-arrow to end. Review URL: http://codereview.chromium.org/155871 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21310 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Detect control-key changes in autocomplete field.shess@chromium.org2009-07-212-1/+33
| | | | | | | | | http://crbug.com/10934 TEST=Type 'something', and press Control. Autocomplete should show www.something.com at the top. If that's what you'd get anyhow, try a different word. Control-enter should take you there. Review URL: http://codereview.chromium.org/159105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21192 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Strip newlines from paste.shess@chromium.org2009-07-203-0/+155
| | | | | | | | | | | | | | http://crbug.com/11817 TEST=Copy an URL somewhere and break it apart with newlines at random places. Copy/paste it into omnibox and the newlines should be gone. Try this one: http://dev.chro mium.org/develo pers/how-tos/ge t-the-code Review URL: http://codereview.chromium.org/159018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21125 0039d316-1c4b-4281-b951-d872f2087c98
* Linux omnibox suggestions, only force LTR on URLs.deanm@chromium.org2009-07-161-5/+15
| | | | | | | | | | | I had previously forced LTR on all match contents. These are usually URLs, but in the case of history they are the search query. Use the classification to only for LTR on match contents that are actually URLs. Review URL: http://codereview.chromium.org/155636 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20867 0039d316-1c4b-4281-b951-d872f2087c98
* Work on RTL / BiDi Omnibox.deanm@chromium.org2009-07-161-12/+26
| | | | | | | | | Based on work from Evan Stade. Review URL: http://codereview.chromium.org/155567 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20862 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Refactor location-bar autocomplete cell classes.shess@chromium.org2009-07-162-7/+13
| | | | | | | | | | | LocationBarCell -> AutocompleteTextFieldCell. LocationBarFieldEditor -> AutocompleteTextFieldEditor. AutocompleteTextField added as placeholder for future work (hints and keyword search). Review URL: http://codereview.chromium.org/149717 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20853 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the default for what to do on startup be restore last session onsky@chromium.org2009-07-162-4/+10
| | | | | | | | | | | | | | chrome os as well as changing autocomplete edit/popup font sizes on chrome os. As suggested by Evan I've moved these options into chrome/browser/defaults.h so that we don't have a ton of #ifdefs every where. BUG=none TEST=none Review URL: http://codereview.chromium.org/155576 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20852 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove guard on FocusLocation() in autocomplete field.shess@chromium.org2009-07-152-12/+7
| | | | | | | | | | | | | | | | | Reapplies http://codereview.chromium.org/149492 . That version was accidentally calling this code as part of the class implementation, which caused the code to receive the "done editing" notification, which caused the code to drop the popup... This version stops using FocusLocation() internally, instead messaging field_ directly. http://crbug.com/12246 TEST=Type some stuff in address bar. Popup should popup with suggestions. With cursor still in bar, Command-l should select all. Review URL: http://codereview.chromium.org/155537 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20769 0039d316-1c4b-4281-b951-d872f2087c98
* Backing out r20493 (http://codereview.chromium.org/149492), as it ↵avi@chromium.org2009-07-142-3/+8
| | | | | | | | | | | inadvertently killed the Omnibox suggestion list. BUG=http://crbug.com/16714 TEST=Type in the omnibox; you should get a suggestion list. Review URL: http://codereview.chromium.org/149622 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20642 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] AcceptInput() doesn't really need focus (as when called via "Go" button).shess@chromium.org2009-07-131-5/+4
| | | | | | | | | http://crbug.com/15811 TEST=Browse to www.google.com. Focus is in document. Click Go. No more crash. Review URL: http://codereview.chromium.org/149487 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20495 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Always restyle omnibox after user input.shess@chromium.org2009-07-131-17/+6
| | | | | | | | | | | | Previous version was perhaps too optimal. This should be reasonable for now since it only happens at the pace the user can enter input. http://crbug.com/14628 TEST=Browse to www.google.com. Copy/paste the entire URL. Should be styled. Review URL: http://codereview.chromium.org/149489 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20494 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove guard on FocusLocation() in autocomplete field.shess@chromium.org2009-07-132-8/+3
| | | | | | | | | | | | I went auditing around, and AFAICT all remaining callers should be fine with selecting everything. http://crbug.com/12246 TEST=Type some stuff in address bar. With cursor in bar, Command-l should select all. Review URL: http://codereview.chromium.org/149492 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20493 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash when clicking a popup entry while composing in the Microsoft IME ↵pkasting@chromium.org2009-07-102-1/+26
| | | | | | | | | | | | on XP. We were forcing the IME to close during the process of updating the edit, which in turn caused us to try and handle "changes to the edit", leading to us (wrongly) rerunning autocomplete and blowing away our result set. BUG=13500 TEST=On XP, open a new tab, set the (Microsoft) IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate, not crash. Review URL: http://codereview.chromium.org/155330 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20395 0039d316-1c4b-4281-b951-d872f2087c98
* Added an helper namespace that provides fetches images from the app bundle ↵thomasvl@chromium.org2009-07-091-9/+10
| | | | | | | | | | | | | and caches them, line NSImage imageNamed: but lets us control the bundle that's checked. Unittest for the helper. Updated the current places that use +[NSImage imageNamed:] to use our cache helper. BUG=none TEST=All the ui images still load. Review URL: http://codereview.chromium.org/149393 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20309 0039d316-1c4b-4281-b951-d872f2087c98
* Copy parsed URL into CF_UNICODETEXT when user select entire of Omnibox.hamaji@chromium.org2009-07-091-12/+15
| | | | | | | | | | | | | | | | | | | | BUG=2820 BUG=8162 TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 and select entire text in Omnibox, then copy the text. Paste the copied text into other applications such as notepad and check if the pasted text contains %E4%B8%8A%E5%9C%B0, not 荳雁慍. Paste the copied text into Firefox's URL bar and type return. Check if you are navigated to the same website. Paste the copied text into textareas in Chrome and check if the pasted text contains %E4%B8%8A%E5%9C%B0. Paste the copied text into Gmail's rich text editing mode and check if the pasted text contains 荳雁慍. Right click the link you pasted in Gmail and check if you see "Go to: http://www.google.com/...%E4%B8%8A%E5%9C%B0". Paste the copied text into URL-aware softwares such as MS-word and check if the pasted text contains 荳雁慍. Check if the link in MS-word is pointing to encoded URL (http://www.google.com/...%E4%B8%8A%E5%9C%B0). TEST=Visit http://www.google.com/search?ie=UTF-8&q=荳雁慍 again and select "q=荳雁慍" in Omnibox, then copy the text. Paste it into somewhere and check if you see "q=荳雁慍". TEST=Copy "荳雁慍" from somewhere and paste it into Omnibox. Copy from Omnibox and paste it into notepad. Then check if the pasted text is NOT encoded. Review URL: http://codereview.chromium.org/119352 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20265 0039d316-1c4b-4281-b951-d872f2087c98
* Initial work on Linux tab to search.deanm@chromium.org2009-07-081-1/+8
| | | | | | | | | | | | | | Still are a bunch of more complicated behavior that doesn't work, like hitting backspace to remove the keyword. The keyword hint and keyword display more or less work, although things have gotten pretty complicated. BUG=10965 TEST=Tab to search with a keyword. Review URL: http://codereview.chromium.org/151209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20140 0039d316-1c4b-4281-b951-d872f2087c98
* Foundations for Print Preview and Setupmhm@chromium.org2009-07-031-5/+7
| | | | | | | | | | | | | Create the foundations of implementing a tab for printing should be in the form of: print:http://www.google.com I have followed similar approach as what has been done with view-source: and chrome-extension: BUG=173, 947 TEST=none Review URL: http://codereview.chromium.org/150207 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19906 0039d316-1c4b-4281-b951-d872f2087c98
* Make Linux restore Omnibox contents on tab switch.evan@chromium.org2009-07-012-29/+165
| | | | | | | | | | | | | | | | | | | | | | | Tested as follows: Create a new window with two tabs. Type a bunch of 'a' characters into tab A's omnibox and a bunch of 'b's into tab B. Then, 1. Select tab A. Left-click in the omnibox and highlight a few characters in the middle. Left-click in the empty space to the right of the text to unhighlight it, then middle-click to make sure that the previously-highlighted text still gets pasted. 2. Repeat 1, but hit a key to remove the selection instead of clicking the mouse. The old highlighted text should still be available as the primary selection. 3. Highlight A's text as in 1. Select tab B and see that the omnibox is updated to B's string and highlighting is removed. Middle-click and confirm that the previously-highlighted text from A is pasted. 4. Select A and left-click in the middle of its string to position the cursor there. Click on tab B and then back on A to check that A's cursor position is restored. 5. Highlight text in A. Select tab B and then highlight text from a different window. Switch back to A and middle-click. The text from the different window, rather than A's previously-highlighted text, should be pasted. BUG=9225 Review URL: http://codereview.chromium.org/151006 Patch from Dan Erat <derat@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19770 0039d316-1c4b-4281-b951-d872f2087c98
* Moved typedef of RedirectList from HistoryService class to history namespace.meelapshah@chromium.org2009-07-013-3/+3
| | | | | | Review URL: http://codereview.chromium.org/151168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19766 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Certain redirections remove sites from the historyyuzo@chromium.org2009-07-012-2/+2
| | | | | | | | | | | | | | | | | | | Currently, PageTransition::CHAIN_END flag is removed from a History database entry for a redirect source, even when the redirect is user initiated. This change prevents the flag removal for user-initiated redirects. TEST=Open http://www.google.com/ig and click on tabs multiple times. Without this change, only the last tab clicked appears in the History page (CTRL+H). With this change, all the tabs should appear. TESTED=gcl try, manually BUG=11355 Review URL: http://codereview.chromium.org/147145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19708 0039d316-1c4b-4281-b951-d872f2087c98
* This CL removes the last (major) Windows specific part out of the focus ↵jcampan@chromium.org2009-06-301-2/+1
| | | | | | | | | | | | | | | | | | | | | | | manager. It was previously landed and reverted because it broke the reliability tests. http://codereview.chromium.org/125148 The breakage was caused by constrained windows not getting a hold of the FocusManager when in unparented tabs. The fix is to ensure unparented tab still have a way to access their FocusManager for proper closure. Files changed from the previous patch that need reviewing: native_tab_contents_container_win.cc tab_contents_view_win.h tab_contents_view_win.cc BUG=None TEST=Run all tests (unit, ui, interactive). Extensively test the focus in Chrome. Review URL: http://codereview.chromium.org/146093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19617 0039d316-1c4b-4281-b951-d872f2087c98
* Update Skia transfer mode names in browser/* to Skia r239amanda@chromium.org2009-06-251-1/+1
| | | | | | | TBR=levin Review URL: http://codereview.chromium.org/147131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19218 0039d316-1c4b-4281-b951-d872f2087c98
* Original patch by pmarks@google.com (see http://codereview.chromium.org/113944)ericroman@google.com2009-06-232-17/+13
| | | | | | | | | | | | | | | | | | | | | | | - Pull in googleurl r107, which includes the new CanonicalizeHostVerbose() function: http://code.google.com/p/google-url/source/detail?r=107 - Atomically update Chromium to make use of this new function. This allows us to extract better information about IP addresses using fewer, and cleaner, calls to googleurl. - Also, change a call to CanonicalizeIPAddress() to stay compatible with r107. The upshot of all this is, Chrome will no longer try to connect to IPv4 addresses with overflow "http://192.168.0.257", or hostnames surrounded by square brackets "http://[google.com]" BUG=none TEST={unit_tests,googleurl_unittests,net_unittests} Review URL: http://codereview.chromium.org/146053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19076 0039d316-1c4b-4281-b951-d872f2087c98
* Paste and Go was missing on the omnibar this CL will append a menu item to ↵mhm@chromium.org2009-06-222-4/+45
| | | | | | | | | | | | the current Autocomplete edit box and by using Gtk clipboard, it will paste and search it. BUG=14800 (http://crbug.com/14800) TEST=Selected text from view and right clicked copied. Went to the omnibox and right clicked > Paste and Go. It navigated to the page successfully. Review URL: http://codereview.chromium.org/140050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18967 0039d316-1c4b-4281-b951-d872f2087c98
* More CHECKs in my continuing effort to figure out what is going on. Neither ↵pkasting@chromium.org2009-06-221-2/+2
| | | | | | | | | | Ben nor I can get this one. BUG=13500 TEST=none Review URL: http://codereview.chromium.org/140009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18947 0039d316-1c4b-4281-b951-d872f2087c98
* Revert :nsylvain@chromium.org2009-06-221-1/+2
| | | | | | | | | | | | | | | | | | Changed by: jcampan@chromium.org Changed at: Fri 19 Jun 2009 21:22:47 Branch: src Revision: 18889 Comments: Relanding focus manager refactoring with build fix, see:http://codereview.chromium.org/125148BUG=NoneTEST=NoneTBR=ben Review URL: http://codereview.chromium.org/141013 Because it creates hundreds of new reliability crashes. TBR:jcampan Review URL: http://codereview.chromium.org/140064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18904 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-10 20:16:07 +0000