summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Clipboard:estade@chromium.org2009-09-101-1/+3
| | | | | | | | | | | | | - Move link construction logic to scoped_clipboard_writer.cc - Make callers use EscapeForHTML on the anchor text - Make WriteHyperlink just write html, and not a bookmark as well (only affects one caller, which I updated) - implement WriteBookmark for gtk BUG=18034,18035 Review URL: http://codereview.chromium.org/194052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25833 0039d316-1c4b-4281-b951-d872f2087c98
* Replace icu38/icu38.gyp with icu/icu.gyp in gyp files replace all the ↵jshin@chromium.org2009-09-091-1/+1
| | | | | | | | | | | | | | | | | | references to third_party/icu38 and icudt38.dll with third_party/icu and icudt42.dll in vsprops and cc files. Also, update the icu data module name and the icu data symbol in icu_util.cc In addition, add a dummy C++ source file (xmldummy_mac.cc) to libxml to work around an Xcode bug (xmllint and xmlcatalog are linked with gcc rather than g++ even though it's linked to a "C++ library", libicuuc.a). Also updated is the test results for net_util_unittests. This will not be landed until deps/third_party/icu42 is ready for all 3 platforms (Windows VS build files are not yet updated there). BUG=8198 TEST=On all platforms, all the targets are built fine. Review URL: http://codereview.chromium.org/172031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25708 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-082-6/+10
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression introduced in dnd refactoring. I removed a check forsky@chromium.org2009-09-081-0/+3
| | | | | | | | | | | | | | the URL that I shouldn't have (it won't be needed at some point, but it is now). BUG=21198 TEST=Select a URL and drag to the tab strip. Make sure you get the drop target and you can drop the text to create a new tab. Do the same with www.google.com, you shouldn't get a drop target. Review URL: http://codereview.chromium.org/202010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25653 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 20934: Omnibox keyboard behavior wrong for "See recent pages in ↵suzhe@chromium.org2009-09-062-30/+36
| | | | | | | | | | | | | history" This CL fixes issue 20934 by eliminating the side effect caused by Enter key press event. BUG=20934: Omnibox keyboard behavior wrong for "See recent pages in history" TEST=Input something in omnibox, make sure it triggers "See N recent pages in history containing XXX", then select this item and press Enter to see if chrome://history/#q=XXX is opened. Review URL: http://codereview.chromium.org/196020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25585 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Drop shadow for Omnibox popup.shess@chromium.org2009-09-051-17/+9
| | | | | | | | | | | | | | | Adding the system drop shadow adds a border, so removed the border we were drawing. Also pushed all of the one-pixel-here-one-pixel-there positioning tweaks to -autocompletePopupPosition. http://crbug.com/20283 TEST=Omnibox popup border should have drop shadow, be two pixels below Omnibox, and rounded corners should align with rounded corners of star and go buttons. Review URL: http://codereview.chromium.org/185013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25560 0039d316-1c4b-4281-b951-d872f2087c98
* Use ScopedComPtr instead of CComPtr to reduce a dependency on ATL.jhawkins@chromium.org2009-09-044-13/+16
| | | | | | | | BUG=5027 TEST=none Review URL: http://codereview.chromium.org/201012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25498 0039d316-1c4b-4281-b951-d872f2087c98
* Use system themes where possible in Omnibox edit and dropdown; in other ↵pkasting@chromium.org2009-09-042-29/+34
| | | | | | | | | | cases, provide a pair of colors and use whichever contrasts more with the relevant background color, to maintain readability. BUG=92,18367 TEST=Use the omnibox on various non-default and high-contrast system themes. Observe that everything is always readable. Review URL: http://codereview.chromium.org/200009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25494 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Make Omnibox a little bit transparent.shess@chromium.org2009-09-041-3/+7
| | | | | | | | | | | | | Randomly chose 90% opaque. For some reason -controlColor didn't work right anymore for hovered background, switch to -controlHighlightColor (which sounds closer to the point anyhow). http://crbug.com/20679 TEST=Omnibox popup should be slightly transparent, but not annoyingly so. Review URL: http://codereview.chromium.org/188014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25475 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 23702.hbono@chromium.org2009-09-041-12/+0
| | | | | | Review URL: http://codereview.chromium.org/173343 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25442 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing focus in location bar and accelerators on Linux toolkit views.jcampan@chromium.org2009-09-032-0/+4
| | | | | | | | | | | | | | | BUG=None TEST=Focus the location bar, deactive/reactivate the browser window with Alt-Tab, the focus should still be on the location bar. Click few links on a page to have a history navigation. Focus the location bar, use backspace to delete some text. Focus a text area in a web page, make sure backspace works as expected (deletes text). Now click on a non text area, press backspace. You should trigger a navigate back. Review URL: http://codereview.chromium.org/185014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25389 0039d316-1c4b-4281-b951-d872f2087c98
* Make the omnibox 2 hover code a tiny bit less goofy by removing a now-unused ↵pkasting@chromium.org2009-09-035-15/+2
| | | | | | | | | | | | function (although it may have to come back eventually) and using the Model's conception of hover state instead of direct hot-tracking in the view. Unfortunately, there are still problems, including bogus mousemove events for the same point and no WM_MOUSELEAVE events, all of which the old code handled. I think fixing this is going to require implementing a TODO in the code to hoist mouse handling to the main dropdown view, at which point I can probably address issue 13703 as well. BUG=13279 TEST=none Review URL: http://codereview.chromium.org/187002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25336 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Use rounded corners in AutocompletePopupViewGtk.erg@google.com2009-09-011-14/+12
| | | | | | Review URL: http://codereview.chromium.org/173646 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25080 0039d316-1c4b-4281-b951-d872f2087c98
* Unbreak the world. Turns out SetProfile(NULL) causes a DCHECK failure.pkasting@chromium.org2009-09-012-10/+3
| | | | | | | | | TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/177055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25053 0039d316-1c4b-4281-b951-d872f2087c98
* More work fixing miscellaneous issues in the autocomplete code, probably ↵pkasting@chromium.org2009-09-0111-185/+182
| | | | | | | | | | | | | | | | | none of which will help my crasher :( * Force the query to stop if the user deletes a match. This makes more sense from a UI perspective and allows some code to be simpler. * Prevent us from potentially doing a "minimal changes" match in a different profile (hard to trigger, likely no practical effects) * Remove unneeded Reset() call on a repeating timer (which will auto-reset itself) * Rename one of the notifications and move its listener to the edit, since that's who really cares about it anyway. * Make the controller's Stop(true) notify the popup via the normal observer pipeline rather than coding something special into the popup's StopAutocomplete(). * Rename |paste_and_go_controller| |synchronous_controller| and use it instead of using the main popup controller to do the synchronous query when calling URLsForDefaultMatch(). This makes things both simpler and safer. BUG=none TEST=Using the omnibox still works fine Review URL: http://codereview.chromium.org/178049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25044 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Simplify omnibox selection code and stop taking back selection.derat@chromium.org2009-08-312-25/+22
| | | | | | | | | | | | | | | | | | | | | | | | This fixes a long-time bug (mentioned at the end of my description in http://codereview.chromium.org/159185 but reported more recently) where Chrome would steal back the PRIMARY selection the first time that another app takes it. I tested by going through my test cases from the following earlier changes and also confirming that the selection-stealing issue is also fixed: http://codereview.chromium.org/151006 http://codereview.chromium.org/155971 http://codereview.chromium.org/159185 http://codereview.chromium.org/164539 http://codereview.chromium.org/173098 BUG=20460 TESTED=see above Review URL: http://codereview.chromium.org/176029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24971 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix operation of Control key in Omnibox.shess@chromium.org2009-08-311-5/+3
| | | | | | | | | | | http://crbug.com/20455 TEST=Enter "this" into address bar. Hold Control, should see "www.this.com" as first item. Release, and it should go back to "this" immediately. Review URL: http://codereview.chromium.org/182021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24939 0039d316-1c4b-4281-b951-d872f2087c98
* OSX: Remove some nsnotificationcenter observers more reliably.shess@chromium.org2009-08-312-3/+10
| | | | | | | | | | | | There are some crashers which show up as an objc_msgSend when posting a notification. So I went around reviewing our observers looking for places where it's possible that we weren't unregistering correctly. These may have already been correct, but this change would seem to make unregistration more reliable. Review URL: http://codereview.chromium.org/174480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24938 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix Option-return in Omnibox.shess@chromium.org2009-08-311-0/+12
| | | | | | | | | | | | | Option-return inserted a literal newline, did not want. Also fixed Option-tab to not insert literal tab. http://crbug.com/17914 TEST=Type text, option-tab should not insert literal tab, option-return should not insert newline. Both should do nothing. Review URL: http://codereview.chromium.org/181024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24936 0039d316-1c4b-4281-b951-d872f2087c98
* I was too aggressive when placing this check. With rapid typing and ↵pkasting@chromium.org2009-08-311-1/+1
| | | | | | | | | | | deletion it's perfectly reasonable for the controller to be running a query when the popup is not open. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/177041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24931 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r24920 without the other cruft that I had in my checkout, which broke ↵pkasting@chromium.org2009-08-312-33/+24
| | | | | | | | | | | the compile. TBR=mmoss BUG=none TEST=none Review URL: http://codereview.chromium.org/176043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24928 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r24920 due to compile failures.mmoss@chromium.org2009-08-312-28/+29
| | | | | | | | | TBR=pkasting Review URL: http://codereview.chromium.org/181023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24927 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:pkastingmmoss@chromium.org2009-08-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24924 0039d316-1c4b-4281-b951-d872f2087c98
* Minor autocomplete fixes while trying to track down a topcrash:pkasting@chromium.org2009-08-312-29/+32
| | | | | | | | | | | | | * Turn some DCHECKs into CHECKs (I don't think any of these will get hit) * Ensure that URLsForDefaultMatch() doesn't leave any results lying around on the controller, since the popup isn't open (and those two states should be locked in step) * Eliminate some old code in Move() that shouldn't have actually done anything anymore (since result() should already be in sync with the popup, and SetSelectedLine() is going to stop the controller) * Use a pre-existing helper function at two places in the Edit for readability BUG=none TEST=none Review URL: http://codereview.chromium.org/180045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24920 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutocompleteController::done() match up with when results are actually ↵pkasting@chromium.org2009-08-312-8/+8
| | | | | | | | | | | | pushed to listeners. r24290 made it possible for the controller to be "done" (in that all providers had finished) but have not yet sent the final results to listeners. This makes done() only return true when the controller has actually pushed the final results. I'm not sure precisely what effects this discrepancy could have had but I suspect they were bad, given that callers assume done() means "results are stable". BUG=none TEST=none Review URL: http://codereview.chromium.org/173631 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24914 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Handle shift-delete when omnibox popup is up.shess@chromium.org2009-08-282-0/+18
| | | | | | | | | | | | | | | | When the user hits shift-delete (that's forward delete), attempt to delete the item highlighted from the list. This only seems to work for history items. http://crbug.com/20281 TEST=No idea. I've managed to delete an item, but most items seem immune to deletion, this code is calling the right place, but the match itself checks !deletable. Sometimes I have luck going to a site, then typing part of the URL and using shift-del on it. Review URL: http://codereview.chromium.org/176022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24819 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-285-17/+11
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Handle middle click in autocomplete popup.shess@chromium.org2009-08-282-2/+90
| | | | | | | | | | | | Middle click should open the item clicked in a background tab. http://crbug.com/20282 TEST=Start typing in omnibox. Middle click an item. The item should open in a different tab without affecting the current omnibox state. Review URL: http://codereview.chromium.org/179009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24793 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-285-11/+17
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Handle backspacing out of keyword search.shess@chromium.org2009-08-282-0/+31
| | | | | | | | | | | | | | | | | | When the user hits backspace with the caret on the LHS in a keyword search, should exit keyword search. [Apple keyboards may label what I'm calling "backspace" as "delete". The wide key above |\ key.] http://crbug.com/20286 TEST=Type www.google.com, then tab to enter keyword search. Type some text. Select-all and hit backspace, should stay in keyword mode. Type some text, backspace should work as normal. Type some text, position caret at LHS, backspace should take you out of keyword mode. Review URL: http://codereview.chromium.org/180009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24767 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Don't eat tab if tab-to-search hint not visible.shess@chromium.org2009-08-282-9/+15
| | | | | | | | | | | | | http://crbug.com/20284 TEST=Type "test text". You should see "Type to search" hint. TAB should take you into the content view. Unfortunately, there are other unrelated bugs around the tab sequencing, so this only works with NTP on a new window. Hit TAB twice and you should start tabbing between thumbnails. Review URL: http://codereview.chromium.org/180010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24741 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Tweaks to Omnibox metrics.shess@chromium.org2009-08-281-2/+5
| | | | | | | | | | | | Pull in the popup corners by half a pixel to more closely match the rounding on the buttons. Pull up the gap between the popup and the field by one pixel to match Windows. http://crbug.com/20446 Review URL: http://codereview.chromium.org/178007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24739 0039d316-1c4b-4281-b951-d872f2087c98
* Fix control key and paste behavior in Linux omnibox.suzhe@chromium.org2009-08-283-6/+53
| | | | | | | | | | | | | BUG=12316: Linux Omnibox, autocomplete on paste annoying. BUG=13096: Support desired_tld in Linux omnibox BUG=20166: Linux omnibox control key behavior is incorrect TEST=Select all text in omnibox and paste something into omnibox by either ctrl-v, paste item in context menu or middle click, to see if inline autocomplete is not activated. TEST=Input something in omnibox, eg. "goog", make sure the inline autocomplete is activated, then press ctrl key to see if the inline autocomplete is still there. TEST=Input something in omnibox, eg. "cnn", press ctrl-Enter to see if www.cnn.com is opened. Review URL: http://codereview.chromium.org/173462 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24705 0039d316-1c4b-4281-b951-d872f2087c98
* Do at least some rudimentary sorting of bookmarked URLs in the omnibox ↵pkasting@chromium.org2009-08-282-15/+21
| | | | | | | | | dropdown (existing sort was effectively random). Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/165455 ), r=sky,me, tweaked. BUG=16230 TEST=In the omnibox dropdown, bookmarked URLs that have been typed more often should be ranked above those that have been typed less often. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24704 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] The autocomplete popup now gets its position from the toolbar controller,rohitrao@chromium.org2009-08-275-17/+13
| | | | | | | | | | rather than simply growing its width by 2*height. BUG=None TEST=The autocomplete popup should continue to appear in the same location. Review URL: http://codereview.chromium.org/173439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24586 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Fix the find bar so the match count is inside the entry.erg@google.com2009-08-261-8/+2
| | | | | | | | | | In addition, only draw the dirty rectangle area when manually drawing a gtk entry. http://crbug.com/17962 Review URL: http://codereview.chromium.org/174577 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24558 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use URL-encoded strings when user's input is in progress or the text isn'tjshin@chromium.org2009-08-261-3/+9
| | | | | | | | | | | | | | | | | | | | | | | | | HTTP/HTTPs. It seems that Firefox is doing the same thing. BUG=16534 (http://crbug.com/16534) TEST=Visit any website and append double-quote (") for the URL and invoke "Select All" by Control-A, then copy the URL by Control-C. Paste the result into notepad and check if the double-quote is NOT encoded. TEST=Access file:///" and select whole Omnibox and copy the URL. Paste the text into notepad and check if the double-quote is NOT URL encoded. TEST=Put " in Omnibox and type enter key so that you will be navigated to http://www.google.co.jp/search?sourceid=chrome&ie=UTF-8&q=%22. Copy whole content in Omnibox and paste it into notepad. Then, check if the double-quote is URL-encoded (%22). Original Review: http://codereview.chromium.org/155495/show Patch by hamaji@chromium.org (he's on vacation and asked me to land) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24472 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression issue 20066.suzhe@chromium.org2009-08-261-3/+14
| | | | | | | | | | | This CL fixes issue 20066, a regression issue caused by a change in CL 172041. BUG=20066: Regression: search keywords search with default search engine only. TEST=Assuming 'y' is associated to a search engine, type "y abc" in omnibox and press enter shall search abc with the search engine associated to 'y'. Review URL: http://codereview.chromium.org/173332 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix double control key issue with the omnibox.deanm@chromium.org2009-08-251-4/+10
| | | | | | | | | | | Previously holding two controls keys and releasing one would show the non-control omnibox results, but hitting enter would take the control results. Fix this by showing the correct results if any control key is held down. Review URL: http://codereview.chromium.org/173324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24253 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Show the correct text for the omnibox "paste and go/search" menu item.estade@chromium.org2009-08-252-20/+12
| | | | | | | | BUG=20151 Review URL: http://codereview.chromium.org/174363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24187 0039d316-1c4b-4281-b951-d872f2087c98
* Implements unimplemented methods of AutocompleteEditViewGtk and fixes a ↵suzhe@chromium.org2009-08-222-89/+140
| | | | | | | | | | | | | | | | | | | regression issue. This CL implements two unimplemented methods of AutocompleteEditViewGtk: OnRevertTemporaryText() and IsSelectAll(). The implementation are mostly copied from autocomplete_edit_view_mac.mm. Some grammer errors and a valgrind warning introduced by CL 165457 are also fixed. This CL was just updated to fix a regression caused by CL 165457 (issue 19631). BUG=19631: Tabbing on Omnibox enters in to search UI mode TEST=Input something in omnibox and make sure some text is selected and popup view is opened, change current selection in popup view by pressing up/down then press escape to see if omnibox is reverted to its original content and selection. TEST=Make sure www.google.com is one of the search engine, open www.google.com then move the focus back to omnibox and press tab to see if the focus is moved into web page. Review URL: http://codereview.chromium.org/172041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24052 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Omnibox keyword, keyword hint, and search hint support.rohitrao@chromium.org2009-08-212-0/+32
| | | | | | | | | | | | | | | | | BUG=http://crbug.com/10944 BUG=http://crbug.com/10943 BUG=http://crbug.com/12285 TEST=With empty field, should see "Type to search" in light text on the RHS of the omnibox. Type "google" and should see "Press [Tab] to search Google" in light text on the RHS. Hit TAB, should see a rounded [Search Google:] item on the left and the cursor is now right of that. Popup should show "Keyword:" in some entries. Patch by shess@chromium.org. Review URL: http://codereview.chromium.org/173194 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23964 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile errorpkasting@chromium.org2009-08-201-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23878 0039d316-1c4b-4281-b951-d872f2087c98
* Initialize all new booleans in unittest constructor.pkasting@chromium.org2009-08-201-0/+2
| | | | | | | | | TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/173148 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23876 0039d316-1c4b-4281-b951-d872f2087c98
* Fix uninitialized memory read in autocomplete tests.brettw@chromium.org2009-08-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/173142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23872 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to minimize omnibox flicker, without increasing lag too much.pkasting@chromium.org2009-08-202-96/+151
| | | | | | | | | | This also updates a bunch of comments, mostly to keep terminology like "results" and "matches" consistent, occasionally to fix grammar or other issues. BUG=18369 TEST=none Review URL: http://codereview.chromium.org/173031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23859 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Attempt #2 at updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-202-0/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | r23596 was the original attempt; r23714 reverted it. Using gtk_text_buffer_copy_clipboard() gives the GtkTextBuffer ownership of the GtkClipboard and appears to prevent it from unhighlighting its text. Tested as follows: 1. Select text in webkit and hit Ctrl-C; check that both the PRIMARY and CLIPBOARD selections contain it. 2. Click in the omnibox. All of the text gets highlighted. Check that the PRIMARY selection contains the omnibox text and the CLIPBOARD selection contains the webkit text. 3. Type Ctrl-C and confirm that the CLIPBOARD selection now contains the omnibox text. 4. Copy webkit text back to both selections. 5. Type Ctrl-L. The omnibox text gets highlighted but both selections still contain the webkit text. 6. Type Ctrl-C and confirm that both selections now contain the omnibox text. 7. Try hitting Ctrl-C again while the omnibox text is on the CLIPBOARD selection to make sure that a bizarre GTK crash doesn't occur (see comment in code). BUG=19648 TESTED=see above Review URL: http://codereview.chromium.org/173098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23834 0039d316-1c4b-4281-b951-d872f2087c98
* Various omnibox UI fixes:rohitrao@chromium.org2009-08-203-37/+80
| | | | | | | | | | | | | * Truncate match contents to 70% of the available width, reserving 30% for the description. * Animate omnibox shrinkage. BUG=14898 TEST=Omnibox should animate smaller, but not bigger/opened/closed. Match description should always be partially visible, if present. Review URL: http://codereview.chromium.org/173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23821 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Revert updating PRIMARY selection on Ctrl-C in omnibox.derat@chromium.org2009-08-192-21/+0
| | | | | | | | | | | | | | | This backs out r23596. I'm pretty sure that it worked when I tested it right before submitting, but it's totally breaking stuff now -- it looks like when I update the PRIMARY selection, GTK notices that it's lost the selection and automatically unhighlights the text in the omnibox, making it impossible to use Ctrl-C to copy omnibox text to the clipboard. :-( BUG=19648 TESTED=Hit Ctrl-L, Ctrl-C and confirmed that text remains highlighted and becomes CLIPBOARD selection. Review URL: http://codereview.chromium.org/174058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23714 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 19421.hbono@chromium.org2009-08-191-0/+12
| | | | | | | | | | | | | This issue is caused by AutocompleteEditViewMac::SetText() that updates the value of an AutocompleteEditField instance while an input method is composing text. Same as Windows, NSTextView finishes an ongoing composition when we update the value of an AutocompleteEditField object. To fix this issue, we check whether or not NSTextView has marked text and exit if it has. BUG=19421 "Korean IME does not work in the omnibox" TEST=Select Korean 2-set keyboard, type 'g', 'k', 's', 'r', 'm', 'f' keys, and verify we can see two Korean syllables. +rohitrao for reviewers since shess is out for the week Review URL: http://codereview.chromium.org/171103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23702 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 07:37:17 +0000