summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* The history tests relies on being about to reset a profile, which means we needthomasvl@chromium.org2009-04-141-0/+13
| | | | | | | | | to load a bunch of resources. For the Mac, this means we build the app first and the unittest looks into the app bundle to pull resources. Review URL: http://codereview.chromium.org/73046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13686 0039d316-1c4b-4281-b951-d872f2087c98
* Color/emphasize correct portions of view-source: URLs. Original patch by ↵pkasting@chromium.org2009-04-144-8/+104
| | | | | | | | Shinichiro Hamaji (see http://codereview.chromium.org/62094/show ), r=me. BUG=2349 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13671 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the omnibox show past searches and suggestions for keywords.sky@chromium.org2009-04-146-186/+515
| | | | | | | | | | | | | | | We talked about primary and secondary, but after doing it all I felt keyword and default better portrayed what is going on. After trying this out I think we need to tune relevancy. But that can be done later BUG=3636 TEST=make sure omnibox isn't broken. Review URL: http://codereview.chromium.org/66073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13668 0039d316-1c4b-4281-b951-d872f2087c98
* Fix missing virtual GetModel().shess@chromium.org2009-04-102-0/+7
| | | | | | | | | GetModel() was added by http://codereview.chromium.org/67035 which running my change on the trybots, and I trusted the merge. Review URL: http://codereview.chromium.org/66054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13541 0039d316-1c4b-4281-b951-d872f2087c98
* Fix build bustage - make sure GTK Autocomplete edit/popup implement the ↵ben@chromium.org2009-04-103-4/+7
| | | | | | | | | GetModel interface method. TBR=deanm Review URL: http://codereview.chromium.org/66052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13539 0039d316-1c4b-4281-b951-d872f2087c98
* Allow a different omnibox popup to be enabled via the command line ↵ben@chromium.org2009-04-105-13/+50
| | | | | | | | | | | | (--enable-omnibox2). This will allow a views-based omnibox popup conforming to the new spec (stub provided) to be brought up without disturbing ToT UX. Also adds new images from Nicholas. Review URL: http://codereview.chromium.org/67035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13538 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-106-2/+782
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13534 0039d316-1c4b-4281-b951-d872f2087c98
* Move to custom painting the omnibox results with GDK.deanm@chromium.org2009-04-092-51/+168
| | | | | | | | | | | | | | | | | | | | - Don't draw with ChromeCanvas, we will have better text layout by using Pango directly, and better remote X performance by not blitting a bitmap. - Text is draw with Pango on top of GDK (no Cairo inbetween). - Double buffered server side, and just a few GDK operations for rects. - Improve our handling of InvalidateLine / PaintUpdatesNow. We previously always invalidated the entire window. We now communicate with the model the way we should, and only invalidate damaged lines, and then do a sync paint in PaintUpdatesNow to repaint them. This is a small step backwards, because we are no longer showing the description text. This easy to fix, but I'm going to try to implement the entire new results look and icons at the same time. Review URL: http://codereview.chromium.org/63119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13413 0039d316-1c4b-4281-b951-d872f2087c98
* Properly handle empty components when converting url_parse::Parsed object.estade@chromium.org2009-04-081-0/+1
| | | | | | | | | | Add a unittest for the below bug. BUG=9859 Review URL: http://codereview.chromium.org/62162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13388 0039d316-1c4b-4281-b951-d872f2087c98
* Fix mouse wheel redirection when omnibox has focusamit@chromium.org2009-04-082-0/+13
| | | | | | | | | | | | | | Since focus manager subclass now no longer handlers mouse wheel redirection, handle WM_MOUSEWHEEL in autocomplete_edit_view_win and give other windows chance to handle mouse wheel. Bug 9647 Review URL: http://codereview.chromium.org/63061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13360 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt to fix crash that I don't fully understand and can't repro :(pkasting@chromium.org2009-04-081-2/+13
| | | | | | | BUG=8933 Review URL: http://codereview.chromium.org/63085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13357 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix for omnibox crash.estade@chromium.org2009-04-081-0/+6
| | | | | | | | BUG=9760 Review URL: http://codereview.chromium.org/63095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13340 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 9596.hbono@chromium.org2009-04-071-3/+3
| | | | | | | | | | | This issue is caused by my bonehead mistake in r4300: I misunderstand the behavior of Vista when we call the SetWindowsText() function. It actually cancels an ongoing composition. So, changing this behavior caused this regression. To fix this issue, this change cancels an ongoing composition instead of completing it. As far as I tested on my XP PC, this fix works also on XP. BUG=9596 Review URL: http://codereview.chromium.org/60084 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13241 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Initial implemention of Mac Omnibox."shess@chromium.org2009-04-076-780/+2
| | | | | | | | | | Reverts: http://codereview.chromium.org/50074 http://src.chromium.org/viewvc/chrome?view=rev&revision=13201 Review URL: http://codereview.chromium.org/63047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13227 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implemention of Mac Omnibox.shess@chromium.org2009-04-066-2/+780
| | | | | | | | | | | | | | | | AutocompletePopupViewMac implements AutocompletePopupView in terms of a bare NSWindow containing an NSTableView. AutocompleteTableTarget implements an Obj-C class to bridge from appkit callbacks back to the popup view (and from there to the model which contains the data it needs). AutocompleteEditViewMac implements AutocompleteEditView in terms of an NSTextField, which is passed down from a nib owner. It works with the popup view to make sure the popup is positioned correctly. AutocompleteFieldDelegate is an internal Obj-C class to bridge from appkit callbacks back to the edit view (and then the edit model). LocationBarViewMac implements LocationBar for interacting with the rest of the browser, and AutocompleteEditController for managing the edit and popup views. It is mostly placeholder code stolen from the gtk implementation. --- I've tried to implement an amount of code which worked and was useful, but which didn't drag on and on into the future. So no tab to search or hints or anything, sometimes ugly, selection may be funky, etc. Review URL: http://codereview.chromium.org/50074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13201 0039d316-1c4b-4281-b951-d872f2087c98
* Pasting successfully into a TextField should always triggerfinnur@chromium.org2009-04-061-2/+6
| | | | | | | | | | | | | | OnContentsChanged on the controller. BUG=None TEST= 1) Navigate to google.com, copy the contents of the OmniBox (the URL) and paste it back into the OmniBox. The dropdown should appear. 2) Navigate to google.com, copy the word Privacy into the clipboard. Open the Find box, Paste into the Find bar. It should search. Close the Find bar. Reopen the Find bar. Paste again. It should search. Review URL: http://codereview.chromium.org/63014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13187 0039d316-1c4b-4281-b951-d872f2087c98
* Revert Linux Omnibox color changes in r12516.deanm@chromium.org2009-03-261-3/+3
| | | | | | | | | This just reverts the Omnibox portion of the change. This code is structured to match Windows, and will eventually be pulled from LocationBarView. Review URL: http://codereview.chromium.org/53093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12544 0039d316-1c4b-4281-b951-d872f2087c98
* Linux UI theming:estade@chromium.org2009-03-251-4/+4
| | | | | | | | | - Improve appearance of menus by setting background to white (matching windows and fitting better with the overall appearance). - Disable user theming of native widgets: since our widgets are a hodge-podge of native and custom-drawn, there's no way we can support user theming. Eventually users will be able to choose a theme for chromium; until then make everything look like chrome. Review URL: http://codereview.chromium.org/49035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12516 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the Linux Omnibox ssl background / scheme coloring.deanm@chromium.org2009-03-241-8/+16
| | | | | | | | | | | We now correctly reset the background color on tab switches, and navigations from a ssl to non-ssl page. BUG=8236,9225 Review URL: http://codereview.chromium.org/49015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12371 0039d316-1c4b-4281-b951-d872f2087c98
* Fully enable history_url_provider_unittest.cc for Mac.shess@chromium.org2009-03-232-11/+0
| | | | | | | | | | | | | gfx::GetCleanStringFromUrl() got implemented for Mac at some point (I suspect when fonts landed), so now all of this code should be portable. There is a slight difference in how ElideUrl() works, due to font metric differences, but that should not be relevant to this code. Review URL: http://codereview.chromium.org/42513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12310 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 2720.hbono@chromium.org2009-03-192-0/+24
| | | | | | | To investigate this issue, we noticed some IMEs got confused when we change the text in a rich-edit control and finish an ongoing IME composition while they are composing a text. To prevent this, we accept keywords when they are activated. Review URL: http://codereview.chromium.org/42275 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12089 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/ref_counted.h.thestig@chromium.org2009-03-182-2/+0
| | | | | | Review URL: http://codereview.chromium.org/48105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
* Renames AccessibleWrapper to ViewAccessibilityWrapper for clarity. klink@chromium.org2009-03-171-2/+2
| | | | | | | | Reorders the functions in ViewAccessibility to match the order used in BrowserAccessibility, accessibility.h and in Glue/WebKit. Review URL: http://codereview.chromium.org/46011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11914 0039d316-1c4b-4281-b951-d872f2087c98
* Don't leak AutocompleteEditViewGtk objects. I meant reset() not release().deanm@chromium.org2009-03-171-2/+2
| | | | | | | Review URL: http://codereview.chromium.org/48066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11859 0039d316-1c4b-4281-b951-d872f2087c98
* Porting unit tests in chrome/phajdan.jr@chromium.org2009-03-171-1/+1
| | | | | | | | | | | | | | | | | Enable following tests on Linux: browser/autocomplete/autocomplete_unittest.cc browser/navigation_controller_unittest.cc browser/search_engines/template_url_model_unittest.cc browser/sessions/session_backend_unittest.cc browser/tab_contents/web_contents_unittest.cc Remove not-existing file from remove list for Linux. Check for zero-size write in SessionBackend because it's an error in POSIX (but is ok from the session backend's perspective). Review URL: http://codereview.chromium.org/42223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11852 0039d316-1c4b-4281-b951-d872f2087c98
* Move controls into their own dir under chrome/views/controlsben@chromium.org2009-03-171-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of our GTK code that was previous manually handling references ↵deanm@chromium.org2009-03-162-30/+29
| | | | | | | | | (and often doing it incorrect / leaking) to use an OwnedWidgetGtk. Review URL: http://codereview.chromium.org/48007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11750 0039d316-1c4b-4281-b951-d872f2087c98
* Enable AutocompleteTest, HistoryURLProviderTest,shess@chromium.org2009-03-164-17/+17
| | | | | | | | | | | HistoryContentsProviderTest, and KeywordProviderTest from chrome/browser/autocomplete. NOTIMPLEMENTED bits where HistoryURLProviderTest and AutocompleteTest have UI dependencies, and ExternalProtocolHandler has OS dependencies. Review URL: http://codereview.chromium.org/43034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11729 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/scoped_ptr.h. Reduce usage from ~800 files ↵thestig@chromium.org2009-03-133-2/+1
| | | | | | | | to ~400. Review URL: http://codereview.chromium.org/46039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11651 0039d316-1c4b-4281-b951-d872f2087c98
* Fix ownership error with GtkTextTagTable and GtkTextTag.deanm@chromium.org2009-03-131-3/+2
| | | | | | | | | | | | | | | When we create with gtk_text_buffer_create_tag: """ The returned tag is owned by the buffer's tag table, so the ref count will be equal to one. """ We do not own the tags, only the table. Review URL: http://codereview.chromium.org/46044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11647 0039d316-1c4b-4281-b951-d872f2087c98
* Improve the look of the Linux omnibox.deanm@chromium.org2009-03-131-6/+8
| | | | | | | | | | | | | | | | - Paint a border around the input widget, which makes it fit better into the toolbar. A bordered widget is also very nice to have for debugging, so I abstracted a small helper for making a bordered bin. - Improve the results popup by painting with some Pango attributes. Sort of looks awful over NX, but I'm hoping it looks better on a real session. BUG=8236 Review URL: http://codereview.chromium.org/46035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11644 0039d316-1c4b-4281-b951-d872f2087c98
* Revert a change made to try and make purify errors go away now that Erik Kay ↵pkasting@chromium.org2009-03-131-5/+2
| | | | | | | | has disabled purify runs for the relevant tests. Review URL: http://codereview.chromium.org/42162 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11638 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup AutocompleteEditViewGtk's resources and widgets.deanm@chromium.org2009-03-131-0/+19
| | | | | | | Review URL: http://codereview.chromium.org/46034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11636 0039d316-1c4b-4281-b951-d872f2087c98
* Call into the IM hooks from the Linux Omnibox keyboard handling.deanm@chromium.org2009-03-131-14/+28
| | | | | | | | | This should give input methods the proper chance to handle enter and escape. Review URL: http://codereview.chromium.org/43149 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11627 0039d316-1c4b-4281-b951-d872f2087c98
* Make toggling fullscreen mode on/off significantly less janky-looking by ↵pkasting@chromium.org2009-03-122-0/+17
| | | | | | | | means of various crazy hacks. Review URL: http://codereview.chromium.org/42106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11550 0039d316-1c4b-4281-b951-d872f2087c98
* Hookup the escape key on Linux Omnibox to revert to the permanent text (like ↵deanm@chromium.org2009-03-121-2/+7
| | | | | | | | | | | Windows). BUG=8236 Review URL: http://codereview.chromium.org/42074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11529 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a Linux Omnibox bug where a widget was used after it was destroyed.deanm@chromium.org2009-03-121-0/+4
| | | | | | | Review URL: http://codereview.chromium.org/42073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11528 0039d316-1c4b-4281-b951-d872f2087c98
* Better keyboard and mouse handling in Omnibox:deanm@chromium.org2009-03-122-33/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | - Grab enter key events before they get to GtkTextView. We need to do this, otherwise enter when text is selected will replace the text, and we won't get a chance to catch that happening. This might have problems with IME, but it should be straightforward to fix anything IME related. - Don't deselect when we lose focus. This sometimes looks a bit strange, but it's the GTK thing to do. This also unbreaks copy and paste via the context menu, since popping up the context menu makes the GtkTextView lose focus. - Rewrite the inefficent newline eater. This should now only be needed for newlines that didn't come from the keyboard (like when you paste text). Use the builtin iter support for finding line boundaries, hopefully more efficient than checking the characters one by one. Still might have some bad behavior when pasting a ton of newline characters, but that can be improved later. This fixes inline autocomplete, you can now hit the enter key on an inline autocompleted suggestion, and you will get the intented navigation, instead of the navigation with the selected completion removed. This also adds support for alt-enter in Omnibox to navigate in a new tab. BUG=8236 Review URL: http://codereview.chromium.org/43072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11527 0039d316-1c4b-4281-b951-d872f2087c98
* Add a GDK_COLOR_RGB macro for constructing GdkColors.deanm@chromium.org2009-03-122-5/+7
| | | | | | | | | This does the simple math of * 257 to map from a 1 byte component to the gint16 GdkColor values, and initializes the pixel field to 0. Review URL: http://codereview.chromium.org/43077 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11526 0039d316-1c4b-4281-b951-d872f2087c98
* This changes the base clipboard class, as accomplishing paste requires that ↵avi@chromium.org2009-03-101-1/+1
| | | | | | | | Clipboard::FormatType be IPC-able. The lowest-common denominator of unsigned int, NSString*, and GdkAtom is string, so string it is. (Linux changes by estade.) Review URL: http://codereview.chromium.org/41012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11383 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanups and hookups to LocationBarViewGtk.deanm@chromium.org2009-03-102-4/+8
| | | | | | | | | | | | | | | | | - Rename FocusLocation to SetFocus (and don't make it select all). This matches the Windows style more closely. - Implement SetUserText (basically copied from Windows w/ a TODO). - Switch to the gtk_accel APIs instead of using the widget ones. - Hookup FocusSearch (and its ctrl-k accelerator). - Hookup AcceptInput (the go button now works!). - Fix lack of space before { - Rename edit_view_ to location_entry_ to match the Windows LocationBarView. - Don't plumb FocusLocationBar through BrowserWindow -> BrowserToolbar. Review URL: http://codereview.chromium.org/43025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11339 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a GTK LocationBarView and Autocomplete{Edit,Popup}View.deanm@chromium.org2009-03-104-0/+854
| | | | | | | | | | | This implements some beginning functionality of "omnibox". It uses GtkTextView for a rich text edit for the location bar. Color emphasis, inline autocomplete, and the results popup work. You can select one of the omnibox results using the keyboard. Mouse selection doesn't work. The results popup code will have to be scraped and reimplemented with cairo / pango. BUG=8236 Review URL: http://codereview.chromium.org/40013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11323 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-054-8/+12
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-053-8/+8
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* Try to fix a Purify UMR error. This isn't great, but it's better than nothing.deanm@chromium.org2009-03-041-2/+5
| | | | | | | | BUG=8314 Review URL: http://codereview.chromium.org/39125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10889 0039d316-1c4b-4281-b951-d872f2087c98
* revert broken change 10833nsylvain@chromium.org2009-03-031-2/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10837 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-031-1/+2
| | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10818 Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10833 0039d316-1c4b-4281-b951-d872f2087c98
* Remove NativeUI, HistoryTabUI, DownloadsTabUI since they've been superceded.ben@chromium.org2009-03-031-2/+2
| | | | | | Review URL: http://codereview.chromium.org/39005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10832 0039d316-1c4b-4281-b951-d872f2087c98
* Revert dsh's change 10818nsylvain@chromium.org2009-03-031-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10821 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10818 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 11:27:15 +0000