summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Revert 105678 - Caused flakiness described in http://crbug.com/100479rsleevi@chromium.org2011-10-166-36/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HQP Refactoring (in Preparation for SQLite Cache) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson,brettw Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/. Review URL: http://codereview.chromium.org/8291005 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8310006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105697 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache) mrossetti@chromium.org2011-10-156-32/+36
| | | | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson,brettw Previously reviewed and LG'ed as http://codereview.chromium.org/8120004/. Review URL: http://codereview.chromium.org/8291005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105678 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in instant where we would end up incorrectly using thesky@chromium.org2011-10-151-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | preview when we shouldn't. Here's the sequence that would trigger it: 1. focus the omnibox (which triggers loading the InstantLoader). 2. Type in a string that'll autocomplete to a url. 3. Arrow over a search suggestion to a non-search entry. 4. Press enter. When you arrow over a non-search we'll hide (what was DestroyPreviewContentsAndLeaveActive) the preview. But if between steps 3 and 4 we get a response back from the page with suggestions we'll set displayable_ to true and think everything is up to date. This leads to IsCurrent returning true when it isn't. To fix this I've nuked is_active(), which was a bit confusing anyway and added is_out_date_ (still confusing, but at least it's private). BUG=100368 TEST=covered by test, see bug for test scenario. R=sreeram@chromium.org,ben@chromium.org TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8298005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105664 0039d316-1c4b-4281-b951-d872f2087c98
* When users navigate to an intranet host that has not been previously typed, ↵pkasting@chromium.org2011-10-141-16/+5
| | | | | | | | | | | | | | | | | | | | treat it as a typed navigation. This fixes two different problems: (1) Due to scheme-stripping, a user who navigated to e.g. "host/path" via a link or bookmark, for a not-previously-typed host, would erroneously get a search page instead of a navigation when reloading via hitting enter or when editing the path to be something else. We could instead fix this by being more conservative about scheme-stripping, but that is uglier UI, a bigger change, and doesn't solve problem (2). (2) Users who navigated to intranet hosts (with or without a path or other URL components) via link clicks/bookmarks/etc. would later try to type them and be frustrated that the omnibox would do a search and then show the accidental search infobar. This change makes the omnibox more aggressive about learning that such hostnames are valid intranet hosts even before users type them, if they've at least visited them. There are four issues here: (1) Because in incognito mode we never add navigations to any history DBs, users there won't see the above benefits. In fact, users there will struggle to use (new) intranet hosts in general. I filed bug 100271 about this. (2) The omnibox will now be more likely to inline-autocomplete intranet URLs you haven't actually typed before. After thinking for a while I don't think this will have a large effect either way especially as intranet URLs are often short (and thus it's less likely users will try to search or navigate to a pure prefix of one). (3) Heavy intranet users will have a larger in-memory DB. I don't think this effect will be dramatic since it's just one URL per unique hostname, and there's no real way around this anyway. (4) The additional checking in AddPage() could make navigation slower. I don't think this ought to happen because most navigations will fail the RCDS check for "no known TLD" (which ought to be fast, as that code is called by things like cookie management), so they'll never even check the database. If this turns out to be wrong, then we'll need to fall back on something like the solution in bug 100271. BUG=94806 TEST=On a clean profile, add a bookmark for some intranet host (without navigating there), with or without a path. Click on the bookmark. Then try to modify the path and check that the omnibox still wants to navigate, not search. Review URL: http://codereview.chromium.org/8286011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105565 0039d316-1c4b-4281-b951-d872f2087c98
* Tweak omnibox parsing heuristics more:pkasting@chromium.org2011-10-135-65/+109
| | | | | | | | | | | | | | * UNKNOWN inputs with at least one non-host component get displayed as "possible navigations" (by setting |have_what_you_typed_match| true in HistoryURLProvider::DoAutocomplete()). * Inputs with at least two non-host components (generally) get treated as URLs by AutocompleteInput::Parse(). Technically these could be searches but intranet URLs are much more likely. * Allow more cases to be REQUESTED_URL, such as "user@host" + ctrl. I'm not sure these were ever intentionally excluded from the ctrl-enter handling, and I don't see why they should be. Also use url_parse::ParsePort(), which didn't use to exist (I think?) to replace some code in AutocompleteInput::Parse(). BUG=99131 TEST=Covered by unittests Review URL: http://codereview.chromium.org/8258004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105363 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 105300 - HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-10-136-36/+32
| | | | | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731,92718 TEST=Unit tests updated. TBR=atwilson,brettw Review URL: http://codereview.chromium.org/8120004 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105313 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-10-136-32/+36
| | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData. 3. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 4. Correctly handle the adding and removing of page title words when a URL change is detected. 5. Move most of the support types, including the new URLIndexPrivateData class, into a new file, in_memory_url_index_types.h. 6. Replace static class member functions with non-friend, non-class functions for better flexibility. 7. Move convenience types out from InMemoryURLIndex class up into history namespace. 8. Rename convenience types to generalize their intent. 9. Other small cleanups. BUG=96731,92718 TEST=Unit tests updated. TBR=atwilson,brettw Review URL: http://codereview.chromium.org/8120004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105300 0039d316-1c4b-4281-b951-d872f2087c98
* Move PageTransition into content namespace. While I'm touching all these ↵jam@chromium.org2011-10-1313-29/+33
| | | | | | | | | files, I've also updated it to use the enum naming convention in the Content API. BUG=98716 Review URL: http://codereview.chromium.org/8253002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105254 0039d316-1c4b-4281-b951-d872f2087c98
* Don't call instant's Update() if the text was not user entered.sreeram@chromium.org2011-10-121-2/+7
| | | | | | | | | | | | | | | Put back some of the checks that used to exist before r104553. These effectively prevent InstantController::Update() from being called when the omnibox text is changed due to reasons other than user input (such as accepting a LinkInfoBar suggestion). BUG=99836 TEST=See bug. Review URL: http://codereview.chromium.org/8233041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105126 0039d316-1c4b-4281-b951-d872f2087c98
* Add browser metrics to Chrome client cl #2.georgey@chromium.org2011-10-101-0/+19
| | | | | | | | BUG=94616 TEST=none Review URL: http://codereview.chromium.org/8174012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104689 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Complete cleanup of history/.jhawkins@chromium.org2011-10-081-2/+4
| | | | | | | | | | | | Previous version reverted; linux touch build now fixed. TBR=csilv BUG=none TEST=none Review URL: http://codereview.chromium.org/8205024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104660 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 104597 - base::Bind: Complete cleanup of history/.acolwell@chromium.org2011-10-071-4/+2
| | | | | | | | | | | | | | | | Breaks Linux Touch. BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8163005 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/8207012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104604 0039d316-1c4b-4281-b951-d872f2087c98
* base::Bind: Complete cleanup of history/.jhawkins@chromium.org2011-10-071-2/+4
| | | | | | | | | | | BUG=none TEST=none R=csilv@chromium.org Review URL: http://codereview.chromium.org/8163005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104597 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the AutoCompletePopupView to get rid of gtk/gdk related code.jennyz@chromium.org2011-10-071-1/+2
| | | | | | | | | | BUG=97837 TEST=NONE Review URL: http://codereview.chromium.org/8162010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104576 0039d316-1c4b-4281-b951-d872f2087c98
* Make instant only load searches for the default provider.sky@chromium.org2011-10-072-30/+9
| | | | | | | | | | BUG=99266 TEST=make sure instant does search only. R=sreeram@chromium.org Review URL: http://codereview.chromium.org/8176005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104553 0039d316-1c4b-4281-b951-d872f2087c98
* Move json_value_serializer from content/common to base.dpranke@chromium.org2011-10-071-1/+1
| | | | | | | | | | R=darin@chromium.org BUG=92044 TEST= Review URL: http://codereview.chromium.org/8165009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104527 0039d316-1c4b-4281-b951-d872f2087c98
* Restrict Omnibox Prerender to URL matches.dominich@chromium.org2011-10-062-99/+155
| | | | | | | | | | | | | | We don't want to prerender search results even in the rare case that they would match something in the user's recent history. We do still want to preconnect, however. This CL also has the benefit of explicitly logging 0 confidence results to UMA which helps with statistical analysis. Previously, some corner cases would return 0 without logging so the recorded counts were inconsistent. BUG=None TEST=NetworkActionPredictor.* Review URL: http://codereview.chromium.org/8137031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104303 0039d316-1c4b-4281-b951-d872f2087c98
* Moved PrerenderManager to ProfileKeyedService system.dominich@chromium.org2011-10-051-1/+2
| | | | | | | | | | | | | | As per https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/554b5b0ca05e001d# it is recommended that weak references to services be removed from Profiles and constructed as ProfileKeyedServices instead. This does this for the PrerenderManager. (Continuation of http://codereview.chromium.org/7795009/) BUG=94643 TEST=Prerender* Review URL: http://codereview.chromium.org/7846001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104130 0039d316-1c4b-4281-b951-d872f2087c98
* Don't destroy instant loaders if you don't have to.sreeram@chromium.org2011-10-041-11/+7
| | | | | | | | | | | | | | | | As long as the omnibox retains focus, don't delete any instant loaders. This includes cases where the user is not typing actively, or when the user switches tabs (but retaining focus in the omnibox). The rationale is that the user may type at any time, so it's useful to keep the instant loaders ready to process the user query. BUG=none TEST=PreloadInstantTest.* Review URL: http://codereview.chromium.org/8085010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103938 0039d316-1c4b-4281-b951-d872f2087c98
* Splitting the NetworkActionPredictor.Action histogram based on field trial.dominich@chromium.org2011-10-032-5/+6
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8095001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103709 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeURLComponent() functions into net namespace.tfarina@chromium.org2011-10-021-2/+2
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8109004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103677 0039d316-1c4b-4281-b951-d872f2087c98
* Added multiple NetworkActionPredictor heuristics and a field trial to select ↵dominich@chromium.org2011-09-271-24/+64
| | | | | | | | | | | | between them. BUG= TEST=NetworkActionPredictor* Review URL: http://codereview.chromium.org/8036003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103036 0039d316-1c4b-4281-b951-d872f2087c98
* Change some uses of old callback types to new ones.pkasting@chromium.org2011-09-272-4/+6
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8055022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103028 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox enters keyword search mode incorrectlykeishi@chromium.org2011-09-262-21/+124
| | | | | | | | | | | | Happens when input starts with default search engine keyword. BUG=95454 TEST=1. Set default search engine keyword to 'g'. 2. Type 'grand canyon' into omnibox. 3. Confirm that it is not in keyword search mode. Review URL: http://codereview.chromium.org/7754008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102688 0039d316-1c4b-4281-b951-d872f2087c98
* Remove non trivial static from global scope in ShortcutsProvider to improve ↵georgey@chromium.org2011-09-243-18/+22
| | | | | | | | | | startup performance. BUG=none TEST=already unit-tested. Review URL: http://codereview.chromium.org/7995012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102627 0039d316-1c4b-4281-b951-d872f2087c98
* Place field trial name at the end (as a suffix).sreeram@chromium.org2011-09-231-3/+2
| | | | | | | | | | | | For consistency in how histograms are usually named. BUG=none TEST=none Review URL: http://codereview.chromium.org/8015016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102613 0039d316-1c4b-4281-b951-d872f2087c98
* Reintroducing check for NULL tab before updating Instant.dominich@chromium.org2011-09-201-0/+3
| | | | | | | | | | BUG=97233 TEST=instant_browsertest.cc:* Review URL: http://codereview.chromium.org/7976007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102054 0039d316-1c4b-4281-b951-d872f2087c98
* Add Field Trial for Prerender From Omnibox.dominich@chromium.org2011-09-201-7/+4
| | | | | | | | | | BUG=95066 TEST=None Review URL: http://codereview.chromium.org/7825009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101963 0039d316-1c4b-4281-b951-d872f2087c98
* Makes intranet urls autocomplete again. This patch gives the relevancesky@chromium.org2011-09-205-76/+242
| | | | | | | | | | | | | | that such sites had in the past. The other key it does it to make sure FixupExactSuggestion returns false so that we don't use the what you typed match. BUG=94805 TEST=see bug R=pkasting@chromium.org Review URL: http://codereview.chromium.org/7756020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101959 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes and simplification to ShortcutsBackend including addition of "DeleteAll"georgey@chromium.org2011-09-173-103/+102
| | | | | | | | TEST=unit-tests BUG=none Review URL: http://codereview.chromium.org/7821011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101611 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100530 - Disable the in memory URL index. This is a temporary test to ↵brettw@chromium.org2011-09-141-2/+2
| | | | | | | | | | | see if it affects crashes in Chrome. Review URL: http://codereview.chromium.org/7796011 TBR=brettw@google.com Review URL: http://codereview.chromium.org/7885050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101182 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from chrome://extensions to chrome://settings/extensionSettings.finnur@chromium.org2011-09-131-0/+1
| | | | | | | | BUG=87377 TEST=All links that went to chrome://extensions (from the wrench menu/extension action context menu etc) should go to the new settings page. Review URL: http://codereview.chromium.org/7782026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100893 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100828 Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100857 0039d316-1c4b-4281-b951-d872f2087c98
* Fix Linux Views build breakage.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | | | | | | Revert 100828 - Move URLFetcher from content/common to content/common/net. Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 TBR=willchan@chromium.org Review URL: http://codereview.chromium.org/7884003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100829 0039d316-1c4b-4281-b951-d872f2087c98
* Move URLFetcher from content/common to content/common/net.willchan@chromium.org2011-09-131-1/+1
| | | | | | | | | | | Add a OWNERS for content/common/net BUG=none TEST=none Review URL: http://codereview.chromium.org/7875006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100828 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99124: Revert 99099 Fix up more WaitForNavigation calls.gbillock@chromium.org2011-09-121-2/+3
| | | | | | | | | | | | | | | Revert task manager test. This one looks to be more complicated. See http://codereview.chromium.org/7745037/ (original review) R=phajdan.jr@chromium.org BUG=None. TEST=browser_tests,ui_tests Review URL: http://codereview.chromium.org/7831020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100749 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying prefetch to account for multi-profile.rlp@chromium.org2011-09-101-3/+6
| | | | | | | | | | | | | | | | | | | | Items of note: - predictor_api is gone. Most functions in predictor_api.cc have moved into the chrome_browser_net::Predictor class or the Profile class. - The predictor state is cleaned up in the Profile dtor. - Predictor is owned by the ProfileIOData of the profile. - InitialObserver class is gone since each profile keeps their own info, the non-OTR don't care if anyone is OTR. - Predictor is created by the profile and then passed to the ProfileIOData. Then its initialization is finished on the IOThread. - ConnectInterceptor now subclasses off of UrlRequestJobFactory::Interceptor. - Updated Profile to create a SimpleShutdownPredictor with limited functionality when in unittests. BUG=89937,90114 TEST=passes existing Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=97446 Review URL: http://codereview.chromium.org/7467012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100555 0039d316-1c4b-4281-b951-d872f2087c98
* Disable the in memory URL index. This is a temporary test to see if it ↵brettw@google.com2011-09-091-2/+2
| | | | | | | | affects crashes in Chrome. Review URL: http://codereview.chromium.org/7796011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100530 0039d316-1c4b-4281-b951-d872f2087c98
* Fix prerender-from-omnibox/Instant issues.dominich@chromium.org2011-09-082-13/+27
| | | | | | | | | | | When we attempt to show an Instant preview tab we return a boolean to indicate success. We then only try to prerender if this returns false and if the prerender-from-omnibox flag is set. BUG=94423 TEST=Manual: Tested combinations of no flags, --prerender-from-omnibox, and --restrict-instant-to-search. Review URL: http://codereview.chromium.org/7828057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100091 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 100003 - Moved PrerenderManager to ProfileKeyedService system.dominich@chromium.org2011-09-071-2/+1
| | | | | | | | | | | | | | | As per https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/554b5b0ca05e001d# it is recommended that weak references to services be removed from Profiles and constructed as ProfileKeyedServices instead. This does this for the PrerenderManager. BUG=94643 TEST=Prerender* Review URL: http://codereview.chromium.org/7795009 TBR=dominich@chromium.org Review URL: http://codereview.chromium.org/7837045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100014 0039d316-1c4b-4281-b951-d872f2087c98
* Moved PrerenderManager to ProfileKeyedService system.dominich@chromium.org2011-09-071-1/+2
| | | | | | | | | | | | As per https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thread/554b5b0ca05e001d# it is recommended that weak references to services be removed from Profiles and constructed as ProfileKeyedServices instead. This does this for the PrerenderManager. BUG=94643 TEST=Prerender* Review URL: http://codereview.chromium.org/7795009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100003 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 99883 - Completely disable about:flagsthakis@chromium.org2011-09-071-1/+1
| | | | | | | | | | | | | | | This is an attempt to improve stability on the m14 branch. I will revert this CL right after merging it to m14. BUG=95592 TEST=Go to about:flags and chrome://flags. Nothing should be there. Go to about:version, no --begin-flags and --end-flags should be there. Review URL: http://codereview.chromium.org/7837006 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/7841022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99888 0039d316-1c4b-4281-b951-d872f2087c98
* Completely disable about:flagsthakis@chromium.org2011-09-071-1/+1
| | | | | | | | | | | | This is an attempt to improve stability on the m14 branch. I will revert this CL right after merging it to m14. BUG=95592 TEST=Go to about:flags and chrome://flags. Nothing should be there. Go to about:version, no --begin-flags and --end-flags should be there. Review URL: http://codereview.chromium.org/7837006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99883 0039d316-1c4b-4281-b951-d872f2087c98
* Confidence ranges were coming in too high and had occasional divide-by-zero ↵dominich@chromium.org2011-09-072-10/+9
| | | | | | | | | | | leading to CHECK failures. Changed the math and the unit tests to satisfy stricter confidence requirements and remove divide by zero. BUG=95453 TEST=None Review URL: http://codereview.chromium.org/7833046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99879 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Split BookmarkModel::SetURLStarred in two helper functions in ↵tfarina@chromium.org2011-09-031-4/+7
| | | | | | | | | | | | | | | | | | bookmark_utils. This patch splits SetURLStarred into: - bookmark_utils::AddIfNotBookmarked - bookmark_utils::RemoveAllBookmarks BUG=None TEST=None R=sky@chromium.org Review URL: http://codereview.chromium.org/7825017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99524 0039d316-1c4b-4281-b951-d872f2087c98
* Update base/timer.h code to pass through Location from call sites. (reland) ↵jbates@chromium.org2011-09-022-2/+4
| | | | | | | | original CL w/LGTMs: http://codereview.chromium.org/7812036/ Review URL: http://codereview.chromium.org/7824041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99409 0039d316-1c4b-4281-b951-d872f2087c98
* Track recommended actions for all UMA users.dominich@chromium.org2011-09-021-10/+13
| | | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/7830023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99367 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Currently, base/timer.cc calls PostTask with FROM_HERE as the Location,mattm@chromium.org2011-09-022-4/+2
| | | | | | | | | | | | so the original code that created the delayed callback is lost." This reverts commit 4cf5cf73d319b69c32ad30af8954235755856455. (r99284) TBR=jbates@chromium.org Review URL: http://codereview.chromium.org/7825026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99290 0039d316-1c4b-4281-b951-d872f2087c98
* Currently, base/timer.cc calls PostTask with FROM_HERE as the Location, so ↵jbates@chromium.org2011-09-022-2/+4
| | | | | | | | | | the original code that created the delayed callback is lost. This change adds a tracked_objects::Location parameter to the APIs in base/timer.h so we can trace the PostTask callbacks. The other files are touched to add the FROM_HERE Location parameter. Review URL: http://codereview.chromium.org/7812036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99284 0039d316-1c4b-4281-b951-d872f2087c98
* Fix crash in CanFindIntranetURL() due to FixupUserInput() changing the ↵pkasting@chromium.org2011-09-017-33/+47
| | | | | | | | | | AutocompleteInput's text_ but not its parts_, and us newly trying to use those parts_ later. BUG=94158 TEST=Covered by unittests Review URL: http://codereview.chromium.org/7822009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99233 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-06 13:11:12 +0000