summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Cleanup: Include browser.h -> ui/browser.h [Part 2].jhawkins@chromium.org2010-11-162-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/5046002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66229 0039d316-1c4b-4281-b951-d872f2087c98
* Makes search provider honor inline autocomplete.sky@chromium.org2010-11-152-7/+19
| | | | | | | | | BUG=63151 TEST=see bug Review URL: http://codereview.chromium.org/4978002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66186 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AutocompleteEditViewTest.BasicTextOperationsphajdan.jr@chromium.org2010-11-121-1/+2
| | | | | | | | | | | TBR=suzhe BUG=62935 TEST=interactive_ui_tests Review URL: http://codereview.chromium.org/4882002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65923 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the instant suggested text autocomplete after 1.3 seconds. Theresky@chromium.org2010-11-1110-45/+66
| | | | | | | | | | | | are a number of parts of this patch that need work, but it should be good enough for us to decide if we want to pursue it. BUG=none TEST=none Review URL: http://codereview.chromium.org/4385001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65741 0039d316-1c4b-4281-b951-d872f2087c98
* Don't allow exact keyword matches for most uses of the autocomplete ↵pkasting@chromium.org2010-11-1015-51/+150
| | | | | | | | | | classifier. Patch by Naoki Takano (see http://codereview.chromium.org/4142006 ), r=me. BUG=60059 TEST=Change a search engine keyword to "a", highlight text beginning with "a" in a webpage (e.g. "a movie"), right-click and select "Search Google for a movie". The result should be a Google search page, not a result page for whatever search engine has the keyword "a". Review URL: http://codereview.chromium.org/4717001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65706 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for classes other than native control to processsky@chromium.org2010-11-102-1/+44
| | | | | | | | | | | | messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/4637002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65612 0039d316-1c4b-4281-b951-d872f2087c98
* Update internal state on undo to avoid a crash.sadrul@chromium.org2010-11-101-2/+4
| | | | | | | | | | | | | | Update actions_in_current_group when removing an action so that it doesn't crash afterwards. BUG=61607,62609 TEST=manual (see bug) Do not set text if it didn't change, because it registers a delete/insert undo-able action-couple. Review URL: http://codereview.chromium.org/4683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65609 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks the ranking of past searches so they get autocompleted.sky@chromium.org2010-11-092-9/+29
| | | | | | | | | | | | If you don't like the scoring I've given them, please suggest an alternative. BUG=61518 TEST=none Review URL: http://codereview.chromium.org/4751001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65566 0039d316-1c4b-4281-b951-d872f2087c98
* Split out command IDs from chrome_dll_resource.h.evan@chromium.org2010-11-084-4/+4
| | | | | | | | | | | | The name of this file is a leftover from Windows. Split the command ids (which are used on all platforms) out, leaving just the Windows-specific resource IDs in the original file. TEST=compiles Review URL: http://codereview.chromium.org/4710001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65453 0039d316-1c4b-4281-b951-d872f2087c98
* Fix compile failurepkasting@chromium.org2010-11-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65392 0039d316-1c4b-4281-b951-d872f2087c98
* Don't treat retyping the current search query as a reload.pkasting@chromium.org2010-11-081-3/+7
| | | | | | | | BUG=54274 TEST=none Review URL: http://codereview.chromium.org/4605002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65388 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 65109 - Adds the ability for classes other than native control to processsky@chromium.org2010-11-042-44/+1
| | | | | | | | | | | | | | | messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/4470001 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/4528001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65122 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for classes other than native control to processsky@chromium.org2010-11-042-1/+44
| | | | | | | | | | | | messages bounced to the parent and wires it up for autocompleteedit, which I'm going to need shortly. BUG=none TEST=none Review URL: http://codereview.chromium.org/4470001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65109 0039d316-1c4b-4281-b951-d872f2087c98
* Makes SearchProvider use the in memory db for results.sky@chromium.org2010-11-043-108/+39
| | | | | | | | | BUG=61518 TEST=none Review URL: http://codereview.chromium.org/4257002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65083 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Drags from the omnibox should use the 'http://' version of the url.erg@google.com2010-11-042-0/+23
| | | | | | | | | BUG=61489 TEST=manual. see bug. Review URL: http://codereview.chromium.org/4441001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65078 0039d316-1c4b-4281-b951-d872f2087c98
* Fix some UI issues with omnibox extensions in incognito.mpcomplete@chromium.org2010-11-032-16/+34
| | | | | | | | | | | Also moved a shared method from ExtensionEventRouter to ExtensionsService. BUG=58210 TEST=Install the extension in chrome/common/extensions/docs/examples/extensions/chrome_search. You should not see the UI artifacts described in the bug. Review URL: http://codereview.chromium.org/4234004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64964 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Improve preedit string and Instant suggestion support in omnibox.suzhe@chromium.org2010-11-023-86/+383
| | | | | | | | | | | | | | | This CL contains following major changes: 1. Uses GtkLabel instead of GtkTextView for displaying instant suggestion. 2. Attaches the instant view to a child anchor in the text view. 3. Treats preedit string as part of user input, so that autocomplete match can take effect with uncommitted preedit string. BUG=27547 TEST=Instant suggestion should work as normal. And preedit string should trigger autocomplete match and work with Instant suggestion. Review URL: http://codereview.chromium.org/4202005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64825 0039d316-1c4b-4281-b951-d872f2087c98
* Make all browser code use browser::Navigate to open tabs.ben@chromium.org2010-11-021-4/+2
| | | | | | | | | BUG=none TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc. Review URL: http://codereview.chromium.org/3834002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
* Adds keyword_search_terms to in memory db so that we can synchronouslysky@chromium.org2010-11-011-1/+1
| | | | | | | | | | | get past searches. BUG=none TEST=none Review URL: http://codereview.chromium.org/4087013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64668 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to show verbatim instant results rather thansky@chromium.org2010-11-015-1/+54
| | | | | | | | | | | predictive results. More work is needed if we decide this is the direction to go, but it's good enough for us to play with. BUG=61378 TEST=none Review URL: http://codereview.chromium.org/4196009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64662 0039d316-1c4b-4281-b951-d872f2087c98
* Instant - move AutocompleteLosingFocus implementation to InstantController.estade@chromium.org2010-11-012-3/+44
| | | | | | | | | | | This way Linux and Windows can share. BUG=58937 TEST=manual Review URL: http://codereview.chromium.org/4157004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64657 0039d316-1c4b-4281-b951-d872f2087c98
* Part 3 of immutable Extension refactor.mpcomplete@chromium.org2010-10-291-1/+1
| | | | | | | | | | | | | Make ExtensionsService hold const Extension pointers only. This ensures that extensions can't be modified after they're created, and lets us share them between threads. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4138006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove base/gtk_util.h by moving its methods tojhawkins@chromium.org2010-10-292-11/+13
| | | | | | | | | | | gfx/gtk_util.h BUG=none TEST=none Review URL: http://codereview.chromium.org/4150006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64348 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux] Handle preedit string in omnibox correctly (part1).suzhe@chromium.org2010-10-272-0/+34
| | | | | | | | | | | This CL hooks GtkTextView's "preedit-changed" signal (added since 2.20.0) to clear existing selection range when a preedit string is set. BUG=18808 IME canidate and previous URL will show together in Omnibox when typing Chinese using SCIM TEST=See bug reports. Review URL: http://codereview.chromium.org/4190006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64170 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Added unit tests for omnibox highlightingscr@chromium.org2010-10-2730-444/+950
| | | | | | | | | | BUG=55418 TEST=unit_tests --gtest_filter=AutocompletePopupViewGtkTest.\* should run tests on GTK but not Windows or Mac. Review URL: http://codereview.chromium.org/4082002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64169 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] fix buildestade@chromium.org2010-10-271-1/+1
| | | | | | | | | | | | gtk_widget_set_can_focus is 2.18+ TBR=markus BUG=none TEST=build Review URL: http://codereview.chromium.org/4097003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64001 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] omnibox changes for instantestade@chromium.org2010-10-272-18/+113
| | | | | | | | | | | | | Most notable change is display of the instant suggestion via gtk_text_view_add_child_in_window There are a lot of TODOs still but this seems like a good checkpoint for review. BUG=58937 TEST=manual (although some stuff still doesn't work) Review URL: http://codereview.chromium.org/4099005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64000 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Fix several pass-by-values.jhawkins@chromium.org2010-10-261-1/+1
| | | | | | | | | | CID=12543,12544,12758,12878,12879,12918,13252,13285,13301,13391 BUG=none TEST=none Review URL: http://codereview.chromium.org/4040003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63910 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable AutocompleteBrowserTest.Basicisherman@chromium.org2010-10-261-9/+1
| | | | | | | | | BUG=49324 TEST=browser_tests --gtest_filter=AutocompleteBrowserTest.Basic --gtest_repeat=10000 --gtest_break_on_failure Review URL: http://codereview.chromium.org/3436027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63870 0039d316-1c4b-4281-b951-d872f2087c98
* [linux] instant search/browsing first cutestade@chromium.org2010-10-261-2/+13
| | | | | | | | | | | Implements the tab contents switching stuff (but not the suggestion text bit). BUG=58937 TEST=manual (must be enabled in about:flags) Review URL: http://codereview.chromium.org/4049002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63815 0039d316-1c4b-4281-b951-d872f2087c98
* Some cleanup of view accessibility and view accessibility wrapper.ctguil@chromium.org2010-10-221-11/+7
| | | | | | | | | | | | | | | 1. Remove the ViewAccessibilityWrapper class. The view can directly manage it's ViewAccessibility. 2. Always use GetAccessibleForView to retrieve a view's associated accessibility object. This ensures that the correct accessibility object is returned for native view host objects. 3. Update get_accFocus to use FocusManager. 4. Move oleacc guid definitions to view_win.cc. BUG=none TEST=interactive_ui_tests:BrowserViewsAccessibilityTest.TestBrowserRootViewAccObj TEST=Manual: I can select the accessibility object of a native view host within AccExplorer32.exe. Review URL: http://codereview.chromium.org/4047001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63451 0039d316-1c4b-4281-b951-d872f2087c98
* Convert gfx::ElideText from using wstrings to string16.tony@chromium.org2010-10-212-3/+8
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3885003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63433 0039d316-1c4b-4281-b951-d872f2087c98
* Make the Windows location bar send accessibility events to thedmazzoni@chromium.org2010-10-211-0/+11
| | | | | | | | | | | | accessibility extension API on Windows. This adds a few more accessibility events to views accessibility while we're at it. BUG=none TEST=none Review URL: http://codereview.chromium.org/3999001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63394 0039d316-1c4b-4281-b951-d872f2087c98
* Move all ResourceBundle::GetNSImageNamed() calls to GetNativeImageNamed().rsesek@chromium.org2010-10-211-1/+1
| | | | | | | | | | | This is part of the first stage of cleaning up ResourceBundle's interface. BUG=58030 TEST=Compile and unit tests. Review URL: http://codereview.chromium.org/3806007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63367 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more deinlining.erg@google.com2010-10-202-0/+3
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3879002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63261 0039d316-1c4b-4281-b951-d872f2087c98
* Removes two unused methods:rohitrao@chromium.org2010-10-205-19/+0
| | | | | | | | | | | InstantLoader::DestroyPreviewContents() AutocompleteEditView::GetMaxYCoordinate() BUG=None TEST=Everything should still compile. Review URL: http://codereview.chromium.org/3772008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63218 0039d316-1c4b-4281-b951-d872f2087c98
* Move BaseDropTarget and BaseDragSource from base to app/win. Remove the ↵brettw@chromium.org2010-10-171-5/+5
| | | | | | | | | | "Base" class name prefix and put in the app::win namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/3822007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62900 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Added Support for DIM AutoComplete Match Classification specifiers.scr@chromium.org2010-10-153-18/+49
| | | | | | | | | | | BUG=55418 TEST=Type "yout" in the autocomplete and look for "youtube" in the autocomplete popup. The letters "yout" should be dimmer than the suggested letters "ube" which should be "normal". Review URL: http://codereview.chromium.org/3750008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62791 0039d316-1c4b-4281-b951-d872f2087c98
* Move iat_patch from base to app/win. Remove the functions from the header sincebrettw@chromium.org2010-10-141-3/+3
| | | | | | | | | | | | they aren't used, and just make them local to the .cc file. Rename the .cc file to iat_patch_function to match the class definition. Put it in the app::win namespace to match the directories. Update callers. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3743006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62678 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Plumb through the Instant and omnibox popup bounds. This will allow ↵rohitrao@chromium.org2010-10-147-8/+25
| | | | | | | | | | instant results to properly move out of the way of the omnibox. BUG=56385 TEST=Do a Google search with Instant turned on. The omnibox should not overlap with the results. Review URL: http://codereview.chromium.org/3735005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62550 0039d316-1c4b-4281-b951-d872f2087c98
* Move Stats, histograms, and field trial into a metrics subdirectory of base andbrettw@chromium.org2010-10-144-4/+3
| | | | | | | | | put them in the base namespace. TEST=it compiles BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Added Support for DIM AutoComplete Match Classification specifiers.estade@chromium.org2010-10-132-11/+25
| | | | | | | | | | | | | | BUG=55418 TEST=Type "yout" in the autocomplete and look for "youtube" in the autocomplete popup. The letters "yout" should be dimmer than the suggested letters "ube" which should be "normal". patch by Sheridan Rawlins <scr [at] chromium [dot] org> original review: http://codereview.chromium.org/3647004/show Review URL: http://codereview.chromium.org/3770004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62442 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Final Part:tfarina@chromium.org2010-10-121-5/+5
| | | | | | | | | | | | | | - Rename chrome_thread.cc to browser_thread.cc - Rename chrome_thread_unittest.cc to browser_thread_unittest.cc - Include browser_thread.h instead of chrome_thread.h where needed. - Fix gyp files according. BUG=56926 TEST=trybots and compiled locally Review URL: http://codereview.chromium.org/3643005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62356 0039d316-1c4b-4281-b951-d872f2087c98
* Final phase of the URL History Quick autocomplete provider integration. This ↵mrossetti@chromium.org2010-10-129-145/+617
| | | | | | | | | | | | | phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider. Previous CL: http://codereview.chromium.org/3375002 BUG=23654,19736 TEST=Green bots. Start typing text which occurs in URLs which are in the history. Verify that those history items appear if they have been manually typed more than once or the have been visited more than three time or they have been visited within the last three days. Review URL: http://codereview.chromium.org/3713003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62298 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeThread to BrowserThread Part19:tfarina@chromium.org2010-10-123-3/+3
| | | | | | | | | | | - Include browser_thread.h instead of chrome_thread.h in more 65 files. BUG=56926 TEST=trybots Review URL: http://codereview.chromium.org/3717003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62226 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Initial Instant implementation.rohitrao@chromium.org2010-10-121-0/+4
| | | | | | | | | | | | | | | | This is a very rough cut. Many things are still unfinished and will be fixed in future CLs: - Clicking on instant results clears the results. - Suggestions do not work yet. - The omnibox popup overlaps with instant results. - HTTP auth dialogs cause crashes. BUG=56385 TEST=No visible impact when --enable-match-preview is not set on the command line. TEST=Instant results should appear when typing in the omnibox. TEST=Instant results should disappear when clicking outside the browser window or clicking on devtools or the sidebar. Review URL: http://codereview.chromium.org/3624001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62221 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 62193 - Final phase of the URL History Quick autocomplete provider ↵mrossetti@chromium.org2010-10-119-617/+145
| | | | | | | | | | | | | | integration. This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider. BUG=None TEST=None Review URL: http://codereview.chromium.org/3375002 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/3660007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62201 0039d316-1c4b-4281-b951-d872f2087c98
* Final phase of the URL History Quick autocomplete provider integration. ↵mrossetti@chromium.org2010-10-119-145/+617
| | | | | | | | | | | This phase hooks up the InMemoryURLIndex to the HistoryQuickProvider which is itself made active during the autocomplete process. A small amount of refactoring was done to liberate some common functionality from the history_url_provider. BUG=None TEST=None Review URL: http://codereview.chromium.org/3375002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62193 0039d316-1c4b-4281-b951-d872f2087c98
* Removes the #ifdef around Instant-related AutocompleteEditController ↵rohitrao@chromium.org2010-10-103-12/+1
| | | | | | | | | | methods. Adds empty implementations on Mac and Linux. BUG=56385 TEST=No visible impact. Review URL: http://codereview.chromium.org/3625004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62125 0039d316-1c4b-4281-b951-d872f2087c98
* The start of the instant opt-in mocks.sky@chromium.org2010-10-081-0/+2
| | | | | | | | | | | I also had to make it so you can turn off animations in CustomButton. BUG=54833 TEST=none Review URL: http://codereview.chromium.org/3544015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62009 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-06-10 00:32:08 +0000