summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Use KF_ALTDOWN flag instead of GetKeyState(VK_MENU)xiyuan@chromium.org2009-12-171-1/+1
| | | | | | | | | | | | | KF_ALTDOWN is more accurate than GetKeyState(VK_MENU). When usre presses RightShift+RightAlt, the fake VK_CONTROL generated carries KF_ALTDOWN in its flags but GetKeyState(VK_MENU) is clear. BUG=30244 TEST=Verify RightAlt+RightShift does not change to RTL and issue 24888 does not regress. However, RightShift+RightAlt still changes RTL as this is the behavior of richedit. Review URL: http://codereview.chromium.org/505026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34850 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-164-3/+12
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Make a shared app menu model and update win and mac to use it. Remove the ↵pinkerton@chromium.org2009-12-152-2/+1
| | | | | | | | | | NSMenu from Toolbar.xib. BUG=22646 TEST=the app menu works as it used to. Review URL: http://codereview.chromium.org/482006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34561 0039d316-1c4b-4281-b951-d872f2087c98
* Fix issue 30244xiyuan@chromium.org2009-12-141-2/+3
| | | | | | | | | | | | Ensure Alt is clear for our Ctrl+Shift/Shift+Ctrl logic so that Hebrew IME generated Shift+Ctrl does not pass through and triggers RTL. BUG=30244 TEST=Verify fix for 30244 and issue 24888 does not regress. Review URL: http://codereview.chromium.org/497010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34497 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts my r4300 and re-fixes Issue 3156 and 13500.hbono@chromium.org2009-12-092-23/+16
| | | | | | | | | | | | | | | | | | My r4300, which is a fix Issue 3156, has been causing regressions (Issue 9596, Issue 13500, Issue 29290, etc.) Every time when this change caused regressions, we added more code to Chromium and made Chromium code more complicated. So, I think it is better to revert this change once and find another solution for Issue 3156 rather than to add another workaround for Issue 29290. To look into Issue 3156 more deeply, it is caused by a recursive message-handler call. When SetWindowText() is called while an IME is composing text, the IME calls SendMessage() to send a WM_IME_COMPOSITION message. When we receive this WM_IME_COMPOSITION message, it updates the omnibox and calls SetWindowText()... This recursive call caused not only Issue 3156 but also caused some other IME issues, such as Issue 13500. BUG=3156,13500,29290 TEST=On XP, open a new tab, set the IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate and show the popup URL without a crash. TEST=Open Gmail, compose a new e-mail (without using a tear-off window), set the IME to Hiragana, type 'c' in its message body, and wait for the draft auto-saving. The browser should show the 'c' character. Review URL: http://codereview.chromium.org/467015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34145 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: implement "Search the Web..." (Opt-Cmd-F).viettrungluu@chromium.org2009-12-072-1/+14
| | | | | | | | | | | | | | This focuses the Omnibox with '?' in the contents with the text insertion point immediately after (and no selection), unless the Omnibox already has something beginning with '?' in which case it selects the text after the '?'. This is what Ctrl-K does on other platforms. On the Mac, we get a menu item (under Edit -> Find), and the Mac-standard shortcut of Opt-Cmd-F (users can set Cmd-K as a short cut in System Preferences if they really want). Changes to MainMenu.xib: added ^IDS_EDIT_SEARCH_WEB_MAC menu item ("Search the Web...", tag 39002, Opt-Cmd-F as keyboard shortcut, sending -commandDispatch: to first responder) as first item in Find submenu, followed by a separator. BUG=29501 TEST=Check that this feature has the behaviour described above (using both the menu item and using Opt-Cmd-F), with (1) nothing in the Omnibox to begin with, (2) a random URL in the Omnibox, and (3) "?<some search term(s)>". Check that the Omnibox is properly focused (so set focus to various places, and make sure that the Omnibox gets focused). Review URL: http://codereview.chromium.org/460111 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33971 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Route edit-state messages via observer rather than delegate.shess@chromium.org2009-12-042-270/+125
| | | | | | | | | | | | | | | | | | | AutocompleteTextField routes messages to AutocompleteEditViewMac via a Cocoa-style delegate and also a C++ observer class. The Cocoa-style delegate has been gradually being pruned down in favor of the observer, this CL completes the transformation. The noted bugs occur because some bit of Cocoa code was sending spurious delegate notifications. Since this code no longer depends on those notifications, the spurious notifications are no longer a problem for this case. BUG=19116, 17803 TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox). Review URL: http://codereview.chromium.org/391025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33853 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor the menu model to live outside views/ so it can be sharedpinkerton@chromium.org2009-12-042-7/+9
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/465005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33827 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-1/+0
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-0/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Restore omnibox text selection on tab switch.derat@chromium.org2009-11-242-12/+5
| | | | | | | | | | | | | | | | | Tested by: - highlighting omnibox text - switching to a different tab - highlighting some other text - switching back to the first tab - confirming that the omnibox highlighting was restored but PRIMARY didn't get updated when switching back BUG=20674 TEST=see above Review URL: http://codereview.chromium.org/440003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32914 0039d316-1c4b-4281-b951-d872f2087c98
* Use AutoReset (formerly ScopedBool) where possible.pkasting@chromium.org2009-11-201-2/+2
| | | | | | | | | | This frequently saves a tiny bit of code, but even when it doesn't I think it's more future-proof (less error-prone). BUG=none TEST=none Review URL: http://codereview.chromium.org/399096 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32708 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two issues from valgrind, and some cleanup:sky@chromium.org2009-11-201-28/+1
| | | | | | | | | | | | | | | . Makes it so observer installed by WidgetGtk is cleaned up and not leaked. . Removes unnecessary static_cast<int> in view. . Fixes some leaks in textfield and button. . Removes AutocompletePopupViewGTK's copy of PangoFontFromGfxFont. BUG=none TEST=none Review URL: http://codereview.chromium.org/420005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32686 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Remove problematic theme styles from the location bar.erg@google.com2009-11-181-0/+29
| | | | | | | | | BUG=27103 TEST=Use xfce-stellar theme. There shouldn't be an inner box in the location bar and typing shouldn't cause text to move up and down. Review URL: http://codereview.chromium.org/399087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32416 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-172-4/+4
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* A quick fix for Issue 3798.hbono@chromium.org2009-11-171-0/+27
| | | | | | | | | | Some Chinese IMEs insert whitespace characters (U+3000) instead of input characters while they are composing text. So, trimming these whitespace characters (at the beginning of an omnibox) prevents from inputting text on these IMEs. As a quick fix, this change prevent our AutocompleteEditViewWin::OnImeComposition() from starting auto-complete when an omnibox starts with whitespace characters. BUG=3798 TEST=Type "google.com" on Omnibox, type "Tab" to start tab-to-search, type 'nihao' on Microsoft New Phonetic IME, and see we can see Chinese characters in the omnibox. Review URL: http://codereview.chromium.org/391070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32166 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-132-2/+4
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Ignore incorrect focus notifications in Omnibox.shess@chromium.org2009-11-121-0/+9
| | | | | | | | | | | | | | | | | | | | | | | After the user runs a Print or Page Layout panel, autocomplete_edit_view_mac.mm starts seeing -controlTextDidBeginEditing: notifications when the field does not have a field editor. The code thoroughly depends on having a field editor when it has focus, so this breaks things badly. -controlTextDidBeginEditing: appears to be sent multiple times when in this state, once inappropriately, and later when everything is set up correctly (when the user edits), so this simply ignores the inappropriate notification. In the case that is being ignored, AutocompleteEditViewMac will fire DCHECKs all over the place, so it's somewhat unlikely that this case is happening in correct operation. BUG=19116, 17803 TEST=Login to gmail, select a message, j, k, and other keys should work (and not send you to the omnibox). Bring up the Print panel and cancel. Bring up a new tab and close it. gmail's accelerator keys should still work right (not send focus to omnibox). Review URL: http://codereview.chromium.org/391001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31825 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Support undo in the omnibox.rohitrao@chromium.org2009-11-121-0/+3
| | | | | | | | BUG=http://crbug.com/18084 TEST=You should be able to undo and redo typing and pasting in the omnibox, unless autocomplete has kicked in or you selected/highlighted an entry in the popup. Review URL: http://codereview.chromium.org/246009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31785 0039d316-1c4b-4281-b951-d872f2087c98
* Total guess fixes for the bug.thomasvl@chromium.org2009-11-121-1/+2
| | | | | | | | | | | | Add DCHECKs for main thread in all the places we use animation contexts. Added a stack based class that takes an animate flag to enable/disable animation operations (grouping, durations) to clean up the code that does optional animation. This might help the crashes in the bug because before we created animation context groups when we didn't need them and those empty groups could be tripping up something in the system frameworks (I some something similar in nib loading on 10.6). BUG=26979 TEST=like we have a repeat fail case... Review URL: http://codereview.chromium.org/390014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31781 0039d316-1c4b-4281-b951-d872f2087c98
* Adding implementation of AutocompleteEditViewMac::IsSelectAll().jcampan@chromium.org2009-11-122-7/+9
| | | | | | | | | | | Also makes the SetUserText behavior similar to the Windows/Linux versions (by calling SetWindowTextAndCaretPos() that also deals with the selection). R=shess BUG=None TEST=Make sure the location bar still works as expected on Mac. Review URL: http://codereview.chromium.org/329024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31745 0039d316-1c4b-4281-b951-d872f2087c98
* Avoid inconsistent state (leading to checkfailures) due to Windows ↵pkasting@chromium.org2009-11-111-6/+1
| | | | | | | | | | | | minimize/restore functionality hiding and showing the autocomplete dropdown outside of the awareness of the controller. Instead, this switches to the simpler model of just creating a new HWND when we want to show the dropdown, and destroying it when we want to close it. Happily, this also seems to save quite a bit of code. BUG=20511 TEST=Type a character in the omnibox, minimize the window, and restore it. The dropdown should have disappeared. Review URL: http://codereview.chromium.org/391011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31649 0039d316-1c4b-4281-b951-d872f2087c98
* Added a flag to the Canvas class which allows forcing an RTL directionalityidana@chromium.org2009-11-111-1/+1
| | | | | | | | | | | | | on text drawn using Canvas::DrawStringInt(). Using this flag, it is possible to render RTL text correctly on platforms where LRE/PDF chars are not supported (e.g. Windows XP with no RTL fonts installed). BUG=23425 TEST=Run chrome and enter Hebrew text into the omnibox (see bug description). Make sure suggestions are formatted correctly. Verify in both RTL and LTR UIs. Review URL: http://codereview.chromium.org/384018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31619 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for slowing down all animations on the Mac by using the shift and/ordmaclach@chromium.org2009-11-101-1/+3
| | | | | | | | | | | | | | | control key. BUG=27274 TEST= 1) create a window. 2) Create a tab. 3) Hold down the shift key and click in the close button on the tab. 4) Watch animation proceed slowly. (and slower if you hold down shift + control) This should apply to all non-web page animations. Review URL: http://codereview.chromium.org/388004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31588 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with inline autocomplete and URLs that change length ↵pkasting@chromium.org2009-11-075-39/+84
| | | | | | | | | | | | | | | | | | | | during fixup: * URLs with http auth info, which gets stripped * URLs with IDN hosts * URLs with escaped values that get unescaped In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode. The fix is to track how fixup affects the offsets into the URL we care about. Plumbing this required an enormous number of additions :( There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match. Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong). This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it). BUG=4010 TEST=Covered by unittests Review URL: http://codereview.chromium.org/372017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-066-2/+14
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-066-14/+2
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts some useful code accidently removed by CL ↵suzhe@chromium.org2009-11-062-6/+6
| | | | | | | | | | | | http://codereview.chromium.org/340024/show BUG=12316, 24818 TEST=Clear the omnibox, and paste something into it by middle click, the inline autocomplete shouldn't be triggered. TEST=Input something in the omnibox to trigger inline autocomplete, then press and hold ctrl key and click the text to clear the selection, then release ctrl key, the text in the omnibox shouldn't be changed. Review URL: http://codereview.chromium.org/362018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31198 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-066-2/+14
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/361025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
* Restoring r29827. The skia file is new to this attempt, and may be what was ↵pamg@google.com2009-11-042-13/+0
| | | | | | | | | | | | | | | causing a unit test to crash last time. Refactor security-icon code to a more general form, also more consistent with the Windows implementation, in preparation for implementing page actions. Review URL: http://codereview.chromium.org/264037 BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/348069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31023 0039d316-1c4b-4281-b951-d872f2087c98
* Try to add more sanity checking to help track down a crash.pkasting@chromium.org2009-11-042-3/+9
| | | | | | | | BUG=20511 TEST=none Review URL: http://codereview.chromium.org/342112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30908 0039d316-1c4b-4281-b951-d872f2087c98
* Eliminate QueryOptions::most_recent_visit_only. All non-unittest consumers ↵pkasting@chromium.org2009-11-031-2/+1
| | | | | | | | | | of this set it to true, so just turn it on unconditionally. BUG=none TEST=none Review URL: http://codereview.chromium.org/341087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30880 0039d316-1c4b-4281-b951-d872f2087c98
* Better handling of UNKNOWN versus QUERY in a couple ways.pkasting@chromium.org2009-11-034-15/+69
| | | | | | | | | | | | First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces. The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now. Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs. BUG=26341 TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate. Review URL: http://codereview.chromium.org/353010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30830 0039d316-1c4b-4281-b951-d872f2087c98
* Removes test that we're likely never going to reenable.sky@chromium.org2009-11-031-66/+32
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/340069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30813 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for fix to allow navigation when there is no history DB.pkasting@chromium.org2009-11-023-7/+33
| | | | | | | | BUG=25822 TEST=none Review URL: http://codereview.chromium.org/343067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30744 0039d316-1c4b-4281-b951-d872f2087c98
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-022-0/+15
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Re-enable omnibox select-all-on-click for Chrome OS builds.derat@chromium.org2009-10-312-0/+101
| | | | | | | | TEST=built chrome-os and non- binaries and made sure they worked as expected Review URL: http://codereview.chromium.org/342069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30667 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure we can still navigate to URLs when the History DB can't be loaded.pkasting@chromium.org2009-10-302-4/+19
| | | | | | | | BUG=25822 TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation. Review URL: http://codereview.chromium.org/343051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30633 0039d316-1c4b-4281-b951-d872f2087c98
* Factor search vs. navigate classification into its own file to make it more ↵pkasting@chromium.org2009-10-292-82/+16
| | | | | | | | | broadly usable. Patch by Thiago Farina (see http://codereview.chromium.org/328031 ), r=me. BUG=21317 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30473 0039d316-1c4b-4281-b951-d872f2087c98
* Use a regular interface pointer for ITextDocument in AutocompleteEditViewWin.ben@chromium.org2009-10-292-8/+25
| | | | | | | | | | | | | I'm doing this because we want precise control over the lifetime of the validity of this pointer. It turns out the paint patching code caused richedit20.dll to be unloaded, which caused the pointer held by the ScopedComPtr member to become junk and the subsequent ~ScopedComPtr to crash. BUG=none TEST=none Review URL: http://codereview.chromium.org/340014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30429 0039d316-1c4b-4281-b951-d872f2087c98
* linux: don't override mouse selection behavior in omniboxevan@chromium.org2009-10-282-90/+2
| | | | | | | | | | | | | | | | | | | This means we now don't match Windows Chrome (which selects all on single click) nor Firefox (which selects all on double click). Patch by Dan Erat; I'm submitting it on his behalf. This is an EXPERIMENT. I may revert it at my own discretion. If you don't like it, please complain at http://code.google.com/p/chromium/issues/detail?id=26140 so your feedback can be tallied. BUG=11614,12713,19508,others. TEST=single click in omnibox does not select all Review URL: http://codereview.chromium.org/340024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30400 0039d316-1c4b-4281-b951-d872f2087c98
* Loosen RFC 1738 compliance check to allow underscores where we already ↵pkasting@chromium.org2009-10-272-5/+7
| | | | | | | | | | | | allowed hyphens, to match real-world needs. I don't believe further loosening will be required but that data will hopefully be coming soon. In the meantime people are asking for this fix. BUG=25714 TEST=Entring "a_b.com" in the omnibox should default to navigate, not search Review URL: http://codereview.chromium.org/339017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30245 0039d316-1c4b-4281-b951-d872f2087c98
* Remove dead variables.pkasting@chromium.org2009-10-271-10/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/329030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30234 0039d316-1c4b-4281-b951-d872f2087c98
* Simplify threading in browser thread by making only ChromeThread deal with ↵jam@chromium.org2009-10-271-3/+8
| | | | | | | | different thread lifetimes.The rest of the code doesn't get MessageLoop pointers since they're not thread-safe and instead just call PostTask on ChromeThread. If the target thread is not alive, then the task is simply deleted.In a followup change, I'll remove any remaining MessageLoop* caching. With this change, there's little to be gained by caching since no locks are involved if the target MessageLoop is guaranteed to outlive the current thread (inferred automatically by the order of the chrome_threads_ array).BUG=25354 Review URL: http://codereview.chromium.org/306032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30163 0039d316-1c4b-4281-b951-d872f2087c98
* CompactNavigationBar for toolkit views build, with some design change per ↵oshima@chromium.org2009-10-262-0/+4
| | | | | | | | | | | | | | | | | Cole's request. * Swapped the positions of entry field and navigation buttons. * Hide navigation buttions when the entry field gains focus. - To implement this, I added OnKillFocus in AutocompleteEditController, and updated corresponding files. * Added accelerator (shift-ctrl-0) to toggle compact navigation bar Changes to BrowserExtender * Made all virtual methods in BrowserExtender pure virtual. * Added HideToolbar method to control visibility of toolbar from Extender. Review URL: http://codereview.chromium.org/329009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30082 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Adjust Omnibox implementation to not break undo chain.shess@chromium.org2009-10-261-1/+1
| | | | | | | | | | | | This does not fix undo, it just makes the implementation break it less. BUG=18084 TEST=Omnibox should continue to work. Review URL: http://codereview.chromium.org/337027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30071 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 29827 - Refactor securityicon code to a more general form, also more ↵nsylvain@chromium.org2009-10-232-0/+13
| | | | | | | | | | | | | | | | consistent with the Windows implementation, in preparation for implementing page actions. BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/264037 TBR=pamg@google.com Review URL: http://codereview.chromium.org/333002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29847 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor security-icon code to a more general form, also more consistent withpamg@google.com2009-10-222-13/+0
| | | | | | | | | | | the Windows implementation, in preparation for implementing page actions. BUG=14899, 22922, 12281 TEST=unit tests included Review URL: http://codereview.chromium.org/264037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29827 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Cmd-Return in the omnibox should revert the omnibox text back to its ↵rohitrao@chromium.org2009-10-223-12/+29
| | | | | | | | | | original state. BUG=23514 TEST=Type a URL into the omnibox, then Cmd-Return. The omnibox text should revert to its original state. Review URL: http://codereview.chromium.org/260008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29743 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 23:23:22 +0000