summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Revert 113071 - Revert 113047 - Make ExtensionService use ExtensionSet.yoz@chromium.org2011-12-061-2/+2
| | | | | | | | | | | | | | | | | | | ExtensionManagementApiBrowserTest.LaunchApp fixed by r113141. Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8789018 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8822021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113233 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 113047 - Make ExtensionService use ExtensionSet.yoz@chromium.org2011-12-061-2/+2
| | | | | | | | | | | | | | | | It broke ExtensionManagementApiBrowserTest.LaunchApp. Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 TBR=yoz@chromium.org Review URL: http://codereview.chromium.org/8789018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113071 0039d316-1c4b-4281-b951-d872f2087c98
* Make ExtensionService use ExtensionSet.yoz@chromium.org2011-12-051-2/+2
| | | | | | | | | | | Make ExtensionSet iterate like a set instead of a map. BUG=104091 TEST=existing tests Review URL: http://codereview.chromium.org/8733004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113047 0039d316-1c4b-4281-b951-d872f2087c98
* Strip invalid characters (line breaks, tabs), javascript:schemes from the ↵ncj674@motorola.com2011-12-041-0/+3
| | | | | | | | | | | | | | copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703 TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8702002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112923 0039d316-1c4b-4281-b951-d872f2087c98
* Removing history-based omnibox prerender heuristics.dominich@chromium.org2011-12-022-112/+65
| | | | | | | | | BUG=105763 Review URL: http://codereview.chromium.org/8735004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112790 0039d316-1c4b-4281-b951-d872f2087c98
* Fix reference to potentially NULL TabContentsWrapper.dominich@chromium.org2011-12-021-4/+11
| | | | | | | | | BUG=105689 Review URL: http://codereview.chromium.org/8745016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112705 0039d316-1c4b-4281-b951-d872f2087c98
* Improve Autocomplete Matches and Handling of Large Results Setsmrossetti@chromium.org2011-12-011-10/+1
| | | | | | | | | | | | | | Do not call FixupUserInput as it was prepending unexpected prefixes (such as file://) to the search string and bypassing valid results. Move the search string decomposition operation from the HQP into the IMUI. In the final substring filtering use whitespace delineated terms rather than words. Instead of bailing if we get a large results set (>500) filter it down to 500 by sorting by typed-count/visit-count/last-visit. This means it's no longer necessary to bypass the HQP if there is only one character in the search term so get rid of the ExpandedInMemoryURLIndexTest.ShortCircuit unit test. BUG=101301,103575 TEST=Added unit tests. Review URL: http://codereview.chromium.org/8526010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112527 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to IWYU for files that previously were getting a bunch ofjoi@chromium.org2011-12-011-0/+1
| | | | | | | | | | | header files via io_thread.h or browser_thread.h TBR=owners (previously approved on codereview 8477004) BUG=98716 Review URL: http://codereview.chromium.org/8746023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Convert ASCIIToUTF16("") to string16().jhawkins@chromium.org2011-11-281-2/+3
| | | | | | | | | | | | | Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111548 - Broke OmniboxViewTest.AcceptKeywordBySpace on Linuxrsleevi@chromium.org2011-11-241-3/+0
| | | | | | | | | | | | | | | | Strip invalid characters (line breaks, tabs), javascript:schemes from the copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703. TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 TBR=ncj674@motorola.com Review URL: http://codereview.chromium.org/8690006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111558 0039d316-1c4b-4281-b951-d872f2087c98
* Strip invalid characters (line breaks, tabs), javascript:schemes from the ↵ncj674@motorola.com2011-11-241-0/+3
| | | | | | | | | | | | | copied text while pasting text, droping text and creating right click popup for omnibox. BUG=82181, 103703. TEST=Copy a string with line breaks "\n" or tabs "\t". Then right click on omnibox. Chromium should not trigger DCHECKS. Review URL: http://codereview.chromium.org/8513002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111548 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 111378 - HQP Refactoring (in Preparation for SQLite Cache)zmo@google.com2011-11-244-11/+8
| | | | | | | | | | | | | | | | | | | | (See crbug.com/105340 for reverting reason and how to reproduce the issue locally) 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8662035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111482 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting based on discussions on #chromium with shess and rsleevijamiewalch@google.com2011-11-231-3/+1
| | | | | | | | | | | | | | | | | | | | Revert 111386 - Add a field trial for using lower sqlite cache sizes. There are a few relevant histograms that I annotated with the field trial name, and I added a new AddPage histogram. TEST=none BUG=none Review URL: http://codereview.chromium.org/8379009 TBR=brettw@chromium.org Review URL: http://codereview.chromium.org/8677025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111433 0039d316-1c4b-4281-b951-d872f2087c98
* Add a field trial for using lower sqlite cache sizes.brettw@chromium.org2011-11-231-1/+3
| | | | | | | | | | | | | There are a few relevant histograms that I annotated with the field trial name, and I added a new AddPage histogram. TEST=none BUG=none Review URL: http://codereview.chromium.org/8379009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111386 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-234-8/+11
| | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryService, where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8451009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111378 0039d316-1c4b-4281-b951-d872f2087c98
* Adding histograms for better Omnibox prerender performance tracking.dominich@chromium.org2011-11-221-0/+3
| | | | | | Review URL: http://codereview.chromium.org/8602005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111207 0039d316-1c4b-4281-b951-d872f2087c98
* Adding a fourth omnibox prerender experiment.dominich@chromium.org2011-11-213-45/+160
| | | | | | | | | | | | | This adds or updates entries in the database for the entire chain of text the user typed. For example, if the user types 'goog' and navigates to google.com, this will add or update database entries for 'go' -> google.com, 'goo' -> google.com and 'goog' -> google.com. BUG= TEST= Review URL: http://codereview.chromium.org/8600004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111005 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-214-6/+8
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8612007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
* Force navigation to non-numeric hostnames with ports (e.g. "abc:81"). This ↵pkasting@chromium.org2011-11-192-13/+10
| | | | | | | | | | restores the pre-Chrome-15 behavior for these inputs. BUG=103598 TEST=Typing "abcdefg:123" in the address bar should attempt to navigate, not search, by default. Review URL: http://codereview.chromium.org/8510024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110821 0039d316-1c4b-4281-b951-d872f2087c98
* Correctly score intranet URLs with typed_counts of 0 as UNVISITED_INTRANET ↵pkasting@chromium.org2011-11-192-13/+20
| | | | | | | | | | if they are on known hostnames. BUG=103470 TEST=On a clean profile, type an intranet host (e.g. "go/") and hit enter; then paste a different address on that host (e.g. "go/shuttlealerts") and hit enter; then in a new tab, paste that second address again and verify that the default action is to navigate rather than search. Review URL: http://codereview.chromium.org/8497050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110820 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Remove 14 exit time destructors and 2 static initializers.thakis@chromium.org2011-11-162-7/+7
| | | | | | | | | | | | BUG=101600, 94925 TEST=none TBR=mnissler Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=110235 Review URL: http://codereview.chromium.org/8573021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110330 0039d316-1c4b-4281-b951-d872f2087c98
* Deflake AutocompleteBrowserTest.FocusSearch test.dominich@chromium.org2011-11-161-7/+1
| | | | | | | | | | TBR=pkasting BUG=104307,104124 Review URL: http://codereview.chromium.org/8572027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110240 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110235 - chrome: Remove 14 exit time destructors and 2 static ↵kmadhusu@chromium.org2011-11-162-7/+7
| | | | | | | | | | | | | | | initializers. BUG=101600, 94925 TEST=none TBR=mnissler Review URL: http://codereview.chromium.org/8573021 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/8568039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110238 0039d316-1c4b-4281-b951-d872f2087c98
* chrome: Remove 14 exit time destructors and 2 static initializers.thakis@chromium.org2011-11-162-7/+7
| | | | | | | | | | BUG=101600, 94925 TEST=none TBR=mnissler Review URL: http://codereview.chromium.org/8573021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110235 0039d316-1c4b-4281-b951-d872f2087c98
* Cope with a race condition in NetworkActionPredictor and ↵dominich@chromium.org2011-11-152-7/+5
| | | | | | | | | | | NetworkActionPredictorDB initialization. BUG=104124 Review URL: http://codereview.chromium.org/8566018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110119 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutocompleteBrowserTest.FocusSearch flaky on Windows and Linux. (reland)joi@chromium.org2011-11-151-1/+7
| | | | | | | | | | | Use MAYBE_ convention as FocusSearch is a method call in the file as well. TBR=isherman@chromium.org BUG=104307 Review URL: http://codereview.chromium.org/8572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110111 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 110092 - Mark AutocompleteBrowserTest.FocusSearch flaky on Windows ↵joi@chromium.org2011-11-151-4/+0
| | | | | | | | | | | | | | and Linux. TBR=isherman@chromium.org BUG=104307 Review URL: http://codereview.chromium.org/8574006 TBR=joi@chromium.org Review URL: http://codereview.chromium.org/8468006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110093 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutocompleteBrowserTest.FocusSearch flaky on Windows and Linux.joi@chromium.org2011-11-151-0/+4
| | | | | | | | | TBR=isherman@chromium.org BUG=104307 Review URL: http://codereview.chromium.org/8574006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110092 0039d316-1c4b-4281-b951-d872f2087c98
* net: Move UnescapeRule into the net namespace.tfarina@chromium.org2011-11-153-7/+6
| | | | | | | | | | | BUG=64263 TEST=None R=willchan@chromium.org Review URL: http://codereview.chromium.org/8552002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110085 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded forward declarations from various chrome/browser ↵thestig@chromium.org2011-11-155-15/+1
| | | | | | | | | | | subdirectories. BUG=none TEST=none Review URL: http://codereview.chromium.org/8539006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109987 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutocompleteBrowserTest.Basic flaky on Win and Linux.joi@chromium.org2011-11-141-1/+6
| | | | | | | | | TBR=pkasting@chromium.org BUG=104124 Review URL: http://codereview.chromium.org/8566004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109873 0039d316-1c4b-4281-b951-d872f2087c98
* Enable extension APIs for content scripts.aa@chromium.org2011-11-121-1/+1
| | | | | | | | | | | This only enables extension functions. I will do events in a separate change. BUG=81760,80308 Review URL: http://codereview.chromium.org/8540012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109812 0039d316-1c4b-4281-b951-d872f2087c98
* Add database to use as the source of an alternative algorithm for Network ↵dominich@chromium.org2011-11-108-55/+1276
| | | | | | | | | | | | Action Prediction BUG=98110 TEST=unit_tests:NetworkActionPredictor*,interactive_ui_tests:OmniboxViewTest* Review URL: http://codereview.chromium.org/8241014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109509 0039d316-1c4b-4281-b951-d872f2087c98
* Fix AutocompleteMatch DCHECK() triggered by ↵asvitkine@chromium.org2011-11-102-7/+14
| | | | | | | | | | | | | | | | | | | |RenderViewContextMenu::AppendSearchProvider()|. Makes |AppendSearchProvider()| sanitize the text by replacing unwanted whitespace characters with spaces. Do this instead of calling |AutocompleteMatch::SanitizeString()|, since we want to preserve the whitespace between words separated by newlines here, rather than appending such words together. Added |ReplaceChars()| to base/string_util to support replacing any occurence of the given characters with a replacement string. BUG=103338 TEST=Right click on multiline text in a text area in a Debug build. A DCHECK() shouldn't trigger. Review URL: http://codereview.chromium.org/8502027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109430 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor omnibox creation and max edit width determination, moving them from ↵ben@chromium.org2011-11-091-35/+43
| | | | | | | | | | | | #ifdef'ed code in LocationBarView behind OmniboxView. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=109088 Review URL: http://codereview.chromium.org/8457006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109150 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 109088 - Refactor omnibox creation and max edit width determination, ↵thakis@chromium.org2011-11-081-43/+35
| | | | | | | | | | | | | moving them from #ifdef'ed code in LocationBarView behind OmniboxView. BUG=none TEST=none Review URL: http://codereview.chromium.org/8457006 TBR=ben@chromium.org Review URL: http://codereview.chromium.org/8498023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109095 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor omnibox creation and max edit width determination, moving them from ↵ben@chromium.org2011-11-081-35/+43
| | | | | | | | | | #ifdef'ed code in LocationBarView behind OmniboxView. BUG=none TEST=none Review URL: http://codereview.chromium.org/8457006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109088 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 108478 - HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-033-10/+3
| | | | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8437042 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8430038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108486 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-033-3/+10
| | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Previously reviewed as: http://codereview.chromium.org/8384024/ Review URL: http://codereview.chromium.org/8437042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108478 0039d316-1c4b-4281-b951-d872f2087c98
* Prerendered tabs use the same SessionStorage namespace as the tab that ↵cbentzel@chromium.org2011-11-021-2/+6
| | | | | | | | | | | | | triggered the prerender. If the prerendered page is swapped in to a tab which has a different namespace, it will be canceled. BUG=80679 Review URL: http://codereview.chromium.org/8392041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108342 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor loading out of ExtensionService.yoz@chromium.org2011-11-021-4/+5
| | | | | | | | | | | | | | | | - Make ExtensionServiceBackend go away, as it's only used for installing unpacked extensions. Tear this out into UnpackedInstaller task. - Pull out LoadAllExtensions / LoadInstalledExtension into InstalledExtensionLoader task. - Break out component extensions to be handled by ComponentLoader. Coming soon: a unit test for InstalledExtensionLoader. BUG=97883 TEST=existing tests + InstalledExtensionLoaderUnittest Review URL: http://codereview.chromium.org/8417012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108319 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-026-0/+12
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 108207 - HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-023-10/+3
| | | | | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Review URL: http://codereview.chromium.org/8384024 TBR=mrossetti@chromium.org Review URL: http://codereview.chromium.org/8437035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108224 0039d316-1c4b-4281-b951-d872f2087c98
* HQP Refactoring (in Preparation for SQLite Cache)mrossetti@chromium.org2011-11-023-3/+10
| | | | | | | | | | | | | | 1. Move ownership of the InMemoryURLIndex from the InMemoryHistoryBackend to the HistoryBackend where it truly belongs. 2. Handle (by notification) URL visits, updates and deletes. Refactor use of NOTIFICATION_HISTORY_URLS_DELETED to provide the deleted URLRow so that row ID is available. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Other small cleanups. BUG=96731, 92718 TEST=Unit tests updated. TBR=atwilson (for profile_sync_service_typed_url_unittest.cc) Review URL: http://codereview.chromium.org/8384024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108207 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ShortcutsProvider for omnibox on the trunk by defaultgeorgey@chromium.org2011-11-022-2/+5
| | | | | | | | TEST=should be enabled by default and disablable in about:flags BUG=none Review URL: http://codereview.chromium.org/8387060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108200 0039d316-1c4b-4281-b951-d872f2087c98
* Make the omnibox treat all paths that end in \ or / as URLs, not just paths ↵pkasting@chromium.org2011-11-012-2/+8
| | | | | | | | | | that consist solely of a slash. BUG=102435 TEST=Typing "abcdef/ghi j" should show a search (magnifying glass) as the default action, but adding a '\' or '/' should change it to a navigation (globe). Review URL: http://codereview.chromium.org/8427019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108147 0039d316-1c4b-4281-b951-d872f2087c98
* Improve omnibox accessibility on Windows.dmazzoni@chromium.org2011-10-313-378/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | This refactors and improves a bunch of views accessibility code on Windows and has the result of enabling NVDA to announce the text selection in the omnibox. The AutocompleteAccessibility class is removed; its functionality is rolled into NativeViewAccessibilityWin. NativeViewAccessibilityWin adds IAccessible2 and IAccessibleText interfaces, allowing it to directly expose the caret and selection to compatible assistive technology. In addition, this gives each accessible object an unique id. Finally, the reference from a View to its NativeViewAccessibilityWin is changed from a scoped_refptr to a ScopedComPtr, because another process may still have a reference to the accessible COM object when the View is deleted. BUG=53380 TEST=Manually test the omnibox with NVDA on Windows. It should announce text that's selected, including autocompletions. Review URL: http://codereview.chromium.org/8391010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107924 0039d316-1c4b-4281-b951-d872f2087c98
* Create Private Data for InMemoryURLIndex (in Preparation for SQLite Cache) mrossetti@chromium.org2011-10-303-25/+18
| | | | | | | | | | | | | | | 1. Encapsulate the private, persistent data for the InMemoryURLIndex in a new class, URLIndexPrivateData (found in in_memory_url_index_types.h). 2. Move most of the support types, including the new URLIndexPrivateData class, into in_memory_url_index_types.h. 3. Correctly handle the adding and removing of page title words when a URL change is detected. 4. Replace static class member functions with non-friend, non-class functions for better flexibility. 5. Move convenience types out from InMemoryURLIndex class up into history namespace. 6. Rename convenience types to generalize their intent. BUG=92718 TEST=Enhanced unit tests. Review URL: http://codereview.chromium.org/8359019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107893 0039d316-1c4b-4281-b951-d872f2087c98
* Strip special characters in extension omnibox suggestions.asvitkine@chromium.org2011-10-286-21/+96
| | | | | | | | | | | | | | | | This makes the drop downs on Mac and Linux match how Windows currently renders these suggestions when they include newline, tab and carriage return characters. Removes invalid characters in matches coming from extension suggestions and apps. BUG=100564 TEST=Manual per bug and added ExtensionAppProviderTest.CreateMatchSanitize KeywordProviderTest.SuggestionMatchSanitize tests. Review URL: http://codereview.chromium.org/8364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107746 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-286-17/+17
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-31 08:51:58 +0000