summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Omnibox: Refactor SearchProvider Utility for Creating Suggestionsmpearson@chromium.org2014-01-033-58/+49
| | | | | | | | | | | | | | | Cleanup SearchProvider interfaces to reduce the number of parameters to CreateSearchSuggestion(), which was bloated while adding support for entity suggestions in https://codereview.chromium.org/26688004 This is another necessary step for reviving https://codereview.chromium.org/23164011/ BUG=259486 Review URL: https://codereview.chromium.org/121493006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242919 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Launch Stop Timer Behaviormpearson@chromium.org2014-01-032-15/+8
| | | | | | | | | | | | | | | | | | Previously, we ran an experiment that caused all autocomplete providers to stop delivering results after 1.5 seconds. This was caused by the assumption that results coming in after that length of time are disruptive, likely causing more harm than benefit. We decided to launch this experiment. This change turns on that behavior for everyone. This change also converts the old "use stop timer" field trial code to a parameterized form, so we can run future experiments with shorter timeouts. BUG= Review URL: https://codereview.chromium.org/117233009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242915 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using base::string16;' from base/strings/string16.h and remove temporarydbeam@chromium.org2013-12-301-2/+2
| | | | | | | | | | | | PRESUBMIT.py _CheckForString16(). R=brettw@chromium.org, maruel@chromium.org TBR=sky@chromium.org, tsepez@chromium.org BUG=329295 Review URL: https://codereview.chromium.org/93903011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242733 0039d316-1c4b-4281-b951-d872f2087c98
* Move kFileScheme constant into content namespace.tfarina@chromium.org2013-12-301-1/+1
| | | | | | | | | | BUG=None TEST=None, no functional changes TBR=jam@chromium.org Review URL: https://codereview.chromium.org/120593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242712 0039d316-1c4b-4281-b951-d872f2087c98
* HUP Experimental Scoring framework.bartn@chromium.org2013-12-263-62/+262
| | | | | | | | | | | | | | | | | | | | High level summary: (a) Introduce a new set of Finch variation params and use it in the Omnibox bundled experiment (b) Group together HUP scoring params in a HUPScoringParams struct and initialize it based on the new experiment params (c) Modify HUP scoring by applying optional demotion This change is fairly safe because of the following reasons: (1) It is disabled by default (2) It never changes the relative order of HUP matches (3) It can only demote a HUP match (4) It is fairly isolated and unobtrusive BUG=295756 TESTS=OmniboxFieldTrialTest,HistoryURLProviderTest Review URL: https://codereview.chromium.org/23707058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242569 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of char16 to use the base:: namespace.avi@chromium.org2013-12-258-9/+9
| | | | | | | | | | BUG=329295 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/113403006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242503 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of UTF conversions in chrome/browser to use the base:: ↵avi@chromium.org2013-12-2427-176/+221
| | | | | | | | | | | | namespace. BUG=330556 TEST=no change TBR=ben@chromium.org Review URL: https://codereview.chromium.org/109013006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242447 0039d316-1c4b-4281-b951-d872f2087c98
* Update some uses of Value in chrome/browser to use the base:: namespace.avi@chromium.org2013-12-232-23/+26
| | | | | | | | | | | BUG=88666 TEST=no change R=brettw@chromium.org TBR=ben@chromium.org Review URL: https://codereview.chromium.org/106433007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242387 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Move kFileSystemScheme constant into content namespace.tfarina@chromium.org2013-12-231-2/+2
| | | | | | | | | | BUG=None TEST=None TBR=jam@chromium.org Review URL: https://codereview.chromium.org/104043010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242336 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Bug Fixes for Shortcuts Inliningmpearson@chromium.org2013-12-207-130/+209
| | | | | | | | | | | | | | | | | | | Precisely, fixes up URL-like inputs before comparing to the shortcuts fill_into_edit in order to better determine inlineability. This is especially useful for inputs such as about: which need to have their scheme fixed up to be recognized as comparable to chrome:// shortcuts. BUG=328220 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=242029 R=pkasting@chromium.org Review URL: https://codereview.chromium.org/108643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242119 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 242029 "Omnibox: Bug Fixes for Shortcuts Inlining"mpearson@chromium.org2013-12-205-137/+54
| | | | | | | | | | | | | | | | | | | | | | | Accidentally didn't check in the latest patch of this changeset. > Omnibox: Bug Fixes for Shortcuts Inlining > > Precisely, fixes up URL-like inputs before comparing to the shortcuts > fill_into_edit in order to better determine inlineability. > > This is especially useful for inputs such as about: which need to have > their scheme fixed up to be recognized as comparable to chrome:// > shortcuts. > > BUG=328220 > > Review URL: https://codereview.chromium.org/108643003 TBR=mpearson@chromium.org Review URL: https://codereview.chromium.org/106573003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242106 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Bug Fixes for Shortcuts Inliningmpearson@chromium.org2013-12-205-54/+137
| | | | | | | | | | | | | | | Precisely, fixes up URL-like inputs before comparing to the shortcuts fill_into_edit in order to better determine inlineability. This is especially useful for inputs such as about: which need to have their scheme fixed up to be recognized as comparable to chrome:// shortcuts. BUG=328220 Review URL: https://codereview.chromium.org/108643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@242029 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox Style Cleanupmpearson@chromium.org2013-12-191-1/+1
| | | | | | | | | | | | | Following on post-submission suggestions from https://codereview.chromium.org/113773003/ TBR=sky BUG= Review URL: https://codereview.chromium.org/106263003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241912 0039d316-1c4b-4281-b951-d872f2087c98
* Updated AutocompleteResultTests.kmadhusu@chromium.org2013-12-193-123/+94
| | | | | | | | | | | Follow up CL for crrev.com/69703002 BUG=269186 TEST=none Review URL: https://codereview.chromium.org/101043011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241782 0039d316-1c4b-4281-b951-d872f2087c98
* Move c/c/e/extension_set to top-level extensions/rdevlin.cronin@chromium.org2013-12-171-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | Move extension_set.h/cc and extension_set_unittest to extensions/common/. Remove unused includes. Add includes where transitive includes were used. Update DEPS. No functional changes. BUG=162530 TBR=sky@chromium.org (c/b/autocomplete, c/b/ui, c/test) TBR=jam@chromium.org (c/b/automation) TBR=atwilson@chromium.org (c/b/background, c/b/sync, c/b/policy) TBR=bauerb@chromium.org (c/b/browsing_data, c/b/content_settings, c/b/managed_mode) TBR=satorux@chromium.org (c/b/chromeos) TBR=yurys@chromium.org (c/b/devtools) TBR=thestig@chromium.org (c/b/media_galleries) TBR=stevenjb@chromium.org (c/b/notifications) TBR=battre@chromium.org (c/b/profile_resetter) TBR=dmazzoni@chromium.org (c/b/speech) TBR=kinuko@chromium.org (c/b/sync_file_system) TBR=pkotwicz@chromium.org (c/b/themes) Review URL: https://codereview.chromium.org/102103005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241131 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Make HQP Show Scheme At Right Timesmpearson@chromium.org2013-12-161-1/+1
| | | | | | | | | | | | | | In particular, the HistoryQuick provider should show the scheme of a URL match it's suggesting if there is a match in the scheme. The previous code was entirely wrong and only worked for prefix matches. TBR=sky,pkasting BUG=324746 Review URL: https://codereview.chromium.org/113773003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@241052 0039d316-1c4b-4281-b951-d872f2087c98
* Improve psuggest delete.mariakhomenko@chromium.org2013-12-161-1/+10
| | | | | | | | | | | Deletes a corresponding history entry when a psuggest entry is being deleted. Only deletes entries generated by the given provider. BUG=312494 Review URL: https://codereview.chromium.org/108513009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240903 0039d316-1c4b-4281-b951-d872f2087c98
* Modified GetMatchToPrefetch() to return a valid match for prefetching even ↵kmadhusu@chromium.org2013-12-133-43/+168
| | | | | | | | | | | | | | | when hide_verbatim flag is turned off. Details (repeating our email conversation) : This change is for re-implementation of Chrome Instant (Design doc: https://goto.google.com/fdgbe), in which the Suggest server tells Chrome which search suggestion to prefetch and then Chrome uses the hint details to prefetch the query results. We only prerender the top match marked for prefetching. But this doesn't work because of how Chrome deals with verbatim matches. So, we initially proposed that we require the search to be the top match, except for the cases where hide verbatim applied and the verbatim match is hidden. This works well but unfortunately, it seems like hide verbatim won't work without further UI changes in the omnibox. Until we figure out a way to hide the top verbatim match, we want to continue doing the same even with the hide verbatim turned off. In this CL, I made changes to obey the prefetch hint if the search is the top match, unless it is only being outranked by a verbatim suggestion match. BUG=269186 TEST=none Review URL: https://codereview.chromium.org/69703002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240747 0039d316-1c4b-4281-b951-d872f2087c98
* Replace string16 with base::string16 in chrome/browserbrettw@chromium.org2013-12-134-6/+7
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/114193006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240689 0039d316-1c4b-4281-b951-d872f2087c98
* Replace string16 with base::string16 in chrome/browserbrettw@chromium.org2013-12-123-10/+10
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/108123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240485 0039d316-1c4b-4281-b951-d872f2087c98
* Replace string16 with base::string16 in chrome/browserbrettw@chromium.org2013-12-121-3/+4
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/112993002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240447 0039d316-1c4b-4281-b951-d872f2087c98
* Modify Entity Suggestion support and Add Profile Suggest supportskanuj@chromium.org2013-12-116-206/+105
| | | | | | | | | | | | | - Added new AutocompleteMatchType for the two, and additionally for personalized and infinite suggestion. - Added logging for the new suggestion types. - Annotation for entities is now used as description in the match. This allows multiline rendering in mobile easily. - Profile suggestions also look like entity suggestion, and use title, annotation and query fields in response. BUG= Review URL: https://codereview.chromium.org/58003005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@240174 0039d316-1c4b-4281-b951-d872f2087c98
* Use base namespace for string16 in chrome/browserbrettw@chromium.org2013-12-102-19/+21
| | | | | | | | TBR=sky Review URL: https://codereview.chromium.org/109263006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239856 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Refactor SearchProvider for Entity Suggestionsmpearson@chromium.org2013-12-102-88/+35
| | | | | | | | | | | | | Cleanup SearchProvider interfaces to better support entity suggestions, which were introduced in https://codereview.chromium.org/26688004 This is a necessary step for reviving https://codereview.chromium.org/23164011/ BUG=259486 Review URL: https://codereview.chromium.org/98713006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239793 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Allow Shortcuts to Inlinempearson@chromium.org2013-12-075-75/+225
| | | | | | | | BUG=324809 Review URL: https://codereview.chromium.org/103283002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239360 0039d316-1c4b-4281-b951-d872f2087c98
* Add base namespace to some instances of string16.brettw@chromium.org2013-12-068-205/+230
| | | | | | | | | | Adds the base:: qualifier to more instances of string16 in chrome/browser. BUG= Review URL: https://codereview.chromium.org/104043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239257 0039d316-1c4b-4281-b951-d872f2087c98
* Assume search provider only sends deletion path.mariakhomenko@chromium.org2013-12-061-3/+6
| | | | | | | | | | Append the base google url we use for completions to the delete path. BUG= Review URL: https://codereview.chromium.org/104593011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@239177 0039d316-1c4b-4281-b951-d872f2087c98
* Replace string16 with base::string16.brettw@chromium.org2013-12-0441-366/+397
| | | | | | | | | | This updates portions of chrome/browser/... to use the base namespace. BUG= Review URL: https://codereview.chromium.org/105193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238766 0039d316-1c4b-4281-b951-d872f2087c98
* Added the Profile Settings Reset sub-page of settings to url_constants.cc ↵engedy@chromium.org2013-12-041-0/+1
| | | | | | | | | | | | and builtin_provider.cc; and cleaned up accessing it from ProfileResetGlobalError. This makes the feature reachable through the Omnibox; and allows for nicer disposition: the sub-page will open in-place when the NTP is the current tab, or in the existing settings page if one is already open. BUG=298036 Review URL: https://codereview.chromium.org/101833002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238572 0039d316-1c4b-4281-b951-d872f2087c98
* Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to ↵brettw@chromium.org2013-12-032-2/+3
| | | | | | | | | | | base namespace. BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/102843002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238465 0039d316-1c4b-4281-b951-d872f2087c98
* Store xsrf token received with psuggest results.mariakhomenko@chromium.org2013-12-034-84/+395
| | | | | | | | | | | Stores xsrf token in AutocompleteMatch search_terms_args for later use in case the user triggers deletion of a suggestion. BUG=312477 Review URL: https://codereview.chromium.org/54203008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238422 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure zero suggest can handle XSSI-escaped output.mariakhomenko@chromium.org2013-12-034-22/+54
| | | | | | | | | | | | Zero suggest request re-uses the same URL as regular suggest and therefore will be requesting xssi=t by default. We should make sure the output is then correctly parsed. BUG= Review URL: https://codereview.chromium.org/96753004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238360 0039d316-1c4b-4281-b951-d872f2087c98
* Move EmptyString, kWhitespace and the BOM to base.brettw@chromium.org2013-12-022-6/+7
| | | | | | | | | | | | | | | This moves EmptyString*, kWhitespace*, and the UTF 8 Byte Order Marker to the base:: namespace. Many of them just got changed to a default-constructed string when a reference was not required. I qualified some string16s with base:: when I was changing adjacent code. I need to do another pass to finish these up. BUG= TBR=sky@chromium.org Review URL: https://codereview.chromium.org/89243003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238032 0039d316-1c4b-4281-b951-d872f2087c98
* Move kFtpScheme into content namespace.tfarina@chromium.org2013-12-011-1/+1
| | | | | | | | | | BUG=None TEST=None, no functional changes. TBR=jam@chromium.org Review URL: https://codereview.chromium.org/97683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238004 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Make HistoryURL Highlight Titles like HistoryQuick Providermpearson@chromium.org2013-11-276-48/+71
| | | | | | | | | | | | | | | | | | Previously HistoryURL provider would highlight page titles by searching for the first occurrence of the input term and highlighting it. This was case sensitive. Now HistoryURL provider highlights page titles in the same way as HistoryQuick provider: it normalizes the title (i.e., lowercases it) and highlights all occurrences that appear at word breaks. TBR=sky BUG=318329 Review URL: https://codereview.chromium.org/77453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@237504 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Don't Let Users Escape Keyword Mode Accidentallympearson@chromium.org2013-11-223-197/+267
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The current code already protects against users escaping keyword mode accidentally in regular (non-reorder mode). This change simply adds the proper annotations so reorder mode has the protection as well. There are three parts to this change: * Mark navsuggestions as "not allowed to be default match" if the user is in keyword mode. Revise tests to reflect this. * Add a constraint that, in keyword mode, there must be at least one keyword (query) suggestion that be the default match. Restore the keyword verbatim if the constraint is violated. Revise tests to reflect this. * As a post-processing step, if there is at least one keyword mode match that can be default [1], mark all matches from other sources (e.g., the default search engine) as not allowed to be the default match. Revise tests to reflect this. [1] Given the second bullet (the constraint), you might wonder why it could be the case that there might not be a keyword mode match that can be default. The reason for this criteria is that the user could be in keyword mode for a keyword extension or some such thing, but we can't trust KeywordProvider to always make a default match in those cases. For instance, the extension could be disabled. Hence, we maintain the invariant that SearchProvider always returns a match that can be default, even if needs to back off to the default provider match to do so. By the way, the regular mode protection works as follows: (i) demote all navsuggestions past the score of the top query when in keyword mode (ii) abandon suggested relevance scores on the default provider, meaning the top result from the default provider will score 250 when in keyword mode (iii) enforce a constraint that a match (thus implicitly a keyword mode match) must score at least 850 Together, these constraints (and the way it fixes the violations) guarantee that a query from the keyword provider comes first in regular (non-reorder mode). BUG=317946,318543 Review URL: https://codereview.chromium.org/67693004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236777 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Make ScoredHistoryMatch a Classmpearson@chromium.org2013-11-212-10/+12
| | | | | | | | | | | | | Makes it easier to understand what's going on because now most member variables will have underscores. TBR=sky BUG= Review URL: https://codereview.chromium.org/73423005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236584 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetLocationEntry to GetOmniboxView.msw@chromium.org2013-11-201-48/+46
| | | | | | | | | | | | | LocationEntry is an outdated name for the Omnibox. Other related renames and minor refactoring. BUG=319037 TEST=none, no changes. R=pkasting@chromium.org,sky@chromium.org Review URL: https://codereview.chromium.org/63503005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236275 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: remove old flags, add new flag for query extraction.samarth@chromium.org2013-11-201-3/+0
| | | | | | | | | | | | | | | | | | This change does three things: (1) Remove flags for Instant Extended. Instant Extended is now always on. (2) Add a separate flag to control query extraction. Also rename suppress_on_srp to query_extraction to make its purpose clearer. (3) Assorted cleanup resulting from (1) and (2). Note that a lot more code (especially in search.cc) can be cleaned up and I will address that in follow up changes. Attempting to keep this from snowballing into a huge CL. BUG=297915 Review URL: https://codereview.chromium.org/73613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@236116 0039d316-1c4b-4281-b951-d872f2087c98
* Move Extension and PermissionsData to extensions/common.yoz@chromium.org2013-11-152-2/+2
| | | | | | | | | | BUG=298586 R=cdn@chromium.org, miket@chromium.org, sky@chromium.org TBR=cdn@chromium.org Review URL: https://codereview.chromium.org/15239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235462 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Disable Default Provider Suggested Relevance Scores In Keyword Modempearson@chromium.org2013-11-142-4/+88
| | | | | | | | | | | | | | | | | | | | | | | | As said here: https://code.google.com/p/chromium/issues/detail?id=252469#c6 >>> I cannot think of a convincing reason at this time to keep suggested relevance scores for the default provider when the user has triggered a keyword provider. I think we should revert the default provider to classic relevance scoring when in keyword mode. The idea with keyword modes is that the keyword suggestions should generally trump the default suggestions--after all, the user triggered keyword mode--and the default suggestions are only there as a backup in case the keyword was invoked accidentally or its suggestions are bad. Keeping suggested relevance scores, whether for verbatim or suggestions, from the default provider tend to make the default provider results score annoyingly high compared to the keyword results. >>> BUG=252469,226418 Review URL: https://codereview.chromium.org/68203019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235186 0039d316-1c4b-4281-b951-d872f2087c98
* InstantExtended: update tests for Instant Extended (part 6).samarth@chromium.org2013-11-141-159/+238
| | | | | | | | | | | | | Update search provider and toolbar unit tests for Instant Extended. Note that this is split off from http://crrev.com/24733003 so that it's not a single mega-CL. BUG=297915 R=pkasting@chromium.org Review URL: https://codereview.chromium.org/61893028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@235142 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Loosen SearchProvider Constraints for Reorder Modempearson@chromium.org2013-11-133-30/+667
| | | | | | | | | | | Reorder mode doesn't have as strict constraints as the current regular mode. BUG=309147 Review URL: https://codereview.chromium.org/58953007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234857 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: In Reorder Mode, SearchProvider Doesn't Need to Remove Stale Resultsmpearson@chromium.org2013-11-121-8/+19
| | | | | | | | | BUG=309465 R=msw@chromium.org, pkasting@chromium.org Review URL: https://codereview.chromium.org/66503003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234661 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for forced URLs to TopSites.beaudoin@chromium.org2013-11-121-1/+1
| | | | | | | | | | | | | | | This CL makes it possible to add MostVisitedURLs to TopSites that have a non-null |last_forced_time| indicating that these URLs are "forced" and should stay in top-sites even as other non-forced URLs come in. These forced URLs are evicted on a Least Recently Used basis based on |last_forced_time|. Internally, the list of Forced URLs is kept at the beginning of the TopSitesCache list of MostVisitedURLs. These forced URLs are not returned by GetMostVisitedURLs. Forced URLs make it possible for Chrome to capture thumbnails of sites that may have been suggested through other processes than the TopSitesBackend. They are not used yet but a soon-to-follow CL will link them to thumbnails requested via the chrome-search://thumb2/... TBR'ing owners for minor API change. BUG= TBR=bulach@chromium.org,sky@chromium.org,darin@chromium.org,benwells@chromium.org,estade@chromium.org, Review URL: https://codereview.chromium.org/53283004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234394 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Non-Substituting Keywords Should Not Have a Spacempearson@chromium.org2013-11-092-1/+9
| | | | | | | | | | (after the keyword) BUG=316907 Review URL: https://codereview.chromium.org/66993004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@234097 0039d316-1c4b-4281-b951-d872f2087c98
* Shorten INSTANT_NEW_TAB_PAGE_WITH_FAKEBOX_AS_STARTING_FOCUS, ↵hfung@chromium.org2013-11-084-17/+13
| | | | | | | | | | | | INSTANT_NEW_TAB_PAGE_WITH_OMNIBOX_AS_STARTING_FOCUS, NEW_TAB_PAGE, and OBSOLETE_INSTANT_NEW_TAB_PAGE enums. This is based the suggestion at https://codereview.chromium.org/23621037/diff/972001/chrome/browser/autocomplete/search_provider.cc#newcode941 BUG= Review URL: https://codereview.chromium.org/65373002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233988 0039d316-1c4b-4281-b951-d872f2087c98
* Omnibox: Fix Inline Autocompletion of Navsuggest in Forced Query Modempearson@chromium.org2013-11-072-8/+9
| | | | | | | | | | | | | | | | | | | | | | | This moves the block of code that adds the "?" from one place to another. Its original location was wrong because it incremented |inline_autocomplete_offset| before passing it to FormatUrl(). This could change how FormatUrl() would correct inline_autocomplete_offset when its value is near the end of the formatted string. This is wrong. In both locations, in effect we are adding the "?" prefix after FormatUrl() runs. This means we should correct the inline_autocomplete_offset value to compensate for the extra character "?" only after FormatUrl() runs. This fixes the bug. I also added a test that would've caught this issue. BUG=313451 Review URL: https://codereview.chromium.org/62153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233544 0039d316-1c4b-4281-b951-d872f2087c98
* Send URLs on non-zero prefix suggest requests also.hfung@chromium.org2013-11-075-106/+274
| | | | | | | | BUG= Review URL: https://codereview.chromium.org/23621037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233494 0039d316-1c4b-4281-b951-d872f2087c98
* Moved extension and value builder code to extensions component.benwells@chromium.org2013-11-051-2/+2
| | | | | | | | | | | | This is only used by tests but it has no chrome dependencies, and test in extensions use it, so it should move down to. TBR=sky@chromium.org BUG=162530 Review URL: https://codereview.chromium.org/48643003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233119 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-11 23:16:40 +0000