summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* Disable autocomplete for search keywords.isherman@chromium.org2010-08-172-5/+8
| | | | | | | | | | | We have custom UI for search keywords anyway, so in practice a user would never see the autocompleted url. But, we had been computing the index incorrectly in some cases, as we trim off "http://" and "www." to compute the keyword. Since we don't use it anyway, simplify the logic and get rid of it :) BUG=none TEST=none Review URL: http://codereview.chromium.org/3151020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56445 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show accidental search infobar for bookmark keywords.isherman@chromium.org2010-08-171-1/+2
| | | | | | | | | BUG=6854 TEST=none Review URL: http://codereview.chromium.org/3119007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56413 0039d316-1c4b-4281-b951-d872f2087c98
* Include ICU headers in a way that will also work with use_system_icu=1phajdan.jr@chromium.org2010-08-171-1/+2
| | | | | | | | | TEST=none BUG=28294 Review URL: http://codereview.chromium.org/3145014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56396 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring DictionaryValue ↵viettrungluu@chromium.org2010-08-172-2/+4
| | | | | | | | | | | Get{Boolean,Integer,Real,Binary,Dictionary,List}(). BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3187004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56302 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring Get(As)String() methods from Value, etc.viettrungluu@chromium.org2010-08-161-10/+14
| | | | | | | | | BUG=23581 TEST=builds and passes tests Review URL: http://codereview.chromium.org/3117017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56187 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Remove "obviously" unneeded standard C++ library #includes.viettrungluu@chromium.org2010-08-151-1/+0
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3179017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56171 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Forward declare everything possible in testing_profile.herg@google.com2010-08-132-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3129007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56053 0039d316-1c4b-4281-b951-d872f2087c98
* Rework gfx::Font by moving platform-specific code into inner classes.ben@chromium.org2010-08-135-20/+20
| | | | | | | | | | | | | gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage. gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk). BUG=none TEST=existing unittests Review URL: http://codereview.chromium.org/3083022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98
* Clone of issue 2941001. See initial review below.twiz@google.com2010-08-121-1/+3
| | | | | | | | | | | | | | http://codereview.chromium.org/2941001 Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly. BUG=None TEST=None Review URL: http://codereview.chromium.org/2819086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
* Fix gcc warningpkasting@chromium.org2010-08-091-1/+1
| | | | | | | | BUG=51146 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55500 0039d316-1c4b-4281-b951-d872f2087c98
* Prevent password leakage to the suggest server by being more strict about ↵pkasting@chromium.org2010-08-092-27/+63
| | | | | | | | | | not doing suggest when the user might have typed a username. Since we might parse this as something else (e.g. a scheme, or a hostname that's going to have a port number), the added checks are mainly for things that don't appear to be "usernames" (which were already not sent). BUG=51146 TEST=Unittest Review URL: http://codereview.chromium.org/3044054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55496 0039d316-1c4b-4281-b951-d872f2087c98
* Blind fix for a crash due to r54649. Committing results can mean the ↵pkasting@chromium.org2010-08-092-6/+10
| | | | | | | | | | provided is no longer valid. In that case the best we can do is to clamp to the valid range. BUG=51634 TEST=none (hard to reproduce this) Review URL: http://codereview.chromium.org/3139001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55495 0039d316-1c4b-4281-b951-d872f2087c98
* Adds some experimental stuff for tab preview: ability to determine maxsky@chromium.org2010-08-099-2/+32
| | | | | | | | | | | screen position of popup and current url in omnibox. BUG=none TEST=none Review URL: http://codereview.chromium.org/3076040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55399 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h.viettrungluu@chromium.org2010-08-054-5/+0
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3027041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55136 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug 12305 -- 1.66:1 should be UNKNOWN, not URL.erg@google.com2010-08-042-32/+51
| | | | | | | | | | | | Rearranges the autocomplete heuristics to reject malformed IP addresses before accepting them based on having a port or a username or a password. BUG=12305 TEST=AutocompleteTest.InputType Review URL: http://codereview.chromium.org/2868085 Patch from Ilya Sherman <isherman@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54977 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a deprecated wstring ToLower function.tony@chromium.org2010-08-041-1/+1
| | | | | | | | BUG=23581 Review URL: http://codereview.chromium.org/3044043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54946 0039d316-1c4b-4281-b951-d872f2087c98
* Add Framework for History Quick Providermrossetti@chromium.org2010-08-046-194/+218
| | | | | | | | | | | Incorporate 'quick' history provider index as an autocomplete provider in preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results. BUG=None TEST=None Review URL: http://codereview.chromium.org/3005050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54908 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Some clang appeasing.thakis@chromium.org2010-08-041-2/+2
| | | | | | | | BUG=TEST=none Review URL: http://codereview.chromium.org/3089004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54870 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] More m6 toolbar fixes.estade@chromium.org2010-08-041-3/+3
| | | | | | | | | | | | | | - make wrench menu a custom button rather than gtk_chrome_button (changes appearance slightly) - correct sizing/spacing of wrench menu - new overflow chevron graphic (also a CustomDrawButton converted from a gtk_chrome_button) - fix things I broke when I was hastily fixing the build earlier BUG=50682 TEST=visual Review URL: http://codereview.chromium.org/3053038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54850 0039d316-1c4b-4281-b951-d872f2087c98
* Move owned_widget_gtk.* out of common/, into browser/gtk/.estade@chromium.org2010-08-031-1/+1
| | | | | | | | | | | common/ is for files shared between the renderer and browser processes, and OwnedWidgetGtk is not used outside of browser/. BUG=none TEST=compile Review URL: http://codereview.chromium.org/3063023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54817 0039d316-1c4b-4281-b951-d872f2087c98
* Forward-declare AutocompleteMatch as a struct in autocomplete_popup_view_gtk.hhans@chromium.org2010-08-031-1/+1
| | | | | | | | | | | | AutocompleteMatch is a struct, and should thus be forward-declared as such. Otherwise, Clang warns about the mismatch, and we treat the warning as an error. BUG=49304 TEST=None Review URL: http://codereview.chromium.org/2805086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54777 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] M6 Omnibox positioning changes.shess@chromium.org2010-08-031-9/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | 3px from top and bottom of images to cell edges in popup. With this change baselines worked out without tweaking. Omnibox popup text wasn't quite aligned with field because previous change used leading 'w' (regression). This change measured using leading 'P'. Adjust keyword-hint decoration spacing around the image. Also adjust baseline to match font (regression). Modify ImageDecoration to center the image horizontally, which allows the decoration width to be independent of the image width. PageActionDecoration uses this to pin the effective size at |kPageActionIconMaxSize|. Position page-action and bookmark popups so top border is at same gap from Omnibox (2px) as Omnibox popup. The mocks actually show the bookmark point as an additional px from the star "crotch", but I think this is reasonable for M6. BUG=50575, 50765 TEST=none. Everything still works? Review URL: http://codereview.chromium.org/3015046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54767 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-031-0/+1
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two bugs caused by scheme stripping:pkasting@chromium.org2010-08-031-2/+4
| | | | | | | | | | | * We no longer detected that the user was dragging the permanent_text_, and thus that we could give the drag a title and favicon. * We no longer scored hitting enter on the URL as a RELOAD. BUG=47555 TEST=Visit www.google.com. Drag the omnibox text to the desktop. The shortcut should have a title and favicon. Review URL: http://codereview.chromium.org/3030039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54694 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] compile fix, try2estade@chromium.org2010-08-031-4/+4
| | | | | | | | | TBR=pkasting, ncarter TEST=compile Review URL: http://codereview.chromium.org/3060037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54659 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] Remove reference to obsolete constant.estade@chromium.org2010-08-031-13/+2
| | | | | | | | | TBR=ncarter TEST=compile; also autocomplete popup text aligns with omnibox text Review URL: http://codereview.chromium.org/3053036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54656 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a number of problems caused by the AutocompleteController purposefully ↵pkasting@chromium.org2010-08-034-19/+42
| | | | | | | | | | committing out-of-date results after the edit had changed. Simply not doing this commit would make the popup appear less responsive, so instead we're more careful to not try and update the edit with the out-of-date data, and instead force the popup to get newer results in cases where it might have been out-of-date. BUG=46315 TEST=Type a letter that inline autocompletes, then immediately hit ctrl-a. You should get everything selected, not nothing. Also, typing a letter that inline autocompletes, then immediately a random other letter and the down arrow key, should show a popup with results for the two letters you typed, not just the first. Review URL: http://codereview.chromium.org/3047041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54649 0039d316-1c4b-4281-b951-d872f2087c98
* [GTK] fix up spacing in upper chrome.estade@chromium.org2010-08-031-24/+6
| | | | | | | | | | | | | These changes mirror pkasting's work on windows for milestone6. TODO (in a follow up patch): convert the wrench menu into a CustomDrawButton (you will notice that currently it is too wide and has the wrong sort of background hover appearance). BUG=50682 TEST=look of upper chrome Review URL: http://codereview.chromium.org/3007018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54648 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-312-2/+4
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Un-tweak omnibox height and spacing and font.shess@chromium.org2010-07-302-2/+2
| | | | | | | | | | | | | | | | | Partial revert of http://codereview.chromium.org/3046029 . Toolbar.xib change to make Omnibox 27px tall again. Omnibox font back to system size, shift baselines to match, inset location icon additional pixel to look good WRT text spacing, adjust ev and keyword bubbles to match, adjust popup to match. BUG=50765, 50575 TEST=See 50765 Review URL: http://codereview.chromium.org/2806098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54410 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Incorporate 'quick' history provider index as an autocomplete ..."phajdan.jr@chromium.org2010-07-306-223/+197
| | | | | | | | | | Broke AutocompleteEditViewTest.DesiredTLD and AutocompleteEditView.EscapeToDefaultMatch on Linux. TBR=mrossetti Review URL: http://codereview.chromium.org/3052031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54380 0039d316-1c4b-4281-b951-d872f2087c98
* Incorporate 'quick' history provider index as an autocomplete provider in ↵mrossetti@chromium.org2010-07-306-197/+223
| | | | | | | | | | | preparation for the replacement of the current history_url_provider. This step refactors the history provider code a bit, introduces the replacement class (history-quick_provider), and adds a unittest template. Note that the 'quick' provider will only support the fast, synchronous autocomplete pass. Once the quick provider has been completed the current history_url_provider will be replaced. In the meantime, the latter will remain in operation in order to provide the slower history results. BUG=None TEST=None Review URL: http://codereview.chromium.org/3017008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54354 0039d316-1c4b-4281-b951-d872f2087c98
* Reland r54074.dtseng@chromium.org2010-07-301-0/+2
| | | | | | Review URL: http://codereview.chromium.org/3010040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54334 0039d316-1c4b-4281-b951-d872f2087c98
* GTTF: Move more test server code from net/url_request/url_request_unittest.hphajdan.jr@chromium.org2010-07-291-0/+1
| | | | | | | | | | | | | to net/test/test_server.h No code changes, just a move. TEST=none BUG=49680 Review URL: http://codereview.chromium.org/3034038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54201 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] First pass at final sizing of toolbar items.shess@chromium.org2010-07-292-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Toolbar.xib changes: - buttons from 31x27 to 29x29 so that the visual is 27x27. - shift things left to take up opened space. - omnibox to 29 pixels tall. - wrench also to 29x29. - all of that raised a single pixel to recenter. - swap positions of home and reload. Modify home-button-adjustment code to reflect rearranged home/reload positions. Increase Omnibox font size by one point to match increased field height (and Windows Omnibox). Revise various font clients to recognize this. Shift Omnibox baseline and other measurements to account for increased height. Shift globe/search icon in by one pixel so icons on both sides of Omnibox are 4px from border. Matching shift in popup. Fix EV-bubble to use appropriate green for text, rather than black. Push out bubble to have a single-pixel space WRT Omnibox border. Tighten corners to tuck into Omnibox corners. Handle different lhs padding versus location icon (image should end up in same spot, even though the bubble draws outside the image). BUG=50575 TEST=none Review URL: http://codereview.chromium.org/3046029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54188 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-292-3/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 54074 - Add initial tests for keyboard access (tabbing in some dialogs).rohitrao@chromium.org2010-07-291-2/+0
| | | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 TBR=dtseng@chromium.org Review URL: http://codereview.chromium.org/3046031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54093 0039d316-1c4b-4281-b951-d872f2087c98
* Add initial tests for keyboard access (tabbing in some dialogs).dtseng@chromium.org2010-07-281-0/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/3015026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54074 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Fix some presubmit errors.tfarina@chromium.org2010-07-281-3/+2
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3026031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54020 0039d316-1c4b-4281-b951-d872f2087c98
* Modified resources for M6 theme. This doesn't actually modify layout yet, ↵pkasting@chromium.org2010-07-281-2/+2
| | | | | | | | | | just images and identifier names. BUG=50107 TEST=none Review URL: http://codereview.chromium.org/3035034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53993 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2616-0/+16
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Cancel autocomplete popup animations using an AppKit bug workaround.rohitrao@chromium.org2010-07-231-6/+22
| | | | | | | | BUG=49125 TEST=Resize window while popup is open/animating. Should not look horrible. Review URL: http://codereview.chromium.org/3051002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53472 0039d316-1c4b-4281-b951-d872f2087c98
* Attemp 2 at:sky@chromium.org2010-07-211-7/+0
| | | | | | | | | | | | | | | | Makes the toolbar visible for apps again. Here's the set of patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566) If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none TBR=finnur Review URL: http://codereview.chromium.org/3056003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53204 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 53062 - Makes the toolbar visible for apps again. Here's the set of ↵pinkerton@chromium.org2010-07-201-0/+7
| | | | | | | | | | | | | | | | | | patches I reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 TBR=sky@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53073 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the toolbar visible for apps again. Here's the set of patches Isky@chromium.org2010-07-201-7/+0
| | | | | | | | | | | | | | reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for 45566. If you see anything missing, please let me know. Also, there are some grd strings no longer necessary. I'll nuke those separately. BUG=49013 TEST=none Review URL: http://codereview.chromium.org/2888020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53062 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve clipboard compatibility with firefox + evolution.estade@chromium.org2010-07-201-5/+4
| | | | | | | | | | BUG=48424 TEST=copying from the chrome bookmark manager into firefox should save the bookmark's title as well as url TEST=copying the address from the omnibox into evolution copies text, and doesn't create an attachment Review URL: http://codereview.chromium.org/3022004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52983 0039d316-1c4b-4281-b951-d872f2087c98
* Header Cleanup: Remove unncessary include of sqlite_utils.h in some files.tfarina@chromium.org2010-07-171-1/+0
| | | | | | | | | | | BUG=None TEST=trybots Signed-off-by: Thiago Farina <tfarina@chromium.org> Review URL: http://codereview.chromium.org/2843061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52827 0039d316-1c4b-4281-b951-d872f2087c98
* Disable AutocompleteBrowserTest.Basic instead of FLAKY_oshima@chromium.org2010-07-161-2/+2
| | | | | | | | | BUG=49324 TEST=none Review URL: http://codereview.chromium.org/3039007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52718 0039d316-1c4b-4281-b951-d872f2087c98
* Mark AutocompleteBrowserTest.Basic as flaky.oshima@chromium.org2010-07-161-1/+9
| | | | | | | | | | TBR=phajdan.jr@chromium.org BUG=49324 TEST=none Review URL: http://codereview.chromium.org/3020007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52701 0039d316-1c4b-4281-b951-d872f2087c98
* Use the extension icon for extension omnibox results instead of the genericmpcomplete@chromium.org2010-07-156-24/+75
| | | | | | | | | | | | | | | search icon. I refactored the extension menu manager to separate the icon-specific bits. BUG=46479 TEST=load the chrome search extension at src/chrome/common/extensions/docs/examples/extensions/chrome_search/ and type "src foo" into the omnibox. You should see the extension icon instead of the magnifying glass. Switch back and forth between the "src" keyword result, other results, and other keywords and the icons should update properly. Review URL: http://codereview.chromium.org/2973006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52535 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-16 04:44:56 +0000