summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autocomplete
Commit message (Collapse)AuthorAgeFilesLines
* GTK: delete text when cutting from the omnibox.estade@chromium.org2010-05-201-2/+5
| | | | | | | | | BUG=44232 TEST=cut all the contents from the omnibox. The url (along with the protocol) should be on both PRIMARY and CLIPBOARD selections. The omnibox should now lay empty. Review URL: http://codereview.chromium.org/2108014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47847 0039d316-1c4b-4281-b951-d872f2087c98
* Elide the EV bubble when it's extremely long. This limits it to half the ↵pkasting@chromium.org2010-05-202-4/+4
| | | | | | | | | | location bar width, unless eliding to that would result in a width of less than 150 px. BUG=42856 TEST=Visit https://www.barbican.org.uk/eticketing/index.asp and make the window smaller. The EV bubble should shrink, eliding in middle, until it hits a minimum size. Review URL: http://codereview.chromium.org/2084012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47819 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup a bunch of TODO(shess).shess@chromium.org2010-05-194-39/+20
| | | | | | | | | | | | | | | | | | The TODO on AutocompleteEditViewMac about the popup needing the field for placement and font got half done. The placement part just seemed too intrusive to be worthwhile, but the font part seemed reasonable to get rid of. The others are all either not sensible anymore, or were addressed without being removed, or have been in there long enough that if nobody has complained by now, their subject must not matter. BUG=none TEST=none Review URL: http://codereview.chromium.org/2127009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47732 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: prepend protocol to cuts/copies from the omnibox.estade@chromium.org2010-05-181-3/+6
| | | | | | | | | | | I messed this up with r46767 BUG=44244 TEST=cut and copy both prepend the protocol when used on the entire omnibox contents. Review URL: http://codereview.chromium.org/2081005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47544 0039d316-1c4b-4281-b951-d872f2087c98
* Remove --omnibox-popup-count flag.tfarina@chromium.org2010-05-186-44/+33
| | | | | | | | | BUG=40083 TEST=compiles Review URL: http://codereview.chromium.org/2013008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47482 0039d316-1c4b-4281-b951-d872f2087c98
* Support speculative pre-connection to search URLsjar@chromium.org2010-05-181-1/+21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Implement several flavors of TCP/IP speculative preconnection under a command line flag (not yet on by default). The first area of preconnection takes place when a user types a query into the omnibox, as we preconnect to the search service when the omnibox suggests it is going to do a search. The second area involves subresources, such as images. When a navigation takes place, and we've seen navigations to that domain/port before, and the history-based probabability that we'll need to make a connection to a second site (host/port) is sufficiently large, then we preconnect to that second site while we are still connecting to the primary site (and before we've gotten content from the primary site. We also fall-back to mere DNS pre-resolution of subresource hostnames when the probability of a connection to the subresource is not high enough. BUG=42694 r=pkasting,willchan,mbelshe Review URL: http://codereview.chromium.org/1585029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47479 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Allow users to override fonts and font sizes in gtk-mode.erg@chromium.org2010-05-181-6/+8
| | | | | | | | | | | | | | | | This works on both the location bar and the find bar, the only places I could find where we do weird stuff with widgets. We still force font sizes in chrome-theme mode. Effectively, while this doesn't completely solve 22614, it should mitigate the symptoms in a lot of cases. BUG=12195,22614 TEST=In GNOME, change your system font while chrome is in gtk-theme mode. The font in the location bar and in the find bar should match the application font. Review URL: http://codereview.chromium.org/2124005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47478 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Null terminate text/html data we send to the clipboard. Change ↵thestig@chromium.org2010-05-172-3/+5
| | | | | | | | | | WriteHyperlink to take string16 anchor text. BUG=42624 TEST=none Review URL: http://codereview.chromium.org/2036013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47432 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure the Omnibox is hidden when toolbar is collapsed.finnur@chromium.org2010-05-131-0/+7
| | | | | | | | | BUG=None TEST=Visual inspection. The Omnibox should never become visible for tabs with a collapsed toolbar (app tabs). F11 twice should not show the Omnibox. Review URL: http://codereview.chromium.org/2032015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47119 0039d316-1c4b-4281-b951-d872f2087c98
* Changes autocomplete to only prefix with http if haven't modifiedsky@chromium.org2010-05-102-14/+29
| | | | | | | | | | | host. BUG=43585 TEST=see bug Review URL: http://codereview.chromium.org/1993006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46860 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: add http:// to cuts as well as copies in the omnibox.estade@chromium.org2010-05-082-6/+18
| | | | | | | | | BUG=43569 TEST=manual Review URL: http://codereview.chromium.org/2021006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46767 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLFetcher and related classes to chrome/common/net.sanjeevr@chromium.org2010-05-072-2/+2
| | | | | | | | BUG=None TEST=Build and Unittests Review URL: http://codereview.chromium.org/1995008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46739 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix omnibox popup for scaling.shess@chromium.org2010-05-072-52/+72
| | | | | | | | | | | | | | | | | Make it so that the code carefully shuffled rects, points, and sizes through the right conversions as it moves from view coordinates to screen coordinates (to position the popup). This only really comes up when you're debuggin whether your pretty scalable PDF graphics really work by using Quartz Debug to set the scale factor to 3 or something. BUG=40999 TEST=See bug Review URL: http://codereview.chromium.org/2028004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46729 0039d316-1c4b-4281-b951-d872f2087c98
* Remove/update a bunch of references to the Google-internal bug tracker.evan@chromium.org2010-05-071-1/+2
| | | | | | | | | | Many of our references turn out to just be context for a given workaround, e.g. "Set the foobar here because the destructor dereferences it, see http://private-bug-url". Review URL: http://codereview.chromium.org/2004004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46645 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fixes janky animations in the omnibox popup.rohitrao@chromium.org2010-05-062-16/+43
| | | | | | | | BUG=None TEST=Hold down 'a' in the omnibox. The animation should be smooth and not flickery. Review URL: http://codereview.chromium.org/2010002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46632 0039d316-1c4b-4281-b951-d872f2087c98
* Small cleanups/style fixes. Simplifies RTL functions slightly.pkasting@chromium.org2010-05-051-5/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1932006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46419 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Unify drag and copy from Omnibox.shess@chromium.org2010-05-042-12/+17
| | | | | | | | | | | | | | | | Previously drags went through the NSText code, which allowed drag of rich text out of the Omnibox. Modify so that both drag and copy use the same core code. Also undo the drag-all-like-location-bar-icon effect from an earlier change. BUG=41414, 43183, 41218 TEST=Compare Copy with drag&drop into TextEdit with various selections. Review URL: http://codereview.chromium.org/1936002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46407 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Always reset attributes as Omnibox changes.shess@chromium.org2010-05-041-0/+6
| | | | | | | | | | | | | | | r45524 regressed things so that color and other attributes could "leak" through as the omnibox text was changed to values which where those attributes were no longer appropriate. For instance strike-through or https coloring. This resets the text attributes for the in-focus case. BUG=43149 TEST=See bug report. Review URL: http://codereview.chromium.org/1938004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46404 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Mark the following tests as no longer flaky:phajdan.jr@chromium.org2010-05-031-1/+1
| | | | | | | | | | | | | | | | AutocompleteEditViewTest.EnterToSearch (bug 31732) BrowserTest.SingleBeforeUnloadAfterWindowClose (bug 27039) FindInPageControllerTest.PreferPreviousSearch (bug 32312) SessionRestoreUITest.DontRestoreWhileIncognito (bug 39490) SessionRestoreUITest.ShareProcessesOnRestore (bug 40181) TabRestoreUITest.RestoreToDifferentWindow (bug 14132, the other test is still flaky) TEST=no longer flaky BUG=31732, 27039, 32312, 39490, 40181, 14132 Review URL: http://codereview.chromium.org/1697021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46213 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Fix issue 34343: "Tab to search" hint on omnibox disappears on drag ↵suzhe@chromium.org2010-04-302-9/+13
| | | | | | | | | | | | | dropped tab. This CL is just a clone of http://codereview.chromium.org/1519005. As I just rebuilt my working environment. BUG=34343 TEST=Input www.google.com to trigger "tab to search" hint, then drag the tab into a new window, then check if "tab to search" hint is still there. Review URL: http://codereview.chromium.org/1523016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46112 0039d316-1c4b-4281-b951-d872f2087c98
* Implement UI automation on the Mac.jrg@chromium.org2010-04-291-0/+1
| | | | | | | | | | | | | | | | | | | Code is untested. From gChat: me: do you have a good test I can use to make sure mac impl of ui_controls for sending events works OK? Or would you prefer I send you CLs to play with and we iterate by hand? Joe: I would like the CL to play with to see if I can get it to work with the code I wrote Warning to Joe: mouse moved events currently use the Mac coordinate frame (0,0 is bottom-left not top-left). That's easy to switch; I'd like to do whatever is easiest to get WebDriver working. BUG=26102 Review URL: http://codereview.chromium.org/1701006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46005 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding http://codereview.chromium.org/1746009/showjcivelli@chromium.org2010-04-292-2/+2
| | | | | | | | | | | | | | | | | | (fixed the ChromeOS build). The app launcher now uses the location bar (instead of the autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1792010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45957 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 45936 - The app launcher now uses the location bar (instead of the ↵jcivelli@chromium.org2010-04-292-2/+2
| | | | | | | | | | | | | | | | | | | | autocomplete edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every innerclass gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1746009 TBR=jcivelli@google.com Review URL: http://codereview.chromium.org/1737021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45937 0039d316-1c4b-4281-b951-d872f2087c98
* The app launcher now uses the location bar (instead of the autocomplete ↵jcivelli@google.com2010-04-292-2/+2
| | | | | | | | | | | | | | | | | edit), so it has "tab to search" and the icons on the left side, Also split location_bar_view.cc so that every inner-class gets its own .h and .cc file. BUG=None TEST=Make sure the location bar works as expected (tab to search, bookmark star, page actions...). Open the app launcher, make sure "tab to search" works as expected. Review URL: http://codereview.chromium.org/1746009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45936 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes one of the AddTabWithURL variants.sky@chromium.org2010-04-291-2/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1736022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45902 0039d316-1c4b-4281-b951-d872f2087c98
* Adds comment to AdjustTextForCopy. I saw your request for asky@chromium.org2010-04-281-0/+3
| | | | | | | | | | | description after I landed the change. BUG=none TEST=none Review URL: http://codereview.chromium.org/1734011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45804 0039d316-1c4b-4281-b951-d872f2087c98
* Changes mac to call into AutocompleteEditModel method forsky@chromium.org2010-04-271-23/+15
| | | | | | | | | | | determining text to copy to clipboard. BUG=41493 TEST=see bug Review URL: http://codereview.chromium.org/1765008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45747 0039d316-1c4b-4281-b951-d872f2087c98
* Changes Linux to call into AutocompleteEditModel method forsky@chromium.org2010-04-272-49/+62
| | | | | | | | | | | | | determining text to copy to clipboard. I also added call to WriteBookmark and fixed up setting selected_text_. BUG=41493 TEST=make sure copy/paste from the omnibox work sanely on linux. Seriously though, see the three bugs for specifics. Review URL: http://codereview.chromium.org/1801001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45700 0039d316-1c4b-4281-b951-d872f2087c98
* Tweaks to copy/paste of omnibox on windows:sky@chromium.org2010-04-274-31/+193
| | | | | | | | | | | | | | | | . Makes copy prefix the text with http if the user hasn't edited the text, and the scheme is http but the text doesn't include http. . Makes copying use the url as the text if the user hasn't edited the text and it's http/https. . Makes control-insert/shift-insert use our copy/paste. BUG=41639 41489 41493 TEST=make sure copy/paste from the omnibox work sanely. Seriously though, see the three bugs for specifics. Review URL: http://codereview.chromium.org/1761002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45667 0039d316-1c4b-4281-b951-d872f2087c98
* Honor the select_all argument to AutocompleteEditViewMac::FocusLocation.mark@chromium.org2010-04-261-3/+5
| | | | | | | | | | | | | | | | | | | | | | | Calling -[NSWindow makeFirstResponder:] to give focus to the AutocompleteTextField will select the entire contents of the field. If the field is already focused and "select all" is not desired, avoid making this call. If "select all" is desired, or if the field is not focused (regardless of the value of select_all), the field will be focused and its entire contents selected. BUG=40322, 40682 TEST=With a profile primed so that "google.com" is the first suggestion when typing "g" in the location bar, and no windows open, quickly press command-N and begin typing "google" while the tab is being created. Expect all of the entered characters to make it to the location bar. When the bug occurs, the location bar in its entirety will be selected at some point during or immediately following tab creation, which will cause previously-typed text to be lost or the first autocomplete suggestion to be chosen, and something like "ogle" or "google.com/ogle" to appear in the location bar. Review URL: http://codereview.chromium.org/1709010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45628 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix issue 19421: IMEs do not work well in the omnibox due to a race ↵suzhe@chromium.org2010-04-242-40/+68
| | | | | | | | | | | | | | | | condition This CL makes following major changes: 1. Exclude marked text from GetText()'s result. 2. When the text field is in editing mode, EmphasizeURLComponents() changes its attributes through its editor rather than reseting its content. 3. When the text field is in editing mode, SetText() sets its content through its editor. BUG=19421 TEST=See bug report. Review URL: http://codereview.chromium.org/1549033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45524 0039d316-1c4b-4281-b951-d872f2087c98
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-2323-550/+861
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Don't select all when autofocusing the location bar on New Tab creation. ↵pkasting@chromium.org2010-04-233-7/+9
| | | | | | | | | | Users could already be typing in the omnibox before the load commits (e.g. due to a slow renderer process startup) and this typing would then be selected and overwritten. BUG=41466 TEST=On a very slow machine, typing before a new tab finishes loading should not be selected or cleared once the tab finishes loading. Review URL: http://codereview.chromium.org/1738004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45406 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Omnibox popup icons and text lined up under toolbar.shess@chromium.org2010-04-221-2/+2
| | | | | | | | | | | | Make the icons line up under the star icon, and the text line up under the field text. BUG=42338 TEST=Start typing, verify that things like up. Use Pixie.app if you need magnification. Review URL: http://codereview.chromium.org/1729007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45381 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement OnDragCanceled() for autocomplete popup view on linux.erg@chromium.org2010-04-222-2/+22
| | | | | | | | | | | | | Pressing escape while performing a drag inside the autocomplete popup should abort the drag and not changed the selected item. This is a rewrite of pkasting's r37724 for GTK instead of views. BUG=35710 TEST=none Review URL: http://codereview.chromium.org/1758002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45322 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-2223-862/+551
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Override cursor colors in chrome-theme mode.erg@chromium.org2010-04-211-0/+2
| | | | | | | | | | | On dark gtk themes with light text, the cursor is often white, so in chrome-theme mode we had a white cursor on white background. BUG=40094 TEST=none Review URL: http://codereview.chromium.org/1723001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45213 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Position the EV certificate stuff inside a green bubble.erg@chromium.org2010-04-202-9/+2
| | | | | | | | | | | | This patch explicitly doesn't move the EV certificate bubble one pixel to the left; that's hairier than expected and will be a separate patch. BUG=41999 TEST=none Review URL: http://codereview.chromium.org/1528046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45084 0039d316-1c4b-4281-b951-d872f2087c98
* SSL UI changes, Windows, code side (images are separate).pkasting@chromium.org2010-04-196-62/+15
| | | | | | | | | | | | | | | | * Remove "Type to search" hint * Remove "Untrusted website" label * Add EV cert bubble, make it function like a location icon for clicks/drags * Modify spacing for EV/tab-to-search bubbles to keep icons and text aligned with dropdown * Change non-EV HTTPS coloring from blue to green Mac and Linux should compile, but only some of the above changes have been made for them. Specifically, there is no EV cert bubble, the non-EV scheme color isn't changed, and the icon/text alignment in the tab-to-search bubble hasn't been touched. BUG=41481 TEST=paypal.com should generate a bubble around the lock and cert holder name, which responds to clicks and drags like the location icon would Review URL: http://codereview.chromium.org/1585043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44929 0039d316-1c4b-4281-b951-d872f2087c98
* Paste of URL into PowerPoint2008 fails.jrg@chromium.org2010-04-191-1/+5
| | | | | | | | | BUG=http://crbug.com/41842 TEST=Copy entire string from Omnibox and paste into PowerPoint2008 document. Review URL: http://codereview.chromium.org/1671001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44916 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Select better greens in the native omnibox popup.erg@chromium.org2010-04-161-29/+58
| | | | | | | | | BUG=40126 TEST=none Review URL: http://codereview.chromium.org/1539042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44822 0039d316-1c4b-4281-b951-d872f2087c98
* Fix memory smash, take 2.pkasting@chromium.org2010-04-142-1/+9
| | | | | | | | | | Fix freed-memory accesses of members of a destroyed object while unwinding the callstack. This avoids introducing a different memory corruption issue at shutdown by using WeakPtr to hold the object that the OS can delete out from under us. It also clarifies and simplifies the shutdown sequence by moving the AutocompleteController::Stop() call into the controller's destructor, and avoiding notifying observers of changes; this actually altogether sidesteps the problematic codepath for which I needed the WeakPtr, but I'm not sure whether the OS still might be able to destroy the object at another time, so I'm leaving the WeakPtr in. BUG=41274 TEST=Run Chrome with full page heap on. Clicking an item in the omnibox dropdown should not crash. Review URL: http://codereview.chromium.org/1657002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44581 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make the primary selection include the url's scheme when an entire URL ↵estade@chromium.org2010-04-142-19/+115
| | | | | | | | | | | | | is selected. sometimes the scheme will be hidden, which is the reason we need this workaround. BUG=41173 TEST=manual Review URL: http://codereview.chromium.org/1638007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44519 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Fix MouseDown/MouseUp error for Steve animation effectsthomasvl@chromium.org2010-04-141-3/+3
| | | | | | | | | | | | | - Pull in new GTM with Animation fixes - Switch masks to be mouse up, not down. - Remove the steve effect from places where users don't really trigger the animation, so the effect doesn't seem "random" - Move the animation duration set to be per click in the prefs window instead of binding the time at window open. BUG=41393 TEST=Steve animation effects are back. Review URL: http://codereview.chromium.org/1618021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44516 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Set the selection colors on the omnibox.erg@chromium.org2010-04-141-0/+24
| | | | | | | | | | | This prevents GTK theme colors from bleeding into the omnibox. TEST=none BUG=none Review URL: http://codereview.chromium.org/1605026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44482 0039d316-1c4b-4281-b951-d872f2087c98
* Removes assert in autocomplete test that is no longer valid. Thesky@chromium.org2010-04-141-1/+0
| | | | | | | | | | | | | reason the assert is no longer valid is that browser tests no longer run a nested message loop. BUG=none TEST=none TBR=suzhe@chromium.org Review URL: http://codereview.chromium.org/1645006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44445 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Update top padding on icons in the autocomplete popup.erg@chromium.org2010-04-131-1/+1
| | | | | | | | | | | | | | Technically, this still isn't centered (there's one more pixel below the icon then there is over it). But being off-center one pixel up looks better than being off-centere one pixel down. (And both look better than the current trunk.) BUG=41189 TEST=none Review URL: http://codereview.chromium.org/1568031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44415 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Move reload in gtk mode and fix omnibox popup location.erg@chromium.org2010-04-134-16/+60
| | | | | | | | | | | | | - The reload button in GTK mode now is the normal stock gtk icon again. - The horizontal bounds of the omnibox popup are now the equal to the location bar box in GTK mode. BUG=41189 TEST=none Review URL: http://codereview.chromium.org/1604028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44380 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash in autocomplete when typing some URLs. The problemsky@chromium.org2010-04-121-2/+8
| | | | | | | | | | | | occurred because HistoryURLProvider used the url to determine what to markup vs the actual text. BUG=41054 TEST=see bug Review URL: http://codereview.chromium.org/1562023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44282 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] PDF icons for omnibox nits.shess@chromium.org2010-04-121-11/+12
| | | | | | | | | | | A couple of post-mortem nits from Trung. BUGS=none TEST=trybots Review URL: http://codereview.chromium.org/1542024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44273 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-29 09:53:06 +0000