| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
BUG=100845
TEST=none (purely a refactoring change)
TBR=dhollowa@chromium.org, akalin@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11415162
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
HTML spec.
The spec is currently hosted at http://www.whatwg.org/specs/web-apps/current-work/multipage/association-of-controls-and-forms.html#autofilling-form-controls:-the-autocomplete-attribute
Also changes the data type of FormFieldData::autocomplete_attribute and FormFieldData::form_control_type to std::string.
BUG=156508,156633
Review URL: https://chromiumcodereview.appspot.com/11198048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163764 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The motivation for this CL is to move PasswordForm and friends (which are totally unrelated to WebKit) out of webkit/ and into a target that platforms that do not use WebKit (such as iOS) can logically depend on.
As such, this CL does three things:
1. Separates the WebKit-related code in webkit/forms from the
non-WebKit-related code. Concretely, this means having the WebKit::WebFormElement->PasswordForm conversion function in its own file.
2. Moves the core, non-WebKit-related forms code to chrome/common and content/public/common depending on where its usage points are.
3. Moves the above-mentioned conversion function to content/public/renderer. It cannot stay in webkit/ as it (now) has a dependency on content/, and as it is used only in chrome/renderer and content/renderer, this is a good place for it.
The rest of this CL is churn due to namespace, file location, and GYP target changes.
BUG=
Review URL: https://chromiumcodereview.appspot.com/11000016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160280 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This makes ScopedVector's clear() method destroy the
elements before clearing the internal vector, matching the
behavior of the erase() method. I'm moving clear()'s
previous element-preserving behavior into a new weak_clear()
method, matching weak_erase().
I'm also removing ScopedVector::reset(), as it duplicated
clear()'s new behavior and isn't a part of std::vector.
BUG=137909
TEST=added
Review URL: https://chromiumcodereview.appspot.com/10797017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147360 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/8680040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes AutofillMergeTest fixture from using a scoped_ptr<PersonalDataManagerMock> to direct PersonalDataManagerMock member.
BUG=94026
TEST=AutofillMergeTest.*
Review URL: http://codereview.chromium.org/8043027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102808 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Converts PersonalDataManager over to be a ProfileKeyedService. Decouples Sync code from PersonalDataManager and moves to a notification-based update. Changes various test mocks over to the new ProfileKeyedService mechanisms.
BUG=94026
TEST=PersonalDataManagerTest.*:AutofillTest.*:AutofillMetricsTests.*:AutofillDataTypeControllerTest.*: and other Sync tests.
Review URL: http://codereview.chromium.org/7967024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102598 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=81846
TEST=*
R=isherman@chromium.org
Review URL: http://codereview.chromium.org/7892048
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@101602 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the test suite implicitly provides global resources for each test,
but they're re-initialized between each test.
The performance overhead is negligible.
We need that to continue moving tests from unit_tests
to content_unittests. Because of shared test fixtures
the test suites need to be compatible.
BUG=90443
Review URL: http://codereview.chromium.org/7744039
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98526 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=90905
Review URL: http://codereview.chromium.org/7616019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_glue::FormField's unwieldy full constructor and StricktlyEqualsHack() method. The only clients are in test code, and we can better support these clients in other ways.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7576001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For a detailed description see part #1, http://codereview.chromium.org/6478005/
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7465041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
stored Autofill data.
This is what the toolbar server expects of all of its clients.
BUG=none
TEST=unit_tests --gtest_filter=PersonalDataManagerTest.GetAvailableFieldTypes:FormStructureTest.*
Review URL: http://codereview.chromium.org/6931029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84405 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
parsing with lookahead.
* Adds an AutofillScanner class to help with lookahead parsing.
* Remove the NULL-termination from FormStructure's fields vector
* Remove some redundant DCHECKs
* Refactor PersonalDataManager::ImportFormData() to take a single form, not a vector of forms.
* Move EmailField class to its own file
* Remove some obsolete billing/shipping address distinguishing code
* Refactor the code to remove the really wonky FormFieldSet() class
* Refactor some interfaces to take |size_t| rather than |int|
* Remove some unused fields from FormStructure
* Const-correctness
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6910018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84211 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
http://chromegw.corp.google.com/i/chromium/builders/Vista%20Tests%20%28dbg%29%281%29/builds/8263/steps/unit_tests/logs/TestLongSafePureFilenameRevert 81416 - Autofill extend profiles to include multi-valued fields, part 6 (Aggregation)Extends the Autofill aggregation logic to merge profiles with a common address into a single profile with multi-valued fields. Also, extends the web_database migration to include this new logic when migrating the web_database preferences.BUG=65625TEST=WebDatabaseMigrationTest.MigrateVersion32ToCurrent:AutofillMergeTest.DataDrivenMergeProfiles:AutofillProfileTest.*Review URL: http://codereview.chromium.org/6826059TBR=dhollowa@chromium.orgReview URL: http://codereview.chromium.org/6833026
TBR=siggi@chromium.org
Review URL: http://codereview.chromium.org/6834028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81425 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
http://chromegw.corp.google.com/i/chromium/builders/Vista%20Tests%20%28dbg%29%281%29/builds/8263/steps/unit_tests/logs/TestLongSafePureFilename
Revert 81416 - Autofill extend profiles to include multi-valued fields, part 6 (Aggregation)Extends the Autofill aggregation logic to merge profiles with a common address into a single profile with multi-valued fields. Also, extends the web_database migration to include this new logic when migrating the web_database preferences.BUG=65625TEST=WebDatabaseMigrationTest.MigrateVersion32ToCurrent:AutofillMergeTest.DataDrivenMergeProfiles:AutofillProfileTest.*Review URL: http://codereview.chromium.org/6826059
TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/6833026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81421 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Extends the Autofill aggregation logic to merge profiles with a common address into a single profile with multi-valued fields. Also, extends the web_database migration to include this new logic when migrating the web_database preferences.
BUG=65625
TEST=WebDatabaseMigrationTest.MigrateVersion32ToCurrent:AutofillMergeTest.DataDrivenMergeProfiles:AutofillProfileTest.*
Review URL: http://codereview.chromium.org/6826059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81416 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
R=isherman@chromium.org,dhollowa@chromium.org
BUG=72758
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6688053
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Renames AutofillProfile::GetFieldText to AutofillProfile::GetInfo. To match SetInfo.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6713002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78622 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/6673079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78518 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6658030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77630 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes automatic generation of IPC messages much easier.
Convert autofill messsage to automatic generation in the process.
Attempt #2: fix build on chromeos, see http://codereview.chromium.org/6633001
for original CL.
Review URL: http://codereview.chromium.org/6625087
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Convert autofill messages to use the new IPC macros. This requires
changing the FormField class to a struct with publically-visible members,
which was what should have been done in the first place, instead of the
trivial setters/getters which are accessed in various combinations
independently of each other throughout the code.
Review URL: http://codereview.chromium.org/6633001
TBR=tsepez@chromium.org
Review URL: http://codereview.chromium.org/6623086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77298 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
changing the FormField class to a struct with publically-visible members,
which was what should have been done in the first place, instead of the
trivial setters/getters which are accessed in various combinations
independently of each other throughout the code.
Review URL: http://codereview.chromium.org/6633001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77296 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6626042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77140 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=existing unit_tests
Review URL: http://codereview.chromium.org/6621008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76910 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=72758
TEST=compiled locally and trybots
Review URL: http://codereview.chromium.org/6592067
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6437001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74867 0039d316-1c4b-4281-b951-d872f2087c98
|
|
aggregation.
BUG=none
TEST=unit_tests --gtest_filter=AutoFillMergeTest.*
Review URL: http://codereview.chromium.org/6312174
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74210 0039d316-1c4b-4281-b951-d872f2087c98
|