summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill/credit_card.h
Commit message (Collapse)AuthorAgeFilesLines
* Removed deprecated AutofillProfile::Compare, renamed CompareMulti to ↵georgey@chromium.org2012-01-231-5/+1
| | | | | | | | | | | | Compare, fixed related bugs. BUG=109797 TEST=unit tests Review URL: http://codereview.chromium.org/9265023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118750 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of non-shared methods out of the FormGroup class.isherman@chromium.org2011-10-051-1/+2
| | | | | | | | | | | | Some of them can be removed completely! BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8143007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104045 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the "Save credit card for Autofill?" infobar unnecessarily.isherman@chromium.org2011-10-041-0/+6
| | | | | | | | | BUG=98968, 98991 TEST=unit_tests --gtest_filter=PersonalDataManager.*CreditCard* Review URL: http://codereview.chromium.org/8114031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103994 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Include iosfwd in some header files.tfarina@chromium.org2011-10-021-1/+1
| | | | | | | | | | | Better to include iosfwd only when the declaration is needed. R=isherman@chromium.org Review URL: http://codereview.chromium.org/8103020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103668 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate Autofill possible type detection code, and enforce greater match ↵isherman@chromium.org2011-07-221-26/+10
| | | | | | | | | | | | | | | | | | precision. * Only consider submitted field values to match locally stored data if the strings match exactly + This means we will send fewer false positives to the server, at the cost of some false negatives. Most importantly, we should stop identifying ADDRESS_LINE_2 fields as ADDRESS_LINE_1. + There are a few excpetions for structured fields with canonicalized values, like countries (which are canonicalized to country codes) * Eliminate FormGroup::GetMatchingTypes() -- all of this work is now done in a consistent way within AutofillManager * Refactor FormGroup::GetNonEmptyTypes() to be shared code. BUG=81867, 76992 TEST=unit_tests --gtest_filter=AutofillManagerTest.DeterminePossibleFieldTypesForUpload Review URL: http://codereview.chromium.org/7398019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93582 0039d316-1c4b-4281-b951-d872f2087c98
* Don't learn credit cards for Autofill if they are missing any data.isherman@chromium.org2011-07-221-0/+3
| | | | | | | | | BUG=89990 TEST=unit_tests --gtest_filter=PersonalDataManagerTest.AggregateCreditCardWithMissingInfoInNew Review URL: http://codereview.chromium.org/7465019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93548 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename FormGroup::GetPossibleFieldTypes() and ↵tfarina@chromium.org2011-05-091-3/+3
| | | | | | | | | | | | | | | | ::GetAvailableFieldTypes() to be clearer. GetPossibleFieldTypes() -> GetMatchingTypes(). GetAvailableFieldTypes() -> GetNonEmptyTypes(). BUG=81767 TEST=None R=dhollowa@chromium.org,isherman@chromium.org Review URL: http://codereview.chromium.org/6970005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84645 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill Multi-Value: Additional profiles with same name and address not ↵dhollowa@chromium.org2011-04-281-0/+4
| | | | | | | | | | | | | added to DOM UI Separates out the merging from |PersonalDataManager::AddProfile| so that merging only happens on form submission, and not when the user edits profiles manually via preferences. BUG=80341 TEST=PersonalDataManagerTest.AddProfile Review URL: http://codereview.chromium.org/6903091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83270 0039d316-1c4b-4281-b951-d872f2087c98
* Add alt attribute to Autofill credit card iconsisherman@chromium.org2011-04-121-2/+2
| | | | | | | | | BUG=77713 TEST=none Review URL: http://codereview.chromium.org/6825025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81198 0039d316-1c4b-4281-b951-d872f2087c98
* Only strip separators from credit card numbers when implicitly learning or ↵isherman@chromium.org2011-04-111-0/+3
| | | | | | | | | | | | | filling. Preserve whatever the user typed. BUG=78844 TEST=unit_tests --gtest_filter=*CreditCard* Review URL: http://codereview.chromium.org/6821021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81162 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up Autofill CreditCard logicisherman@chromium.org2011-04-061-28/+9
| | | | | | | | | | | | | | | * When determining possible field types (for upload to the server), match against stored data, not just against the Luhn checksum * When displaying the obfuscated credit card number, display exactly the right number of obfuscating '*'s. * When importing credit card data, only save the card if the detected card type is one we recognize. * Prune some unhelpful member variables * Prune some unhelpful methods from the header BUG=77822 TEST=unit_tests --gtest_filter=CreditCardTest.* Review URL: http://codereview.chromium.org/6690038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80580 0039d316-1c4b-4281-b951-d872f2087c98
* Only consider numbers between 12 and 19 digits long to potentially be credit ↵isherman@chromium.org2011-04-061-2/+2
| | | | | | | | | | | card numbers. BUG=64433 TEST=unit_tests --gtest_filter=CreditCardTest.* Review URL: http://codereview.chromium.org/6758027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80577 0039d316-1c4b-4281-b951-d872f2087c98
* Prune dead code: FormGroup::FindInfoMatches(), FormGroup::GetPreviewText()isherman@chromium.org2011-03-311-10/+0
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6783009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80099 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Cleanup in the following files:jhawkins@chromium.org2011-03-301-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | * autofill_download.cc * autofill_ie_toolbar_import_win.cc * autofill_field.h * autofill_metrics.cc * autofill_profile.cc * autofill_type.cc * autofill_xml_parser.cc * contact_info.cc * credit_card.cc * credit_card_field.cc * fax_number.h * form_field.cc BUG=none TEST=none R=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6775005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79839 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill rename GetFieldText to GetInfodhollowa@chromium.org2011-03-171-1/+1
| | | | | | | | | | | Renames AutofillProfile::GetFieldText to AutofillProfile::GetInfo. To match SetInfo. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78622 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce boxing and unboxing of AutofillFieldTypeisherman@chromium.org2011-03-171-5/+5
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6673079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78518 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill extend profiles to include multi-valued fields, part 2.dhollowa@chromium.org2011-03-091-1/+0
| | | | | | | | | | | No functional change. This partitions the |ContactInfo| class into separate name, email, and company parts. AutoFillProfile is changed to store its component members directly instead of in a map (in preparation for multiple values). And the |Clone| operation is deprecated from the |FormGroup| class on down through the inheritance tree. BUG=65625 TEST=All existing unit tests. Review URL: http://codereview.chromium.org/6650014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77425 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillType to AutofillType.tfarina@chromium.org2011-03-071-4/+4
| | | | | | | | | BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6626042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77140 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillFieldType to AutofillFieldType.tfarina@chromium.org2011-03-011-1/+1
| | | | | | | | | BUG=72758 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/6592067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76442 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill cleanup of labelsdhollowa@chromium.org2011-02-151-2/+1
| | | | | | | | | | | This removes remaining vestiges of profile and credit card labels as a means for identification. Labels do remain in the profile and credit card classes but are private, not persisted to the database, and created upon demand. This also cleans up the web_data_service and web_database methods that used labels as identifiers. BUG=72929 TEST=WebDataServiceAutofillTest.*:WebDatabaseTest.* and miscellaneous others. Review URL: http://codereview.chromium.org/6480073 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@75028 0039d316-1c4b-4281-b951-d872f2087c98
* Support autocompletion for HTMl5 tags:"email", "month" and "tel".dhollowa@chromium.org2011-02-031-0/+3
| | | | | | | | | | | | | | | | | | | BUG=65654 TEST=1.make HTML5 forms with the following input types: - Email input: <input type="email"> - Date picker: <input type="month"> for credit card expiration. - Telephone input: <input type="tel"> - Placeholder text: <input name="address" placeholder="1 Main Street"/> 2.Try to fill. Implement tests for email, month and tel input type. Also this patch needs WebKit patch, please refer to https://bugs.webkit.org/show_bug.cgi?id=51809 Actually, original issue item says placeholder problem, but I cannot reproduce manually. Review URL: http://codereview.chromium.org/6033010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73660 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Display the appropriate CC icon in the AutoFill credit card list.jhawkins@chromium.org2011-01-051-0/+10
| | | | | | | | | BUG=59281 TEST=none Review URL: http://codereview.chromium.org/6083007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70476 0039d316-1c4b-4281-b951-d872f2087c98
* Even more virtual method deinlining.erg@google.com2010-12-131-1/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5741001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69041 0039d316-1c4b-4281-b951-d872f2087c98
* Add the "virtual" keyword on method overrides that are missing it.erg@google.com2010-12-081-1/+1
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/5648004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68606 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill form submission creates wrong credit cards.dhollowa@chromium.org2010-11-111-2/+4
| | | | | | | | | | | Adds logic to filter out credit card submissions that are invalid, or to merge credit cards that match the card number. BUG=57975 TEST=PersonalDataManagerTest.Aggregate* Review URL: http://codereview.chromium.org/4734001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65830 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill deprecate unique_ids in favor of guids for PersonalDataManagerdhollowa@chromium.org2010-11-041-9/+0
| | | | | | | | | | | Final round of unique_id deprecation. These changes migrated web_database schemas for profiles and credit cards, clean up the web_dataservice interface, bring the personal_data_manager interface inline with the GUID interfaces for web_dataservice, convert remaining unit tests to be GUID-based, and some changes to platform UI code that used unique IDs for edits. BUG=58813 TEST=WebDataServiceTest.*, WebDatabaseTest.*, WebDatabaseMigrationTest.*, PersonalDataManagerTest.*, AutoFillTest.*, AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillProfileTest.MergeWith, ProfileSyncServiceAutofillTest.*, TwoClientLiveAutofillSyncTest.* Review URL: http://codereview.chromium.org/4388001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65100 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill deprecate unique_ids in favor of guids for Mac UIdhollowa@chromium.org2010-10-271-6/+14
| | | | | | | | | | | Removes use of labels and unique_ids in the Mac UI for Autofill. BUG=58813 TEST=AutoFillAddressModelTest.*:AutoFillAddressSheetControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillDialogControllerTest.* Review URL: http://codereview.chromium.org/4110004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64073 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill address and credit card data separately.isherman@chromium.org2010-10-261-10/+0
| | | | | | | | | | | | | | | | | Our autofill UI for filling the billing address and credit card information simultaneously quickly gets out of hand for users with multiple address and credit card profiles. We want a clean, simple UI; so we will just fill one part of the form or the other; but not both. This cl also removes the billing address drop down from the Autofill preferences "Add credit card" dialog. BUG=57976 TEST=unit_tests --gtest_filter=*AutoFill* unit_tests --gtest_filter=*Autofill* Review URL: http://codereview.chromium.org/3961004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63964 0039d316-1c4b-4281-b951-d872f2087c98
* This is stage 1 of transition to GUIDs as primary identifier for AutoFill ↵dhollowa@chromium.org2010-10-201-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | profiles and credit cards. The transition will look like this in terms of table migration: Current: CREATE TABLE autofill_profiles ( label VARCHAR, unique_id INTEGER PRIMARY KEY, first_name VARCHAR, middle_name VARCHAR, last_name VARCHAR, email VARCHAR, company_name VARCHAR, address_line_1 VARCHAR, address_line_2 VARCHAR, city VARCHAR, state VARCHAR, zipcode VARCHAR, country VARCHAR, phone VARCHAR, fax VARCHAR); Transitional (adds guid column): CREATE TABLE autofill_profiles ( label VARCHAR, unique_id INTEGER PRIMARY KEY, first_name VARCHAR, middle_name VARCHAR, last_name VARCHAR, email VARCHAR, company_name VARCHAR, address_line_1 VARCHAR, address_line_2 VARCHAR, city VARCHAR, state VARCHAR, zipcode VARCHAR, country VARCHAR, phone VARCHAR, fax VARCHAR, guid VARCHAR NOT NULL); // <- add guid End goal (in follow up CL): CREATE TABLE autofill_profiles ( // remove label // remove unique_id guid VARCHAR NOT NULL PRIMARY KEY // <- reorder guid, make primary first_name VARCHAR, middle_name VARCHAR, last_name VARCHAR, email VARCHAR, company_name VARCHAR, address_line_1 VARCHAR, address_line_2 VARCHAR, city VARCHAR, state VARCHAR, zipcode VARCHAR, country VARCHAR, phone VARCHAR, fax VARCHAR); And similarly for the credit_cards table. BUG=58813 TEST=AutoFillProfileTest.Compare, GUIDTest.GUIDCorrectlyFormatted, WebDataServiceAutofillTest.ProfileRemoveGUID, WebDataServiceAutofillTest.CreditCardRemoveGUID, WebDatabaseTest.AutoFillProfile, WebDatabaseTest.CreditCard, WebDatabaseMigrationTest.MigrateVersion30ToCurrent Review URL: http://codereview.chromium.org/3760009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63173 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Continue fixing nits found by my automated source scanner.erg@google.com2010-10-051-1/+2
| | | | | | | | | | | (~1.3 megs off Debug linux .a files) BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3556013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61587 0039d316-1c4b-4281-b951-d872f2087c98
* DOMUI: Implement adding and editing credit cards in the AutoFill page.jhawkins@chromium.org2010-09-131-6/+6
| | | | | | | | | BUG=49094 TEST=none Review URL: http://codereview.chromium.org/3308006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59276 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Determine credit card type based on the CC number and display thejhawkins@chromium.org2010-07-301-5/+1
| | | | | | | | | | | appropriate CC icon. BUG=50080 TEST=none Review URL: http://codereview.chromium.org/3010041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54280 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill Empty profiles should not be saved from AutoFillDialog Add and Edit ↵dhollowa@chromium.org2010-07-211-0/+3
| | | | | | | | | | | | | | | sheets on Mac. Changes the AutoFillDialog on Mac to not store intermediate results of "Add" and "Edit" actions when those actions result in empty address or credit card information. Empty addresses and credit card information is culled at this level now, not just after "Save" from the main dialog. BUG=47742 TEST=AutoFillDialogControllerTest.AddNewProfile, AutoFillDialogControllerTest.AddNewEmptyProfile, AutoFillDialogControllerTest.AddNewCreditCard, AutoFillDialogControllerTest.AddNewEmptyCreditCard Review URL: http://codereview.chromium.org/3061001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53276 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Aggregate profile data. Remove the AutoFill InfoBar. Remove more ↵jhawkins@chromium.org2010-07-011-21/+4
| | | | | | | | | | | remnants of shipping address and CVV. BUG=47426,47423 TEST=PersonalDataManager.* Review URL: http://codereview.chromium.org/2818033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: De-segregate credit card filling.jhawkins@chromium.org2010-06-171-0/+2
| | | | | | | | | BUG=45616 TEST=AutoFillManagerTest.* Review URL: http://codereview.chromium.org/2859006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50167 0039d316-1c4b-4281-b951-d872f2087c98
* Putting this back in since it didn't solve the failures.thomasvl@chromium.org2010-06-081-3/+4
| | | | | | | | | | | | | | | | | | | Revert 49164 - Backing this out to see if it fixes the failures on the two windows bots (landed about when they started). Revert 49030 AutoFill: Don't save credit card numbers from Autocomplete to the WebDB. BUG=8026 TEST=AutocompleteHistoryManagerTest Review URL: http://codereview.chromium.org/2676003 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/2748002 TBR=thomasvl@chromium.org Review URL: http://codereview.chromium.org/2770001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49165 0039d316-1c4b-4281-b951-d872f2087c98
* Backing this out to see if it fixes the failures on the two windows bots ↵thomasvl@chromium.org2010-06-081-4/+3
| | | | | | | | | | | | | | | | (landed about when they started). Revert 49030 - AutoFill: Don't save credit card numbers from Autocomplete to the WebDB. BUG=8026 TEST=AutocompleteHistoryManagerTest Review URL: http://codereview.chromium.org/2676003 TBR=jhawkins@chromium.org Review URL: http://codereview.chromium.org/2748002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49164 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Don't save credit card numbers from Autocomplete to the WebDB.jhawkins@chromium.org2010-06-071-3/+4
| | | | | | | | | BUG=8026 TEST=AutocompleteHistoryManagerTest Review URL: http://codereview.chromium.org/2676003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49030 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Remove one incorrect comment and one useless comment.jhawkins@chromium.org2010-04-131-2/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1653001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44319 0039d316-1c4b-4281-b951-d872f2087c98
* Hook autofill++ WebDatabase changes up to the NotificationService.tim@chromium.org2010-03-271-1/+1
| | | | | | | | TEST=WebDataServiceAutofillTest Review URL: http://codereview.chromium.org/1385002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42881 0039d316-1c4b-4281-b951-d872f2087c98
* Adds obscuring to credit card numbers when displayed.avi@chromium.org2010-03-261-0/+2
| | | | | | | | | | | xib change: added tag to fields that are used for credit card numbers. BUG=http://crbug.com/38259 TEST=as in bug Review URL: http://codereview.chromium.org/1219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42768 0039d316-1c4b-4281-b951-d872f2087c98
* Where possible, use return-by-const-ref for accessors in AutoFill data ↵jhawkins@chromium.org2010-03-031-32/+33
| | | | | | | | | | structures. In addition, I fixed the access levels of many of the modified methods. BUG=31775 TEST=none Review URL: http://codereview.chromium.org/661421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40477 0039d316-1c4b-4281-b951-d872f2087c98
* Adding summary string generation for the AutoFill feature.dhollowa@chromium.org2010-02-131-1/+1
| | | | | | | | | | | | | | | | | | Includes a small modification to the generated resources, needed additional whitespace in credit card summary. Added summary generation to autofill_profile.* and modified summary generation in credit_card.* to match. credit_card.* modifications were largely to use string16 instead of std::wstring. Factored out common unit testing utilities into autofill_common_unittest.*, and added unit tests for summary string generation for credit_card.* and autofill_profile.*. BUG=35551 TEST=unit_tests --gtest_filter=AutoFillProfileTest.*:CreditCardTest.* Review URL: http://codereview.chromium.org/606031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39002 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill dialog for the Mac. This is UI only at this point. The UI is not ↵dhollowa@chromium.org2010-02-121-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | hooked up to the back end yet. The UI demonstrates manipulation of one address and one credit card record. Eventually buttons will be added to add and remove additional records. The additions in this CL are: - Preferences dialog has a new "Change autofill settings" button that triggers an autofill settings dialog. - The autofill settings dialog now exists and allows the user to manipulate form autofill data. Specifically address information and credit card information. - Each address or credit card record is presented in a disclosure view to allow for summary or detailed views of each record. - The autofill dialog is layed out dynamically in a vertical list (ordered by y) using the VerticalLayoutView. - Sections are delimited visually with the SectionSeparatorView. There are currently two sections, one for addresses and one for credit cards. - Unit tests are present that exercise the invocation of the dialog and check basic functionality. Checks are performed to see that data is flowing from core profile and credit card data structures into Cocoa model data structures used for bindings internally by the UI. - There are three .xib files (AutoFillDialog.xib, AutoFillAddressFormView.xib, and AutoFillCreditCardFormView.xib) that partition the dialog UI into distinct views, controllers, and model objects. - Cocoa databinding is utilized to syncronize dependent parts of the UI. - All strings are stored in internationalized form in .grd files and .xib files (with one small TODO execption, see below). The things remaining to do are: - Hook the UI up to the backend model, specifically the PersonalDataManager data. - Add support for arbitrary number of address and credit card records. I.e. Add and Delete buttons. - Scroll-to-Point support for autoscrolling when tabbing between fields. - Billing and shipping address popups in the credit card section. - Any validation of input (need to circle back with UI folks on this). - Input validation unit tests. - String concatenation of the summary label needs to be internationalized. BUG=33029 TEST=none Review URL: http://codereview.chromium.org/558066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38873 0039d316-1c4b-4281-b951-d872f2087c98
* Added Credit card preview in the form ******[last four digits], Exp: [Date - ↵georgey@chromium.org2010-02-031-0/+3
| | | | | | | | | | month and year] BUG=33026 TEST=should appear like in mocks, when dialog is finished Review URL: http://codereview.chromium.org/566027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37961 0039d316-1c4b-4281-b951-d872f2087c98
* First revision of the AutoFill settings dialog.georgey@chromium.org2010-01-281-0/+1
| | | | | | | | | | | | | | | | What works: 1. Layout (for the most part) 2. Editing and saving the items What does not 1. Scroll 2. Delete/Add buttons 3. some layout quirks 4. collapsible editable sets. BUG=33026 TEST=none for now. Review URL: http://codereview.chromium.org/554081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37357 0039d316-1c4b-4281-b951-d872f2087c98
* Implement adding, updating and removing credit cards from the web database ↵jhawkins@chromium.org2010-01-251-5/+37
| | | | | | | | | | through the gtk AutoFill dialog. BUG=18201 TEST=WebDatabaseTest.CreditCard, PersonalDataManagerTest.SetCreditCards Review URL: http://codereview.chromium.org/555068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37036 0039d316-1c4b-4281-b951-d872f2087c98
* Notify the AutoFillManager when the user clicks "Apply" or "OK". Adds an ↵jhawkins@chromium.org2010-01-211-1/+2
| | | | | | | | | | AutoFillDialogObserver interface that is used to send the profile information back to clients. BUG=none TEST=none Review URL: http://codereview.chromium.org/555023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36779 0039d316-1c4b-4281-b951-d872f2087c98
* Add CreditCard, a form group that stores credit card information.jhawkins@chromium.org2010-01-061-0/+125
BUG=none TEST=none Review URL: http://codereview.chromium.org/518031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35645 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-19 01:28:00 +0000