summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill/form_group.h
Commit message (Collapse)AuthorAgeFilesLines
* Remove the rest of #pragma once in one big CL.ajwong@chromium.org2012-07-111-1/+0
| | | | | | | | | For context see this thread: https://groups.google.com/a/chromium.org/forum/?fromgroups#!topic/chromium-dev/RMcVNGjB4II TBR=thakis,pkasting,jam git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146163 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of non-shared methods out of the FormGroup class.isherman@chromium.org2011-10-051-20/+1
| | | | | | | | | | | | Some of them can be removed completely! BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8143007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104045 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show the "Save credit card for Autofill?" infobar unnecessarily.isherman@chromium.org2011-10-041-3/+0
| | | | | | | | | BUG=98968, 98991 TEST=unit_tests --gtest_filter=PersonalDataManager.*CreditCard* Review URL: http://codereview.chromium.org/8114031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@103994 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate Autofill possible type detection code, and enforce greater match ↵isherman@chromium.org2011-07-221-5/+22
| | | | | | | | | | | | | | | | | | precision. * Only consider submitted field values to match locally stored data if the strings match exactly + This means we will send fewer false positives to the server, at the cost of some false negatives. Most importantly, we should stop identifying ADDRESS_LINE_2 fields as ADDRESS_LINE_1. + There are a few excpetions for structured fields with canonicalized values, like countries (which are canonicalized to country codes) * Eliminate FormGroup::GetMatchingTypes() -- all of this work is now done in a consistent way within AutofillManager * Refactor FormGroup::GetNonEmptyTypes() to be shared code. BUG=81867, 76992 TEST=unit_tests --gtest_filter=AutofillManagerTest.DeterminePossibleFieldTypesForUpload Review URL: http://codereview.chromium.org/7398019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93582 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename FormGroup::GetPossibleFieldTypes() and ↵tfarina@chromium.org2011-05-091-4/+4
| | | | | | | | | | | | | | | | ::GetAvailableFieldTypes() to be clearer. GetPossibleFieldTypes() -> GetMatchingTypes(). GetAvailableFieldTypes() -> GetNonEmptyTypes(). BUG=81767 TEST=None R=dhollowa@chromium.org,isherman@chromium.org Review URL: http://codereview.chromium.org/6970005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84645 0039d316-1c4b-4281-b951-d872f2087c98
* Prune dead code: FormGroup::FindInfoMatches(), FormGroup::GetPreviewText()isherman@chromium.org2011-03-311-11/+0
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6783009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80099 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill rename GetFieldText to GetInfodhollowa@chromium.org2011-03-171-1/+1
| | | | | | | | | | | Renames AutofillProfile::GetFieldText to AutofillProfile::GetInfo. To match SetInfo. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78622 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce boxing and unboxing of AutofillFieldTypeisherman@chromium.org2011-03-171-5/+4
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6673079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78518 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill extend profiles to include multi-valued fields, part 2.dhollowa@chromium.org2011-03-091-3/+0
| | | | | | | | | | | No functional change. This partitions the |ContactInfo| class into separate name, email, and company parts. AutoFillProfile is changed to store its component members directly instead of in a map (in preparation for multiple values). And the |Clone| operation is deprecated from the |FormGroup| class on down through the inheritance tree. BUG=65625 TEST=All existing unit tests. Review URL: http://codereview.chromium.org/6650014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77425 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillType to AutofillType.tfarina@chromium.org2011-03-071-5/+5
| | | | | | | | | BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6626042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77140 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillFieldType to AutofillFieldType.tfarina@chromium.org2011-03-011-1/+1
| | | | | | | | | BUG=72758 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/6592067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76442 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill form submission creates wrong credit cards.dhollowa@chromium.org2010-11-111-0/+3
| | | | | | | | | | | Adds logic to filter out credit card submissions that are invalid, or to merge credit cards that match the card number. BUG=57975 TEST=PersonalDataManagerTest.Aggregate* Review URL: http://codereview.chromium.org/4734001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65830 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill deprecate unique_ids in favor of guids for Mac UIdhollowa@chromium.org2010-10-271-1/+1
| | | | | | | | | | | Removes use of labels and unique_ids in the Mac UI for Autofill. BUG=58813 TEST=AutoFillAddressModelTest.*:AutoFillAddressSheetControllerTest.*:AutoFillCreditCardModelTest.*:AutoFillDialogControllerTest.* Review URL: http://codereview.chromium.org/4110004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64073 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more ctor/virtual deinlining.erg@google.com2010-10-191-4/+2
| | | | | | | | | | | (Only 424k off Linux debug .a files). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Save the imported credit card data in response to the CC InfoBar.jhawkins@chromium.org2010-07-121-0/+15
| | | | | | | | | BUG=47428 TEST=none Review URL: http://codereview.chromium.org/2965007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52141 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Aggregate profile data. Remove the AutoFill InfoBar. Remove more ↵jhawkins@chromium.org2010-07-011-1/+5
| | | | | | | | | | | remnants of shipping address and CVV. BUG=47426,47423 TEST=PersonalDataManager.* Review URL: http://codereview.chromium.org/2818033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
* Add more tests for BillingAddress and fix the issues found by the tests.jhawkins@chromium.org2010-03-051-1/+2
| | | | | | | | BUG=none TEST=BillingAddressTest Review URL: http://codereview.chromium.org/669141 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40787 0039d316-1c4b-4281-b951-d872f2087c98
* Where possible, use return-by-const-ref for accessors in AutoFill data ↵jhawkins@chromium.org2010-03-031-1/+1
| | | | | | | | | | structures. In addition, I fixed the access levels of many of the modified methods. BUG=31775 TEST=none Review URL: http://codereview.chromium.org/661421 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40477 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most uses of EmptyString(), EmptyWString(), EmptyString16(), and ↵pkasting@chromium.org2010-01-081-1/+1
| | | | | | | | | | EmptyGURL(), since the code in question can just use the default constructor. BUG=none TEST=none Review URL: http://codereview.chromium.org/517054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35766 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ContactInfo, the FormGroup that stores contact information.jhawkins@chromium.org2010-01-041-2/+5
| | | | | | | | BUG=none TEST=StringUtilTest.Tokenizer Review URL: http://codereview.chromium.org/502103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35475 0039d316-1c4b-4281-b951-d872f2087c98
* Add FormGroup, an interface that represents a collection of form fields ↵jhawkins@chromium.org2009-12-221-0/+52
grouped by type. BUG=none TEST=none Review URL: http://codereview.chromium.org/509014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35131 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-28 22:51:17 +0000