summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill/phone_field.cc
Commit message (Collapse)AuthorAgeFilesLines
* AutoFill: Use DISALLOW_COPY_AND_ASSIGN where possible.jhawkins@chromium.org2010-06-211-16/+9
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2872008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50332 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] more -Wextra support:thomasvl@chromium.org2010-06-171-1/+2
| | | | | | | | | | | | - autofill: explicitly initialize in the copy constructor - make some loops clearly use {} for empty bodies - bump up app mode version number to 1.0 so we don't check for < 0 on the unsigned version number. BUG=34160 TEST=none Review URL: http://codereview.chromium.org/2856006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50095 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill telephone number prefix and suffix heuristics.dhollowa@chromium.org2010-05-201-2/+2
| | | | | | | | | | | Extends matching of telephone number prefix and suffix fields to include fields explicitly labeled with "prefix" and "suffix" strings. BUG=40694 TEST=PhoneFieldTest.ThreePartPhoneNumberPrefixSuffix Review URL: http://codereview.chromium.org/2129016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47829 0039d316-1c4b-4281-b951-d872f2087c98
* Form AutoFill Phone number should be displayed as xxx-xxx-xxxxdhollowa@chromium.org2010-05-141-3/+17
| | | | | | | | | | | | | | | | | Modifies the AutoFill label inferencing logic to skip over <img> tags when deriving labels. It is common to use small images as spacers between elements. Also, extends the phone number heuristics to recognize numbers that are split into three fields of the form [xxx]-[yyy]-[zzzz] where xxx is the area code, yyy is the phone number prefix and zzz is the phone number suffix. Note: This change has a dependency on WebKit change: https://bugs.webkit.org/show_bug.cgi?id=38825. Will need to wait for that to land before committing this change. BUG=38218 TEST=FormManagerTest.LabelsInferredWithImageTags:FormStructureTest.ThreePartPhoneNumber:PhoneFieldTest.ThreePartPhoneNumber Review URL: http://codereview.chromium.org/1979008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47297 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill crash in FormStructure::GetHeuristicAutoFillTypes().dhollowa@chromium.org2010-04-221-0/+7
| | | | | | | | | | | | Fixes over-delete in FormStructure::GetHeuristicFieldInfo and adds defensive checks for NULL in FormStructure::GetHeuristicAutoFillTypes(). Also makes explicit copy constructors for various form field types. BUG=42211 TEST=FormStructureTest Review URL: http://codereview.chromium.org/1744005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45333 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill phone field unit tests.dhollowa@chromium.org2010-03-151-0/+4
| | | | | | | | | | | Adds unit tests for AutoFill phone_field.cc/h. Coverage for Ecml and heuristic based phone field matching. BUG=none TEST=PhoneFieldTest Review URL: http://codereview.chromium.org/985002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41625 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill field parser fixes.dhollowa@chromium.org2010-03-111-2/+2
| | | | | | | | | | | This fixes a number of form field parsing issues. Ecml field name matching. Adds country field parsing. Adds state field parsing. Multi-line address parsing. Fixes issue with empty field names confusing the parser. Fixes issue with phone field parsing. Adds unit tests in form_structure_unittest.cc to verify parsing order issues. Adds new unit tests address_field_unittest.cc that cover parsing of each address component as well as Ecml variants. BUG=37776 TEST=FormStructureTest.Heuristics:AddressFieldTest.*, as well as manual steps described in bug report. Review URL: http://codereview.chromium.org/867003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41331 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a few pieces of the heuristic autofill:jhawkins@chromium.org2010-01-081-1/+1
| | | | | | | | | | | | * Escape a parenthesis. * Add firstname, lastname to the regular expressions for first and last name fields. * Compare the result of WebRegularExpression.match to -1 to mean not found. BUG=none TEST=none Review URL: http://codereview.chromium.org/530006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35822 0039d316-1c4b-4281-b951-d872f2087c98
* Implement PhoneField, a FormField that matches a phone number field in a form.jhawkins@chromium.org2009-12-111-0/+114
BUG=none TEST=none Review URL: http://codereview.chromium.org/488010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34311 0039d316-1c4b-4281-b951-d872f2087c98