summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill/phone_number.cc
Commit message (Collapse)AuthorAgeFilesLines
* Consolidate Autofill possible type detection code, and enforce greater match ↵isherman@chromium.org2011-07-221-109/+129
| | | | | | | | | | | | | | | | | | precision. * Only consider submitted field values to match locally stored data if the strings match exactly + This means we will send fewer false positives to the server, at the cost of some false negatives. Most importantly, we should stop identifying ADDRESS_LINE_2 fields as ADDRESS_LINE_1. + There are a few excpetions for structured fields with canonicalized values, like countries (which are canonicalized to country codes) * Eliminate FormGroup::GetMatchingTypes() -- all of this work is now done in a consistent way within AutofillManager * Refactor FormGroup::GetNonEmptyTypes() to be shared code. BUG=81867, 76992 TEST=unit_tests --gtest_filter=AutofillManagerTest.DeterminePossibleFieldTypesForUpload Review URL: http://codereview.chromium.org/7398019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93582 0039d316-1c4b-4281-b951-d872f2087c98
* Another performance improvement for phone library - at least +25% to ↵georgey@chromium.org2011-06-241-38/+23
| | | | | | | | | | | previous cl (982ms for 100 items DB test comared to 1251ms) But feels like much more as the penalty shifted to DB thread. TEST=The caching object is tested by multiple AutofillManager, PersonalDataManager, etc. unittests + new unit-test to test performance. BUG=85152 Review URL: http://codereview.chromium.org/7044102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90434 0039d316-1c4b-4281-b951-d872f2087c98
* Improved performance of profile merginggeorgey@chromium.org2011-06-031-31/+36
| | | | | | | | | AutofillMergeTest.DataDrivenMergeProfiles Average of 5 runs before change 5388.4ms, after change 2890.4 -46% speed improvement BUG=84684 TEST=unit-test Review URL: http://codereview.chromium.org/7109023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@87755 0039d316-1c4b-4281-b951-d872f2087c98
* Last major phone library change for M13georgey@chromium.org2011-05-271-19/+2
| | | | | | | | BUG=80102 TEST=unit-tested Review URL: http://codereview.chromium.org/7069024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86987 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill phone number enhancements and integration of Phone Number Util ↵georgey@chromium.org2011-05-231-126/+186
| | | | | | | | | | Library: part 3 BUG=71443 TEST=unit-tested Review URL: http://codereview.chromium.org/6877130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86305 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename FormGroup::GetPossibleFieldTypes() and ↵tfarina@chromium.org2011-05-091-14/+14
| | | | | | | | | | | | | | | | ::GetAvailableFieldTypes() to be clearer. GetPossibleFieldTypes() -> GetMatchingTypes(). GetAvailableFieldTypes() -> GetNonEmptyTypes(). BUG=81767 TEST=None R=dhollowa@chromium.org,isherman@chromium.org Review URL: http://codereview.chromium.org/6970005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84645 0039d316-1c4b-4281-b951-d872f2087c98
* Address some style nits with Autofill metricsisherman@chromium.org2011-04-291-8/+11
| | | | | | | | | | | Addressing Jim's nits from http://codereview.chromium.org/6820062/ BUG=none TEST=none Review URL: http://codereview.chromium.org/6897030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83459 0039d316-1c4b-4281-b951-d872f2087c98
* Add per-field-type Autofill quality metrics.isherman@chromium.org2011-04-181-22/+14
| | | | | | | | | BUG=none TEST=unit_tests --gtest_filter=AutofillMetrics* Review URL: http://codereview.chromium.org/6820062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81987 0039d316-1c4b-4281-b951-d872f2087c98
* Prune dead code: FormGroup::FindInfoMatches(), FormGroup::GetPreviewText()isherman@chromium.org2011-03-311-54/+0
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6783009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80099 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename all the entries remaining with AutoFill to Autofill.tfarina@chromium.org2011-03-211-4/+4
| | | | | | | | | | R=isherman@chromium.org,dhollowa@chromium.org BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6688053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78856 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill rename GetFieldText to GetInfodhollowa@chromium.org2011-03-171-1/+1
| | | | | | | | | | | Renames AutofillProfile::GetFieldText to AutofillProfile::GetInfo. To match SetInfo. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78622 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce boxing and unboxing of AutofillFieldTypeisherman@chromium.org2011-03-171-12/+11
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6673079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78518 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill extend profiles to include multi-valued fields, part 2.dhollowa@chromium.org2011-03-091-8/+14
| | | | | | | | | | | No functional change. This partitions the |ContactInfo| class into separate name, email, and company parts. AutoFillProfile is changed to store its component members directly instead of in a map (in preparation for multiple values). And the |Clone| operation is deprecated from the |FormGroup| class on down through the inheritance tree. BUG=65625 TEST=All existing unit tests. Review URL: http://codereview.chromium.org/6650014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77425 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillType to AutofillType.tfarina@chromium.org2011-03-071-20/+20
| | | | | | | | | BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6626042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77140 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillFieldType to AutofillFieldType.tfarina@chromium.org2011-03-011-1/+1
| | | | | | | | | BUG=72758 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/6592067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@76442 0039d316-1c4b-4281-b951-d872f2087c98
* FBTF: Even more ctor/virtual deinlining.erg@google.com2010-10-191-0/+4
| | | | | | | | | | | (Only 424k off Linux debug .a files). BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3859003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63059 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Aggregate profile data. Remove the AutoFill InfoBar. Remove more ↵jhawkins@chromium.org2010-07-011-2/+22
| | | | | | | | | | | remnants of shipping address and CVV. BUG=47426,47423 TEST=PersonalDataManager.* Review URL: http://codereview.chromium.org/2818033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Remove an out-dated comment. We will not support phone extensions.jhawkins@chromium.org2010-06-191-3/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2811017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50307 0039d316-1c4b-4281-b951-d872f2087c98
* New autofill UI. Still not done:georgey@chromium.org2010-06-031-4/+5
| | | | | | | | | | 1. Countries ComboBox - need countries list. 2. Correct icons size. TEST=in the mocks. BUG=37816,39238,41232,41793,36601 Review URL: http://codereview.chromium.org/2500002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48849 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for autofill crash (all systems) - created unit tests for all touched ↵georgey@chromium.org2010-05-251-3/+3
| | | | | | | | | | code as well. BUG=44594 TEST=in the bug: the phone should be *empty* (or shorter than 3 characters) to cause the old crash. Review URL: http://codereview.chromium.org/2066013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48156 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill: Implement set_whole_number and use it to load whole phone numbers ↵jhawkins@chromium.org2010-03-171-0/+10
| | | | | | | | | | from the WebDB. BUG=38218 TEST=WebDatabaseTest.AutoFillProfile Review URL: http://codereview.chromium.org/1043003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41872 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill phone number parser changes.dhollowa@chromium.org2010-03-041-5/+57
| | | | | | | | | | | Moved the PersonalDataManager::ParsePhoneNumber() method into the PhoneNumber class. Made some bug fixes to the parser. Extended its functionality to strip separator characters. Added unit tests to cover the parser. BUG=none TEST=PhoneNumberTest Review URL: http://codereview.chromium.org/669026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40655 0039d316-1c4b-4281-b951-d872f2087c98
* linux: build with -Wextraevan@chromium.org2010-02-051-1/+2
| | | | | | | | | | | | 95% of this is removing "const" from return types, but turning this on found one bug! (A "for" loop that expected its iterator to go negative but which was using an unsigned type.) BUG=34160 Review URL: http://codereview.chromium.org/570012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38266 0039d316-1c4b-4281-b951-d872f2087c98
* Implement RemoveChars, a function to remove a list of characters from a ↵jhawkins@chromium.org2010-02-051-1/+1
| | | | | | | | | | string, and use it in PhoneNumber to remove extra phone number characters. BUG=none TEST=StringUtilTest.RemoveChars Review URL: http://codereview.chromium.org/572015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38162 0039d316-1c4b-4281-b951-d872f2087c98
* Add PhoneNumber, a form group that stores phone numbers.jhawkins@chromium.org2010-01-071-0/+216
BUG=none TEST=none Review URL: http://codereview.chromium.org/523100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35670 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-09 03:54:16 +0000