| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
| |
These changes merge popup menu suggestions for Autocomplete and AutoFill. Suggestions are collected from both sources and returned to the renderer as a single list. This combined list is given to WebKit to display in the suggestions popup. When the user selects an item in the popup the appropriate result gets filled in the fields.
BUG=41328
TEST=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/2878020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51736 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
These changes conditionally turn off auxiliary profiles at compile time for non-Mac platforms.
BUG=48217
TEST=Manual test on Windows: Surf to a form and trigger AutoFill suggestions.
Review URL: http://codereview.chromium.org/2832049
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51586 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
AutoFill dialog
These changes remove the AutoFill enabled radio buttons from the Preferences dialog and adds a single checkbox to the AutoFill dialog to do same. Preferences.xib changes by removing the radio buttons and moving other controls up. AutoFillDialog.xib adds checkbox to control AutoFill enabled preference. Also, other controls in AutoFillDialg.xib now bind their enabled states to the value of the enabled checkbox.
BUG=47435
TEST=AutoFillDialogControllerTest.AutoFillEnabled*
Review URL: http://codereview.chromium.org/2799054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51581 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the header file resulting in
these objects being initialized wherever the form_field.h is included. All this happens during LoadLibrary of
chrome.dll.
Moving the definitions of the string objects to the source file.
Bug=48097
Review URL: http://codereview.chromium.org/2883016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
in a form that has already been auto-filled.
BUG=47436
TEST=AutoFillManagerTest.GetFieldSuggestionsWithDuplicateValues
Review URL: http://codereview.chromium.org/2855030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
remnants of shipping address and CVV.
BUG=47426,47423
TEST=PersonalDataManager.*
Review URL: http://codereview.chromium.org/2818033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Changes the default preference setting for Mac "me" card integration to be enabled.
BUG=46695
TEST=AutoFillDialogControllerTest.AuxiliaryProfilesTrue
Review URL: http://codereview.chromium.org/2800031
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51047 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds a link to http://www.google.com/support/chrome/bin/answer.py?answer=142893 on the AutoFill settings dialog.
Nib changes: Adds button with link cell connected to |openHelp:| action.
BUG=42780
TEST=manual, open dialog and click help button.
Review URL: http://codereview.chromium.org/2825027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51032 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=47422
TEST=none
Review URL: http://codereview.chromium.org/2852025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50879 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
field in an auto-filled form.
BUG=47437
TEST=AutoFillManagerTest.GetFieldSuggestionsFormIsAutoFilled
Review URL: http://codereview.chromium.org/2861025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50782 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2872008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50332 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2811017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50307 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2871014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50306 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2818016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50305 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2833020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=45616
TEST=AutoFillManagerTest.*
Review URL: http://codereview.chromium.org/2859006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50167 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- autofill: explicitly initialize in the copy constructor
- make some loops clearly use {} for empty bodies
- bump up app mode version number to 1.0 so we don't check for < 0 on the unsigned version number.
BUG=34160
TEST=none
Review URL: http://codereview.chromium.org/2856006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
dialog.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2799011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50054 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=46681
TEST=none
Review URL: http://codereview.chromium.org/2813015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50049 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Implements changes based on review feedback with Jeff. Validation icons should not appear in phone and fax input fields until text is input. Credit card expiration date year dropdown should list 10 years at most. CVC input fields are removed.
Nib changes to AutoFillCreditCardSheet.xib removes the CVC entry, associated label, and resize / relayout dialog to account for removal.
BUG=46681, 46635, 46634
TEST=Manual testing, AutoFillDialogControllerTest.*, AutoFillAddressViewControllerTest.*, AutoFillCreditCardViewControllerTest.*
Review URL: http://codereview.chromium.org/2873002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50008 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
TBR=thakis@chromium.org
Review URL: http://codereview.chromium.org/2835007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50000 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49984 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Removes collision with NAME_FULL checks in AutoFill code. Parallel implementations collided in the ether. These changes consolidate the implementations.
BUG=46625
TEST=ContactInfoTest.TestSetFullName
Review URL: http://codereview.chromium.org/2849008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49978 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
as being auto-fillable.
BUG=46463
TEST=AutoFillManagerTest.HiddenFields, FormManagerTest.LabelsHiddenFields,
FormManagerTest.LabelForElementHidden
Review URL: http://codereview.chromium.org/2809005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49753 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Modifies entry labels with trailing colon for Mac UI. Using correct validation icons now. Nib changes for AutoFillAddressSheet.xib and AutoFillCreditCardSheet.xib: rearranges labels and entry fields to right align on label colons. Changes label font to be regular size and regular weight.
BUG=46504
TEST=manual inspection of AutoFill UI.
Review URL: http://codereview.chromium.org/2842002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49734 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/2762013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49561 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
popup.
BUG=45144
TEST=none
Review URL: http://codereview.chromium.org/2773005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
typing in. This change also conveniently removes filling the default profile,
since this feature has been removed from AutoFill.
BUG=46219
TEST=FormManagerTest.FillFormNonEmptyField
Review URL: http://codereview.chromium.org/2766005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49454 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Build succeeds using 10.6 SDK
Review URL: http://codereview.chromium.org/2790005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49279 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
New mocks are attached to bug 44622. These changes replace the in-place editing of address and credit card records with a table of records and separate sheets for manipulating the record data. Changes to the layout of fields on the sheets has been done also.
AutoFillDialog.xib changes: Replaced disclosure based list of address and credit cards with an NSTableView of the same data. Added buttons for "Add", "Edit", and "Remove".
Replaced AutoFillAddressViewController.xib with sheet-based AutoFillAddressSheetController.xib.
Replaced AutoFillCreditCardViewController.xib with sheet-based AutoFillCreditCardSheetController.xib.
BUG=44621
TEST=AutoFillAddressModelTest,AutoFillAddressSheetControllerTest,AutoFillCreditCardModelTest,AutoFillCreditCardSheetControllerTest,AutoFillDialogControllerTest
Review URL: http://codereview.chromium.org/2673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49274 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
remove handling of the default profile, which is no longer a part of the
feature.
BUG=41645
TEST=none
Review URL: http://codereview.chromium.org/2751001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49226 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Revert 49164 - Backing this out to see if it fixes the failures on the two windows bots (landed about when they started).
Revert 49030 AutoFill: Don't save credit card numbers from Autocomplete to the WebDB.
BUG=8026
TEST=AutocompleteHistoryManagerTest
Review URL: http://codereview.chromium.org/2676003
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/2748002
TBR=thomasvl@chromium.org
Review URL: http://codereview.chromium.org/2770001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49165 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
(landed about when they started).
Revert 49030 - AutoFill: Don't save credit card numbers from Autocomplete to the WebDB.
BUG=8026
TEST=AutocompleteHistoryManagerTest
Review URL: http://codereview.chromium.org/2676003
TBR=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/2748002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=44622
TEST=in the bug
Review URL: http://codereview.chromium.org/2638003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49108 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=8026
TEST=AutocompleteHistoryManagerTest
Review URL: http://codereview.chromium.org/2676003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49030 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is because NativeDialogHost sends GTK_RESPONSE_DELETE_EVENT and autofill dialog does not handle it.
BUG=chromium-os:3816
TEST=Verify fix for chromium-os:3816.
Review URL: http://codereview.chromium.org/2655004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=40617
TEST=none
Review URL: http://codereview.chromium.org/2521001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48858 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
1. Countries ComboBox - need countries list.
2. Correct icons size.
TEST=in the mocks.
BUG=37816,39238,41232,41793,36601
Review URL: http://codereview.chromium.org/2500002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48849 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48798
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48811 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
TBR=sergeyu@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48800 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Chrome Sync works
Review URL: http://codereview.chromium.org/2255007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48798 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=41234
TEST=none
Review URL: http://codereview.chromium.org/2464002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
The new AutoFill dialog mocks eliminate the need for a "default" address and credit card. Removing code related to UI for these defaults. Nib changes: Removed the "Default" radio button from each of the Nibs.
BUG=44621
TEST=AutoFillDialogControllerTest.*:-AutoFillDialogControllerTest.DefaultsChangingLogic
Review URL: http://codereview.chromium.org/2466002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48687 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The mcphee.com site demonstrates two issues. One is label scraping for forms that use <dl> <dt> and <dd> elements to partition labels and input elements. The other is dynamic html where JavaScript is used to manipulate the form elements dynamically as the user proceeds through checkout. These changes address both. Label scraping is implemented for <dl> <dt> and <dd> elements. Form filling, both at the FormManager and AutoFillManager levels are now more robust in the face of changing form structure between the time of page load and form fill.
This does not "fix" the mcphee page though, as we still do not fill the elements that are added to the page after the initial page load.
BUG=44323
TEST=AutoFillManagerTest.FormChangesRemoveField, AutoFillManagerTest.FormChangesAddField, FormManagerTest.LabelsInferredFromTableCellNested, FormManagerTest.LabelsInferredFromDefinitionList, FormManagerTest.FillFormChangedFormDataFields, manual tests using mphee.html and mcphee2.html sample files attached to bug report and original bug steps using live mcphee checkout.
Review URL: http://codereview.chromium.org/2240004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48429 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
code as well.
BUG=44594
TEST=in the bug: the phone should be *empty* (or shorter than 3 characters) to cause the old crash.
Review URL: http://codereview.chromium.org/2066013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Trivial change to test commit from alternate network.
BUG=none
TEST=none
TBR=georgey@chromium.org
Review URL: http://codereview.chromium.org/2117028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48012 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Extends matching of telephone number prefix and suffix fields to include fields explicitly labeled with "prefix" and "suffix" strings.
BUG=40694
TEST=PhoneFieldTest.ThreePartPhoneNumberPrefixSuffix
Review URL: http://codereview.chromium.org/2129016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47829 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
address.
Fixes address type matching in |AddressField::AddressTypeFromText| method. Also, extends |AutoFillManager::FillAutoFillFormData| method to fill associated billing address when filling a credit card that has billing information set in preferences. Adds new unit test AutoFillManagerTest.FillCreditCardFormWithBilling and fixes others.
BUG=44227
TEST=AddressFieldTest.ParseOneLineAddress, \
AddressFieldTest.ParseOneLineAddressBilling, \
AddressFieldTest.ParseOneLineAddressShipping, \
AutoFillManagerTest.FillCreditCardForm, \
AutoFillManagerTest.FillCreditCardFormWithBilling, \
FormStructureTest.HeuristicsSample8, \
and manual test with everything2.html bug file.
Review URL: http://codereview.chromium.org/2078016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47731 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The lego.com page represents a couple different issues. (1) is that the address fields are identified as billing address fields. So when filling from a profile and not a credit card those fields did not get filled. Based on discussion with Jeff Chang we're changing this so that when filling a profile, billing fields get treated as normal address fields and will be filled. In the code the distinction of billing versus "home" address information has now been removed as it is no longer applicable. (2) Company fields now get heuristically matched and filled.
BUG=40683
TEST=Manual testing of https://shop.lego.com/Checkout/Address/, \
Unit tests: AddressFieldTest.ParseCompany, AddressFieldTest.ParseCompanyEcml \
FormStructureTest.HeuristicsWithBilling FormStructureTest.HeuristicsSample6
Review URL: http://codereview.chromium.org/2085006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47331 0039d316-1c4b-4281-b951-d872f2087c98
|