summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill
Commit message (Collapse)AuthorAgeFilesLines
* Remove overly defensive NOTREACHED()isherman@chromium.org2011-07-261-2/+2
| | | | | | | | | | BUG=87214 TEST=none Review URL: http://codereview.chromium.org/7489026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94200 0039d316-1c4b-4281-b951-d872f2087c98
* Don't consider repeated fields (adjacent fields of the same type) to be ↵isherman@chromium.org2011-07-262-9/+70
| | | | | | | | | | | | section breaks for Autofill BUG=75124 TEST=AutofillTest.AutofillFormWithRepeatedField Review URL: http://codereview.chromium.org/7488037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94051 0039d316-1c4b-4281-b951-d872f2087c98
* Do not try to Autofill "nickname" or "maiden name" fields.isherman@chromium.org2011-07-252-7/+13
| | | | | | | | | | BUG=52198 TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics* Review URL: http://codereview.chromium.org/7493033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93974 0039d316-1c4b-4281-b951-d872f2087c98
* Show all multi-valued suggestions for the initiating field for Autofillisherman@chromium.org2011-07-252-26/+65
| | | | | | | | | | BUG=87333 TEST=unit_tests --gtest_filter=AutofillManager.GetFieldSuggestionsForMultiValuedProfileUnfilled Review URL: http://codereview.chromium.org/7492033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93972 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Autofill Feedback infobar in preparation for the branch.isherman@chromium.org2011-07-231-3/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7484044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93751 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an old TODOisherman@chromium.org2011-07-231-1/+0
| | | | | | | | | | | | (I changed my mind, there's no particular reason to push this logic out to clients of the function.) BUG=none TEST=none Review URL: http://codereview.chromium.org/7488005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93747 0039d316-1c4b-4281-b951-d872f2087c98
* Consolidate Autofill possible type detection code, and enforce greater match ↵isherman@chromium.org2011-07-2230-964/+854
| | | | | | | | | | | | | | | | | | precision. * Only consider submitted field values to match locally stored data if the strings match exactly + This means we will send fewer false positives to the server, at the cost of some false negatives. Most importantly, we should stop identifying ADDRESS_LINE_2 fields as ADDRESS_LINE_1. + There are a few excpetions for structured fields with canonicalized values, like countries (which are canonicalized to country codes) * Eliminate FormGroup::GetMatchingTypes() -- all of this work is now done in a consistent way within AutofillManager * Refactor FormGroup::GetNonEmptyTypes() to be shared code. BUG=81867, 76992 TEST=unit_tests --gtest_filter=AutofillManagerTest.DeterminePossibleFieldTypesForUpload Review URL: http://codereview.chromium.org/7398019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93582 0039d316-1c4b-4281-b951-d872f2087c98
* Don't learn credit cards for Autofill if they are missing any data.isherman@chromium.org2011-07-225-78/+119
| | | | | | | | | BUG=89990 TEST=unit_tests --gtest_filter=PersonalDataManagerTest.AggregateCreditCardWithMissingInfoInNew Review URL: http://codereview.chromium.org/7465019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93548 0039d316-1c4b-4281-b951-d872f2087c98
* Disable Autofill server queries for forms with only <select> fields.isherman@chromium.org2011-07-222-0/+87
| | | | | | | | | | BUG=89986 TEST=FormStructureTest.ShouldBeParsed Review URL: http://codereview.chromium.org/7471029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93539 0039d316-1c4b-4281-b951-d872f2087c98
* Don't save default form field values for Autofillisherman@chromium.org2011-07-224-54/+108
| | | | | | | | | | BUG=89253 TEST=AutofillManagerTest.FormSubmittedWithDefaultValues Review URL: http://codereview.chromium.org/7473023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93538 0039d316-1c4b-4281-b951-d872f2087c98
* Deprecate Profile::GetDefaultRequestContext().willchan@chromium.org2011-07-201-1/+1
| | | | | | | | | | | | Make it private and establish a friend whitelist for existing users. BUG=64339 TEST=none Review URL: http://codereview.chromium.org/7438002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93200 0039d316-1c4b-4281-b951-d872f2087c98
* Remove Autofill Feedback infobar for forms with >100 fieldsisherman@chromium.org2011-07-201-39/+0
| | | | | | | | | | | | This infobar has been useful, but the marginal utility of leaving it active is low. BUG=88791 TEST=none Review URL: http://codereview.chromium.org/7457013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93164 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some more form signatures from the hunt for top Autofill forms.isherman@chromium.org2011-07-201-3/+0
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7411003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93163 0039d316-1c4b-4281-b951-d872f2087c98
* some cleanup for base/stl_utildilmah@chromium.org2011-07-194-4/+4
| | | | | | | | | | | | | removed unused/irrelevant functions removed irrelevant comments Moved stl_util-inl.h => stl_util.h BUG=None TEST=None Review URL: http://codereview.chromium.org/7342047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some additional signatures from the Autofill top forms hunt.isherman@chromium.org2011-07-161-10/+0
| | | | | | | | | | | | Forms include: twitter settings, Czech email client, Russian email client, Facebook pages, DeviantArt, and formspring.me BUG=none TEST=none Review URL: http://codereview.chromium.org/7397006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92780 0039d316-1c4b-4281-b951-d872f2087c98
* Add "pais" for country in SpanishTakano.Naoki@gmail.com2011-07-141-1/+1
| | | | | | | | | | BUG=76301 TEST=20_register_epson.com.mx.html Review URL: http://codereview.chromium.org/7354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92613 0039d316-1c4b-4281-b951-d872f2087c98
* Add Autofill Feedback infobar for forms with >100 fieldsisherman@chromium.org2011-07-141-3/+42
| | | | | | | | | | BUG=88791 TEST=Navigate to https://www.corp.google.com/~isherman/no_crawl/scratch/100fields.html, see infobar. Review URL: http://codereview.chromium.org/7354008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92473 0039d316-1c4b-4281-b951-d872f2087c98
* Remove several top sites' form signatures from list of unknown top Autofill ↵isherman@chromium.org2011-07-141-8/+0
| | | | | | | | | | | | | | forms Sites include: 4chan, reddit, tumblr, facebook, blogger, and Google Translate BUG=none TEST=none Review URL: http://codereview.chromium.org/7352002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92472 0039d316-1c4b-4281-b951-d872f2087c98
* Tighten up two Autofill postal code regexes to require word boundariesisherman@chromium.org2011-07-131-1/+1
| | | | | | | | | | BUG=77678 TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics15 Review URL: http://codereview.chromium.org/7347002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92288 0039d316-1c4b-4281-b951-d872f2087c98
* Fix apellido from proral to singular in last name matching pattern.Takano.Naoki@gmail.com2011-07-122-1/+9
| | | | | | | | | | | | Epson.com.mx's last name uses "apellido" in last name matching pattern. So I change it from proral to singular. BUG=76301 TEST=Run FormStructureBrowserTest.DataDrivenHeuristics20 Review URL: http://codereview.chromium.org/7334002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92157 0039d316-1c4b-4281-b951-d872f2087c98
* When Autofilling <select> elements, consider both the element's value and ↵isherman@chromium.org2011-07-122-25/+82
| | | | | | | | | | | | its contents. BUG=76544, 78801, 85006 TEST=unit_tests --gtest_filter=SelectControlHandlerTest.* Review URL: http://codereview.chromium.org/7324019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92156 0039d316-1c4b-4281-b951-d872f2087c98
* Improve Autofill heuristics to work with kneedraggers.comisherman@chromium.org2011-07-121-1/+1
| | | | | | | | | | BUG=40687 TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics15 Review URL: http://codereview.chromium.org/7237043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92149 0039d316-1c4b-4281-b951-d872f2087c98
* Moving notification types which are chrome specific to a new header file ↵ananta@chromium.org2011-07-104-15/+15
| | | | | | | | | | | | | chrome_notification_types.h. This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END which defines the end of the enum used by content to define notification types. The notificaton_type.h file in content\common has been renamed to content_notification_types.h BUG=76698 Review URL: http://codereview.chromium.org/7327007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
* Change the order of company and normal address line checks.Takano.Naoki@gmail.com2011-07-071-3/+3
| | | | | | | | | | | | | | Change the order of company and normal address line checks. Because in the label of address line1, there might be "company". BUG=64569 FIX=Run 15_crbug_64569.html TEST= Review URL: http://codereview.chromium.org/7277079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91667 0039d316-1c4b-4281-b951-d872f2087c98
* Add flag to enable Autofill prompt for additional user feedback.isherman@chromium.org2011-07-023-0/+211
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7273088 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91399 0039d316-1c4b-4281-b951-d872f2087c98
* Add "ccfullname" for credit card holder name matching pattern.Takano.Naoki@gmail.com2011-07-013-1/+21
| | | | | | | | | | | | "CCFullName" matches general name pattern, so Added "ccfullname" for credit card holder name matching pattern. BUG=64569 TEST=CreditCardFieldTest.ParseCreditCardHolderNameWithCCFullName or run 15_crbug_64569.html Review URL: http://codereview.chromium.org/7218070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91261 0039d316-1c4b-4281-b951-d872f2087c98
* Multiprofile: Remove AllSources() usage on CONTENT_SETTINGS_CHANGED.erg@chromium.org2011-06-282-3/+14
| | | | | | | | | | BUG=87457 TEST=none Review URL: http://codereview.chromium.org/7277013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90852 0039d316-1c4b-4281-b951-d872f2087c98
* Added <cc>:3 - <phone>:10 matching pattern for phone field.Takano.Naoki@gmail.com2011-06-283-1/+43
| | | | | | | | | | | | To detect 3 country code number and 10 phone number combination, added the matching pattern in phone field. BUG=76331 TEST=Run 13_register_supershuttle.com.html Review URL: http://codereview.chromium.org/7239019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90716 0039d316-1c4b-4281-b951-d872f2087c98
* Don't upload crowdsourcing data to Autofill server if no local data is ↵isherman@chromium.org2011-06-271-4/+8
| | | | | | | | | | | | available. BUG=none TEST=none Review URL: http://codereview.chromium.org/7262016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90667 0039d316-1c4b-4281-b951-d872f2087c98
* Another performance improvement for phone library - at least +25% to ↵georgey@chromium.org2011-06-244-90/+201
| | | | | | | | | | | previous cl (982ms for 100 items DB test comared to 1251ms) But feels like much more as the penalty shifted to DB thread. TEST=The caching object is tested by multiple AutofillManager, PersonalDataManager, etc. unittests + new unit-test to test performance. BUG=85152 Review URL: http://codereview.chromium.org/7044102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90434 0039d316-1c4b-4281-b951-d872f2087c98
* Make ConfirmInfoBarDelegate::GetLinkText() const.pkasting@chromium.org2011-06-242-2/+2
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/7236017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90309 0039d316-1c4b-4281-b951-d872f2087c98
* Show Autofill predictions when flag is enabled even when no Autofill ↵isherman@chromium.org2011-06-241-4/+2
| | | | | | | | | | | | profiles are available. BUG=none TEST=none Review URL: http://codereview.chromium.org/7248022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90308 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90103 - Revert 90034 - Autofill heuristics checkout files for ↵dhollowa@chromium.org2011-06-223-8/+14
| | | | | | | | | | | | | | | | | | | 06_checkout_urbanoutfitters.com.html Extends heuristics engine to look at field values. Tweaks regexes to match idioms in this form. BUG=86606 TEST=FormStructureBrowserTest.* with 06_checkout_urbanoutfitters.com.html Review URL: http://codereview.chromium.org/7206069 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/7236003 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/7236008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90132 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 90034 - Autofill heuristics checkout files for ↵dhollowa@chromium.org2011-06-223-14/+8
| | | | | | | | | | | | | | | | 06_checkout_urbanoutfitters.com.html Extends heuristics engine to look at field values. Tweaks regexes to match idioms in this form. BUG=86606 TEST=FormStructureBrowserTest.* with 06_checkout_urbanoutfitters.com.html Review URL: http://codereview.chromium.org/7206069 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/7236003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90103 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 06_checkout_urbanoutfitters.com.htmldhollowa@chromium.org2011-06-223-8/+14
| | | | | | | | | | | Extends heuristics engine to look at field values. Tweaks regexes to match idioms in this form. BUG=86606 TEST=FormStructureBrowserTest.* with 06_checkout_urbanoutfitters.com.html Review URL: http://codereview.chromium.org/7206069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90034 0039d316-1c4b-4281-b951-d872f2087c98
* Add Autofill metric logging for uploads corresponding to forms with no ↵isherman@chromium.org2011-06-222-1/+8
| | | | | | | | | | | | server response. BUG=none TEST=none Review URL: http://codereview.chromium.org/7216006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89973 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 06_checkout_qvc.com.htmldhollowa@chromium.org2011-06-221-3/+3
| | | | | | | | | | | Changes regex strings to match phone prefix and extension. Adds <li> label inferencing. BUG=86603 TEST=FormStructureBrowserTest.* with 06_checkout_qvc.com.html Review URL: http://codereview.chromium.org/7206048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89953 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 04_checkout_jcrew.com.htmldhollowa@chromium.org2011-06-224-20/+43
| | | | | | | | | | | Adds inferencing logic to scan backwards a table-row. Fixes fallout: heuristic order of first, middle, last names. And billing versus shipping logic for addresses. BUG=86602 TEST=FormStructureBrowserTest.* with 04_checkout_jcrew.com.html Review URL: http://codereview.chromium.org/7210026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89940 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 03_checkout_gamestop.com.htmldhollowa@chromium.org2011-06-211-1/+1
| | | | | | | | | | | Restricts phone extension regex. It was overly matchy. BUG=86599 TEST=FormStructureBrowserTest.* with 03_checkout_gamestop.com.html Review URL: http://codereview.chromium.org/7200034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89788 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 02_checkout_cafepress.comdhollowa@chromium.org2011-06-211-1/+1
| | | | | | | | | | | Extends full name regex to match billName and shipName found in this form. BUG=86586 TEST=FormStructureBrowserTest.* with 02_checkout_cafepress.com.html Review URL: http://codereview.chromium.org/7206012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89787 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics enable tests for 07_*.comdhollowa@chromium.org2011-06-211-0/+8
| | | | | | | | | | | Enables tests for 07_*.com BUG=86402 TEST=FormStructureBrowserTest.* with 07_*.com.html Review URL: http://codereview.chromium.org/7189062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89771 0039d316-1c4b-4281-b951-d872f2087c98
* Add a debugging flag to annotate web forms with their Autofill field type ↵isherman@chromium.org2011-06-203-3/+76
| | | | | | | | | | | | | predictions. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=89716 Review URL: http://codereview.chromium.org/7187029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89745 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89716 - Add a debugging flag to annotate web forms with their ↵isherman@chromium.org2011-06-203-76/+3
| | | | | | | | | | | | | | Autofill field type predictions. BUG=none TEST=none Review URL: http://codereview.chromium.org/7187029 TBR=isherman@chromium.org Review URL: http://codereview.chromium.org/7204037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89720 0039d316-1c4b-4281-b951-d872f2087c98
* Add a debugging flag to annotate web forms with their Autofill field type ↵isherman@chromium.org2011-06-203-3/+76
| | | | | | | | | | | predictions. BUG=none TEST=none Review URL: http://codereview.chromium.org/7187029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89716 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 89611 - Autofill DataDrivenHeuristics tests fail on Windowsdhollowa@chromium.org2011-06-181-20/+32
| | | | | | | | | | | | | | Reenables heuristics tests on Windows. Tests run faster now after r89396. BUG=85276 TEST=FormStructureBrowserTest.* Review URL: http://codereview.chromium.org/7204009 TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/7189053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89613 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill DataDrivenHeuristics tests fail on Windowsdhollowa@chromium.org2011-06-181-32/+20
| | | | | | | | | | | Reenables heuristics tests on Windows. Tests run faster now after r89396. BUG=85276 TEST=FormStructureBrowserTest.* Review URL: http://codereview.chromium.org/7204009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89611 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill heuristics checkout files for 02_checkout_advanceautoparts.com.htmldhollowa@chromium.org2011-06-184-1/+47
| | | | | | | | | | | Fixes label inferencing logic for the table case. The code should start looking at the previous table element, not the current element. BUG=86414 TEST=FormStructureBrowserTest.* with 02_checkout_advanceautoparts.com.html Review URL: http://codereview.chromium.org/7201010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89609 0039d316-1c4b-4281-b951-d872f2087c98
* Make sure autofill_manager brings up the browser with the correct profile.mirandac@chromium.org2011-06-171-1/+2
| | | | | | | | | BUG=86361 TEST=autofill tests remain working. Review URL: http://codereview.chromium.org/7189036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89516 0039d316-1c4b-4281-b951-d872f2087c98
* Fix up Autofill server experiment id metrics.isherman@chromium.org2011-06-161-2/+1
| | | | | | | | | | | The UMA_HISTOGRAM_ENUMERATION macro declares a static object, so we need to explode the macro. BUG=none TEST=none Review URL: http://codereview.chromium.org/7184003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89397 0039d316-1c4b-4281-b951-d872f2087c98
* Add Korean regex to autofill heuristicsjshin@chromium.org2011-06-151-18/+18
| | | | | | | | | BUG=83928 TEST=1. unit_tests --gtest_filter=AutofillMergeTest.* 2. browser_tests --gtest_filter=FormStructureB*.DataDrivenHeur* Review URL: http://codereview.chromium.org/6372006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@89242 0039d316-1c4b-4281-b951-d872f2087c98