summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill
Commit message (Collapse)AuthorAgeFilesLines
* Clean up Autofill CreditCard logicisherman@chromium.org2011-04-066-140/+107
| | | | | | | | | | | | | | | * When determining possible field types (for upload to the server), match against stored data, not just against the Luhn checksum * When displaying the obfuscated credit card number, display exactly the right number of obfuscating '*'s. * When importing credit card data, only save the card if the detected card type is one we recognize. * Prune some unhelpful member variables * Prune some unhelpful methods from the header BUG=77822 TEST=unit_tests --gtest_filter=CreditCardTest.* Review URL: http://codereview.chromium.org/6690038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80580 0039d316-1c4b-4281-b951-d872f2087c98
* Only consider numbers between 12 and 19 digits long to potentially be credit ↵isherman@chromium.org2011-04-063-18/+57
| | | | | | | | | | | card numbers. BUG=64433 TEST=unit_tests --gtest_filter=CreditCardTest.* Review URL: http://codereview.chromium.org/6758027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80577 0039d316-1c4b-4281-b951-d872f2087c98
* Explicitly mention the icu namespace in autofillthakis@chromium.org2011-04-031-1/+1
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6691023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80289 0039d316-1c4b-4281-b951-d872f2087c98
* Prune dead code: FormGroup::FindInfoMatches(), FormGroup::GetPreviewText()isherman@chromium.org2011-03-3112-369/+0
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6783009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80099 0039d316-1c4b-4281-b951-d872f2087c98
* Moved URLRequestContextGetter to net/ so it can be used by projects such as ↵sanjeevr@chromium.org2011-03-312-2/+2
| | | | | | | | | | jingle. BUG=None TEST=Build. Review URL: http://codereview.chromium.org/6778025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80033 0039d316-1c4b-4281-b951-d872f2087c98
* Add metrics for autofill heuristic, server, and overall field type ↵isherman@chromium.org2011-03-314-123/+323
| | | | | | | | | | | prediction quality. BUG=76945 TEST=unit_tests --gtest_filter=AutofillMetrics.* Review URL: http://codereview.chromium.org/6708099 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79954 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Cleanup in the following files:jhawkins@chromium.org2011-03-3025-21/+80
| | | | | | | | | | | | | | | | | | | | | | | | * autofill_download.cc * autofill_ie_toolbar_import_win.cc * autofill_field.h * autofill_metrics.cc * autofill_profile.cc * autofill_type.cc * autofill_xml_parser.cc * contact_info.cc * credit_card.cc * credit_card_field.cc * fax_number.h * form_field.cc BUG=none TEST=none R=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6775005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79839 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a stray debugging printfisherman@chromium.org2011-03-301-1/+0
| | | | | | | | | | BUG=none TEST=compiles TBR=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6675035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79791 0039d316-1c4b-4281-b951-d872f2087c98
* Add metric for number of Autofill address suggestions shown in popupisherman@chromium.org2011-03-305-32/+105
| | | | | | | | | BUG=none TEST=unit_tests --gtest_filter=AutofillMetrics* Review URL: http://codereview.chromium.org/6773001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79790 0039d316-1c4b-4281-b951-d872f2087c98
* iwyu: Cleanup in the following files:jhawkins@chromium.org2011-03-299-10/+61
| | | | | | | | | | | | | | | | | * address.cc * address_field.cc * autofill_cc_infobar_delegate.cc * autofill_country.cc * autofill_manager.cc BUG=none TEST=none R=dhollowa@chromium.org Review URL: http://codereview.chromium.org/6683064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79728 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill extend profiles to include multi-valued fields, part 3.dhollowa@chromium.org2011-03-287-64/+380
| | | | | | | | | | | Adds new GetMultiInfo/SetMultiInfo methods to the AutofillProfile class and propagates the multi-valued data down through to the WebDatabase layer. Single-valued mechanisms are still in place. Some of these will be removed once Sync is updated. BUG=65625 TEST=WebDatabaseTest.*:AutofillProfileTest.* Review URL: http://codereview.chromium.org/6726042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79629 0039d316-1c4b-4281-b951-d872f2087c98
* AutoFill -> Autofill Part Nisherman@chromium.org2011-03-282-10/+10
| | | | | | | | | BUG=72758 TEST=none Review URL: http://codereview.chromium.org/6713095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79617 0039d316-1c4b-4281-b951-d872f2087c98
* Log Autofill credit card metrics as histogram; rename metrics from AutoFill ↵isherman@chromium.org2011-03-289-83/+192
| | | | | | | | | | | to Autofill BUG=72758 TEST=unit_tests --gtest_filter=AutofillMetricsTest.CreditCardInfoBar Review URL: http://codereview.chromium.org/6696101 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79616 0039d316-1c4b-4281-b951-d872f2087c98
* Move some files from base to base/memory.levin@chromium.org2011-03-2822-38/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | raw_scoped_refptr_mismatch_checker.h ref_counted.cc ref_counted.h ref_counted_memory.cc ref_counted_memory.h ref_counted_unittest.cc scoped_callback_factory.h scoped_comptr_win.h scoped_handle.h scoped_native_library.cc scoped_native_library.h scoped_native_library_unittest.cc scoped_nsobject.h scoped_open_process.h scoped_ptr.h scoped_ptr_unittest.cc scoped_temp_dir.cc scoped_temp_dir.h scoped_temp_dir_unittest.cc scoped_vector.h singleton.h singleton_objc.h singleton_unittest.cc linked_ptr.h linked_ptr_unittest.cc weak_ptr.cc weak_ptr.h weak_ptr_unittest.cc BUG=None TEST=Compile Review URL: http://codereview.chromium.org/6714032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79524 0039d316-1c4b-4281-b951-d872f2087c98
* Add SCOPED_TRACE to data driven tests.isherman@chromium.org2011-03-271-0/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6733055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79511 0039d316-1c4b-4281-b951-d872f2087c98
* Fix flakiness and enable RenderViewHostManagerTest on Linux/Mac.creis@google.com2011-03-251-4/+4
| | | | | | | | | BUG=67532 TEST=browser_tests --gtest_filter=RenderViewHostManagerTest.* Review URL: http://codereview.chromium.org/6730016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79416 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of references to Autocomplete from src\content, specifically from ↵dhollowa@chromium.org2011-03-233-12/+16
| | | | | | | | | | | | | TabContents Moves the tab's instance of AutocompleteHistoryManager from TabContents to TabContentsWrapper as a helper class. Also adds virtual accessor to test infrastucture so that |contents()| can come from TabContentsWrapperTestHarness or RenderViewHostTestHarness, depending on the situation. BUG=77087 TEST=AutofillManangerTest.* Review URL: http://codereview.chromium.org/6722029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79172 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of renderer->browser messages to content.jam@chromium.org2011-03-231-1/+1
| | | | | | | TBR=tsepez Review URL: http://codereview.chromium.org/6721021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79152 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of references to autofill from src\content, specifically from ↵dhollowa@chromium.org2011-03-231-2/+2
| | | | | | | | | | | | | TabContents Moves the tab's instance of AutofillManager from TabContents to TabContentsWrapper as a helper class. BUG=77087 TEST=FormStructureBrowserTest.*:TranslateManagerTest.* Review URL: http://codereview.chromium.org/6722018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@79122 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename all the entries remaining with AutoFill to Autofill.tfarina@chromium.org2011-03-2133-357/+357
| | | | | | | | | | R=isherman@chromium.org,dhollowa@chromium.org BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6688053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78856 0039d316-1c4b-4281-b951-d872f2087c98
* Reenable implicit learning of Autofill data.isherman@chromium.org2011-03-194-7/+32
| | | | | | | | | BUG=76653, 75862 TEST=unit_tests --gtest_filter=AutoFillManagerTest.FormSubmitted Review URL: http://codereview.chromium.org/6714010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78813 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a lot more unused strings, mostly from settings.estade@chromium.org2011-03-181-1/+1
| | | | | | | | | | | There are plenty more strings flagged by the script, but it's not clear to me they should be removed (e.g., they may exist to make a translation cut-off even if they aren't used in the UI yet) BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6677094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78762 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill rename GetFieldText to GetInfodhollowa@chromium.org2011-03-1720-122/+118
| | | | | | | | | | | Renames AutofillProfile::GetFieldText to AutofillProfile::GetInfo. To match SetInfo. BUG=none TEST=none Review URL: http://codereview.chromium.org/6713002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78622 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill database migration to clean up bogus profiles.dhollowa@chromium.org2011-03-176-76/+188
| | | | | | | | | | | | | Adds a |WebDatabase| migration to clean up old profiles. The profiles are merged in much the same way as when aggregated using form submission. Profiles that are identical to another, subsets of another, or contain invalid or incomplete email, state, zip, or address get filtered out. Additionally, the filtered profiles are remembered in a "trash can" mechanism to later reflect these changes in Sync, so that they don't reappear unintentionally. BUG=65625 TEST=PersonalDataManagerTest.*:AutoFillMergeTest.DataDrivenMergeProfiles:WebDatabaseMigrationTest.*:WebDatabaseTest.* Review URL: http://codereview.chromium.org/6676031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78589 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce boxing and unboxing of AutofillFieldTypeisherman@chromium.org2011-03-1729-387/+312
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6673079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78518 0039d316-1c4b-4281-b951-d872f2087c98
* Dead code pruning: FormStructure::HasAutoFillableValues()isherman@chromium.org2011-03-173-106/+0
| | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/6693002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78479 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of native autofill dialogs.estade@chromium.org2011-03-168-1627/+0
| | | | | | | | | BUG=none TEST=trybots Review URL: http://codereview.chromium.org/6667053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78430 0039d316-1c4b-4281-b951-d872f2087c98
* Only detect heuristic autofill types on page load (not on form submission).isherman@chromium.org2011-03-165-35/+90
| | | | | | | | | BUG=75862, 76034 TEST=none Review URL: http://codereview.chromium.org/6673033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78336 0039d316-1c4b-4281-b951-d872f2087c98
* Don't rely on email fields to detect section breaks for autofill.isherman@chromium.org2011-03-163-1/+36
| | | | | | | | | | | Websites often ask for the email to be entered twice (as confirmation), so this ends up being a poor signal for where logical form section breaks are. BUG=75871 TEST=unit_tests --gtest_filter=AutofillManagerTest.FillFormWithMultipleEmails Review URL: http://codereview.chromium.org/6684023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78335 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor Autofill metrics logging to avoid calling into ↵isherman@chromium.org2011-03-144-78/+92
| | | | | | | | | | | GetPossibleFieldTypes() redundantly. BUG=75862 TEST=manual: Add *lots* of autofill addresses and submit a form; note that the browser hang is reduced Review URL: http://codereview.chromium.org/6685028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78086 0039d316-1c4b-4281-b951-d872f2087c98
* Cache ICU collators for Autofill country detection; improve performance on ↵isherman@chromium.org2011-03-141-17/+29
| | | | | | | | | | | form submit. BUG=75862 TEST=manual: add a *lot* of autofill addresses to Chromium; fill+submit a form and experience far less of a hang Review URL: http://codereview.chromium.org/6686026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@78083 0039d316-1c4b-4281-b951-d872f2087c98
* Cache ICU collator keys for autofill country code lookup.isherman@chromium.org2011-03-111-82/+240
| | | | | | | | | | | Fixes a browser hang on form submission. BUG=74911 TEST=manual: submit a form with autofill enabled and several profiles stored, don't observe a hang. Review URL: http://codereview.chromium.org/6677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77780 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillProfile to AutofillProfile.tfarina@chromium.org2011-03-1023-394/+394
| | | | | | | | | BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6658030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77630 0039d316-1c4b-4281-b951-d872f2087c98
* Dispatch change event for autofilled fieldsisherman@chromium.org2011-03-101-2/+56
| | | | | | | | | BUG=42716 TEST=interactive_ui_tests --gtest_filter=AutoFillTest.OnChangeAfterAutoFill Review URL: http://codereview.chromium.org/6649015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77617 0039d316-1c4b-4281-b951-d872f2087c98
* AutofillProfile::SetInfo() should allow for billing field typesdhollowa@chromium.org2011-03-101-4/+4
| | | | | | | | | | | Corrects a logic error introduced with the refactoring in http://codereview.chromium.org/6650014/. |SetInfo| and |FindInfoMatches| should no-op with billing types. BUG=75498 TEST=Existing unit tests. Review URL: http://codereview.chromium.org/6661011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77588 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac] Remove native/Cocoa preferences.rsesek@chromium.org2011-03-0918-2817/+1
| | | | | | | | | BUG=73011 TEST=Tabbed options work as before. --disable-tabbed-options does nothing. Review URL: http://codereview.chromium.org/6621076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77477 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill extend profiles to include multi-valued fields, part 2.dhollowa@chromium.org2011-03-0921-380/+472
| | | | | | | | | | | No functional change. This partitions the |ContactInfo| class into separate name, email, and company parts. AutoFillProfile is changed to store its component members directly instead of in a map (in preparation for multiple values). And the |Clone| operation is deprecated from the |FormGroup| class on down through the inheritance tree. BUG=65625 TEST=All existing unit tests. Review URL: http://codereview.chromium.org/6650014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77425 0039d316-1c4b-4281-b951-d872f2087c98
* Options: Remove the kDisabledTabbedOptions flag.jhawkins@chromium.org2011-03-091-13/+3
| | | | | | | | | BUG=75320 TEST=none Review URL: http://codereview.chromium.org/6650007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77404 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the settings page for es-419 locale: Spanish (Latin America).satorux@chromium.org2011-03-092-1/+6
| | | | | | | | | | | | | | | | Before the fix, the settings page for es-419 was half broken as there was an JavaScript error like below while loading the page. Uncaught TypeError: Cannot read property 'name' of undefined The error was caused by the fact that "419" isn't a valid country code. BUG=chromium-os:12857 TEST=open the "Languages and Input" settings on Chromium OS, and confirmed that it's shown correctly. Review URL: http://codereview.chromium.org/6626070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77402 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for Autofill credit card label should be non-empty even when there is no ↵georgey@chromium.org2011-03-093-4/+13
| | | | | | | | | | credit card number BUG=65174 TEST=unit-tested Review URL: http://codereview.chromium.org/6627002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77381 0039d316-1c4b-4281-b951-d872f2087c98
* Update a bunch of files to the new location of notification files.tfarina@chromium.org2011-03-083-8/+8
| | | | | | | | | | | First part of the remaining files. BUG=None TEST=None Review URL: http://codereview.chromium.org/6649001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77330 0039d316-1c4b-4281-b951-d872f2087c98
* Make FormField be a struct rather than a class per c++ standards.tsepez@chromium.org2011-03-0819-124/+124
| | | | | | | | | | | This makes automatic generation of IPC messages much easier. Convert autofill messsage to automatic generation in the process. Attempt #2: fix build on chromeos, see http://codereview.chromium.org/6633001 for original CL. Review URL: http://codereview.chromium.org/6625087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77307 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 77296 - zea@chromium.org2011-03-0819-124/+124
| | | | | | | | | | | | | | | Convert autofill messages to use the new IPC macros. This requires changing the FormField class to a struct with publically-visible members, which was what should have been done in the first place, instead of the trivial setters/getters which are accessed in various combinations independently of each other throughout the code. Review URL: http://codereview.chromium.org/6633001 TBR=tsepez@chromium.org Review URL: http://codereview.chromium.org/6623086 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77298 0039d316-1c4b-4281-b951-d872f2087c98
* Convert autofill messages to use the new IPC macros. This requirestsepez@chromium.org2011-03-0819-124/+124
| | | | | | | | | | | changing the FormField class to a struct with publically-visible members, which was what should have been done in the first place, instead of the trivial setters/getters which are accessed in various combinations independently of each other throughout the code. Review URL: http://codereview.chromium.org/6633001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77296 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for autofill DCHECKgeorgey@chromium.org2011-03-082-3/+25
| | | | | | | | BUG=74492 TEST=unit-tested Review URL: http://codereview.chromium.org/6621004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77213 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Rename OnDialogResponse() to OnResponse() to standardize on a ↵tfarina@chromium.org2011-03-072-10/+9
| | | | | | | | | | | | | | | | | | | | | | | | | consistent naming scheme. This allow us to have a single pattern for handling the gtk "response" callback. So now in every gtk dialog on chromium, it looks like this: my_dialog_gtk.h: CHROMEGTK_CALLBACK_1(MyDialogGtk, void, OnResponse, int); my_dialog_gtk.cc: void MyDialogGtk::OnResponse(GtkWidget* dialog, int response_id) { } And to subscribe to this event: g_signal_connect(dialog_, "response", G_CALLBACK(OnResponseThunk), this); BUG=None TEST=None Review URL: http://codereview.chromium.org/6627038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77180 0039d316-1c4b-4281-b951-d872f2087c98
* Add additional patterns to match area code and country code correctly on ↵georgey@chromium.org2011-03-071-2/+2
| | | | | | | | | | some sites (apple developer registration) BUG=none TEST=unit-tested Review URL: http://codereview.chromium.org/6621022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77166 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill profile cleanup. Encapsulation and labels.dhollowa@chromium.org2011-03-072-21/+16
| | | | | | | | | | | Moves private typedefs into class, and cleans up some remaining label code. BUG=none TEST=none Review URL: http://codereview.chromium.org/6633005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77151 0039d316-1c4b-4281-b951-d872f2087c98
* autofill: Rename AutoFillType to AutofillType.tfarina@chromium.org2011-03-0748-547/+548
| | | | | | | | | BUG=72758 TEST=existing unit_tests Review URL: http://codereview.chromium.org/6626042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77140 0039d316-1c4b-4281-b951-d872f2087c98
* Move notification service code to content. We'll need to figure out how to ↵jam@chromium.org2011-03-071-5/+5
| | | | | | | | | split the type enum so that chrome specific parts aren't in content later. TBR=avi Review URL: http://codereview.chromium.org/6627043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@77102 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 09:51:45 +0000