summaryrefslogtreecommitdiffstats
path: root/chrome/browser/autofill
Commit message (Collapse)AuthorAgeFilesLines
* Added multi-valued field sync to Autofill (client) (Issue: Autofill profiles ↵georgey@chromium.org2012-01-071-2/+3
| | | | | | | | | | | | with multi-valued...) BUG=77444 TEST=unit-tests Review URL: http://codereview.chromium.org/8969006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116812 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor and fix feedbackrkc@chromium.org2012-01-061-12/+7
| | | | | | | | | | | | | | | | | | | | | This CL does the following things, .) Removes user-facing categories from the UI completely. .) Changes categories that are still used (Autofill for example) use category tags instead of the category enum (which has been deprecated) .) Updates the protocol buffers .) Refactors the code to change bug report to feedback and re-organizes the file naming/layout .) Cleans up the unused feedback strings, files and code .) Cleans up the code at a few places .) Makes a few UI changes to get closer to the mock given in chromium:98738 This seems like a really huge CL but in reality it just just a couple of hundred lines of 'code' changes; a lot of this is just code being deleted BUG=chromium:98738 TEST=Tested sending reports. Review URL: http://codereview.chromium.org/9006003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116598 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 116512 - SwitchTabAndHideAutofillPopup failing linux chromeos bot.kkania@chromium.org2012-01-059-457/+20
| | | | | | | | | | | | | | | | | | First pass for new GTK Autofill popup. This first pass just displays the new Autofill popup and then hides it at the correct times. The box is the correct size, but none of the text is drawn at the moment. This is only enabled when the --external-autofill-popup flag is enabled. BUG=51644 Review URL: http://codereview.chromium.org/8890035 TBR=csharp@chromium.org Review URL: http://codereview.chromium.org/9109031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116575 0039d316-1c4b-4281-b951-d872f2087c98
* First pass for new GTK Autofill popup.csharp@chromium.org2012-01-059-20/+457
| | | | | | | | | | | | | This first pass just displays the new Autofill popup and then hides it at the correct times. The box is the correct size, but none of the text is drawn at the moment. This is only enabled when the --external-autofill-popup flag is enabled. BUG=51644 Review URL: http://codereview.chromium.org/8890035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116512 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of tab_contents.h includes from chrome. These are all ↵jam@chromium.org2012-01-041-2/+2
| | | | | | | | | trivial changes to use WebContents instead of TabContents. BUG=98716 Review URL: http://codereview.chromium.org/9030032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116392 0039d316-1c4b-4281-b951-d872f2087c98
* Convert WebContents to return a content::NavigationController instead of the ↵jam@chromium.org2012-01-042-2/+2
| | | | | | | | | | implementation. Update all the headers in chrome to use the interface only. In a subsequent cl, I'll rename the implementation to NavigationControllerImpl and also get rid of content::NavigationController everywhere. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8983010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116244 0039d316-1c4b-4281-b951-d872f2087c98
* Convert all the notifications which use NavigationController to ↵jam@chromium.org2012-01-031-0/+1
| | | | | | | | | | content::NavigationController. After this is done, we can then make WebContents return a content::NavigationEntry instead of the impl. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9016047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116150 0039d316-1c4b-4281-b951-d872f2087c98
* Replace most of Browser::GetSelectedTabContents calls into ↵jam@chromium.org2012-01-031-5/+8
| | | | | | | | | | | | Browser::GetSelectedWebContents. I've converted the easy ones, I'll do the ones with more dependencies in a separate change to keep things trivial to review. I considered taking out GetSelectedTabContents altogether and having people just use GetSelectedTabContentsWrapper()->web_contents() per the existing comment in browser.h, but there are a lot of callers and it seemed too long to type. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/9015022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116122 0039d316-1c4b-4281-b951-d872f2087c98
* Convert a bunch of WebContentsObservers to use web_contents() instead of ↵jam@chromium.org2011-12-252-14/+14
| | | | | | | | | | tab_contents(), as well as all the dependent code. BUG=98716 TBR=joi Review URL: http://codereview.chromium.org/8982008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115777 0039d316-1c4b-4281-b951-d872f2087c98
* Move TabContentsObserver to content/public, rename it to ↵jam@chromium.org2011-12-222-5/+5
| | | | | | | | | | WebContentsObserver, and put it into the content namespace. BUG=98716 TBR=tburkard Review URL: http://codereview.chromium.org/9026011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115599 0039d316-1c4b-4281-b951-d872f2087c98
* Move navigation_details.h to content/public/browser.jam@chromium.org2011-12-221-1/+1
| | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8949066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115498 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::browser_context() to GetBrowserContext and put it into ↵jam@chromium.org2011-12-211-3/+3
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9021022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115435 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 115346. The change didn't break anything, the test was faulty. Will ↵jam@chromium.org2011-12-212-3/+3
| | | | | | | | | | | | | | | | | | | | disable in a followup. - Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_tests on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 TBR=thakis@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115428 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r115276, it broke PanelDownloadTest.Download in interactive_ui_teststhakis@chromium.org2011-12-212-3/+3
| | | | | | | | | | | | | | | | on win,linux,mac. Original change: Rename TabContents::controller() to GetController and put it into the WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 TBR=jam Review URL: http://codereview.chromium.org/9018016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115346 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::controller() to GetController and put it into the ↵jam@chromium.org2011-12-212-3/+3
| | | | | | | | | | WebContents namespace. BUG=98716 TBR=dpranke Review URL: http://codereview.chromium.org/8956050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115276 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContents::render_view_host() to GetRenderViewHost and put it into ↵jam@chromium.org2011-12-203-8/+8
| | | | | | | | | the WebContents interface. BUG=98716 Review URL: http://codereview.chromium.org/9007026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
* Group forms-related files in webkit/glue in a forms/ subdirectory.isherman@chromium.org2011-12-1524-182/+195
| | | | | | | | | | BUG=none TEST=compiles Review URL: http://codereview.chromium.org/8680040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114581 0039d316-1c4b-4281-b951-d872f2087c98
* [Autofill] Fix flakiness in autofill browsertest.binji@chromium.org2011-12-131-0/+37
| | | | | | | | | | BUG=81451 TEST=AutofillTest.* Review URL: http://codereview.chromium.org/8921026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114177 0039d316-1c4b-4281-b951-d872f2087c98
* Clean up TCW, make it solely a hub for 1:1 observer/helper objects.avi@chromium.org2011-12-122-1/+4
| | | | | | | | | BUG=105872 TEST=no functional change Review URL: http://codereview.chromium.org/8892011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114017 0039d316-1c4b-4281-b951-d872f2087c98
* Removing MessageLoop::QuitTask() from chrome/dcheng@chromium.org2011-12-101-1/+1
| | | | | | | | | | | | base/task.h is going away and being replaced by base/bind.h and base/callback.h. This CL was automatically generated by sed. BUG=none TEST=none Review URL: http://codereview.chromium.org/8873032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113896 0039d316-1c4b-4281-b951-d872f2087c98
* Re-committing http://codereview.chromium.org/8736001/ originally committed ↵georgey@chromium.org2011-12-031-6/+6
| | | | | | | | | | | | | revision=112305 The difference is the phone library pulled is version 407 instead of 403, it includes fixes, including missing licenses. Original description: Pull the phone library directly. Delete old version. TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8790002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112865 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to IWYU for files that previously were getting a bunch ofjoi@chromium.org2011-12-011-0/+1
| | | | | | | | | | | header files via io_thread.h or browser_thread.h TBR=owners (previously approved on codereview 8477004) BUG=98716 Review URL: http://codereview.chromium.org/8746023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112455 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112305 - Pull the phone library directly. Delete old version.isherman@chromium.org2011-12-011-6/+6
| | | | | | | | | | | | TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8736001 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/8762016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112381 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112319 - Revert 112305 - Pull the phone library directly. Delete old ↵isherman@chromium.org2011-11-301-6/+6
| | | | | | | | | | | | | | | | version. TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8736001 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/8759004 TBR=isherman@chromium.org Review URL: http://codereview.chromium.org/8757005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 112305 - Pull the phone library directly. Delete old version.isherman@chromium.org2011-11-301-6/+6
| | | | | | | | | | | TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8736001 TBR=georgey@chromium.org Review URL: http://codereview.chromium.org/8759004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112319 0039d316-1c4b-4281-b951-d872f2087c98
* Pull the phone library directly. Delete old version.georgey@chromium.org2011-11-301-6/+6
| | | | | | | | TEST=unit-tests BUG=105577 Review URL: http://codereview.chromium.org/8736001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112305 0039d316-1c4b-4281-b951-d872f2087c98
* Autofill: Remove a regular expression for fax which is no longer used.jhawkins@chromium.org2011-11-301-8/+0
| | | | | | | | | | | BUG=81846 TEST=none R=isherman@chromium.org Review URL: http://codereview.chromium.org/8745018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112251 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Convert ASCIIToUTF16("") to string16().jhawkins@chromium.org2011-11-284-8/+12
| | | | | | | | | | | | | Inspired by r111713. BUG=none TEST=none R=gbillock@chromium.org Review URL: http://codereview.chromium.org/8687002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111768 0039d316-1c4b-4281-b951-d872f2087c98
* Moving AutofillAgent Logic into Browsercsharp@chromium.org2011-11-226-39/+204
| | | | | | | | | | | | | | | | | This is the first attempt at moving some of the Autofill logic out of the autofillagent in the renderer and into the external delegate in the browser. I just focused on OnSuggestionsReturned, so the browser side should be able to correcrtly create the list of suggestions to show. There are still features that need to be moved, such as the ability to select an item, which I will address in future cls. BUG=51644 TEST= Review URL: http://codereview.chromium.org/8488011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111240 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of a bunch of view_messages.h includes from chrome by making the ↵jam@chromium.org2011-11-212-2/+2
| | | | | | | | | TabContentsObserver interface not use a struct from it. Instead, the interface uses a new struct, content::FrameNavigateParams, that's in the public directory. The IPC message's struct derives from it. BUG=98716 Review URL: http://codereview.chromium.org/8603015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110963 0039d316-1c4b-4281-b951-d872f2087c98
* Add OVERRIDE to chrome/browser/.avi@chromium.org2011-11-211-8/+13
| | | | | | | | | BUG=104314 TEST=no change Review URL: http://codereview.chromium.org/8612007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110939 0039d316-1c4b-4281-b951-d872f2087c98
* Setting up external delegate calls to allow a future delegate to handle autofillcsharp@chromium.org2011-11-175-15/+53
| | | | | | | | | | | | | | The external delegate IPC calls in autofill_agent are setup so that a future change that adds an external delegate should already have its code called at the correct times and with the correct values. BUG=51644 TEST= Review URL: http://codereview.chromium.org/8490017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110506 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove forward declarations in various chrome/browser directories.thestig@chromium.org2011-11-163-9/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8533030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110225 0039d316-1c4b-4281-b951-d872f2087c98
* Add tracking for new Autofill experiments.isherman@chromium.org2011-11-141-0/+12
| | | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/8537033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109843 0039d316-1c4b-4281-b951-d872f2087c98
* Switch BackgroundContents to use TabContents instead of RenderViewHost.jam@chromium.org2011-11-112-2/+2
| | | | | | | BUG=99698, 98934 Review URL: http://codereview.chromium.org/8469015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109661 0039d316-1c4b-4281-b951-d872f2087c98
* Remove 'using' from browser_thread.h, and make things compile.joi@chromium.org2011-11-031-0/+1
| | | | | | | | BUG=98716 Review URL: http://codereview.chromium.org/8438045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108462 0039d316-1c4b-4281-b951-d872f2087c98
* Switch to composition for TestBrowserThread.joi@chromium.org2011-11-031-5/+2
| | | | | | | | | | | | | | This avoids exposing BrowserThreadImpl internals outside of content/, and goes most of the way to not exposing the fact that underneath, it is a base::Thread. There are only three test files that use the TestBrowserThread::DeprecatedGetThreadObject method. TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8440039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108452 0039d316-1c4b-4281-b951-d872f2087c98
* Move BrowserThread to content namespace.joi@chromium.org2011-11-027-0/+9
| | | | | | | | | TBR=owners BUG=98716 Review URL: http://codereview.chromium.org/8437002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
* Move some Autofill processing logic on form submit to a background thread.isherman@chromium.org2011-11-014-168/+294
| | | | | | | | | | BUG=76992 TEST=Autofill continues to upload form data to the crowdsourcing server Review URL: http://codereview.chromium.org/8387016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108162 0039d316-1c4b-4281-b951-d872f2087c98
* Roll libjingle 88:92sergeyu@chromium.org2011-11-011-1/+1
| | | | | | | | | | | | | | Beside other changes the new version of libjingle has thread-safe QName class and has all std::string and QName statics removed. BUG=94993,102451 TEST=Compiles Review URL: http://codereview.chromium.org/8413059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108065 0039d316-1c4b-4281-b951-d872f2087c98
* External autofill delegates.jrg@chromium.org2011-10-295-2/+205
| | | | | | | | | | BUG= TEST= Review URL: http://codereview.chromium.org/8353025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107839 0039d316-1c4b-4281-b951-d872f2087c98
* Split BrowserThread into public API and private implementation, step 1.joi@chromium.org2011-10-288-17/+18
| | | | | | | | | | | | | | | | | | | | | Only content/ now has the ability to create BrowserThread objects, with the exception that tests can create the content::TestBrowserThread subclass, and (temporarily) code in chrome/ can create the DeprecatedBrowserThread subclass. A follow-up change will make content/ take care of its own thread creation, remove DeprecatedBrowserThread, and move all state and non-trivial constructors from BrowserThread down to BrowserThreadImpl. Also moved BrowserProcessSubThread into content/ namespace. As part of follow-up cleanup, chrome/ will stop using this class. BUG=98716 TEST=existing Review URL: http://codereview.chromium.org/8392042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107718 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce visibility of methods in AutofillManager and AutofillDownload.isherman@chromium.org2011-10-285-138/+76
| | | | | | | | | | | | Also remove some obsolete code and simplify some of the code's expectations. BUG=none TEST=none Review URL: http://codereview.chromium.org/8351027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107680 0039d316-1c4b-4281-b951-d872f2087c98
* Handle additional feedback from http://codereview.chromium.org/8395038/.jam@chromium.org2011-10-281-1/+1
| | | | | | | | | | | -rename URLFetcherFactory to URLFetcherImplFactory -rename GetUrl to GetURL and GetOriginalUrl to GetOriginalURL -get rid of request_type in TestURLFetcher's constructor BUG=98716 Review URL: http://codereview.chromium.org/8416020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107665 0039d316-1c4b-4281-b951-d872f2087c98
* Make test URLFetcher implementations not derive from the URLFetcher ↵jam@chromium.org2011-10-261-2/+2
| | | | | | | | | | | implementation, since we want to hide that from chrome completely. SetBackoffDelayForTesting moves from content::UrlFetcher to TestURLFetcher, now that the test objects derive from it. BUG=98716 Review URL: http://codereview.chromium.org/8395038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107468 0039d316-1c4b-4281-b951-d872f2087c98
* Convert chrome callers of UrlFetcher to use the interface. I'll switch tests ↵jam@chromium.org2011-10-261-5/+4
| | | | | | | | | to use composition instead of inheritence in a future change. BUG=98716 Review URL: http://codereview.chromium.org/8395023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107268 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unnecessary dependencies on Autofill.isherman@chromium.org2011-10-251-1/+0
| | | | | | | | | | | | The Autofill cache is now smart enough to update itself after the page is translated. BUG=none TEST=Autofill should still work after Translating web sites Review URL: http://codereview.chromium.org/8382028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107216 0039d316-1c4b-4281-b951-d872f2087c98
* Create a content::UrlFetcher interface that lives in content/public/common ↵jam@chromium.org2011-10-254-19/+20
| | | | | | | | | and convert users to it. I have added a static create function, but will switch instantiations to use it in another change since this has grown a lot. Basically this change converts function names away from unix_hacker style, which they shouldn't have been using anyways since some are virtual, and made all of the other functions virtual. BUG=98716 Review URL: http://codereview.chromium.org/8375039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107151 0039d316-1c4b-4281-b951-d872f2087c98
* Convert URLFetcher::Delegates to use an interface in content/public/common. ↵jam@chromium.org2011-10-243-9/+12
| | | | | | | | Also remove the old URLFetcher delegate callback while I'm touching all of them.BUG=98716,83592 Review URL: http://codereview.chromium.org/8373021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106949 0039d316-1c4b-4281-b951-d872f2087c98
* Fix an Autofill crash caused by accessing the g_browser_process on the DB ↵isherman@chromium.org2011-10-228-17/+66
| | | | | | | | | | | | | | thread. This is meant as a minimal-impact CL, so that it should be safe to merge to M16. The more complete fix is being tracked in bug 100845. BUG=100745 TEST=less crashy Review URL: http://codereview.chromium.org/8355025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106822 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-05-09 08:10:56 +0000