| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
| |
the spec.
BUG=92121
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics01
Review URL: http://codereview.chromium.org/7639010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96563 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=92121
TEST=unit_tests --gtest_filter=AutofillManagerTest.FillFormWithAuthorSpecifiedSections:FormStructureTest.HeuristicsAutocompletetypeWithSections
Review URL: http://codereview.chromium.org/7613015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96506 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=71601
TEST=none
Review URL: http://codereview.chromium.org/7620004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96482 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jcivelli
BUG=90905
Review URL: http://codereview.chromium.org/7616019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96453 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=92121
TEST=unit_tests --gtest_filter=FormStructureTest.*Autocompletetype*; browser_tests --gtest_filter=FormManagerTest.WebFormControlElementToFormFieldAutocompletetype
Review URL: http://codereview.chromium.org/7602006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96131 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
WebUI list)
Every field present in the address editor should be included in the list of distinguishing fields to avoid empty profile labels.
BUG=91722
TEST=unit_tests --gtest_filter=AutofillProfileTest.PreviewSummaryString
Review URL: http://codereview.chromium.org/7528017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96006 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
webkit_glue::FormField's unwieldy full constructor and StricktlyEqualsHack() method. The only clients are in test code, and we can better support these clients in other ways.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7576001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95928 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This avoids having a nested class Observer in PersonalDataManager.
BUG=None
TEST=None
R=jhawkins@chromium.org
Review URL: http://codereview.chromium.org/7541065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95871 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=91873
TEST=none
Review URL: http://codereview.chromium.org/7585020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95865 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.
This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Typed Urls datatype to the new model, and contains the following changes:
- LiveTypedUrlsSyncTest is no longer a class that inherits from LiveSyncTest, but is now a namespace called typed_urls_helper, and contains a bunch of methods that perform various operations related to Typed Urls.
- SingleClientLiveTypedUrlsSyncTest is renamed to SingleClientTypedUrlsSyncTest, and is a subclass of LiveSyncTest. It uses the methods in namespace typed_urls_helper by including its header file and attaching itself to the helper.
In addition, bookmarks, preferences and autofill helpers and the SyncDatatypeHelper were originally implemented as static classes. Based on the code review feedback in this patch, they have been modified to the "functions-in-a-namespace" model similar to typed urls. This patch consists of those changes too.
BUG=88510
TEST=sync_integration_tests, sync_performance_tests
Review URL: http://codereview.chromium.org/7461109
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95862 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
"title/prefix/suffix" for ignore text in name_field and MATCH_SELECT.
BUG=69912
TEST=Run 20_register_alaskaair.com.html
Review URL: http://codereview.chromium.org/7545003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95390 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7554020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95354 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
For a detailed description see part #1, http://codereview.chromium.org/6478005/
BUG=61062
TEST=unit_tests, possibly more
Review URL: http://codereview.chromium.org/7465041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.
This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Autofill datatype to the new model, and contains the following changes:
- LiveAutofillSyncTest no longer inherits from LiveSyncTest, but is renamed to AutofillHelper, and contains a bunch of static methods that perform various operations related to Autofill.
- TwoClientLiveAutofillSyncTest is renamed to TwoClientAutofillSyncTest, and is a subclass of LiveSyncTest. It uses the methods in AutofillHelper by including its header file and attaching itself to the helper.
BUG=88510
TEST=sync_integration_tests, sync_performance_tests
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=95263
Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=95267
Review URL: http://codereview.chromium.org/7536001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95346 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
datatypes: Autofill
The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.
This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Autofill datatype to the new model, and contains the following changes:
- LiveAutofillSyncTest no longer inherits from LiveSyncTest, but is renamed to AutofillHelper, and contains a bunch of static methods that perform various operations related to Autofill.
- TwoClientLiveAutofillSyncTest is renamed to TwoClientAutofillSyncTest, and is a subclass of LiveSyncTest. It uses the methods in AutofillHelper by including its header file and attaching itself to the helper.
BUG=88510
TEST=sync_integration_tests, sync_performance_tests
Review URL: http://codereview.chromium.org/7536001
TBR=rsimha@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95267 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The sync integration tests currently use a class hierarchy where the test classes for each datatype are subclasses of LiveSyncTest. While this design worked in the past, it allows tests to work with only one datatype at a time, and therefore doesn't allow us to test the interplay between datatypes.
This patch is another in the series of patches that will move away from an inheritance model to one where test cases can operate on more than one datatype. It updates the Autofill datatype to the new model, and contains the following changes:
- LiveAutofillSyncTest no longer inherits from LiveSyncTest, but is renamed to AutofillHelper, and contains a bunch of static methods that perform various operations related to Autofill.
- TwoClientLiveAutofillSyncTest is renamed to TwoClientAutofillSyncTest, and is a subclass of LiveSyncTest. It uses the methods in AutofillHelper by including its header file and attaching itself to the helper.
BUG=88510
TEST=sync_integration_tests, sync_performance_tests
Review URL: http://codereview.chromium.org/7536001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95263 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support HTML like """Name <span class="required">*</span> <input type="text" name="name">"""
Of course, pull at a thread and...
Other changes also included to avoid regressions:
* When parsing address fields for heuristics, we try to skip over unlabeled fields in the middle of an address. Updated the code not to also skip over unlabeled fields at the *end* of an address, as these might be part of a different section entirely.
* Tighten the credit card number regex to require the word "card".
* Add "csc" to the credit card security code regex.
* When inferring labels based on <div> structure, be willing to scan up the tree past the closest parent that is a <div>.
* Also when inferring labels based on <div> structure, we previously would only stop early if we were about to escape from a <table> element. Also stop early if we are about to escape from a <fieldset> element. If we see either of these elements, we expect the field label to be contained with the element.
* Allow <label> elements to misuse the 'for' attribute to specify the element's name rather than its id.
BUG=87517
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics*
Review URL: http://codereview.chromium.org/7531023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@95019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7544021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94963 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76788
TEST=no change visible
Review URL: http://codereview.chromium.org/7523054
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7541001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
field names, labels, and values.
BUG=none
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics*
Review URL: http://codereview.chromium.org/7531022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94777 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=90905
Review URL: http://codereview.chromium.org/7532034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94720 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This should make it much safer to use (i.e. memory-safe).
BUG=90585
Review URL: http://codereview.chromium.org/7524033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94694 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7482037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94599 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=81451
TEST=interactive UI tests
R=sergeyu
Review URL: http://codereview.chromium.org/7535001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94557 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=76788
TEST=no change visible
Review URL: http://codereview.chromium.org/7522018
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94511 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87214
TEST=none
Review URL: http://codereview.chromium.org/7489026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
section breaks for Autofill
BUG=75124
TEST=AutofillTest.AutofillFormWithRepeatedField
Review URL: http://codereview.chromium.org/7488037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@94051 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=52198
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics*
Review URL: http://codereview.chromium.org/7493033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=87333
TEST=unit_tests --gtest_filter=AutofillManager.GetFieldSuggestionsForMultiValuedProfileUnfilled
Review URL: http://codereview.chromium.org/7492033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7484044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93751 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
(I changed my mind, there's no particular reason to push this logic out to clients of the function.)
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7488005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93747 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
precision.
* Only consider submitted field values to match locally stored data if the strings match exactly
+ This means we will send fewer false positives to the server, at the cost of some false negatives. Most importantly, we should stop identifying ADDRESS_LINE_2 fields as ADDRESS_LINE_1.
+ There are a few excpetions for structured fields with canonicalized values, like countries (which are canonicalized to country codes)
* Eliminate FormGroup::GetMatchingTypes() -- all of this work is now done in a consistent way within AutofillManager
* Refactor FormGroup::GetNonEmptyTypes() to be shared code.
BUG=81867, 76992
TEST=unit_tests --gtest_filter=AutofillManagerTest.DeterminePossibleFieldTypesForUpload
Review URL: http://codereview.chromium.org/7398019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93582 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=89990
TEST=unit_tests --gtest_filter=PersonalDataManagerTest.AggregateCreditCardWithMissingInfoInNew
Review URL: http://codereview.chromium.org/7465019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93548 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89986
TEST=FormStructureTest.ShouldBeParsed
Review URL: http://codereview.chromium.org/7471029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93539 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=89253
TEST=AutofillManagerTest.FormSubmittedWithDefaultValues
Review URL: http://codereview.chromium.org/7473023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93538 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make it private and establish a friend whitelist for existing users.
BUG=64339
TEST=none
Review URL: http://codereview.chromium.org/7438002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This infobar has been useful, but the marginal utility of leaving it active is low.
BUG=88791
TEST=none
Review URL: http://codereview.chromium.org/7457013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93164 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7411003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
removed unused/irrelevant functions
removed irrelevant comments
Moved stl_util-inl.h => stl_util.h
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/7342047
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@93110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Forms include: twitter settings, Czech email client, Russian email client, Facebook pages, DeviantArt, and formspring.me
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7397006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92780 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=76301
TEST=20_register_epson.com.mx.html
Review URL: http://codereview.chromium.org/7354010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92613 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=88791
TEST=Navigate to https://www.corp.google.com/~isherman/no_crawl/scratch/100fields.html, see infobar.
Review URL: http://codereview.chromium.org/7354008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92473 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
forms
Sites include: 4chan, reddit, tumblr, facebook, blogger, and Google Translate
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/7352002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92472 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=77678
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics15
Review URL: http://codereview.chromium.org/7347002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92288 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Epson.com.mx's last name uses "apellido" in last name matching pattern. So I change it from proral to singular.
BUG=76301
TEST=Run FormStructureBrowserTest.DataDrivenHeuristics20
Review URL: http://codereview.chromium.org/7334002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
its contents.
BUG=76544, 78801, 85006
TEST=unit_tests --gtest_filter=SelectControlHandlerTest.*
Review URL: http://codereview.chromium.org/7324019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92156 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=40687
TEST=browser_tests --gtest_filter=FormStructureBrowserTest.DataDrivenHeuristics15
Review URL: http://codereview.chromium.org/7237043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@92149 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
chrome_notification_types.h.
This file lives in chrome\common. The chrome specific notifications start from NOTIFICATION_CONTENT_END
which defines the end of the enum used by content to define notification types. The notificaton_type.h file
in content\common has been renamed to content_notification_types.h
BUG=76698
Review URL: http://codereview.chromium.org/7327007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91972 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Change the order of company and normal address line checks. Because in the label of address line1, there might be "company".
BUG=64569
FIX=Run 15_crbug_64569.html
TEST=
Review URL: http://codereview.chromium.org/7277079
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@91667 0039d316-1c4b-4281-b951-d872f2087c98
|