summaryrefslogtreecommitdiffstats
path: root/chrome/browser/automation/automation_provider.cc
Commit message (Collapse)AuthorAgeFilesLines
* Switch FindTabHelper to use WebContentsUserData.avi@chromium.org2012-09-291-4/+3
| | | | | | | | | | BUG=107201 TEST=no visible change Review URL: https://chromiumcodereview.appspot.com/10987094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159429 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor BrowsingDataRemover creation for clarity.mkwst@chromium.org2012-09-041-3/+1
| | | | | | | | | | | | | | We currently have two constructors for BrowsingDataRemover. This CL drops down to a single, private constructor with a few more specific public Create methods. At the same time we're making that chance, we should explicitly refer to the end of time when we want to remove all browsing data from a user's machine, rather than passing in base::Time::Now() which is vulnerable to clock skew or other simply issues of asynchronocity. The new CreateForPeriod method makes that decision explicit. base::Time::Max() has the nice property that it automatically compares as greater than any reasonable time we might encounter. This means we don't have to update every subsystem that BrowsingDataRemover relies on: they can continue to do simple comparisons without the complications of special-casing the null Time. BUG=144946,130732 Review URL: https://chromiumcodereview.appspot.com/10898002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154744 0039d316-1c4b-4281-b951-d872f2087c98
* Kill DownloadItem::IsOtr()benjhayden@chromium.org2012-08-141-2/+2
| | | | | | | | | | | | | | | | Consumers should just remember which DownloadManager they got the item from, or else lookup the item from both managers and rely on the id-space sharing. Also move CreateDownloadItemValue from download_util to download_dom_handler. Reviewers: asanka: * Done: jam: chrome/browser/automation/* jhawkins: downloads_dom_handler.cc rdsmith: * Review URL: https://chromiumcodereview.appspot.com/10805020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151504 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 151036 - Speculative revert to see if this change introduced a ↵ben@chromium.org2012-08-141-5/+4
| | | | | | | | | | | | | | | | | performance regression on Mac intl perf bots. If this change was responsible for this regression, it may also have been responsible for http://crbug.com/133762 http://crbug.com/138260 TEST=mac intl perf bot drops: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1 Review URL: https://chromiumcodereview.appspot.com/10837192 TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831308 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151482 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative revert to see if this change introduced a performance regression ↵ben@chromium.org2012-08-101-4/+5
| | | | | | | | | | | | | | on Mac intl perf bots. If this change was responsible for this regression, it may also have been responsible for http://crbug.com/133762 http://crbug.com/138260 TEST=mac intl perf bot drops: http://build.chromium.org/f/chromium/perf/mac-release-10.5/intl1/report.html?history=150&rev=-1 Review URL: https://chromiumcodereview.appspot.com/10837192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151036 0039d316-1c4b-4281-b951-d872f2087c98
* Relandbenjhayden@chromium.org2012-08-091-1/+0
| | | | | | | | | | | | | | | | | | | | | | | | | DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVING Changes from original CL only in downloads_api.* Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149794 Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=150086 http://crbug.com/140687 Review URL: https://chromiumcodereview.appspot.com/10704026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150890 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 149794 - DownloadItem::Observer::OnDownloadDestroyed() replaces ↵rdsmith@chromium.org2012-08-061-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | DownloadItem::REMOVING Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Review URL: https://chromiumcodereview.appspot.com/10704026 BUG=140687 TBR=benjhayden@chromium.org Review URL: https://chromiumcodereview.appspot.com/10831177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150086 0039d316-1c4b-4281-b951-d872f2087c98
* DownloadItem::Observer::OnDownloadDestroyed() replaces DownloadItem::REMOVINGbenjhayden@chromium.org2012-08-031-1/+0
| | | | | | | | | | | | | | | | | | Reviewers: Ben Goodger: chrome/browser/ui/views/download/download_item_view.*, chrome/browser/plugin_installer.*, chrome/browser/automation/automation_provider.cc rdsmith, asanka: all Nico (thakis): chrome/browser/ui/cocoa/download/download_item_mac.* Achuith: chrome/browser/chromeos/gdata/gdata_download_observer.* Evan (estade): chrome/browser/ui/gtk/download/download_item_gtk.*, chrome/browser/ui/webui/downloads_dom_handler.* Scott (sky): chrome/browser/history/history_unittest.cc Aaron (aa): chrome/browser/extensions/webstore_installer.* Add DownloadItem::Observer::OnDownloadRemoved() to signal when a download is being removed from history. Make chrome.downloads.onErased trigger from DownloadItem::Observer::OnDownloadRemoved() so that extensions don't think that all downloads are being erased just because the browser is closing. Review URL: https://chromiumcodereview.appspot.com/10704026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149794 0039d316-1c4b-4281-b951-d872f2087c98
* Move browsing_data_helper files into a separate directory.markusheintz@chromium.org2012-07-191-2/+2
| | | | | | | | | | BUG=121862 TEST=existing unit_tests TBR=eroman@chromium.org,sky@chromium.org,erg@chromium.org Review URL: https://chromiumcodereview.appspot.com/10805015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147504 0039d316-1c4b-4281-b951-d872f2087c98
* Move tab functions off Browser into browser_tabstrip and browser_tabrestore.ben@chromium.org2012-06-291-1/+2
| | | | | | | | http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10702029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98
* Moves command handling from Browser to a new object, BrowserCommandController.ben@chromium.org2012-06-271-2/+2
| | | | | | | | | | | | | | Notes: . BrowserCommandController now owns the CommandUpdater. . CommandHandler's ExecuteCommand API was massaged a little so that ExecuteCommand/IsCommandEnabled/SupportsCommand methods are always called on it, rather than the wrapping controller. . The creation of BCC was performed as a svn cp so that history for the various Exec methods could be easily carried forward. . Various "CanFoo" methods were extracted from the UpdateFooState() methods and moved to CanFoo(const Browser* browser) in browser_commands. http://crbug.com/133576 TEST=none Review URL: https://chromiumcodereview.appspot.com/10677009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144597 0039d316-1c4b-4281-b951-d872f2087c98
* autocomplete: Extract the two classes in autocomplete_edit.h into their files.tfarina@chromium.org2012-06-231-1/+0
| | | | | | | | | BUG=94842 R=pkasting@chromium.org Review URL: https://chromiumcodereview.appspot.com/10617003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143762 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Add ExternalTabContainer interface.tfarina@chromium.org2012-06-211-4/+0
| | | | | | | | | | | | | | | This allow us to remove a dependency in chrome/browser/ui/views from automation. BUG=125846 R=ananta@chromium.org,robertshield@chromium.org TBR=ben@chromium.org NOTRY=true Review URL: https://chromiumcodereview.appspot.com/10536198 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143349 0039d316-1c4b-4281-b951-d872f2087c98
* Replace usage of browser::FindBrowserForController with ↵ben@chromium.org2012-06-191-6/+4
| | | | | | | | | | browser::FindBrowserWithWebContents http://crbug.com/133414 TEST=none Review URL: https://chromiumcodereview.appspot.com/10536196 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143039 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 43.avi@chromium.org2012-06-121-2/+1
| | | | | | | | | | | | GetOwningTabContentsForWebContents BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10535120 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141602 0039d316-1c4b-4281-b951-d872f2087c98
* TabContentsWrapper -> TabContents, part 6.avi@chromium.org2012-06-081-5/+5
| | | | | | | | | | | | Automation. BUG=131026 TEST=no change Review URL: https://chromiumcodereview.appspot.com/10536058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141127 0039d316-1c4b-4281-b951-d872f2087c98
* Add automation hooks for OOBE transitions.ivankr@chromium.org2012-06-041-4/+4
| | | | | | | | | BUG=126848, chromium-os:12702 TEST=suite:smoke, desktopui_PyAutoFunctionalTests,login_* autotests Review URL: https://chromiumcodereview.appspot.com/10452014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140279 0039d316-1c4b-4281-b951-d872f2087c98
* Teaching BrowsingDataRemover how to delete application data.mkwst@chromium.org2012-06-041-1/+2
| | | | | | | | | | | | | | Adding a parameter to BrowsingDataRemover::Remove in order to support a "Clear app data" flag in the "Clear Browsing Data UI". Additionally, this CL pulls the implementation of DomStorageContext::DeleteDataModifiedSince out of DomStorageContext, and into BrowsingDataRemover in order to manage the complexities of decision-making in the BDR, rather than exporting them out of chrome and into webkit. This patch only addresses localStorage/sessionStorage and quota managed data. Cookies should already ignore the special storage policy, but we'll need to examine the remainder of the types that the BDR touches. BUG=116372 TEST=unit_tests,test_shell_tests Review URL: https://chromiumcodereview.appspot.com/10413072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@140273 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate the rest of the "global" prefs.falken@google.com2012-05-221-2/+1
| | | | | | | | | | | | This is a continuation of the work in r137835. TBR=gene for cloud print, mpcomplete for extension BUG=123812 TEST=browser_tests --gtest_filter=PrefsTab* and ExtensionApiTest.Font* Review URL: https://chromiumcodereview.appspot.com/10409046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138219 0039d316-1c4b-4281-b951-d872f2087c98
* Moves methods for finding browsers to browser_finder.sky@chromium.org2012-05-161-2/+2
| | | | | | | | | | | BUG=none TEST=none R=ben@chromium.org TBR=tim@chromium.org, davemoore@chromium.org, scottbyer@chromium.org, keybuk@chromium.org Review URL: https://chromiumcodereview.appspot.com/10391158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137511 0039d316-1c4b-4281-b951-d872f2087c98
* [chromeos] Automation calls should use the right profile after loginnirnimesh@chromium.org2012-05-151-0/+4
| | | | | | | | | | | | | | | | | | | AutomationProvider keeps a handle to Profile*, initialized at construction, and uses it for a bunch of automation calls including OpenNewBrowserWindow(). The profile in use changes at login on chromeos, which means that AutomationProvider's Profile* is obsolete. Adding code to update AutomatinProvider's Profile* at successful login. BUG=127893, chromium-os:18249 TEST=pyauto test: chromeos_login.ChromeosLogin.testInitialLoginState R=dtu@chromium.org Review URL: https://chromiumcodereview.appspot.com/10356142 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@137302 0039d316-1c4b-4281-b951-d872f2087c98
* Convert the infobars ui_test to a browser_test. Remove the ExtensionProxy ↵jam@chromium.org2012-04-181-252/+0
| | | | | | | | | class which is now unused, its associated test, and the all the dependent code. BUG=121574 Review URL: https://chromiumcodereview.appspot.com/10115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@132796 0039d316-1c4b-4281-b951-d872f2087c98
* Convert login prompt ui_tests to browser_tests.jam@chromium.org2012-04-121-10/+0
| | | | | | | BUG=121574 Review URL: https://chromiumcodereview.appspot.com/10051023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131993 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 13676 - Revert 131665 - Add a preference for why an extension is ↵yoz@chromium.org2012-04-111-1/+1
| | | | | | | | | | | | | | disabled. Doesn't delete the CRXes yet since ExtensionManagementApiEscalationTest needs them. BUG=121436 TEST=browser_tests TBR=aa@chromium.org Review URL: https://chromiumcodereview.appspot.com/9960087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131678 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 131665 - Add a preference for why an extension is disabled.rsesek@chromium.org2012-04-101-1/+1
| | | | | | | | | | | | | | | | | | Broke linux browser_tests ExtensionManagementApiEscalationTest.DisabledReason,ReEnable Don't show the permissions upgrade alert for extensions disabled by the user. For existing disabled extensions, guess the disabling reason from whether they exceed their granted permissions. BUG=121436 TEST=ExtensionDisabledGlobalErrorTest.* TBR=csilv@chromium.org,jianli@chromium.org,mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10014005 TBR=yoz@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131676 0039d316-1c4b-4281-b951-d872f2087c98
* Add a preference for why an extension is disabled.yoz@chromium.org2012-04-101-1/+1
| | | | | | | | | | | | | | Don't show the permissions upgrade alert for extensions disabled by the user. For existing disabled extensions, guess the disabling reason from whether they exceed their granted permissions. BUG=121436 TEST=ExtensionDisabledGlobalErrorTest.* TBR=csilv@chromium.org,jianli@chromium.org,mark@chromium.org Review URL: https://chromiumcodereview.appspot.com/10014005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@131665 0039d316-1c4b-4281-b951-d872f2087c98
* Add ExtensionSytem::Get(Profile*) as a wrapper aroundmpcomplete@chromium.org2012-04-051-2/+1
| | | | | | | | | | | | | | | ExtensionSystemFactory::GetForProfile. Switch callsites to use that. BUG=104095 TEST=no TBR=akalin TBR=mirandac TBR=jrg TBR=arv Review URL: https://chromiumcodereview.appspot.com/9977021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130785 0039d316-1c4b-4281-b951-d872f2087c98
* Move ExternalTabContainer into a directory with an OWNERS file.robertshield@chromium.org2012-04-031-1/+1
| | | | | | | | | BUG=120901 TEST=NONE Review URL: https://chromiumcodereview.appspot.com/9959051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130508 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 125805 - Reland 124817 - A profile-keyed service for Extensions, ↵yoz@chromium.org2012-04-021-1/+3
| | | | | | | | | | | | | | | | | ExtensionSystem. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. New since last time: Moved LazyBackgroundTaskQueue into ExtensionSystem. BUG=104095 TEST=Open and close an incognito window; should not crash. TBR=aa@chromium.org,akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/9959040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@130128 0039d316-1c4b-4281-b951-d872f2087c98
* Original CL (http://codereview.chromium.org/9390038/) somehow got screwed ↵oshima@chromium.org2012-03-161-1/+0
| | | | | | | | | | | | | | | | | | | | | | | and CQ couldn't patch it. This is exact copy of the original CL to land. * Move automation/ui_controls to ui/ui_controls * Refactored aura impl so that ui/ui_controls doesn't depend on aura. * Moved MoveMouseToCenterAndPress to ui_test_util.h as it depends on views and can't be declared in ui. * a couple of cleanups: - Renamed gtk_screen_utils.h to _util.h to match other util.h files. - indent fix - remove unnecessary includes. This CL allows a test to use ui_controls without depending on chrome. TBR=sky@chromium.org,erg@chromium.org BUG=none TEST=none Review URL: http://codereview.chromium.org/9699098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@127138 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Content API around TracingController.jam@chromium.org2012-03-131-0/+2
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9694028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126396 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Reland 124817 - Take extensions out of Profile into a profile-keyed ↵akalin@chromium.org2012-03-091-3/+1
| | | | | | | | | | | | | | service, ExtensionSystem." I believe this change is causing failures in [SocketApiTest.Socket{TCP,UDP}Extension. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/9648026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125815 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 124817 - Take extensions out of Profile into a profile-keyed service, ↵yoz@chromium.org2012-03-091-1/+3
| | | | | | | | | | | | | | | | | ExtensionSystem. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. New: PrerenderManagerFactory DependsOn ExtensionSystemFactory. BUG=104095 TEST=Open and close an incognito window; should not crash. TBR=aa@chromium.org,akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/9609024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125805 0039d316-1c4b-4281-b951-d872f2087c98
* Move Render(View|Widget)Host and associated classes to content namespace.joi@chromium.org2012-03-071-0/+1
| | | | | | | | | TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9600036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
* Renaming virtual setters/getters in UserManager.nkostylev@chromium.org2012-03-061-1/+1
| | | | | | | | | | | | | | | | | | Follow up CL for http://codereview.chromium.org/9348022/ * Renamed unix_hacker to CamelStyle methods from UserManager as they are not non-virtual getters and setters any more. - user_is_logged_in() - logged_in_user() - current_user_is_owner() / set_current_user_is_owner() - current_user_is_new() - downloaded_profile_image() BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/9355059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125230 0039d316-1c4b-4281-b951-d872f2087c98
* Move RenderWidgetHost and RenderViewHost interfaces to their own files.joi@chromium.org2012-03-061-1/+1
| | | | | | | | | | | This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl. TBR=jam@chromium.org BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9599011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
* Extract minimal RenderViewHost interface for embedders, leavingjoi@chromium.org2012-03-051-1/+1
| | | | | | | | | | | | RenderViewHostImpl for content. TBR=darin@chromium.org BUG=98716 Review URL: http://codereview.chromium.org/9473001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124941 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 124817 - Take extensions out of Profile into a profile-keyed service, ↵vandebo@chromium.org2012-03-031-3/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | ExtensionSystem. This may be causing this crash: Note: Google Test filter = PrerenderBrowserTest.PrerenderUnload [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from PrerenderBrowserTest, where TypeParam = [ RUN ] PrerenderBrowserTest.PrerenderUnload [2464:2324:0302/211059:6709843:FATAL:profile_dependency_manager.cc(134)] Check failed: false. Attempted to access a Profile that was ShutDown(). This is most likely a heap smasher in progress. After ProfileKeyedService::Shutdown() completes, your service MUST NOT refer to depended Profile services again. Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. BUG=104095 TEST=Open and close an incognito window; should not crash. Review URL: http://codereview.chromium.org/9369013 TBR=yoz@chromium.org Review URL: https://chromiumcodereview.appspot.com/9583036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124831 0039d316-1c4b-4281-b951-d872f2087c98
* Take extensions out of Profile into a profile-keyed service, ExtensionSystem.yoz@chromium.org2012-03-031-1/+3
| | | | | | | | | | | | | Move InitExtensions into ExtensionSystem. Remove a few accessors (ExtensionDevToolsManager, ExtensionMessageService). The others have too many callers to fix in one go. BUG=104095 TEST=Open and close an incognito window; should not crash. Review URL: http://codereview.chromium.org/9369013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124817 0039d316-1c4b-4281-b951-d872f2087c98
* more logs for 26646oshima@chromium.org2012-03-021-0/+1
| | | | | | | | | BUG=chromium-os:26646 TEST=none Review URL: https://chromiumcodereview.appspot.com/9582019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124725 0039d316-1c4b-4281-b951-d872f2087c98
* Break two classes defined in json_value_serializer.cc, .h into separate files.bbudge@chromium.org2012-02-261-1/+1
| | | | | | | | | This will allow the use of JSONStringValueSerializer in the NaCl sandbox. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/9465030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123701 0039d316-1c4b-4281-b951-d872f2087c98
* Use SequencedWorkerPool for disk operations in TraceSubscriberStdio.husky@chromium.org2012-02-241-2/+2
| | | | | | | | | | | | | | | | | This class was hitting a ThreadRestrictions assert because it called OpenFile on the UI thread. To reduce unnecessary copying, I've changed the OnTraceDataCollected argument from std::string to RefCountedString. Second attempt (originally committed in 123140, reverted in 123146). Added DISALLOW_COPY_AND_ASSIGN to fix Windows compilation error. BUG=None TEST=content_unittests Review URL: http://codereview.chromium.org/9443020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123433 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 123140 - Use SequencedWorkerPool for disk operations in ↵groby@chromium.org2012-02-231-2/+2
| | | | | | | | | | | | | | | | | | | | | TraceSubscriberStdio. Reverted since it causes compile failure on Win/Aura. (scoped_refptr of TraceSubscriberStdioImpl which is only forward-declared) This class was hitting a ThreadRestrictions assert because it called OpenFile on the UI thread. To reduce unnecessary copying, I've changed the OnTraceDataCollected argument from std::string to RefCountedString. BUG=None TEST=content_unittests Review URL: http://codereview.chromium.org/9333003 TBR=husky@chromium.org Review URL: https://chromiumcodereview.appspot.com/9447003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123146 0039d316-1c4b-4281-b951-d872f2087c98
* Use SequencedWorkerPool for disk operations in TraceSubscriberStdio.husky@chromium.org2012-02-221-2/+2
| | | | | | | | | | | | | This class was hitting a ThreadRestrictions assert because it called OpenFile on the UI thread. To reduce unnecessary copying, I've changed the OnTraceDataCollected argument from std::string to RefCountedString. BUG=None TEST=content_unittests Review URL: http://codereview.chromium.org/9333003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@123140 0039d316-1c4b-4281-b951-d872f2087c98
* Remove ssl_manager.h dependency from chrome.jam@chromium.org2012-02-131-1/+0
| | | | | | | BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9382042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121704 0039d316-1c4b-4281-b951-d872f2087c98
* Disable InitialLoads observers for AutomationProviders after the first one.dtu@chromium.org2012-02-101-16/+26
| | | | | | | | | | | | | When a new AutomationProvider/Proxy pair is created, the Proxy waits for an InitialLoads message from the Provider, indicating that it's ready to perform automation calls. However, the observers used to trigger that message on the Provider side are only designed to work very early on in the browser's startup, when the initial AutomationProvider is created. Therefore, for subsequent AutomationProviders, the message would never get sent. In particular, this problem shows up when using Chromedriver (which creates additional AutomationProviders) on ChromeOS (which has specific observers that have this assumption, NetworkManagerInitObserver and LoginWebuiReadyObserver). This change disables those observers when a TestingAutomationProvider is created by an automation call (which guarantees that the initial loads were already completed, since it's initiated by a previous TestingAutomationProvider). BUG=chromium-os:19556 TEST=Run the PyAuto test on ChromeOS: python pyauto_webdriver.py. It should not fail with "Unable to either launch or connect to Chrome." Other failures may happen. Review URL: https://chromiumcodereview.appspot.com/9368004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@121344 0039d316-1c4b-4281-b951-d872f2087c98
* Move DOMAutomationController code from chrome to content. This is needed by ↵jam@chromium.org2012-02-031-1/+0
| | | | | | | | | | | interstitial pages which are in content, and also browser tests in content. In followup changes, I'll make interstitial pages not have to derive from a concrete class, and instead implement some sort of delegate interface like we did with WebUI. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9310094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120441 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AutomationProvider::InitialLoadsComplete.dtu@chromium.org2012-02-011-9/+12
| | | | | | | | | | BUG=None. TEST=Run any test. Review URL: http://codereview.chromium.org/9301025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@120016 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of SavePackage usage in Chrome. I've moved IsSavableContents onto ↵jam@chromium.org2012-01-201-1/+0
| | | | | | | | | WebContents itself, IsSavableURL to a file in chrome, and made Chrome's DownloadManagerDelegate give SavePackage the file path through a callback. BUG=98716 Review URL: https://chromiumcodereview.appspot.com/9254051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118452 0039d316-1c4b-4281-b951-d872f2087c98
* Rename TabContentsView to WebContentsView and move to content/public.joi@chromium.org2012-01-181-2/+2
| | | | | | | | | | | | | | Also rename TestTabContentsView to TestWebContentsView. Add content namespace to both. TBR=owners (trivial updates) BUG=98716 Review URL: http://codereview.chromium.org/9241011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@118134 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-07 21:13:48 +0000