| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
| |
BUG=none
Review URL: https://chromiumcodereview.appspot.com/24396002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@224949 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=147070
TBR=cimamoglu@google.com
Review URL: https://codereview.chromium.org/22577010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@217025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=254986
TEST=none
TBR=ben@chromium.org
Review URL: https://codereview.chromium.org/18083008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@209145 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=247723
TEST=none
TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/16746002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205281 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=124218
TEST=existing browser_tests, autotests
TBR=ben
Review URL: https://codereview.chromium.org/13878010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195442 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This CL focuses on cookie parser, CanonicalCookie, and making callers pass PRIORITY_DEFAULT where applicable.
What's NOT included in this CL:
- TODO(rogerm): Persistence in SQL database.
- TODO(huangs): Using cookie priority to affect cookie eviction.
- TODO(huangs): Make priorities available for extension API (right now default value is used to set).
- TODO(lower priority): Cookie viewer update.
- TODO(lower priority): WebCookie update in webkit/glue.
BUG=232693
Review URL: https://codereview.chromium.org/14113014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195245 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=162530
Review URL: https://codereview.chromium.org/13375017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191650 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Support for MAC cookies was mostly removed in r126928.
However, changes to the cookie store were not fully
reverted, and new callsites were introduced due to the
interface changes. This fully removes the interfaces
introduced for MAC cookies, including the
CookieMonster::CookieInfo class.
BUG=none
TBR=willchan
Review URL: https://chromiumcodereview.appspot.com/12326056
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@185160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Kept AddBrowser and RemoveBrowser static (having it access the private members of the appropriate list for the browser added/removed); kept AddObserver and RemoveObserver static so that observers are notified about browser additions, removals, and set actives on every desktop (observers should filter if they so desire).
The only calls that are not-static (i.e. for which consumers need to be aware of HostDesktopType) are: iterators, size(), empty(), get(), and GetLastActive(). All the consumers were already made multi-desktop aware in the multiple CLs preceding this one :)!
BUG=129187, 177341
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=183580
Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=183701
Review URL: https://chromiumcodereview.appspot.com/12281006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183853 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
> Merge BrowserListImpl into BrowserList.
>
> Kept AddBrowser and RemoveBrowser static (having it access the private members of the appropriate list for the browser added/removed); kept AddObserver and RemoveObserver static so that observers are notified about browser additions, removals, and set actives on every desktop (observers should filter if they so desire).
>
> The only calls that are not-static (i.e. for which consumers need to be aware of HostDesktopType) are: iterators, size(), empty(), get(), and GetLastActive(). All the consumers were already made multi-desktop aware in the multiple CLs preceding this one :)!
>
> BUG=129187
>
>
> Review URL: https://chromiumcodereview.appspot.com/12281006
TBR=gab@chromium.org
Review URL: https://codereview.chromium.org/12310034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183701 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Kept AddBrowser and RemoveBrowser static (having it access the private members of the appropriate list for the browser added/removed); kept AddObserver and RemoveObserver static so that observers are notified about browser additions, removals, and set actives on every desktop (observers should filter if they so desire).
The only calls that are not-static (i.e. for which consumers need to be aware of HostDesktopType) are: iterators, size(), empty(), get(), and GetLastActive(). All the consumers were already made multi-desktop aware in the multiple CLs preceding this one :)!
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/12281006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@183580 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
string_number_conversions in some chrome subdirectories.
Review URL: https://codereview.chromium.org/12218065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181564 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The automation layer was already hardcoding HOST_DESKTOP_TYPE_NATIVE all over the place and using BrowserList:: methods which were native desktop only; simply making that definitive, if we ever need the automation layer to work with multi-desktop envrionments we can come back later and fix it as a separate task (for now this contributes to getting rid of generic BrowserList:: methods).
Added a BrowserListImpl::get(int index); method to replace the *(...->begin() + index) paradigm which is completely unecessary given the underlying structure of a BrowserListImpl is a std::vector.
BUG=129187
Review URL: https://chromiumcodereview.appspot.com/12217041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@181025 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
in many scenarios.
Some of these are trivial; some others will potentially require more thinking for the feature to be right (e.g., we might want "Continue where I left off" to be per-desktop, etc.), but at least they now work (i.e., do something) on multi-desktop environments.
Clear candidates for separate desktop-specific iteration were left out in this CL as well as non-trivial swaps which I'll put in their own CL.
This CL is making progress towards getting rid of BrowserList::const_iterator (non-multi-desktop aware) and removes BrowserList::iterator which was already no longer used.
BUG=129187, 170753
Review URL: https://chromiumcodereview.appspot.com/12114034
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@180095 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=163671
Review URL: https://chromiumcodereview.appspot.com/12047128
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178990 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=167548
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/11833044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=167548
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/11674002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BrowserProcess::print_preview_tab_controller() to print_preview_dialog_controller().
BUG=163671
Review URL: https://codereview.chromium.org/11557030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@173856 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107201,163671
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/11316290
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171558 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces the deprecated calls that ran directly through the Profile object.
This is about half of the total GetExtensionService calls in the codebase, but this CL is already ridiculously large.
BUG= http://code.google.com/p/chromium/issues/detail?id=104095
Review URL: https://chromiumcodereview.appspot.com/11365181
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170497 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=no functional change
Review URL: https://chromiumcodereview.appspot.com/11411035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168648 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
through the ExtensionSystem. Extension services were made into ProfileKeyedServices a while ago; this replaces all the deprecated calls that ran directly through the Profile object.
BUG=104095
Review URL: https://chromiumcodereview.appspot.com/11246003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163846 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
propogate to the system.
TestingAutomationProvider Get/SetProxySettings:
1. uses profile on shell
2. handles shared proxy settings through internetoptionshandler
3. changed setproxysettings from a browserhandler call to handler call
Pyauto.py:
1. Gets servicepath and network type for sharedproxysettings call
2. uses network_type parameter (used to be windex) to get network information, since setproxysettings
is now a handler call.
Chromeos_proxy.py:
1. changed to check value in result dictionary instead of presence of key
2. navigate to url and perform setup needed to setproxysettings
TEST=functional/chromeos_proxy.py
BUG=27040
Review URL: https://chromiumcodereview.appspot.com/10829388
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@157295 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no visible change
Review URL: https://chromiumcodereview.appspot.com/10928096
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@156292 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=107201
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10891044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
This change allows testing using Chrome webdriver on App v2 windows. It exposes (via window_handles) and allows switching control to App v2 windows for testing.
BUG=6801177
Review URL: https://chromiumcodereview.appspot.com/10854026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@151328 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=137014,112155
TEST=no
TBR=sky@chromium.org, erg@chromium.org, tony@chromium.org, eroman@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10785017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@147222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=133903
TEST=none
TBR=sky@chromium.org,wtc@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10694093
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@146121 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
http://crbug.com/133576
TEST=none
Review URL: https://chromiumcodereview.appspot.com/10702029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@145015 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Automation.
BUG=131026
TEST=no change
Review URL: https://chromiumcodereview.appspot.com/10536058
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141127 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
Chrome. Store the enum value in the WebContents' property bag.
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/10409088
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=117262
TBR=aa@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10375021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138074 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
EPM:all_hosts_ is used to look for extension render view hosts,
under the assumption it has all of them. This assumption is wrong,
and the name is confusing, so we're removing all_hosts_. A different
container can be used: all_extension_views, which contains
all the RenderViewHosts for extensions.
BUG=102617
TEST=Covered by existing tests
Review URL: http://codereview.chromium.org/10113005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134028 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Once complete, forwarding headers will be removed from net/base/ .
TEST=none
R=willchan
Review URL: http://codereview.chromium.org/9703062
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@126999 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
interact with.
BUG=chromedriver:19
TEST=none
Review URL: http://codereview.chromium.org/9602024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9600036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125388 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This also finishes breaking the Chrome dependency on RenderWidgetHostImpl and RenderViewHostImpl.
TBR=jam@chromium.org
BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9599011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@125166 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
RenderViewHostImpl for content.
TBR=darin@chromium.org
BUG=98716
Review URL: http://codereview.chromium.org/9473001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124941 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- renames ExtensionPermissionsManager to extensions::PermissionsUpdater
- PermissionsUpdaters are now created on demand (vs one per ExtensionService)
- move some includes into the *.cc files
- moves a couple common methods to extension_permissions_api_helpers.cc
BUG=none
TEST=existing
Review URL: http://codereview.chromium.org/8493017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116673 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/9085006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116322 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
GetWebContents() instead.
BUG=98716
TBR=joi
Review URL: http://codereview.chromium.org/8986009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@116086 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the WebContents interface.
BUG=98716
Review URL: http://codereview.chromium.org/9021022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the WebContents interface.
BUG=98716
Review URL: http://codereview.chromium.org/9007026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115200 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also, don't throw an alert error in set selected if the selection causes
an alert.
BUG=94959
TEST=none
Review URL: http://codereview.chromium.org/8965008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114874 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/8771065
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113320 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
tabs, particularly extension bg pages, infobars, and popups. This is
needed to enable WebDriver to work with these views.
BUG=93571
TEST=none
Review URL: http://codereview.chromium.org/8790003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
interface is implemented by the RenderProcessHostImpl class which lives in content\browser\renderer_host\render_process_host_impl.cc/.h. The RenderProcessHostImpl class is a consolidation of the RenderProcessHost and BrowserRenderProcessHost classes.
The RenderProcessHost public interface was created from the now deleted RenderProcessHost class defined in content\browser\renderer_host\render_process_host.h.
Additional methods have been added to the interface to ensure that it works correctly with the MockRenderProcessHost class used by unit tests. I had to implement a number of overrides in the MockRenderProcessHost class to ensure that tests work correctly. This was because of assumptions in the tests that the MockRPH class was a real RPH which it was till now.
Added a TODO for the methods which could potentially be removed from this interface. Will revisit that in a subsequent CL.
BUG=98716
TEST=No change in functionality. Hopefully it all compiles and works.
Review URL: http://codereview.chromium.org/8515027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110615 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This enables short-lived session-only cookies which get deleted as soon as they
expire, not only when the session ends. Short-lived session-only cookies are
created e.g., when content settings allow only session-only cookies.
BUG=NONE
TEST=CookieMonsterTest.ShortLivedSessionCookies
Review URL: http://codereview.chromium.org/8507006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109415 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
file.
Part 1 of upcoming changes to move RPH/BRPH to a public interface.
BUG=98716
Review URL: http://codereview.chromium.org/8451012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108608 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
TBR=owners
BUG=98716
Review URL: http://codereview.chromium.org/8437002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108270 0039d316-1c4b-4281-b951-d872f2087c98
|