summaryrefslogtreecommitdiffstats
path: root/chrome/browser/automation
Commit message (Collapse)AuthorAgeFilesLines
* posix: implement AutomationWindowTracker.evan@chromium.org2009-04-083-16/+37
| | | | | | Review URL: http://codereview.chromium.org/62135 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13331 0039d316-1c4b-4281-b951-d872f2087c98
* Skeleton setup for new Automated UI test framework.huanr@chromium.org2009-04-081-12/+44
| | | | | | | | | | | | | | | | | | | | | | | | | | | | - Add automated_ui_test_base.{cc,h} that defines an AutomatedUITestBase class. This class can be used for both UI test suites and automated UI test running on ChromeBot. - Add automated_ui_test_test and include it in UI test suite so we can individually test all commands provided in AutomatedUITestBase. - Change AutomatedUITest to be a subclass of AutomatedUITestBase. Move RunCommandAsync(), RunCommand(), and NewTab() from AutomatedUITest to AutomatedUITestBase. The plan is moving all individual UI command functions (after they are converted to sync mode) to AutomatedUITestBase so they can be shared by UI test suites and automated UI test. - In automation_provider.cc, add a mapping mechanism from command to notification type. This will make it easy to add more command types. Review URL: http://codereview.chromium.org/56190 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13312 0039d316-1c4b-4281-b951-d872f2087c98
* linux: pass a bunch more ui tests.evan@chromium.org2009-04-071-0/+2
| | | | | | | | Mostly random portability fixes: use portable functions, use FilePath, etc. Review URL: http://codereview.chromium.org/62117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13302 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land popup routing fix for browser.ben@chromium.org2009-04-071-2/+3
| | | | | | | | | | Just the bugfix + test now. Test is disabled pending a working framework. http://crbug.com/8472 Review URL: http://codereview.chromium.org/59007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13282 0039d316-1c4b-4281-b951-d872f2087c98
* Refactor AppModalDialogQueue and move JS Alert boxes into a MVC.tc@google.com2009-04-071-9/+6
| | | | | | | | | | | | JavascriptMessageBoxHandler (handles alert, confirm, prompt, and onbeforeunload) was a views class. This change converts it into an MVC so we can port to linux/mac. AppModalDialog is the model+controller, JavascriptMessageBoxDialog is the windows specific view. The onbeforeunload dialog (JavascriptBeforeUnloadHandler) was a subclass of JavascriptMessageBoxHandler that had a different title and button text. I merged this class into JavascriptMessageBoxHandler by passing a bool to handle the custom button text. Review URL: http://codereview.chromium.org/63033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13276 0039d316-1c4b-4281-b951-d872f2087c98
* Updated the AutomationMsg_TabReposition IPC to be able to set the parent of ↵ananta@chromium.org2009-04-071-0/+8
| | | | | | | | | | a window. Bug=1751431 Review URL: http://codereview.chromium.org/62042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13253 0039d316-1c4b-4281-b951-d872f2087c98
* Switching things to FilePath:phajdan.jr@chromium.org2009-04-072-5/+4
| | | | | | | | | | | | | | | | Remove following deprecated wstring-using functions: net/net_util: FilePathToFileURL net/net_util: FileURLToFilePath Switch net/base/upload_data to FilePath. Switch upload-related parts of net/url_request/url_request to FilePath. Made necessary adjustments in rest of code (a lot). Review URL: http://codereview.chromium.org/63011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13242 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the Find bar ownership to the Browser object for portability and ↵finnur@chromium.org2009-04-051-17/+9
| | | | | | | | testability purposes.BUG=None.TEST=No new functionality, just moving stuff around and as such it is covered by pre-existing tests. Review URL: http://codereview.chromium.org/60105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13134 0039d316-1c4b-4281-b951-d872f2087c98
* Remove some uses of custom tab contents types from some tests.brettw@chromium.org2009-04-041-29/+17
| | | | | | | | | | | | | | | This required redoing the tests that used it to use the new RenderViewHost test harness. This is mostly straightforward, but required more work for the NavigationController tests. I removed a few random places that were testing for the tab types. I also made different versions of a few functions that don't take tab contents types next to the existing ones that do, so my touched code won't have to be changed again when I remove the tab contents types. Review URL: http://codereview.chromium.org/62039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13132 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Move IPC code to ipc/"agl@chromium.org2009-04-032-3/+3
| | | | | | | This reverts commit r13062 which, unsurprisingly, broke the build. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13063 0039d316-1c4b-4281-b951-d872f2087c98
* Move IPC code to ipc/agl@chromium.org2009-04-032-3/+3
| | | | | | | (No review URL: Rietvelt couldn't cope) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13062 0039d316-1c4b-4281-b951-d872f2087c98
* Use WebScriptSource and WebFindInPageRequest from the WebKit API.darin@chromium.org2009-03-312-8/+7
| | | | | | | | | | | | | | | | | | This change introduces some helper functions in glue_util.cc for efficient conversion between WebString and WebCore::String when inside the implementation of webkit/glue. This is a temporary change since eventually all code in glue that uses WebCore will be moved into the WebKit API implementation. Instead of making the Chrome automation use WebFindInPageRequest, I decided to introduce AutomationMsg_Find_Params as a copy of the old FindInPageRequest structure. That preserves the IPC protocol and avoids making the automation library depend on WebKit. R=dglazkov Review URL: http://codereview.chromium.org/57060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12881 0039d316-1c4b-4281-b951-d872f2087c98
* Mechanic change based on comment from previous code review.huanr@chromium.org2009-03-311-6/+5
| | | | | | | | | Rename RunCommand to RunCommandAsync and RunCommandSync to RunCommand. Review URL: http://codereview.chromium.org/57039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12836 0039d316-1c4b-4281-b951-d872f2087c98
* This check in is the initial step to try improve UIhuanr@chromium.org2009-03-272-0/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | automation framework. Currently we are not consistent in UI automation. After receiving the automation message, the automation provider in browser does not always execute UI commands synchronously. In many cases, it simply sends back an acknowledgement and dispatches the command. On the test client side, it waits and polls the result after sending the message. I think this causes lots of UI test flakeyness and makes the test slow. I plan to convert all asynchronous execution to synchronous. It may take some time to get them all done. I CC'ed a few people so they are aware of this ongoing work. Feel free to comment on whether and how to address the issue. This check in adds an UI automation message AutomationMsg_WindowExecuteCommandSync that executes accelerators synchronously. The existing automation message AutomationMsg_WindowExecuteCommand only dispatches the accelerator. There are many UI accelerators using the existing async version. In this check in I only made the conversion for IDC_NEW_TAB to try out the new mechanism. Review URL: http://codereview.chromium.org/53108 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12632 0039d316-1c4b-4281-b951-d872f2087c98
* Redone http://codereview.chromium.org/42571idanan@chromium.org2009-03-241-2/+2
| | | | | | | | | | | Issue 6477: Support modifier clicks on UI elements Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=maruel Review URL: http://codereview.chromium.org/53020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12403 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting r12383, caused a build breakage on all platforms.maruel@chromium.org2009-03-241-2/+2
| | | | | | | TBR=idanan Review URL: http://codereview.chromium.org/42571 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12385 0039d316-1c4b-4281-b951-d872f2087c98
* Issue 6477: Support modifier clicks on UI elementsidanan@chromium.org2009-03-241-2/+2
| | | | | | | | | | | | | | | | | | | Mouse event flags transformed to WindoOpenDisposition so that browser commands can all inteterpert event modifiers. Implemented home, forward and backwards middle-click andshift middle click. Previously working on issue 358 which was market a duplicate and concerned with the home and tabstrip subset of this behavior: Can't open a new tab by middle-clicking home button. No functionality has been lost or altered, only the use ofmodifiers give access to increased functionality. BUG=6477 TBR=ben@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12383 0039d316-1c4b-4281-b951-d872f2087c98
* Enable first UI test on Linux (browser/images_uitest.cc)phajdan.jr@chromium.org2009-03-201-0/+2
| | | | | | | | | - less things #ifdef-ed - replaced Windows-specific functions with portable equivalents Review URL: http://codereview.chromium.org/50059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12213 0039d316-1c4b-4281-b951-d872f2087c98
* Make startup_tests build and work on Mac.phajdan.jr@chromium.org2009-03-184-0/+24
| | | | | | | | | | Also ensure that Chromium.app quits properly between the tests. http://crbug.com/8391 Review URL: http://codereview.chromium.org/42306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11998 0039d316-1c4b-4281-b951-d872f2087c98
* Move windowing related objects into chrome/views/window subdir.ben@chromium.org2009-03-171-2/+2
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/42272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
* Move widget related files into views/widgetben@chromium.org2009-03-171-1/+1
| | | | | | | TBR=sky git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11811 0039d316-1c4b-4281-b951-d872f2087c98
* forgot this fileben@chromium.org2009-03-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11701 0039d316-1c4b-4281-b951-d872f2087c98
* rollback againben@chromium.org2009-03-141-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11696 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-141-1/+1
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42201 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11695 0039d316-1c4b-4281-b951-d872f2087c98
* revertben@chromium.org2009-03-131-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11671 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Window->WindowWinben@chromium.org2009-03-131-1/+1
| | | | | | | | | Pull basic Window interface out of WindowWin into new interface, Window. Convert code to use it. Review URL: http://codereview.chromium.org/42169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11668 0039d316-1c4b-4281-b951-d872f2087c98
* wtc: please look at URL related code, and hooks and nitsjar@chromium.org2009-03-132-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | you might have commented on before. huanr: please look at sdch_filter code. The intent was no semantic change, and only change in histograms and stats gathered. I wanted to be sure I had better stats on several failure cases, as the turn-around time of adding stats to instrument such cases after they surface is just too long. The big feature is the mechanism for getting the total number of bytes passed to a filter. We use the filter context to achieve this, and then the SDCH filter can calculate compression ratio (from pre-gunzip vs post SDCH decompress). The number of bytes read was also histogrammed in a number of error scenarios, to better diagnose what is going on when these cases arrise (example: When some data is still buffered in the VCDIFF decoder). The sdch_filter destructor was getting long and hard to read with multiple if blocks, so I cleaned that up as well a bit (less indentation, and use of early returns). Nits not included in previous CL that earlier are listed as well. r=wtc,huanr Review URL: http://codereview.chromium.org/40319 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11665 0039d316-1c4b-4281-b951-d872f2087c98
* Add support for repositioning/resizing a tab window. This is needed as the ↵ananta@chromium.org2009-03-132-0/+29
| | | | | | | | | | SetWindowPos call can fail on Vista if the caller is running under low IL. Review URL: http://codereview.chromium.org/42150 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11604 0039d316-1c4b-4281-b951-d872f2087c98
* Fix 'inspect element' crash when hosted in external tabamit@chromium.org2009-03-121-5/+6
| | | | | | | | | | | | | | If chrome tab is hosted in an external tab and 'inspect element' is invoked via GUI (as opposed to sending an automation request for AutomationMsg_InspectElement), we get a crash in AutomationProvider::ReceivedInspectElementResponse BUG=1694650 Review URL: http://codereview.chromium.org/43102 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11587 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGEdeanm@chromium.org2009-03-1016-16/+0
| | | | | | | | | Normalize end of file newlines in chrome/. All files end in a single newline. Review URL: http://codereview.chromium.org/42015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11331 0039d316-1c4b-4281-b951-d872f2087c98
* Changing ForwardMessageToExternalHost to postMessage and passing a propertommi@chromium.org2009-03-092-4/+8
| | | | | | | | | | | | | | | MessageEvent object to the onmessage handler. Also adding support for origin and target parameters. The origin parameter is implicit but target can be specified when calling postMessage. If no target is specified we default to "*". At the moment I'm only allowing target == "*" messages to pass through since I haven't implemented support for matching more complicated patterns :) Review URL: http://codereview.chromium.org/40128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11275 0039d316-1c4b-4281-b951-d872f2087c98
* Use FilterContext to allow filters to access URLRequestJob datajar@chromium.org2009-03-094-7/+28
| | | | | | | r=wtc,darin,huanr Review URL: http://codereview.chromium.org/40138 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11248 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NavigationEntry title to string16. TabContents::GetTitle no longer needsbrettw@chromium.org2009-03-041-1/+2
| | | | | | | | | | | | | | | to be virtual, either. This also changes how the display URL is computed. Instead of doing it preemptively, we now do so lazily. This allows us to do the URL formatting correctly using the elider so that we can do IDN and unescaping. I changed string_util's singleton functions. I was worried that other code might make a singleton of string, which would give you this same value as a non-const string. This would mean our empty strings might no longer be empty. Review URL: http://codereview.chromium.org/39022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10872 0039d316-1c4b-4281-b951-d872f2087c98
* Register an onmessage handler with the external host binding instead of ↵ananta@chromium.org2009-03-032-4/+3
| | | | | | | | | | | explicitly passing in a target Javascript function to execute. The onmessage handler is a one argument Javascript function for now. Review URL: http://codereview.chromium.org/28291 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10760 0039d316-1c4b-4281-b951-d872f2087c98
* Separate the AutocompleteEditView from the cross-platform code.deanm@chromium.org2009-03-021-0/+1
| | | | | | | | | | | | Separate the platform specific AutocompleteEditView from the cross-platform model and controller. This leaves the model/controller in autocomplete_edit.{h,cc}, and moves the view into autocomplete_edit_view.h and autocomplete_edit_view_win.{h,cc}. There is now an abstract interface (AutocompleteEditView) which the model uses to talk to the view. Other views (for example, the LocationBarView) will still talk directly to the AutocompleteEditViewWin, which is the full Chrome view. This change also pulled in the Windows specific edit_drop_target code into autocomplete_edit_view_win.cc. Review URL: http://codereview.chromium.org/27327 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10712 0039d316-1c4b-4281-b951-d872f2087c98
* Compile parts of chrome/browser/automation on Linux.phajdan.jr@chromium.org2009-02-253-38/+174
| | | | | | | | | This patch involves heavy temporary stubbing-out of windowsic parts of automation framework. Review URL: http://codereview.chromium.org/28092 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10351 0039d316-1c4b-4281-b951-d872f2087c98
* ui test fail. revert.ben@chromium.org2009-02-251-17/+12
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10322 0039d316-1c4b-4281-b951-d872f2087c98
* AppModalDialogQueue shouldn't depend on views.ben@chromium.org2009-02-251-12/+17
| | | | | | | | Add a simple test, too. Review URL: http://codereview.chromium.org/27080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10320 0039d316-1c4b-4281-b951-d872f2087c98
* Platform cleanup in automation code.phajdan.jr@chromium.org2009-02-242-4/+4
| | | | | | Review URL: http://codereview.chromium.org/27098 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10281 0039d316-1c4b-4281-b951-d872f2087c98
* The find bar should be owned and managed from the BrowserView, not the ↵finnur@google.com2009-02-241-28/+29
| | | | | | | | | | | | | | | | | | | | | | | | WebContentsView, since it's part of the "chrome". Design Doc: http://dev.chromium.org/developers/design-documents/find-bar Things done: - Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed. - Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view. - Moved find control methods to WebContents. - Added recent find result state to WebContents. - Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered. - Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc. - Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs. - Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab. - view.h: Don't lay out child views again if they have a layout manager, it already updated them. TEST=Find box should work as before. BUG=3245 Review URL: http://codereview.chromium.org/27025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the amount of included header files. Vast change like in "Oh God! ↵maruel@chromium.org2009-02-183-0/+3
| | | | | | | | This revision changes half of the source files!". Review URL: http://codereview.chromium.org/20378 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9958 0039d316-1c4b-4281-b951-d872f2087c98
* Enabling the BrowsersRememberFocus interactive UI test. The fix is to change theananta@chromium.org2009-02-132-3/+2
| | | | | | | | | AutomationMsg_ActivateWindow and AutomationMsg_OpenNewBrowserWindow automation messages to sync messages. Review URL: http://codereview.chromium.org/20363 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9800 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the AutomationMsg_SavePackageShouldPromptUser message to a sync messageananta@chromium.org2009-02-112-4/+2
| | | | | | | | | | to fix the SavePage tests on Vista. TBR=jam Review URL: http://codereview.chromium.org/21265 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9592 0039d316-1c4b-4281-b951-d872f2087c98
* The Chrome Automation framework is based on a homegrown request response IPC ↵ananta@chromium.org2009-02-112-845/+846
| | | | | | | | | | model and thus ends up duplicating a lot of functionality already available in the SyncChannel. This CL gets the automation framework to use the SyncChannel. The request response IPCs have been changed to sync IPCs. Review URL: http://codereview.chromium.org/20189 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9585 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from HWNDs to NativeViews, take 2. (First attempt was r9409, in which ↵avi@chromium.org2009-02-101-2/+2
| | | | | | | | I missed a file.) Review URL: http://codereview.chromium.org/20226 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9507 0039d316-1c4b-4281-b951-d872f2087c98
* fix compile failurekuchhal@chromium.org2009-02-101-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9482 0039d316-1c4b-4281-b951-d872f2087c98
* Try reverting r9409 to see if it fixes crashes on chromebot.kuchhal@chromium.org2009-02-101-1/+1
| | | | | | | TBR=avi Review URL: http://codereview.chromium.org/21215 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9481 0039d316-1c4b-4281-b951-d872f2087c98
* Reapplying tab support (change 9388). I synced and re-applied my change and ↵tommi@chromium.org2009-02-102-20/+37
| | | | | | | | | | | | | | found the automation tests not hanging. I also took a look at the logs from the hanging buildbots and the reverted change didn't touch on any of the code that appeared to be hanging. I also put breakpoints on the modified functions while running ui_tests.exe and nothing hit, so it looks like a fluke. I did get a hang though when running an old build of ui_tests.exe with a new version of chrome.dll. Is there any chance that there could have been a stale version on the build bots? Review URL: http://codereview.chromium.org/20214 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9478 0039d316-1c4b-4281-b951-d872f2087c98
* Switch from HWNDs to NativeViews.avi@chromium.org2009-02-091-5/+3
| | | | | | Review URL: http://codereview.chromium.org/21143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9409 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 9388 to see if this fixes ui tests.kuchhal@chromium.org2009-02-092-37/+22
| | | | | | | TBR=tommi Review URL: http://codereview.chromium.org/20179 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9392 0039d316-1c4b-4281-b951-d872f2087c98