summaryrefslogtreecommitdiffstats
path: root/chrome/browser/automation
Commit message (Collapse)AuthorAgeFilesLines
* ChromeFrame uses the IPC automation channel to talk to Chrome. The IPC ↵ananta@chromium.org2009-12-103-0/+146
| | | | | | | | | | | | | | | | | messages sent by ChromeFrame are handled by the AutomationProvider class in Chrome, which also handles other IPC's not used by ChromeFrame. We now have a new class ChromeFrameAutomationProvider which derives from the AutomationProvider class and validates that incoming IPC messages are valid ChromeFrame messages. Bug=29931 Test=Covered by unit test Review URL: http://codereview.chromium.org/476008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34290 0039d316-1c4b-4281-b951-d872f2087c98
* Use gfx::Point instead of GET_X/Y_LPARAM to reduce the dependency on ATL. jhawkins@chromium.org2009-12-071-2/+3
| | | | | | | | | | | Patch from Thiago Farina <thiago.farina@gmail.com> Original review: http://codereview.chromium.org/465004 BUG=5027 TEST=None Review URL: http://codereview.chromium.org/460121 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33996 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce the logging output when running startup tests on linux/mac.tony@chromium.org2009-12-031-1/+1
| | | | | | Review URL: http://codereview.chromium.org/464021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33717 0039d316-1c4b-4281-b951-d872f2087c98
* Speculative fix for ChromeFrame crash in bug ↵ananta@chromium.org2009-12-022-6/+8
| | | | | | | | | | | | | | | | | | | | http://code.google.com/p/chromium/issues/detail?id=29025 The crash occurs while dereferencing the automation channel to send out the SetCookie IPC message on the automation channel to the host browser. Based on what I could see from the crash dump and the code it seems like there could be a scenario where the AutomationResourceContext object could be destroyed while the AutomationCookieStore object is still around and thus ends up with a stale pointer which crashes when dereferenced. Fix is to ensure that all related code paths hold on to a refcounted AutomationResourceContext instance. I will look into whether it is possible to come up with a unit test for this. Bug=29025 Review URL: http://codereview.chromium.org/450020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33524 0039d316-1c4b-4281-b951-d872f2087c98
* Integrate BlacklistManager with Profile.phajdan.jr@chromium.org2009-11-301-3/+0
| | | | | | | | | | | | | Now each Profile has a BlacklistManager that maintains a compiled Blacklist for that Profile. The system does not yet pause user-initiated web requests until the blacklist system is ready. However, the code is not supposed to be ready, and is hidden behind a --enable-privacy-blacklists command-line flag. TEST=Covered by browser_test. BUG=21541 Review URL: http://codereview.chromium.org/371063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33290 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame's host network stack implementation for IE full tab mode ↵ananta@chromium.org2009-11-241-14/+6
| | | | | | | | | | | | | | | | | | | | | | | | implicitly follows redirects. When Chrome receives a notification about a redirect it also attempts to follow the redirect request. While this works in most cases, some sites actually returned an error for the second request initiated by Chrome. Fix is to abort the request in urlmon, when we receive a notification about a redirect. I also fixed the IsRedirectResponse function in the UrlRequestAutomationJob class to only treat 301, 302, 303 and 307 as redirect codes on the same lines as the default http job. Test=covered by existing network tests. I also verified that http://code.google.com/p/chromium/issues/detail?id=25643 works with this CL. Fixes http://code.google.com/p/chromium/issues/detail?id=28296 Bug=28296 Review URL: http://codereview.chromium.org/402107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32896 0039d316-1c4b-4281-b951-d872f2087c98
* Assorted cleanup.estade@chromium.org2009-11-231-4/+5
| | | | | | | | process: grep for TODO(port), find cruft, clean it up Review URL: http://codereview.chromium.org/427004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32844 0039d316-1c4b-4281-b951-d872f2087c98
* Allow extension port connection requests to provide tab information.mad@chromium.org2009-11-192-4/+13
| | | | | | | | | | For Siggi: http://codereview.chromium.org/408015 BUG=0 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32536 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup some callers now that the restriction that ↵eroman@chromium.org2009-11-192-12/+1
| | | | | | | | | | | | | | | ChromeURLRequestContextGetter be released from the IO thread is gone. This was an anoyance for consumers of URLRequestContextGetter, as they would play tricks doing manual AddRef/Release. The actual removal of this policy happened in: r32129. BUG=None Test=Existing tests don't crash/leak. Review URL: http://codereview.chromium.org/332006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32488 0039d316-1c4b-4281-b951-d872f2087c98
* The AutomationMsg_SetCookie IPC should be channeled to the automation cookie ↵ananta@chromium.org2009-11-171-1/+6
| | | | | | | | | | | | store for ChromeFrame. This ensures that the automation client would receive a callback when the cookie is set on the store. Bug=none Review URL: http://codereview.chromium.org/403004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32188 0039d316-1c4b-4281-b951-d872f2087c98
* amit, please review everything, jam please review the changes to the ↵ananta@chromium.org2009-11-173-259/+46
| | | | | | | | | | | | | | | | | | | | | | | | | | | | tab_contents and the renderer_host sources. Remove the AutomationProfileImpl class which wraps the Chrome profile for an external tab container, which hosts ChromeFrame. This object was used to carry a custom URL request context which was used to intercept HTTP requests and cookie requests issued by external tabs. However as the life time of the automation profile class depended on the lifetime of the external tab container object this caused a number of crashes in objects which held on to the automation profile pointer retrieved from the associated tab contents. This does not happen in a regualar Chrome browser instance as the profile is deleted at the very end. We can associate the automation URL request context with the underlying tab_contents which would eventually percolate down to the resource message filter. Doing this would avoid the need for the AutomationProfile class. This CL achieves that. Bug=27695,27662 Review URL: http://codereview.chromium.org/385117 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32127 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-138-20/+20
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Small clean-up to not expose base::Process from RenderProcesHost, and ↵jam@chromium.org2009-11-131-1/+2
| | | | | | | | instead only expose base::ProcessHandle. Precursor to moving process startup off the UI thread. Review URL: http://codereview.chromium.org/387047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31922 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31873 - Revert 31862 Ensure AutomationMsg_SetCookieAsync is sent on ↵levin@chromium.org2009-11-131-1/+11
| | | | | | | | | | | | | IO thread. Restoring this change as it seems the blame list was incorrect on some bot and this change wasn't to blame but r31865 was in fact the real culprit. TBR=stoyan@chromium.org Review URL: http://codereview.chromium.org/384116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31892 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31862 - Ensure AutomationMsg_SetCookieAsync is sent on IO thread.levin@chromium.org2009-11-131-11/+1
| | | | | | | | | | | | These tests started failing with this checkin: AuthenticateSuccess AuthenticateWithTokenSuccess Review URL: http://codereview.chromium.org/387042 TBR=stoyan@chromium.org Review URL: http://codereview.chromium.org/389031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31873 0039d316-1c4b-4281-b951-d872f2087c98
* Ensure AutomationMsg_SetCookieAsync is sent on IO thread.stoyan@chromium.org2009-11-131-1/+11
| | | | | | | | | If SetCookie is invoked via automation and load_requests_via_automation is true, the IPC will be sent back from the UI thread. BUG=27568 Review URL: http://codereview.chromium.org/387042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31862 0039d316-1c4b-4281-b951-d872f2087c98
* ChromeFrame HTTP requests would randomly fail if we navigated to multiple ↵ananta@chromium.org2009-11-114-4/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | HTTP sites. This was because the automation resource message filter tracked HTTP requests based on the request ids which are generated by the renderer process. As a result a new request would get created say with id 0, while an existing request would end in ChromeFrame causing the new request to incorrectly shutdown. Fix is to revert back to the original way of tracking requests with an auto incrementing id. The automation url job maintains both ids now, i.e. the automation request id and the chrome request id. The download notification receives the automation id and basically looks up the associated automation request id and sends the notification back to ChromeFrame. This fixes bug http://code.google.com/p/chromium/issues/detail?id=27401 Other fixes in this CL include the following:- 1. The active document instance would never get destroyed. This was because we call ShowUI on the doc host which maintains a reference. We need to call HideUI in Setsite of NULL, which releases the reference. 2. When the active x instance is shutting down we try to shutdown all running requests in the OnDestroy handler. To ensure that the request is deleted from the request map and released in the same thread which created it we post a task back to the ui thread which never runs as the window is being destroyed. Fix is to create a message only window with every urlmonrequest instance which supports task marshaling. Tests in a future CL. Bug=27401 Review URL: http://codereview.chromium.org/386008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31731 0039d316-1c4b-4281-b951-d872f2087c98
* Rename unused "SSL" related automation methods to be generic, since that's ↵johnnyg@chromium.org2009-11-112-16/+16
| | | | | | | | | | | | what these methods actually do, and so I can repurpose them for a different info-bar test. BUG=none TEST=none Review URL: http://codereview.chromium.org/385029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31718 0039d316-1c4b-4281-b951-d872f2087c98
* A large number of style nits in preparation for turning on automated cpplint.py.erg@google.com2009-11-112-3/+3
| | | | | | Review URL: http://codereview.chromium.org/385023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31669 0039d316-1c4b-4281-b951-d872f2087c98
* Adding support for DatabaseTracker messages todumi@chromium.org2009-11-091-0/+3
| | | | | | | | | | | | | DatabaseDispatcherHost. This code will get called as soon as we switch from WebCore's DatabaseTracker implementation to Chromium's. Also, cleaned up the pre-existing support for VFS messages. BUG=none TEST=none Review URL: http://codereview.chromium.org/340067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31507 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 31419 - Commit Issue 255057: Unit Test for Toggling of Encoding ↵willchan@chromium.org2009-11-092-34/+5
| | | | | | | | | | | | | AutoDetect BUG=23617 TEST=BrowserEncodingTest.TestToggleAutoDetect TBR=rolandsteiner@chromium.org Review URL: http://codereview.chromium.org/378031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31465 0039d316-1c4b-4281-b951-d872f2087c98
* Make AutomatedUITestBase.CloseBrowserWindow more solid.phajdan.jr@chromium.org2009-11-091-1/+1
| | | | | | | | | | | | It still crashes the browser under test, but less frequently. Preserving the FLAKY_ mark in the test. TEST=none BUG=14774 Review URL: http://codereview.chromium.org/371066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31441 0039d316-1c4b-4281-b951-d872f2087c98
* Commit Issue 255057: Unit Test for Toggling of Encoding Auto-Detectrolandsteiner@chromium.org2009-11-092-5/+34
| | | | | | | | BUG=23617 TEST=BrowserEncodingTest.TestToggleAutoDetect git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31419 0039d316-1c4b-4281-b951-d872f2087c98
* Kiosk Mode implementation.mhm@chromium.org2009-11-092-0/+25
| | | | | | | | | | | | Kiosk mode will just hide the status bar and initially set it as full screen. Added some tests to add --kiosk mode as a command switch that tests if its in fullscreen state and doesn't have a status bubble. BUG=23145 TEST=Kiosk Mode functions and Run the ./ui_tests --gtest_filter=KioskModeTest.* Review URL: http://codereview.chromium.org/244003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31412 0039d316-1c4b-4281-b951-d872f2087c98
* Modifying extension automation so that it is done through a particularjoi@chromium.org2009-11-085-51/+130
| | | | | | | | | | | | | | | | | | | | | | | | tab for all extension views. Previously, API routing to the automation client would only work for extension views that were contained in the particular ExternalTab instance being automated. This meant you couldn't test API calls from e.g. background pages. Also using async functions instead of the previous RVH-based hack. Updating one of the UI tests to make the API calls from a background page, to provide an end-to-end test of the new routing. This makes AutomationProvider::SetEnableAutomationExtension Windows-only, but it effectively always was since it was already dependent on ExternalTabContainer (indirectly, to provide a non-empty implementation of TabContentsDelegate::ForwardMessageToExternalHost). BUG=none TEST=ui_tests.exe, chrome_frame_tests.exe, chrome_frame_unittests.exe Review URL: http://codereview.chromium.org/366025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31403 0039d316-1c4b-4281-b951-d872f2087c98
* Amit, please review everything.ananta@chromium.org2009-11-071-1/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | jam, please review changes to the plugin create channel IPCs. mpcomplete, please review changes to chrome_plugin_host.cc ChromeFrame needs to intercept URL requests issued directly by plugins like gears to ensure that they get routed through the host browser network stack. We decide whether or not a request is to be handled based on the renderer process id and the render view id (routing id), which get passed in the ViewHostMsg_RequestResource IPC. If this request is issued by Gears then the routing id comes in as MSG_ROUTING_NONE, which causes the request to go through the chrome network stack. Fix is to pass the host render view id to the plugin in the PluginMsg_Init IPC. The plugin already receives the renderer process id. Both these ids now come back in the ViewHostMsg_RequestResource IPC. This fixes an issue with wave when rendered in full tab mode in ChromeFrame, where dropping a file into a wave would cause the renderer to hang. Fixes bug http://code.google.com/p/chromium/issues/detail?id=23992 Bug=23992 Review URL: http://codereview.chromium.org/370007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31387 0039d316-1c4b-4281-b951-d872f2087c98
* Basic wiring to enable downloads for CF's host browser network stack. A ↵tommi@chromium.org2009-11-074-32/+22
| | | | | | | | notable change here is that url automation job id's no longer exist and instead a request id is used. There's a 1 to 1 relation between a job and a request so this is more convenient. Review URL: http://codereview.chromium.org/355036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31363 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-063-4/+12
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* The URLRequestAutomationJob object which needs to route HTTP requests to the ↵ananta@chromium.org2009-11-064-54/+63
| | | | | | | | | | | | | | | | | | | host browser for ChromeFrame's host network stack implementation can register itself as a protocol factory for http/https instead of using the mechanism to intercept HTTP requests which Gears and the App cache use. This ensures that Gears works partially with ChromeFrame. The protocol factory mechanism also has the same limitation as the intercept mechanism, i.e. it does not support chaining. Partial fix for http://code.google.com/p/chromium/issues/detail?id=23992 Bug=23992 Review URL: http://codereview.chromium.org/365009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31208 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-063-12/+4
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Move the spellchecker to the renderer.estade@chromium.org2009-11-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The motivation is that this removes the sync IPC on every call to the spellchecker. Also, currently we spellcheck in the IO thread, which frequently needs to go to disk (in particular, the entire spellcheck dictionary starts paged out), so this will block just the single renderer when that happens, rather than the whole IO thread. This breaks the SpellChecker class into two new classes. 1) On the browser side, we have SpellCheckHost. This class handles browser-wide tasks, such as keeping the custom words list in sync with the on-disk custom words dictionary, downloading missing dictionaries, etc. On Posix, it also opens the bdic file since the renderer isn't allowed to open files. SpellCheckHost is created and destroyed on the UI thread. It is initialized on the file thread. 2) On the renderer side, SpellChecker2. This class will one day be renamed SpellChecker. It handles actual checking of the words, memory maps the dictionary file, loads hunspell, etc. There is one SpellChecker2 per RenderThread (hence one per render process). My intention is for this patch to move Linux to this new approach, and follow up with ports for Windows (which will involve passing a dictionary file name rather than a file descriptor through to the renderer) and Mac (which will involve adding sync ViewHost IPC callsfor when the platform spellchecker is enabled). Note that anyone using the platform spellchecker rather than Hunspell will get no benefit out of this refactor. There should be no loss of functionality for Linux (or any other platform) in this patch. The following should all still work: - dictionary is loaded lazily - hunspell is initialized lazily, per renderer - language changes work. - Dynamic downloading of new dictionaries - auto spell correct works (as well as toggling it). - disabling spellcheck works. - custom words work (including adding in one renderer and immediately having it take effect in other renderers, for certain values of "immediate") TODO: - move spellchecker unit tests to test SpellCheck2 - add sync IPC for platform spellchecker; port to Mac - add dictionary location fallback; port to Windows - remove SpellChecker classes from browser/ BUG=25677 Review URL: http://codereview.chromium.org/357003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31199 0039d316-1c4b-4281-b951-d872f2087c98
* Add a stub implementation of PersonalDataManager, the connection between the ↵jhawkins@chromium.org2009-11-061-0/+3
| | | | | | | | | | database and the autofill manager. BUG=none TEST=none Review URL: http://codereview.chromium.org/360027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31181 0039d316-1c4b-4281-b951-d872f2087c98
* Sixth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-0/+2
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/370001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31176 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-062-4/+10
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/361025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
* Fourth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-052-2/+3
| | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/360043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31167 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-031-2/+1
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30790 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing of r30726, which was reverted as a possible cause of chromeos ↵estade@chromium.org2009-11-022-0/+11
| | | | | | | | | | | | | | | | | | | buildbot failures Handle GTK enter and leave notification events and pass them to WebKit as mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30771 0039d316-1c4b-4281-b951-d872f2087c98
* Sixth patch in getting rid of caching MessageLoop pointers.jam@chromium.org2009-11-022-16/+14
| | | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30737 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Handle GTK enter and leave notification events and pass them to ↵rafaelw@chromium.org2009-11-022-11/+0
| | | | | | | | | | | | WebKit as " This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726 TBR=estade Review URL: http://codereview.chromium.org/343080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30731 0039d316-1c4b-4281-b951-d872f2087c98
* Handle GTK enter and leave notification events and pass them to WebKit as estade@chromium.org2009-11-022-0/+11
| | | | | | | | | | | | | | | | | mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show Review URL: http://codereview.chromium.org/354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30726 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of MessageLoop* caching in extensions code.jam@chromium.org2009-10-301-3/+0
| | | | | | | BUG=25354 Review URL: http://codereview.chromium.org/345023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30550 0039d316-1c4b-4281-b951-d872f2087c98
* Factor search vs. navigate classification into its own file to make it more ↵pkasting@chromium.org2009-10-291-0/+3
| | | | | | | | | broadly usable. Patch by Thiago Farina (see http://codereview.chromium.org/328031 ), r=me. BUG=21317 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30473 0039d316-1c4b-4281-b951-d872f2087c98
* Lazily create the find bar.ben@chromium.org2009-10-291-2/+2
| | | | | | | | | | | http://crbug.com/21910 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30062 Review URL: http://codereview.chromium.org/334019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30434 0039d316-1c4b-4281-b951-d872f2087c98
* Gets AutomationProxyVisibleTest.WindowGetViewBounds to pass onsky@chromium.org2009-10-283-24/+38
| | | | | | | | | | | views/gtk. BUG=none TEST=none Review URL: http://codereview.chromium.org/338067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30403 0039d316-1c4b-4281-b951-d872f2087c98
* First of several patches to get rid of MessageLoop caching now that we have ↵jam@chromium.org2009-10-282-3/+5
| | | | | | | | | ChromeThread::PostTask. BUG=25354 Review URL: http://codereview.chromium.org/342020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30383 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the browser_sync flag.zork@chromium.org2009-10-271-4/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/337034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30272 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at this. The only change between this and the first is to add the ↵sky@chromium.org2009-10-272-1/+24
| | | | | | | | | | | | | | | GetType message to the end of the list and to keep the old message for creating a new browser as well as adding one that takes the type. To change the params of the message requires updating the reference build. That's best done on a weekend when I'm bored. Makes session restore on Chrome OS restore popups. BUG=18862 TEST=none Review URL: http://codereview.chromium.org/329040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30255 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 30194 - Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-272-18/+3
| | | | | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 TBR=sky@chromium.org Review URL: http://codereview.chromium.org/335047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30204 0039d316-1c4b-4281-b951-d872f2087c98
* Makes session restore on Chrome OS restore popups.sky@chromium.org2009-10-272-3/+18
| | | | | | | | | BUG=18862 TEST=none Review URL: http://codereview.chromium.org/337030 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30194 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 30062.glen@chromium.org2009-10-261-2/+2
| | | | | | Review URL: http://codereview.chromium.org/338022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30068 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 14:52:07 +0000