summaryrefslogtreecommitdiffstats
path: root/chrome/browser/blocked_popup_container.cc
Commit message (Collapse)AuthorAgeFilesLines
* GTK Themes: Theme the popup notification.erg@google.com2009-07-071-5/+6
| | | | | | | | | | | | TEST=Open popuptest.com in one tab and anything else in another. Switch between GTK theme and normal. Theme of blocked popup container should change, even when not the active tab. http://crbug.com/13967 Review URL: http://codereview.chromium.org/149277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20085 0039d316-1c4b-4281-b951-d872f2087c98
* Add remaining functionality for popup blocker: popup menu to unblock ↵pinkerton@chromium.org2009-07-061-0/+9
| | | | | | | | | | individual popups and whitelist sites. Also fixes intermittant leak on valgrind bots from poorly constructed unit test. BUG=13160, 15818 TEST=unblocking popups, whitelisting sites, and unwhitelisting them. Green valgrind bot. Review URL: http://codereview.chromium.org/149145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19944 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. ↵pinkerton@chromium.org2009-07-011-6/+0
| | | | | | | | | | Implement displaying of notification, menu of popups still to come. BUG=13160 TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab. Review URL: http://codereview.chromium.org/150132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19735 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-011-7/+0
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: Initialize member view_ to NULL in constructor.finnur@chromium.org2009-06-291-1/+2
| | | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/150028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19499 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-101-4/+4
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Creates a BlockedPopupContainerView interface, and changes the current ↵erg@google.com2009-06-081-6/+55
| | | | | | | | | | BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17905 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the first of probably several patches trying to clean up the ↵erg@google.com2009-06-041-0/+337
| | | | | | | | | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. This version has minor windows compile fixes that changed from under me. Original Review URL: http://codereview.chromium.org/119006 TBR=beng TEST=Popup notification still works. Review URL: http://codereview.chromium.org/119107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17647 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-031-337/+0
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform." This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483). Review URL: http://codereview.chromium.org/118166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-031-0/+337
BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. Review URL: http://codereview.chromium.org/119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98