summaryrefslogtreecommitdiffstats
path: root/chrome/browser/blocked_popup_container.h
Commit message (Collapse)AuthorAgeFilesLines
* Wire popup blocking UI to the new machinery and port over the user's old ↵pkasting@chromium.org2010-02-021-223/+17
| | | | | | | | | | | | | | | | whitelist. Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it. This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that. There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what. BUG=33314 TEST=Go visit some sites with popups and play with things Review URL: http://codereview.chromium.org/562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-161-6/+8
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Don't save popup blocker whitelist modifications performed while off the record.pkasting@chromium.org2009-11-301-1/+2
| | | | | | | | BUG=none TEST=Go incognito, visit popuptest.com, whitelist popups, restart and verify they're not whitelisted. Review URL: http://codereview.chromium.org/434109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33315 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-111-1/+1
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Fix disabled DCHECK by giving kImpossibleNumberOfPopups real storage.pkasting@chromium.org2009-10-051-1/+1
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/259050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28037 0039d316-1c4b-4281-b951-d872f2087c98
* Rewrite chunks of the blocked popup container code:pkasting@chromium.org2009-10-031-2/+3
| | | | | | | | | | | | | | * Fix an off-by-one error in menu rendering if a renderer actually sent us kImpossibleNumberOfPopups. * Be clearer and stricter about item indexes and sanity checking. Hopefully, this or the previous item fix a crash we saw (no bug filed). * Add notice support (as much as exists for Windows) to GTK and Mac. * Make the implementations in the three platforms mirror each other a little more precisely. * Fix (expected, actual) mis-ordering in Mac unittest. BUG=none TEST=none Review URL: http://codereview.chromium.org/260005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27949 0039d316-1c4b-4281-b951-d872f2087c98
* Added notice for blocked items to the popup containeridanan@chromium.org2009-08-281-0/+31
| | | | | | | | | | | | | | | | | | | | | | Left a TODO to rename the class to something more general but it is preferable to do a rename separate from code changes, it will make things easier to sync and be quicker since that change is relatively trivial. The exact look may be changed later but I'll attach screenshots to this issue to show the initial implementation. Also left as future enhancement is the possibility of limiting the size of the notification list in cases where a lot of hosts are affected. The most extreme example I found was some Gizmodo page with 36 domains using cookies. BUG=16932 TEST=none Review URL: http://codereview.chromium.org/179013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24822 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-281-8/+6
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-281-6/+8
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Send notice for blackisted non-visual resourcesidanan@chromium.org2009-08-211-0/+6
| | | | | | | | | | | | | This is just the piping to call into the blocked_popup_container (which shall be later renamed and expanded to a generalized blocked resource container) from the browser's request context. BUG=16932 TEST=none Review URL: http://codereview.chromium.org/171109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23973 0039d316-1c4b-4281-b951-d872f2087c98
* GTK Themes: Theme the popup notification.erg@google.com2009-07-071-1/+7
| | | | | | | | | | | | TEST=Open popuptest.com in one tab and anything else in another. Switch between GTK theme and normal. Theme of blocked popup container should change, even when not the active tab. http://crbug.com/13967 Review URL: http://codereview.chromium.org/149277 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20085 0039d316-1c4b-4281-b951-d872f2087c98
* Add remaining functionality for popup blocker: popup menu to unblock ↵pinkerton@chromium.org2009-07-061-0/+7
| | | | | | | | | | individual popups and whitelist sites. Also fixes intermittant leak on valgrind bots from poorly constructed unit test. BUG=13160, 15818 TEST=unblocking popups, whitelisting sites, and unwhitelisting them. Green valgrind bot. Review URL: http://codereview.chromium.org/149145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19944 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at popup blocking for Mac. Remove ifdefs in cross-platform code. ↵pinkerton@chromium.org2009-07-011-3/+0
| | | | | | | | | | Implement displaying of notification, menu of popups still to come. BUG=13160 TEST=popup notification should display and popups blocked accordingly. Can close notification widget to prevent more notifications for this tab. Review URL: http://codereview.chromium.org/150132 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19735 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-011-5/+0
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* Create a basic test case for the common usage of BlockedPopupContainer.erg@google.com2009-06-131-1/+2
| | | | | | Review URL: http://codereview.chromium.org/125083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18336 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Implement BlockedPopupContainerView for linux.erg@google.com2009-06-101-1/+1
| | | | | | | | | | | | | | | | This doesn't have: - rounded corners - gradient background - animating in or out. - graphical polish but it is fucntionally complete. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118480 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18113 0039d316-1c4b-4281-b951-d872f2087c98
* Creates a BlockedPopupContainerView interface, and changes the current ↵erg@google.com2009-06-081-39/+54
| | | | | | | | | | BlockedPopupContainerView class into a windows specific instance owned by the new BlockedPopupContainer. http://crbug.com/12843 Review URL: http://codereview.chromium.org/118401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17905 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the first of probably several patches trying to clean up the ↵erg@google.com2009-06-041-0/+258
| | | | | | | | | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. This version has minor windows compile fixes that changed from under me. Original Review URL: http://codereview.chromium.org/119006 TBR=beng TEST=Popup notification still works. Review URL: http://codereview.chromium.org/119107 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17647 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-031-258/+0
| | | | | | | | | | | BlockedPopupContainer into something that can be cross-platform." This reverts commit 0247f4d628f8f56c0a42ab44efd1d29058167a11 (r17483). Review URL: http://codereview.chromium.org/118166 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17485 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first of probably several patches trying to clean up the ↵erg@google.com2009-06-031-0/+258
BlockedPopupContainer into something that can be cross-platform. - BlokedPopupContainers are no longer ConstrainedWindows. - There is now a cross platform base class that contains most of the model/controller logic. The view now inherits from it. This is an improvement. Review URL: http://codereview.chromium.org/119006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17483 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-31 13:44:45 +0000