| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
| |
machine after running the test all night, so I'm reenabling the test
and making the output more humany readable so that if it does fail
hopefully we can figure out where it's going wrong.
BUG=17592
TEST=this is only a test change
Review URL: http://codereview.chromium.org/244007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27230 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Avoids the unnecessary conversion to wstring when calling the WriteBookmarks function, using FilePath instead.
BUG=None
TEST=run unit_tests.exe
Review URL: http://codereview.chromium.org/239002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27186 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Will talk to Scott when he comes back from vacation to get this re-enabled.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/159225
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21435 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
From Thiago:
This patch is to solve the problem in import/export bookmarks. They aren't
exported correctly and also not imported
correctly. Now when the bookmarks are exported the character " are escaped to
" and when they are imported,
they are unescaped.
BUG=7505
TEST=Try importing/exporting bookmarks, make sure nothing is broken.
Review URL: http://codereview.chromium.org/126222
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19654 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BookmarkNode*. This helps in making the BookmarkNode class setters public
also without worrying about someone inadvertently changing BookmarkNode
properties directly for bookmark model bookmarks.
Change all the call sites to reflect this.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/146116
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/100292
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15221 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
s.html' file. Update the unit test to match the change in bookmark_html_writer.cc
The initial CL got reverted because the unittest failed. This CL changes the unittest.
BUG=6957
Review URL: http://codereview.chromium.org/48042
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12426 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7142 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
I tested locally with gcc 4.3, but gcc 4.2 behaves differently and fails.
Review URL: http://codereview.chromium.org/14165
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7087 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/14466
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7079 0039d316-1c4b-4281-b951-d872f2087c98
|
|
BUG=1649
TEST=bring up bookmark manager and try out import/export from the
tools menu. Note that import ALWAYS creates a new folder under
the 'Other bookmarks folder' with the name of Imported (x). This
is by design.
Review URL: http://codereview.chromium.org/9471
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
|