summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks/bookmark_model.cc
Commit message (Collapse)AuthorAgeFilesLines
* Fix Bookmark DeleteMetaInfo to handle pathszea@chromium.org2013-06-211-3/+21
| | | | | | | | | | | | | DeleteMetaInfo checks HasKey before Remove-ing, despite HasKey not supporting paths, while Remove does. This fix lets the Remove itself determine if the path was valid, and does a proper recursive lookup to determine if the meta info string can be cleared. BUG=247788 Review URL: https://chromiumcodereview.appspot.com/16455008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@207703 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Fix a small typo.tfarina@chromium.org2013-06-121-6/+6
| | | | | | | | | | | | The variable [changed_urls] is incorrectly named, it was renamed to [removed_urls] to better reflect what it is and to match with the output parameter of RemoveNodeAndGetRemovedUrls() that returns it. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/16632005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205870 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of strings headers in chrome/browser/bookmarks/.avi@chromium.org2013-06-101-1/+1
| | | | | | | | | | BUG=247723 TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/16320011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205272 0039d316-1c4b-4281-b951-d872f2087c98
* BookmarkModel changes for multiple level undo and redo of bookmarks.tom.cassiotis@gmail.com2013-06-101-0/+36
| | | | | | | | | | | | | | | | Staged commit of a larger feature to ease review and landing the change. - New BookmarkModelObserver entries to be alerted before an action is executed. - BookmarkModel ability to explicitly reorder all children of a bookmark tree. Support function also added to TreeNode for this operation. - Test updated BookmarkModel and BookmarkModelObserver changes. BUG=126092 Review URL: https://chromiumcodereview.appspot.com/16479003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205228 0039d316-1c4b-4281-b951-d872f2087c98
* Use a direct include of utf_string_conversions.h in chrome/browser/, part 1.avi@chromium.org2013-06-091-1/+1
| | | | | | | | | | BUG=none TEST=none TBR=ben@chromium.org Review URL: https://chromiumcodereview.appspot.com/15789014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@205122 0039d316-1c4b-4281-b951-d872f2087c98
* Update chrome/ to use scoped_refptr<T>::get() rather than implicit "operator T*"rsleevi@chromium.org2013-06-021-2/+2
| | | | | | | | | | | Linux fixes, Part 2 of N BUG=110610 TBR=darin Review URL: https://chromiumcodereview.appspot.com/16295003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203625 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of the dependency on c/b/history/snippet.htfarina@chromium.org2013-05-301-1/+2
| | | | | | | | | | | In order to do this we move Snippet Match definitions into BookmarkTitleMatch. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/15963014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203150 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of the dependency on history_notifications.htfarina@chromium.org2013-05-281-2/+2
| | | | | | | | | | | | In order to do this we moved the FaviconChangeDetails struct into c/b/favicon, which bookmarks is already allowed to depend on, as well is history. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/15275004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202587 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Fix var name typo in BookmarkModel::Copy().tfarina@chromium.org2013-05-201-2/+2
| | | | | | | | | | | | | Local variables should be hack_style and do not need trailing underscore (_). The use of trailing underscore is reserved to data member variables (aka fields). BUG=None TEST=None TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/15423002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201059 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of the dependency on history_types.htfarina@chromium.org2013-05-161-2/+3
| | | | | | | | | | | | In order to do this we moved two structs (FaviconBitmapResult and FaviconImageResult) from history to favicon. BUG=144783 TBR=joi@chromium.org, sky@chromium.org Review URL: https://codereview.chromium.org/14699005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@200425 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Make BookmarkModel::IsLoaded() not virtual.tfarina@chromium.org2013-05-081-4/+0
| | | | | | | | | | | | | | | | | | BookmarkModel is not intended to be mocked out nor inherited from. Making IsLoaded() a virtual function allow clients to inherit from BookmarkModel and override its behavior, but that is not what we want and thus we make it non-virtual. Since r184651, nobody inherits from BookmarkModel nor override IsLoaded(). Also while at it, rename it to just loaded() and inline it in the header file, since it's a only a trivial getter. BUG=None R=sky@chromium.org Review URL: https://codereview.chromium.org/15012013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@199021 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 198844 "Move sequenced_task_runner to base/task"dbeam@chromium.org2013-05-081-1/+1
| | | | | | | | | | | | | | | | | Reverting revisions that rely on r198820 so to unbreak the build. > Move sequenced_task_runner to base/task > > BUG= > R=akalin@chromium.org > > Review URL: https://codereview.chromium.org/14927008 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/14985007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198848 0039d316-1c4b-4281-b951-d872f2087c98
* Move sequenced_task_runner to base/taskbrettw@chromium.org2013-05-081-1/+1
| | | | | | | | | BUG= R=akalin@chromium.org Review URL: https://codereview.chromium.org/14927008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@198844 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring: Moved the function CompareString16WithCollator from ↵hajimehoshi@chromium.org2013-04-231-2/+3
| | | | | | | | | | | ui/base/l10n to base/i18n. The function LocalAwareCompareFilenames at base/i18n/file_util_icu.cc needed a function to sort string with consideration of a locale, but it couldn't refer ui/base. BUG=55883 (Indirectly) TEST=Unit tests Review URL: https://chromiumcodereview.appspot.com/14044002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@195711 0039d316-1c4b-4281-b951-d872f2087c98
* Delay bookmarks load while the profile is loading.msarda@chromium.org2013-04-181-2/+3
| | | | | | | | | | | | | | This CL adds a new DeferredSequencedtaskRunner that queues up tasks until a first call to Start is issued. It creates such a task runner for the execution of bookmarks I/O operations. At profile creation, the bookmarks task runner is stopped and its execution is started after the profile has finished loading. BUG=NONE Review URL: https://chromiumcodereview.appspot.com/12952005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194956 0039d316-1c4b-4281-b951-d872f2087c98
* Remove GetApplicationLocale call in BookmarkModel, and just have it use ↵jam@chromium.org2013-04-021-5/+1
| | | | | | | | | ICU's default locale. BUG=225830 Review URL: https://codereview.chromium.org/13461011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191879 0039d316-1c4b-4281-b951-d872f2087c98
* Add a remove all bookmarks method to bookmark model.shashishekhar@chromium.org2013-03-301-20/+65
| | | | | | | | | | | | | Android wants to give users an option to clear all their bookmarks, when they switch their sync accounts. Add a method to bookmark model which clears all the bookmarks. BUG=114408 TEST=included Review URL: https://chromiumcodereview.appspot.com/12473006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@191511 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove bookmark loaded notification.tfarina@chromium.org2013-02-271-7/+2
| | | | | | | | | | | | We converted all the usages of NOTIFICATION_BOOKMARK_MODEL_LOADED to the BookmarkModelObserver equivalent, so we don't need to send it anymore. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/12310153 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@184956 0039d316-1c4b-4281-b951-d872f2087c98
* history: Rename history.h to history_service.htfarina@chromium.org2013-01-251-1/+1
| | | | | | | | | | | | | history.h contains HistoryService class as its main class, so rename the file to match with the class name. BUG=169591 R=brettw@chromium.org Review URL: https://chromiumcodereview.appspot.com/12036069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@178753 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Forward declare FaviconImageResult in bookmark_model.htfarina@chromium.org2012-12-211-1/+2
| | | | | | | | | | BUG=144783 TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11647026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174295 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Get rid of |was_bookmarked| parameter from ↵tfarina@chromium.org2012-12-201-6/+3
| | | | | | | | | | | | | BookmarkModel::AddNode() function. This parameter seems to be unused, so we can kill it now. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11607010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@174175 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Make BookmarkModel not send notifications through ↵tfarina@chromium.org2012-12-091-20/+7
| | | | | | | | | | | | | | | | | | | content::NotificationService. The lack of type safety and the endless dispatching by notification ID makes it a pretty bad interface. So NotificationService is considered pretty evil and should be used in less modules, not more. This removes the chrome::NOTIFICATION_URLS_STARRED notification from BookmarkModel and make the clients listen to BookmarkModel changes through BaseBookmarkModelObserver which is clearer. BUG=144783 R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11450002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@172015 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some FaviconService functions to use New CancelableTaskTrackerkaiwang@chromium.org2012-12-071-18/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This CL converts: FaviconService::GetFaviconImageForURL FaviconService::GetRawFaviconForURL FaviconService::GetFaviconForURL ---------- They depends on --------- HistoryService::GetFaviconsForURL ---------- which depends on -------- HistoryBackend::GetFaviconsForURL So please review above changes first. ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ FaviconService::GetFaviconImageForURL ---------- is used by -------------- bookmarks/bookmark_model.cc ui/intents/web_intent_icon_loader.cc ui/cocoa/history_menu_bridge.mm ui/toolbar/recent_tabs_sub_menu_model.cc ui/toolbar/back_forward_menu_model.cc ui/webui/ntp/app_launcher_handler.cc jumplist_win.cc FaviconService::GetRawFaviconForURL ---------- is used by -------------- android/provider/chrome_browser_provider.cc bookmarks/bookmark_html_writer.cc sync/glue/session_model_associator.cc ui/webui/extensions/extension_icon_source.cc ui/webui/favicon_source.cc ui/webui/ntp/android/bookmarks_handler.cc ui/webui/ntp/favicon_webui_handler.cc FaviconService::GetFaviconForURL ---------- is used by -------------- favicon/favicon_handler.h BUG=155883 Review URL: https://chromiumcodereview.appspot.com/11421188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171675 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark: change Move() with no effect to keep the folder timestamp.kinaba@chromium.org2012-12-051-2/+2
| | | | | | | | | | | | Bookmark Sync may try to Move an entry to the location where it already is placed. Updating the folder's timestamp with such no-op moves unwillingly disorders the "recently used" list of folders; it should better be avoided. BUG=162764 Review URL: https://chromiumcodereview.appspot.com/11411346 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@171134 0039d316-1c4b-4281-b951-d872f2087c98
* Sync the bookmark's icon URL.pkotwicz@chromium.org2012-11-301-0/+2
| | | | | | | | | BUG=160726 Test=TwoClientBookmarksSyncTest.* Review URL: https://chromiumcodereview.appspot.com/11428004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@170326 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Remove file_changed() accessor from BookmarkModel API.tfarina@chromium.org2012-11-201-3/+0
| | | | | | | | | | | | The |file_changed_| data member is assigned but never used. Nor is the getter accessor. Let's remove them altogether, since they aren't used anymore. R=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/11414070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@168682 0039d316-1c4b-4281-b951-d872f2087c98
* Moved JsonPrefStore to use SequencedWorkerPool instead of FILE thread. The ↵zelidrag@chromium.org2012-11-081-1/+2
| | | | | | | | | | | pool also ensures that the same file requests are written in order received and that they block on shutdown. BUG=153367 TEST=existing unit/browser tests Review URL: https://codereview.chromium.org/11027070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@166603 0039d316-1c4b-4281-b951-d872f2087c98
* [Sync] Ensure that creation_time_us changes are pushed into the bookmark modelzea@chromium.org2012-10-271-1/+27
| | | | | | | | | | | | | | | creation_time_us corresponds to the date_added field of a bookmark. Previously we wouldn't update the local date_added field at association time or upon receiving an update. This fixes that. In order to test this (and because it was already broken), I've gone ahead and removed LoadAssociations from the BookmarkModelAssociator as well. BUG=157455 Review URL: https://codereview.chromium.org/11255003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164456 0039d316-1c4b-4281-b951-d872f2087c98
* Transaction version is used to detect out-of-sync between sync model and ↵haitaol@chromium.org2012-10-261-1/+75
| | | | | | | | | | | native model. The values in sync model and native model should be equal. If not, there're some changes that are applied in one but not the other. This change updates the transaction version of a model type in sync when changes to its native model are found. And implement native transaction version for bookmark model. BUG=154858 Review URL: https://chromiumcodereview.appspot.com/11028146 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@164263 0039d316-1c4b-4281-b951-d872f2087c98
* Hopefully fix TwoClientBookmarksSyncTest.SC_AddFirstBMWithFavicon flakinesspkotwicz@chromium.org2012-10-231-4/+5
| | | | | | | | | | BUG=94941 Test=Run test with --gtest_repeat=20 in release mode on mac Review URL: https://chromiumcodereview.appspot.com/11145014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163467 0039d316-1c4b-4281-b951-d872f2087c98
* [Bookmarks] Be less aggressive about collapsing whitespace within bookmark ↵isherman@chromium.org2012-10-201-2/+13
| | | | | | | | | | | | | | | | | | titles. Only replace newlines and other problematic whitespace with spaces; don't collapse runs of whitespace, nor trim leading and trailing whitespace. BUG=128690, 137461 TEST=See steps in reported bugs. A quick summary: (1) Create a bookmark folder in Firefox that ends with trailing whitespace, e.g. "My Bookmarks " (2) Make sure the folder contains multiple bookmarks (3) Quit Firefox (4) Import Firefox bookmarks into Chrome. (5) Ensure there is only one copy of the folder imported. Review URL: https://chromiumcodereview.appspot.com/11196059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@163148 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sync code persist the date node was added. I'm hoping this coverssky@chromium.org2012-10-121-1/+3
| | | | | | | | | | | | | | most of the cases folks are encountering. We may need to persist date_folder_modified to really cover everything. BUG=84880 TEST=covered by tests. R=akalin@chromium.org Review URL: https://chromiumcodereview.appspot.com/11090083 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161655 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Move away from Profile in BookmarkExpandedStateTracker.tfarina@chromium.org2012-10-121-4/+3
| | | | | | | | | | | | | Ben want us to move to a model where an app builds the components it wants (e.g. if it wants Bookmarks, it builds that) and obtains the bookmark service from the browser context. BUG=144783 R=sky@chromium.org Review URL: https://codereview.chromium.org/11103014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@161609 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Merge two BookmarkCodec header doc comments into one.tfarina@chromium.org2012-10-091-6/+4
| | | | | | | | R=sky@chromium.org Review URL: https://codereview.chromium.org/11094002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@160875 0039d316-1c4b-4281-b951-d872f2087c98
* [Coverity] Use-after-freegroby@chromium.org2012-10-031-3/+3
| | | | | | | | | | | | | | | | application_locale was pointing to internal storage of the temporary object returned by GetApplicationLocale. By the time it was used in createInstance, that temp object has gone out of scope and memory potentially reclaimed. CID=106025 R=sky@chromium.org BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/11038013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@159809 0039d316-1c4b-4281-b951-d872f2087c98
* bookmarks: Switch it to use the PrefService from chrome/browser/api/tfarina@chromium.org2012-09-271-1/+0
| | | | | | | | | BUG=144783 R=sky@chromium.org,joi@chromium.org Review URL: https://codereview.chromium.org/10984027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@158937 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bookmarks' dependency on BrowserProcess::GetApplicationLocalekaiwang@chromium.org2012-09-071-4/+4
| | | | | | | BUG=144783 Review URL: https://chromiumcodereview.appspot.com/10911080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155300 0039d316-1c4b-4281-b951-d872f2087c98
* Introduce structures to reduce the number of arguments in the FaviconService ↵leandrogracia@chromium.org2012-09-061-2/+2
| | | | | | | | | | | | | | | | | | methods. Issue 10870022 introduced new arguments for the FaviconService methods, some of them now having more than 6 arguments. These methods cannot be called using the base::Bind mechanism because of template limitations. This patch introduces auxiliar structures to reduce the number of arguments in these methods and therefore allow using base::Bind on them. BUG=146003 Review URL: https://chromiumcodereview.appspot.com/10918065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@155113 0039d316-1c4b-4281-b951-d872f2087c98
* Change FaviconData to be able to return data for multiple bitmaps for same ↵pkotwicz@chromium.org2012-08-301-11/+8
| | | | | | | | | | | | | | icon URL. Add methods to FaviconService to get gfx::Image more easily from Favicon. BUG=138553 Test=Compiles, FaviconHandlerTest.* pass. Review URL: https://chromiumcodereview.appspot.com/10870022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@154157 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 153695 - Change FaviconData to be able to return data for multiple ↵pkotwicz@chromium.org2012-08-281-8/+11
| | | | | | | | | | | | | | | | | | bitmaps for same icon URL. Add methods to FaviconService to get gfx::Image more easily from Favicon. Remove unused FaviconService::GetFaviconForID(). BUG=138553 Test=Compiles, FaviconHandlerTest.* pass. Review URL: https://chromiumcodereview.appspot.com/10870022 TBR=pkotwicz@chromium.org Review URL: https://chromiumcodereview.appspot.com/10891007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153714 0039d316-1c4b-4281-b951-d872f2087c98
* Change FaviconData to be able to return data for multiple bitmaps for same ↵pkotwicz@chromium.org2012-08-281-11/+8
| | | | | | | | | | | | | | | icon URL. Add methods to FaviconService to get gfx::Image more easily from Favicon. Remove unused FaviconService::GetFaviconForID(). BUG=138553 Test=Compiles, FaviconHandlerTest.* pass. Review URL: https://chromiumcodereview.appspot.com/10870022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153695 0039d316-1c4b-4281-b951-d872f2087c98
* Moving FaviconService to a ProfileKeyedService.rlp@chromium.org2012-08-231-6/+8
| | | | | | | | | | | | BUG=112526 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152904 Reverted, was not the cause of problem. Resubmitting. Review URL: https://chromiumcodereview.appspot.com/10828263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@153087 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 152904 - Moving FaviconService to a ProfileKeyedService.ricow@chromium.org2012-08-231-8/+6
| | | | | | | | | | | | | BUG=112526 Review URL: https://chromiumcodereview.appspot.com/10828263 This seems to be causing win7 sync issues. TBR=rlp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10873022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152959 0039d316-1c4b-4281-b951-d872f2087c98
* Moving FaviconService to a ProfileKeyedService.rlp@chromium.org2012-08-231-6/+8
| | | | | | | | BUG=112526 Review URL: https://chromiumcodereview.appspot.com/10828263 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152904 0039d316-1c4b-4281-b951-d872f2087c98
* - Made BookmarkService::GetBookmarks return both urls and title,michaelbai@chromium.org2012-08-061-3/+8
| | | | | | | | | | | | it still return the unique URLs, not matter what the title is. BUG=http://b/6696843 TEST=AndroidProviderBackendTest, BookmarkModelTest, BookmarkModelSQLHandlerTest Review URL: https://chromiumcodereview.appspot.com/10825147 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150136 0039d316-1c4b-4281-b951-d872f2087c98
* Convert BookmarkNode and BookmarkModel to use gfx::Image.rohitrao@chromium.org2012-06-261-9/+11
| | | | | | | | | | BUG=None TEST=None Review URL: https://chromiumcodereview.appspot.com/10628010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@144242 0039d316-1c4b-4281-b951-d872f2087c98
* Removing usage of profile_->GetHistory() from the codebase in order to ↵rlp@chromium.org2012-06-191-1/+3
| | | | | | | | | | | | | remove that function. BUG=97804 TEST=existing unittests TBR=sky@chromium.org Review URL: https://chromiumcodereview.appspot.com/10560019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@143024 0039d316-1c4b-4281-b951-d872f2087c98
* Converting BookmarkModel and HistoryService to ProfileKeyedServices. This ↵rlp@chromium.org2012-06-081-13/+4
| | | | | | | | | | | | | just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow. BUG=97804,112525 TEST=no new, passes existing unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=138867 Review URL: https://chromiumcodereview.appspot.com/10399087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141294 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 138867 b/c too much redness on MFYI waterfall from many, many leak ↵bruening@google.com2012-05-251-4/+13
| | | | | | | | | | | | | | | | reports Revert 138867 - Converting BookmarkModel and HistoryService to ProfileKeyedServices. This just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow. BUG=97804,112525 TEST=no new, passes existing unittests Review URL: https://chromiumcodereview.appspot.com/10399087 TBR=rlp@chromium.org Review URL: https://chromiumcodereview.appspot.com/10444018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138984 0039d316-1c4b-4281-b951-d872f2087c98
* Converting BookmarkModel and HistoryService to ProfileKeyedServices. This ↵rlp@chromium.org2012-05-241-13/+4
| | | | | | | | | | | just performs the initial conversion. Separate CLs to take care of the removal of profile_->Get<Serivce> will follow. BUG=97804,112525 TEST=no new, passes existing unittests Review URL: https://chromiumcodereview.appspot.com/10399087 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@138867 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-01-26 19:27:52 +0000