summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks/bookmark_model.h
Commit message (Collapse)AuthorAgeFilesLines
* Added a method to check if a browser is closing.pinkerton@chromium.org2010-08-101-0/+3
| | | | | | | | | | | | | | | | Added a method to get the next node ID for bookmarks managed by the bookmark model. Added AppleScript support. Added scripting definition file. Added support for saving tab. Added localization support. Added consistent error nos/error messages. (patch developed by v.a.shreyas@gmail.com) BUG=27468 TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55569 0039d316-1c4b-4281-b951-d872f2087c98
* Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h.viettrungluu@chromium.org2010-08-051-3/+1
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3027041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55136 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-261-0/+1
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* Change so that the extension favicon is read on the UI thread since ↵arv@chromium.org2010-03-171-1/+1
| | | | | | | | | | | | | extension objects should only be accessed on the UI thread. This also fixes erg's todo to make favicons use RefCountedMemory instead of RefCountedBytes in all places. BUG=None TEST=None Review URL: http://codereview.chromium.org/1028001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41869 0039d316-1c4b-4281-b951-d872f2087c98
* Add bookmark copying while dragging by holding down the <option> key.mrossetti@chromium.org2010-03-111-0/+5
| | | | | | | | | BUG=35969 TEST=Hold down the <option> key while dragging a bookmark to a new location. Repeat with the following: 1) From bookmark bar to bookmark bar, 2) from bookmark bar into a folder, 3) from within a folder to a different place within the same folder, 4) from within a folder to the bookmark bar, 5) from within a folder to a different folder. Check to insure that the original bookmark (and its contents if it was a folder) are in both the original location and the new location. Review URL: http://codereview.chromium.org/790001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41252 0039d316-1c4b-4281-b951-d872f2087c98
* First stab at a DataTypeController.skrul@chromium.org2010-02-101-1/+1
| | | | | | | | This is my first stab at a DataTypeController, plus a BookmarkDataTypeController implementation. It is not fully wired into the PSS yet :) Review URL: http://codereview.chromium.org/545074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38655 0039d316-1c4b-4281-b951-d872f2087c98
* Implement BookmarkModel::SetUrlarv@chromium.org2010-02-091-2/+7
| | | | | | | | | | BUG=10603 TEST=*_test.exe --gtest_filter=*Bookmark* Also manually tested changing the URL through the bookmarks extension API, bookmark manager, bookmark bar and saw it update in all places and correctly sync to another chrome instance. Review URL: http://codereview.chromium.org/582022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38509 0039d316-1c4b-4281-b951-d872f2087c98
* Add import/export extension apisfeldstein@chromium.org2010-01-281-0/+6
| | | | | | | | | | | This is a duplicate of 543094. That code review seems to have gotten corrupted as i can no longer publish anything from their web UI. It was LGTM'd+nits by arv, which i've fixed here. BUG=32194 TEST=Import and export bookmarks from the extension Review URL: http://codereview.chromium.org/548167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37351 0039d316-1c4b-4281-b951-d872f2087c98
* Use string16 instead of wstring in bookmark data model.munjal@chromium.org2010-01-111-0/+39
| | | | | | | | | | | | | Add overloads to bookmark model for string16. Wrap wstring versions in #if !defined since string16 is just a typedef of wstring on windows. TEST=exist BUG=32013 Review URL: http://codereview.chromium.org/536013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35964 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/469009 for Thiago:sky@chromium.org2009-12-161-3/+3
| | | | | | | | | | | | bookmarks: Update parent (folder) modified time when we create a new bookmark node. BUG=none TEST=none Review URL: http://codereview.chromium.org/500005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34626 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-021-6/+7
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-301-4/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-301-1/+4
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-191-2/+2
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-281-2/+3
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-061-1/+1
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-061-1/+1
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused forward declaration of StarredURLDatabase from bookmark_model.h.phajdan.jr@chromium.org2009-07-271-4/+0
| | | | | | | | | | | Patch by Thiago Farina. Original review: http://codereview.chromium.org/160151 BUG=None TEST=None Review URL: http://codereview.chromium.org/160185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21691 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup in browser/importerphajdan.jr@chromium.org2009-07-201-48/+1
| | | | | | | | | | - forward declare more things - move bits from header to implementation files to cut includes - extract bookmark_model_observer.h out of bookmark_model.h to reduce includes Review URL: http://codereview.chromium.org/159097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21116 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-151-7/+5
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* Try the original CL "Always persist bookmark IDs" again with the fix tomunjal@chromium.org2009-07-131-27/+13
| | | | | | | | | | | | | | Valgrind issue. The fix is in bookmark_storage.h - initialized the newly added member ids_reassigned_ of LoadDetails class. See http://codereview.chromium.org/149310 for the original CL. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/155456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20565 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Always persist bookmark IDs."tc@google.com2009-07-131-13/+27
| | | | | | | | | | | | | This reverts commit r20532 because valgrind was complaining about uninitialized memory: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio TBR=munjal Review URL: http://codereview.chromium.org/155448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20550 0039d316-1c4b-4281-b951-d872f2087c98
* Always persist bookmark IDs.munjal@chromium.org2009-07-131-27/+13
| | | | | | | | | | | | | | | | Remove the preference to persist IDs. NOTE that we need to save the file the first time with IDs since existing bookmark files won't have IDs and the file won't be saved until something changes in the bookmark model. So we need to explicitly save once when we assign ids for the first time. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/149310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20532 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155128 for Thiago.sky@chromium.org2009-07-081-6/+11
| | | | | | | | | | | | | Description from Thiago: Converting the history::StarredEntry::Type to a type defined in BookmarkNode. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20195 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-261-72/+98
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* We need to save bookmarks file when the persist_ids settings changesmunjal@chromium.org2009-05-281-0/+10
| | | | | | | | or when the file is detected to be changed externally. Review URL: http://codereview.chromium.org/114055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17105 0039d316-1c4b-4281-b951-d872f2087c98
* Add a preference to enable/disable ID persistence in bookmark model andmunjal@chromium.org2009-05-271-0/+12
| | | | | | | | add methods in bookmark model to get/set this preference. Review URL: http://codereview.chromium.org/113882 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17017 0039d316-1c4b-4281-b951-d872f2087c98
* Moves decoding and population of bookmark index to background thread.sky@chromium.org2009-05-221-9/+13
| | | | | | | | | BUG=6646 TEST=make sure bookmarks persist after running chrome. Review URL: http://codereview.chromium.org/113768 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16757 0039d316-1c4b-4281-b951-d872f2087c98
* More NotificationRegistrar conversions.pkasting@chromium.org2009-05-221-1/+3
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/113736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16700 0039d316-1c4b-4281-b951-d872f2087c98
* Moves GetFavIcon from BookmarkNode to BookmarkModel. I'm doing thissky@chromium.org2009-05-201-11/+13
| | | | | | | | | | | | | | | | for two reasons: . it cuts down on each node needing a reference to the model. . it makes it clear nodes shouldn't need to talk with the model. I'm primarily doing this for the last point as I'm going to populate nodes on a background thread shortly and I don't want to risk the chance of someone trying to talk with the model. BUG=none TEST=none Review URL: http://codereview.chromium.org/113617 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16491 0039d316-1c4b-4281-b951-d872f2087c98
* Adds an index over bookmark titles for fast look up.sky@chromium.org2009-05-191-0/+9
| | | | | | | | | | | | | The index is currently built on the main thread (because that's where we do the decoding now), but I'll change that after landing this. BUG=6646 TEST=There are tests to cover this, but make sure the omnibox still suggests bookmark titles. Review URL: http://codereview.chromium.org/115403 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16357 0039d316-1c4b-4281-b951-d872f2087c98
* Move tree-related classes that Linux code depends on from views/ to app/phajdan.jr@chromium.org2009-05-131-2/+2
| | | | | | | | | | TEST=If it compiles and unit_tests pass, it's ok. Just moving files around. http://crbug.com/11066 Review URL: http://codereview.chromium.org/115185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15982 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Move the bookmark node iD generation to bookmark model isntead ofmunjal@chromium.org2009-05-121-6/+17
| | | | | | | | bookmark node. This will also make the IDs more dense. Review URL: http://codereview.chromium.org/99304 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15839 0039d316-1c4b-4281-b951-d872f2087c98
* Converted BookmarkStorage to use ImportantFileWriterphajdan.jr@chromium.org2009-05-081-23/+0
| | | | | | | | | | | | | | | | | | Also made BookmarkStorage completely responsible for migration of bookmark data from history database. Previously the logic crossed file and class boundaries a few times. This made it a bit hard to follow. Now it should be a bit more clear. Made ImportantFileWriter also batch data serializations. TEST=Make sure that bookmarks still work. Also test migrating bookmarks from history database. http://crbug.com/10618 Review URL: http://codereview.chromium.org/99192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15635 0039d316-1c4b-4281-b951-d872f2087c98
* Move src/chrome/views to src/views. RS=darin http://crbug.com/11387ben@chromium.org2009-05-081-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15604 0039d316-1c4b-4281-b951-d872f2087c98
* Port the folder selector portion of the BookmarkEditor to GTK.erg@google.com2009-05-051-1/+5
| | | | | | | | | | | | | | | Mirrors the BookmarkEditorView method, where the contents of BookmarkModel are copied to a temporary model so changes can be discarded if the user hits Cancel. In the GTK version, we copy not into another BookmarkModel, but into a GtkTreeStore, which serves as a model to the GtkTreeView on screen. Also ports the unit tests. http://crbug.com/11250 Review URL: http://codereview.chromium.org/99361 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15257 0039d316-1c4b-4281-b951-d872f2087c98
* Implement ID persistence for bookmarks:munjal@chromium.org2009-04-301-1/+14
| | | | | | | | | | | | | | | | - Bookmark codec now takes in a ctor argument persist_ids - If it's true, it will serialize IDs of bookmarks when encoding, and deserialize already serialized IDs (if present) when decoding. - During decoding, unique-ify the IDs if they are not unique. - Add unit tests for all new code. Coming up in a separate changelist: - Move ID generation logic to bookmark model, and make it non-static. Review URL: http://codereview.chromium.org/99217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15013 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/pickle.h. Add some explicit #includes.thestig@chromium.org2009-04-031-4/+8
| | | | | | Review URL: http://codereview.chromium.org/60095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13093 0039d316-1c4b-4281-b951-d872f2087c98
* Move controls into their own dir under chrome/views/controlsben@chromium.org2009-03-171-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for BlockTillLoaded to Linux.markus@chromium.org2009-03-091-9/+2
| | | | | | Review URL: http://codereview.chromium.org/39298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11300 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up sorting of bookmarks to the 'organize menu' in the bookmarksky@google.com2009-02-271-2/+1
| | | | | | | | | | | | | manager (Glen says no context menus for now). All BookmarkModelObservers have been updated appropriately. BUG=1750 TEST=bring up the bookmark manager and try the 'Reorder by title' menu item, make sure it works and I didn't screw up anything around it. Review URL: http://codereview.chromium.org/27262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10633 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability to sort the children of a node in the bookmark model. Isky@google.com2009-02-251-0/+10
| | | | | | | | | | | | plan on doing this in chunks, next phase is updating observers, then changing the bookmark manager to call into the new method. BUG=1750 TEST=none yet Review URL: http://codereview.chromium.org/27082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10313 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-011-1/+1
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Attempt 2 at this. This differs from first version in that I renamedsky@google.com2008-12-161-0/+5
| | | | | | | | | | | | | | | set_store to ClearStore and properly remove an observer I added. And I'm disabling a test that needs more investigation. Makes the interactive bookmark bar view tests faster by disabling saving. This is why BookmarkBarViewTest9 keeps timing out. BUG=none TEST=none Review URL: http://codereview.chromium.org/14471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7091 0039d316-1c4b-4281-b951-d872f2087c98
* Reverts r7062 as caused failures on interactive tests.sky@google.com2008-12-161-6/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7068 0039d316-1c4b-4281-b951-d872f2087c98
* Makes the interactive bookmark bar view tests faster by disablingsky@google.com2008-12-161-0/+6
| | | | | | | | | | | saving. This is why BookmarkBarViewTest9 keeps timing out. BUG=none TEST=none Review URL: http://codereview.chromium.org/14449 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7062 0039d316-1c4b-4281-b951-d872f2087c98
* Moves some utility functions out of bookmark model intosky@google.com2008-12-091-35/+1
| | | | | | | | | | | | bookmark_utils. In addition I've converted to using TreeNodeIterator. This doesn't contain any functionality changes. BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6589 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/ - part 1.deanm@chromium.org2008-11-251-1/+9
| | | | | | | Review URL: http://codereview.chromium.org/11402 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6007 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-13 12:47:18 +0000