summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Fixes bug in determining if we can paste from the clipboard. Need tosky@chromium.org2009-10-012-1/+40
| | | | | | | | | | | use IsFormatAvailableByString rather than IsFormatAvailable. BUG=21106 TEST=see bug, also covered by unit test now. Review URL: http://codereview.chromium.org/256016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27720 0039d316-1c4b-4281-b951-d872f2087c98
* Coverity: check result of file_util::CopyFile.mattm@chromium.org2009-09-291-1/+1
| | | | | | | | | | CID=5099 BUG=none TEST=none Review URL: http://codereview.chromium.org/251023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27450 0039d316-1c4b-4281-b951-d872f2087c98
* Reenables BookmarkHTMLWriterTest. I couldn't repro a failure on mysky@chromium.org2009-09-251-19/+60
| | | | | | | | | | | | | machine after running the test all night, so I'm reenabling the test and making the output more humany readable so that if it does fail hopefully we can figure out where it's going wrong. BUG=17592 TEST=this is only a test change Review URL: http://codereview.chromium.org/244007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27230 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/214030 for Thiago:sky@chromium.org2009-09-253-8/+5
| | | | | | | | | | | Avoids the unnecessary conversion to wstring when calling the WriteBookmarks function, using FilePath instead. BUG=None TEST=run unit_tests.exe Review URL: http://codereview.chromium.org/239002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27186 0039d316-1c4b-4281-b951-d872f2087c98
* Bookmark context menu: pass the correct parent to the bookmark editor.estade@chromium.org2009-09-121-1/+1
| | | | | | | | | BUG=21360 TEST=see bug Review URL: http://codereview.chromium.org/192079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26062 0039d316-1c4b-4281-b951-d872f2087c98
* Clipboard:estade@chromium.org2009-09-101-2/+6
| | | | | | | | | | | | | - Move link construction logic to scoped_clipboard_writer.cc - Make callers use EscapeForHTML on the anchor text - Make WriteHyperlink just write html, and not a bookmark as well (only affects one caller, which I updated) - implement WriteBookmark for gtk BUG=18034,18035 Review URL: http://codereview.chromium.org/194052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25833 0039d316-1c4b-4281-b951-d872f2087c98
* Roll webkit deps 48155:48185 and remove a couple of passing tests from ↵japhet@chromium.org2009-09-081-1/+1
| | | | | | | | | | | | | | | test_expectations.txt. Also, merge in http://codereview.chromium.org/174367 (original author: vandebo@chromium.org), which is the downstream half of r48168. BUG=4360 BUG=21228 BUG=18792 TEST=none TBR=eroman git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25669 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a FaviconService class tied to the profile.arv@google.com2009-08-282-14/+14
| | | | | | | | | | | | | | | | | | | Original issue: http://codereview.chromium.org/115212/show The favicons service is the entry point to getting favicons. Make the DOMUIFactory handle the favicons of DOMUI pages so since DOMUI pages are never added to the history. BUG=5840 TEST=Open a new window and open history and downloads (Ctrl+H and Ctrl+J) in this window. Then close the window and open the NTP. The recently closed windows/tabs should show the favicons for the hsitroy and downloads page. Review URL: http://codereview.chromium.org/178001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24806 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Fix a ton of compiler warnings."tony@chromium.org2009-08-282-8/+2
| | | | | | | | | | | This reverts commit r24792. TBR=estade Review URL: http://codereview.chromium.org/179028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24796 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a ton of compiler warnings.estade@chromium.org2009-08-282-2/+8
| | | | | | | | | | | | | | | Most of these are classes with virtual methods lacking virtual destructors or NULL used in non-pointer context. BUG=none TEST=app_unittests && base_unittests --gtest_filter=-ConditionVariableTest.LargeFastTaskTest patch by Jacob Mandelson <jlmjlm [at] gmail> http://codereview.chromium.org/171028/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24792 0039d316-1c4b-4281-b951-d872f2087c98
* Do at least some rudimentary sorting of bookmarked URLs in the omnibox ↵pkasting@chromium.org2009-08-284-30/+179
| | | | | | | | | dropdown (existing sort was effectively random). Patch by Pierre-Antoine LaFayette (see http://codereview.chromium.org/165455 ), r=sky,me, tweaked. BUG=16230 TEST=In the omnibox dropdown, bookmarked URLs that have been typed more often should be ranked above those that have been typed less often. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24704 0039d316-1c4b-4281-b951-d872f2087c98
* Convert internal time format to Windows 1601 epoch on Linux & Mac.brettw@chromium.org2009-08-261-2/+16
| | | | | | | | | | | Although we represent time internally starting from 1601, there are still things like time explosion that will not work before the year 1900. This limitation is the same as it was previously. BUG=14734 Review URL: http://codereview.chromium.org/173296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24417 0039d316-1c4b-4281-b951-d872f2087c98
* Use 'icu::' namespace explicitly throughout Chrome tree instead of relying ↵jshin@chromium.org2009-08-181-5/+5
| | | | | | | | | | | | | | | | | | | on 'using namespace icu'. This is Chrome's counterpart to the ICU header change that disables 'using namespace icu' (http://codereview.chromium.org/171010/show), which is required to avoid the name colission between Chrome's StringPiece (in base) and ICU's StringPiece. The webkit change (which is minor) will be dealt with in the webkit bugzilla. This can go in before the ICU change/upgrade without affecting anything. BUG=8198 TEST=All the targets are built without an error on all platforms. Review URL: http://codereview.chromium.org/171012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23613 0039d316-1c4b-4281-b951-d872f2087c98
* Cleaning up lines longer than 80 chars under src/chrome/browser. mark@chromium.org2009-08-171-1/+2
| | | | | | | | | | | | | | | | | | | Command: awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' *.cc *.h # recursive find . -type f \( -name '*.cc' -o -name '*.h' \) -exec awk '{if ( length($0) > 80 ) { print FILENAME, FNR, $0 } }' {} \; Patch by Pierre-Antoine LaFayette <pierre.lafayette@gmail.com> BUG=None TEST=None Code review URL: http://codereview.chromium.org/164566 Review URL: http://codereview.chromium.org/171066 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23583 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors OSExchangeData for easier portability.sky@chromium.org2009-08-125-61/+63
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/164401 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@23230 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r22559.aa@chromium.org2009-08-062-2/+2
| | | | | | | | | | | | | | | | | | This caused an easily reproducible crash: 1. Start with a fresh profile 2. Navigate to google.com 3. Restart 4. Navigate to google.com 5. crash The change from pass-by-value to pass-by-ref in fav_icon_helper.* seems to be to blame, but I can't see it right off. TBR=phajdan.jr@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22595 0039d316-1c4b-4281-b951-d872f2087c98
* Bunch of Coverity fixes, rather minor severity.phajdan.jr@chromium.org2009-08-062-2/+2
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/159862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22559 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a unit test for coverage of bug 15786.sky@chromium.org2009-08-051-1/+6
| | | | | | | | | BUG=15786 TEST=this is just a test change. Review URL: http://codereview.chromium.org/160651 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22514 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a DCHECK hit inside the bookmark matching code.evan@chromium.org2009-08-051-9/+10
| | | | | | | | | | | | | | We do bookmark matching in two passes: first, a quick search for all the words, then a second filtering pass that obeys query syntax. We were hitting a DCHECK when the second pass would filter any matches out. For example, the query ["thi"] matches a bookmark [think], but it shouldn't match because quotes mean literal match. BUG=15786 Review URL: http://codereview.chromium.org/159905 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22485 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement bookmark manager copy/paste.estade@chromium.org2009-08-043-46/+85
| | | | | | | | | | | | - Refactor bookmark util clipboard code to be cross platform. - Add a CBF_DATA format for writing arbitrary data to the clipboard. - Change MenuGtk so that showing a menu only makes the menu items update asynchronously. This way we can show the menu immediately and we won't get in trouble if the delegate's IsCommandEnabled() runs a nested message loop. I did not do any mac-side implementation of the new clipboard stuff. The implementation should be easy when they get around to writing the bookmark manager. Review URL: http://codereview.chromium.org/159815 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22419 0039d316-1c4b-4281-b951-d872f2087c98
* Fixing potential memory leak in BookmarkCodec::DecodeNode.finnur@chromium.org2009-08-042-4/+12
| | | | | | | | | | | Coverity finds a condition where this leaks. We are at the moment not using it in such a way that it leaks, but that might of course change. It looks to me like the API is not intended to be used in such a way anyway, so we can just check for it and return false. BUG=15350 TEST=Decoding bookmarks should work as before. Review URL: http://codereview.chromium.org/159075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22379 0039d316-1c4b-4281-b951-d872f2087c98
* Typo fixestade@chromium.org2009-07-311-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22227 0039d316-1c4b-4281-b951-d872f2087c98
* Since bookmark copy/paste is not impl on non-Windows platforms, don't remove ↵estade@chromium.org2009-07-311-0/+5
| | | | | | | | | | | | | nodes when cutting. BUG=18152 TEST=none TBR=erg Review URL: http://codereview.chromium.org/160488 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22221 0039d316-1c4b-4281-b951-d872f2087c98
* Gtk: DnD extravaganzaestade@chromium.org2009-07-282-0/+15
| | | | | | | | | | | | | - Correctly update drag status for drags over renderer. This makes things look quite a bit better. - Rework the dnd utils so that we specify the drag targets in the order we prefer them (for destinations) - Refactor code in bookmark bar so folder and toolbar drags share more code - Allow bookmark bar to accept URI lists and plain text drags (for plain text we require the text to be a valid url) BUG=17431 Review URL: http://codereview.chromium.org/159419 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21767 0039d316-1c4b-4281-b951-d872f2087c98
* Removing unused forward declaration of StarredURLDatabase from bookmark_model.h.phajdan.jr@chromium.org2009-07-271-4/+0
| | | | | | | | | | | Patch by Thiago Farina. Original review: http://codereview.chromium.org/160151 BUG=None TEST=None Review URL: http://codereview.chromium.org/160185 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21691 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup:phajdan.jr@chromium.org2009-07-235-3/+7
| | | | | | | | | - reduce header dependencies by using bookmark_model_observer.h - replace #include <iostream> by #include <iosfwd> in headers Review URL: http://codereview.chromium.org/159280 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21444 0039d316-1c4b-4281-b951-d872f2087c98
* Disables BookmarkHTMLWriterTest for now, since it is very flaky on Windows. ↵klink@chromium.org2009-07-231-1/+1
| | | | | | | | | | | Will talk to Scott when he comes back from vacation to get this re-enabled. BUG=None TEST=None Review URL: http://codereview.chromium.org/159225 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21435 0039d316-1c4b-4281-b951-d872f2087c98
* Header cleanup in browser/importerphajdan.jr@chromium.org2009-07-202-48/+57
| | | | | | | | | | - forward declare more things - move bits from header to implementation files to cut includes - extract bookmark_model_observer.h out of bookmark_model.h to reduce includes Review URL: http://codereview.chromium.org/159097 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21116 0039d316-1c4b-4281-b951-d872f2087c98
* Don't use ID generation logic always. Only reassign IDsmunjal@chromium.org2009-07-153-195/+94
| | | | | | | | | | | | | | when checksums differ or if IDs are missing and do that simply by assigning the next maximum id. Add a unit test. BUG=16357 TEST=NONE Review URL: http://codereview.chromium.org/155560 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20779 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155428 for Thiago, which changessky@chromium.org2009-07-153-11/+12
| | | | | | | | | | | | | | from me to get the thing to work. Merging two versions of BookmarkNodeRemoved into one. BUG=None TEST=Remove some bookmarks from BookmarkBar or Bookmarks Manager and make sure everything works ok. Review URL: http://codereview.chromium.org/155572 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20739 0039d316-1c4b-4281-b951-d872f2087c98
* Try the original CL "Always persist bookmark IDs" again with the fix tomunjal@chromium.org2009-07-1310-147/+106
| | | | | | | | | | | | | | Valgrind issue. The fix is in bookmark_storage.h - initialized the newly added member ids_reassigned_ of LoadDetails class. See http://codereview.chromium.org/149310 for the original CL. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/155456 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20565 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Always persist bookmark IDs."tc@google.com2009-07-1310-104/+146
| | | | | | | | | | | | | This reverts commit r20532 because valgrind was complaining about uninitialized memory: http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Linux%20(valgrind)/builds/697/steps/valgrind%20test:%20unit/logs/stdio TBR=munjal Review URL: http://codereview.chromium.org/155448 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20550 0039d316-1c4b-4281-b951-d872f2087c98
* Always persist bookmark IDs.munjal@chromium.org2009-07-1310-146/+104
| | | | | | | | | | | | | | | | Remove the preference to persist IDs. NOTE that we need to save the file the first time with IDs since existing bookmark files won't have IDs and the file won't be saved until something changes in the bookmark model. So we need to explicitly save once when we assign ids for the first time. TEST=NONE BUG=16068 Review URL: http://codereview.chromium.org/149310 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20532 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 20468.glen@chromium.org2009-07-121-2/+1
| | | | | | Review URL: http://codereview.chromium.org/149514 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20471 0039d316-1c4b-4281-b951-d872f2087c98
* Commit for tfarinaglen@chromium.org2009-07-121-1/+2
| | | | | | | | | | | | | Original CL: http://codereview.chromium.org/155076 Add the menus copy, cut and paste to BookmarkBar and BookmarkMenu. BUG=5354 TEST=None git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20468 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/155128 for Thiago.sky@chromium.org2009-07-086-48/+65
| | | | | | | | | | | | | Description from Thiago: Converting the history::StarredEntry::Type to a type defined in BookmarkNode. BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/155165 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20195 0039d316-1c4b-4281-b951-d872f2087c98
* Have the ApplyEdit* bookmark utilities return the BookmarkNode pointertim@chromium.org2009-07-072-37/+42
| | | | | | | | | so that callers know whether or not the original BookmarkNode* passed in is still valid or not. Review URL: http://codereview.chromium.org/149140 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19999 0039d316-1c4b-4281-b951-d872f2087c98
* Moved typedef of RedirectList from HistoryService class to history namespace.meelapshah@chromium.org2009-07-011-1/+1
| | | | | | Review URL: http://codereview.chromium.org/151168 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19766 0039d316-1c4b-4281-b951-d872f2087c98
* TBR:aa@chromium.org2009-07-011-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19710 0039d316-1c4b-4281-b951-d872f2087c98
* Fix: Certain redirections remove sites from the historyyuzo@chromium.org2009-07-011-1/+1
| | | | | | | | | | | | | | | | | | | Currently, PageTransition::CHAIN_END flag is removed from a History database entry for a redirect source, even when the redirect is user initiated. This change prevents the flag removal for user-initiated redirects. TEST=Open http://www.google.com/ig and click on tabs multiple times. Without this change, only the last tab clicked appears in the History page (CTRL+H). With this change, all the tabs should appear. TESTED=gcl try, manually BUG=11355 Review URL: http://codereview.chromium.org/147145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19708 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/126036 for Thiago.sky@chromium.org2009-06-302-6/+15
| | | | | | | | | | | | | | | | | From Thiago: This patch is to solve the problem in import/export bookmarks. They aren't exported correctly and also not imported correctly. Now when the bookmarks are exported the character " are escaped to &quot; and when they are imported, they are unescaped. BUG=7505 TEST=Try importing/exporting bookmarks, make sure nothing is broken. Review URL: http://codereview.chromium.org/126222 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19654 0039d316-1c4b-4281-b951-d872f2087c98
* Need to temporarily flip this back to gfx::NativeView since the other ↵ben@chromium.org2009-06-272-3/+4
| | | | | | | | | | platforms don't like it as window. Will fix later. TBR=sky BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19461 0039d316-1c4b-4281-b951-d872f2087c98
* First part of bookmark context menu reorg.ben@chromium.org2009-06-272-0/+659
| | | | | | | | | | | BookmarkContextMenu controller (XP state bits) go back into browser/bookmarks. views::MenuItemView infrastructure lives in browser/views/bookmark_context_menu. BUG=none TEST=bookmark context menus on bookmark bar, bookmark manager, bookmark folder menus. Review URL: http://codereview.chromium.org/149055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19458 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark model public interface use const BookmarkNode* instead ofmunjal@chromium.org2009-06-2627-451/+525
| | | | | | | | | | | | | | | BookmarkNode*. This helps in making the BookmarkNode class setters public also without worrying about someone inadvertently changing BookmarkNode properties directly for bookmark model bookmarks. Change all the call sites to reflect this. BUG=none TEST=none Review URL: http://codereview.chromium.org/146116 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19428 0039d316-1c4b-4281-b951-d872f2087c98
* Fork bookmark context menu logic across platforms. There's too much crazy ↵ben@chromium.org2009-06-255-1081/+0
| | | | | | | | | | | stuff going on here, I can't begin to unravel it on more than one platform at a time. TBR=sky BUG=none TEST=none Review URL: http://codereview.chromium.org/146125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19207 0039d316-1c4b-4281-b951-d872f2087c98
* Replace std:;wstring with std::string and string16 in locale-name related APIs.jshin@chromium.org2009-06-241-1/+1
| | | | | | | | | | | | | | | 1. Change the locale param to be std::string because they're always ASCII and change call-sites accordingly. 2. Add GetStringFUTF16 to l10n_util. On Windows, they're inline helpers calling the correspondingGetStringF returning wstring while on Mac/Linux, they just return the result of |string16 GetStringF|without converting to wstring. This is part 1 of the fix for issue 8647. Some of newly introduced conversions are temporary and will be removed later (e.g. ASCIIToWide applied to the result of GetApplicationLocale in a few places). Note : this CL will be landed after http://codereview.chromium.org/147038 is landed. BUG=8647 (http://crbug.com/8647) TEST=Pass l10n_util_unittest and other unit tests Review URL: http://codereview.chromium.org/126223 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19183 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: Fixes regression where "Add Page..." didn't work and printed a ↵erg@google.com2009-06-221-3/+3
| | | | | | | | | | NOTIMPLEMENTED() to the console. http://crbug.com/14935 Review URL: http://codereview.chromium.org/145011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18968 0039d316-1c4b-4281-b951-d872f2087c98
* Rebuild the bookmark context menu from scratch when selection changes.estade@chromium.org2009-06-221-6/+0
| | | | | | | | | | | Since the "remove" item always causes selection to change, we don't have to worry about trying to call remove twice with the same context menu. TEST=see bug. Also, no new crashes on linux. BUG=14443 Review URL: http://codereview.chromium.org/132048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18951 0039d316-1c4b-4281-b951-d872f2087c98
* Move TableModel out of views/ and into app/.estade@chromium.org2009-06-163-16/+8
| | | | | | | | | Remove stub implementation in temp_scaffolding_stubs.h Use l10n_util collator helper function in TableModel::Compare Review URL: http://codereview.chromium.org/126184 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18518 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-131-1/+1
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 20:11:16 +0000