summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Remove unneeded uses of base/pickle.h. Add some explicit #includes.thestig@chromium.org2009-04-031-4/+8
| | | | | | Review URL: http://codereview.chromium.org/60095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13093 0039d316-1c4b-4281-b951-d872f2087c98
* Remove deprecated wstring ctor of JSONFileValueSerializer.phajdan.jr@chromium.org2009-04-032-13/+9
| | | | | | | | Switched callers to FilePath. Review URL: http://codereview.chromium.org/62009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13089 0039d316-1c4b-4281-b951-d872f2087c98
* Temporary fix to avoid crash in typing in Omnibox. The crash happenssky@chromium.org2009-03-261-3/+18
| | | | | | | | | | | | | | | | | | | | | if you have a lower case string that is longer than the mixed case string and we get a match at the end of the string. This crashed because the offset is now past the end of the string. This fix is temporary in that it avoids the crash by not highlighting a match in the string. The right fix will be better parsing so we correctly recognize how the two strings line up, but that'll happen later. BUG=9335 TEST=Create a bookmark with the title on the page http://www.google.com/support/forum/p/Chrome/thread?fid=3b64f0cdd1e29e94000466022c425763&hl=en , then type in i and make sure we don't crash. This is also covered by unit tests now, so don't feel you need to test it. Review URL: http://codereview.chromium.org/42664 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12612 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the path layout in both bookmark manager and download location. (issue 8997)xji@chromium.org2009-03-261-10/+19
| | | | | | | | | | | | http://crbug.com/8997 Previously, the path itself and every single path component are marked with LTR marks. The fix is only mark the path as a whole (but not every single path component)with LTR marks. Review URL: http://codereview.chromium.org/49034 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12539 0039d316-1c4b-4281-b951-d872f2087c98
* A trivial fix for localizing 'Bookmark bar' (folder name) in exported 'bookmarkjungshik@google.com2009-03-252-5/+11
| | | | | | | | | | | | | | s.html' file. Update the unit test to match the change in bookmark_html_writer.cc The initial CL got reverted because the unittest failed. This CL changes the unittest. BUG=6957 Review URL: http://codereview.chromium.org/48042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12426 0039d316-1c4b-4281-b951-d872f2087c98
* Free unit tests for Mac: BookmarkHTMLWriterTest, BookmarkUtilsTest,shess@chromium.org2009-03-221-3/+3
| | | | | | | | DownloadRequestManagerTest, URLFetcher*Test, TimeFormat, RenderWidgetTest Review URL: http://codereview.chromium.org/50081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12269 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a bookmark menu. This is experimental. To turn on you needsky@google.com2009-03-202-4/+37
| | | | | | | | | | | | --bookmark-menu. BUG=3206 TEST=Turn on the bookmark menu via --bookmark-menu and make sure it works. Also make sure I didn't break anything on the bookmark bar. Review URL: http://codereview.chromium.org/42460 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12217 0039d316-1c4b-4281-b951-d872f2087c98
* Remove unneeded uses of base/ref_counted.h.thestig@chromium.org2009-03-181-2/+0
| | | | | | Review URL: http://codereview.chromium.org/48105 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11974 0039d316-1c4b-4281-b951-d872f2087c98
* Mac bookmark work. jrg@chromium.org2009-03-183-2/+41
| | | | | | | | | | | | | | | | | | | | | - The bookmark menu is populated dynamically with bookmarks, including subfolders --> submenus. E.g. star something --> shows up in menu. Menu items are disabled but always present and current. - Always Show Bookmarks" menu now live; reads from / writes to preference, and shows correct "toggle state". - Bookmark bar on each tab, present if requested. (Currently an empty box). - Random stuff; e.g. bookmark prefs init moved to a x-plat location. This CL does not contain Cole's views. Bried english description of the nib file changes: - add a new view for the bookmark bar in the tab; hook it up to the controller - Many tag sets (e.g. View-->Always Show Bookmarks Bar now 40009) - Remove dummy bookmark menu items Review URL: http://codereview.chromium.org/46078 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11936 0039d316-1c4b-4281-b951-d872f2087c98
* Move controls into their own dir under chrome/views/controlsben@chromium.org2009-03-178-8/+8
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/48058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11841 0039d316-1c4b-4281-b951-d872f2087c98
* Move windowing related objects into chrome/views/window subdir.ben@chromium.org2009-03-171-1/+1
| | | | | | | | TBR=sky Review URL: http://codereview.chromium.org/42272 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11819 0039d316-1c4b-4281-b951-d872f2087c98
* Removed unneeded includes of base/time.h.thestig@chromium.org2009-03-162-2/+0
| | | | | | Review URL: http://codereview.chromium.org/48019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11766 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting change 11746 because it broke the unit tests.nsylvain@chromium.org2009-03-161-3/+1
| | | | | | Review URL: http://codereview.chromium.org/42240 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11755 0039d316-1c4b-4281-b951-d872f2087c98
* A trivial fix for localizing 'Bookmark bar' (folder name) in exported ↵jungshik@google.com2009-03-161-1/+3
| | | | | | | | | | | 'bookmarks.html' file. BUG=6957 Review URL: http://codereview.chromium.org/46008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11746 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a regression were showing a link brought a browser when to frontsky@google.com2009-03-131-1/+4
| | | | | | | | | | | when it shouldn't have. BUG=8730 TEST=see bug Review URL: http://codereview.chromium.org/46054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11658 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors code for showing bookmarks menus into a standalone classsky@google.com2009-03-125-0/+506
| | | | | | | | | | | | | | | that isn't tied to the bookmark bar. Removes some dead code from the bookmark bar, and fixes a UMR in chrome_menu that I found when running under purify. There isn't any behavior change in this patch. BUG=none TEST=this is a large refactoring of how bookmark menus are shown. Please thoroughly test menus on the bookmark bar to make sure I didn't screw anything up. Review URL: http://codereview.chromium.org/42128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11558 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug were sorting bookmarks wouldn't trigger a save.sky@google.com2009-03-121-0/+3
| | | | | | | | | BUG=8655 TEST=see bug Review URL: http://codereview.chromium.org/42103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11513 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for BlockTillLoaded to Linux.markus@chromium.org2009-03-092-26/+6
| | | | | | Review URL: http://codereview.chromium.org/39298 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11300 0039d316-1c4b-4281-b951-d872f2087c98
* Test to see if we can reduce some crashes by deferring delegate destruction ↵ben@chromium.org2009-03-061-1/+1
| | | | | | | | until WM_NCDESTROY. This involves adding a specific method to allow delegates to destroy themselves to WindowDelegate, and moving all delete this calls into implementations of that method (to allow delegates to still respond to WM_DESTROY which is legit). Review URL: http://codereview.chromium.org/40192 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11132 0039d316-1c4b-4281-b951-d872f2087c98
* NO CODE CHANGE.maruel@google.com2009-03-051-2/+4
| | | | | | | Split the lines >80 cols. (Part 1) Review URL: http://codereview.chromium.org/39206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11032 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark sorting to sort folders first.sky@google.com2009-03-052-7/+49
| | | | | | | | | BUG=8338 TEST=covered by unit tests Review URL: http://codereview.chromium.org/39175 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10993 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes CRLF and trailing white spaces.maruel@chromium.org2009-03-057-7/+7
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98
* revert broken change 10833nsylvain@chromium.org2009-03-032-75/+61
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10837 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-032-61/+75
| | | | | | | Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=10818 Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10833 0039d316-1c4b-4281-b951-d872f2087c98
* Revert dsh's change 10818nsylvain@chromium.org2009-03-032-70/+57
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10821 0039d316-1c4b-4281-b951-d872f2087c98
* Port DictionaryValue to use string16 instead of wstring.dsh@google.com2009-03-032-57/+70
| | | | | | Review URL: http://codereview.chromium.org/31014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10818 0039d316-1c4b-4281-b951-d872f2087c98
* Enables bookmark_model_unittest on Mac and Linux.avi@chromium.org2009-03-031-19/+19
| | | | | | | | | | Committed on behalf of rohitrao. http://codereview.chromium.org/28299/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10813 0039d316-1c4b-4281-b951-d872f2087c98
* Port Replace(First)SubstringsAfterOffset to string16.dsh@google.com2009-03-031-3/+5
| | | | | | Review URL: http://codereview.chromium.org/28324 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10767 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of wstring variants of StringToFoo.dsh@google.com2009-02-282-6/+6
| | | | | | Review URL: http://codereview.chromium.org/28281 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10664 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up sorting of bookmarks to the 'organize menu' in the bookmarksky@google.com2009-02-2710-14/+148
| | | | | | | | | | | | | manager (Glen says no context menus for now). All BookmarkModelObservers have been updated appropriately. BUG=1750 TEST=bring up the bookmark manager and try the 'Reorder by title' menu item, make sure it works and I didn't screw up anything around it. Review URL: http://codereview.chromium.org/27262 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10633 0039d316-1c4b-4281-b951-d872f2087c98
* Coalesce more hardcoded schemes to using predefined constants.brettw@chromium.org2009-02-261-1/+2
| | | | | | Review URL: http://codereview.chromium.org/31008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10437 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark_context_menu.cc and bookmark_drop_info.cc compile on Posix.jhawkins@chromium.org2009-02-256-34/+58
| | | | | | Review URL: http://codereview.chromium.org/28103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10343 0039d316-1c4b-4281-b951-d872f2087c98
* Adds ability to sort the children of a node in the bookmark model. Isky@google.com2009-02-253-10/+67
| | | | | | | | | | | | plan on doing this in chunks, next phase is updating observers, then changing the bookmark manager to call into the new method. BUG=1750 TEST=none yet Review URL: http://codereview.chromium.org/27082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10313 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark_drag_data.cc compile on Posix.jhawkins@chromium.org2009-02-241-0/+22
| | | | | | Review URL: http://codereview.chromium.org/31007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10300 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmark_utils.cc compile on Posix.jhawkins@chromium.org2009-02-241-5/+36
| | | | | | Review URL: http://codereview.chromium.org/27100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10293 0039d316-1c4b-4281-b951-d872f2087c98
* Update include paths for grit files. Go ahead and resorttc@google.com2009-02-229-21/+12
| | | | | | | | the headers too. Review URL: http://codereview.chromium.org/21472 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10167 0039d316-1c4b-4281-b951-d872f2087c98
* This CL fix the following 2 bugs:xji@chromium.org2009-02-201-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | 1.7324 -- RTL: Path contains Hebrew is wrong on "Download location" text box (http://crbug.com/7324) 2. 7326 -- RTL: Folder icon missing on "Download location" text box (http://crbug.com/7326) The fix are: 1. force path to have LTR directionality. 2. draw icon in mirrored position in RTL locales. Steps for test: 1. Create a folder with a Hebrew file name on Hebrew XP 2. Change the download location to the folder created in step 1 3. Observe the path displayed on "Google Chrome Options" --> "Minor Tweaks" --> "Download location" text box Without the fix: The path contains Hebrew folder name is wrong. It displayed as "cCBA\:" while the path is "c:\CBA" where "CBA" is a Hebrew folder name. And there is no folder icon in the "download location" text box. With the fix: The path displayed correctly as "c:\CBA" or "c:\CBA\FED" where "FED" is subfolder of "CBA". And the folder icon showed at the very right. Review URL: http://codereview.chromium.org/20038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10121 0039d316-1c4b-4281-b951-d872f2087c98
* Add TableModel to the scaffold, so we don't depend on views.thestig@chromium.org2009-02-132-0/+8
| | | | | | Review URL: http://codereview.chromium.org/21315 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9730 0039d316-1c4b-4281-b951-d872f2087c98
* Second try of landing chrome_resources project. Changes from last time:tc@google.com2009-02-122-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | - fix scons dependencies by adding a target for grit/theme_resources.h - fix mac build by adding grit to unittest include path - fix check deps by adding rules for /grit dir. Create a chrome_resources.vcproj that holds grd files that hold non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/24011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9664 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Create a chrome_resources.vcproj that holds grd files that hold"tc@google.com2009-02-122-2/+2
| | | | | | | | | | This reverts commit r9631. TBR=deanm Review URL: http://codereview.chromium.org/23023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9634 0039d316-1c4b-4281-b951-d872f2087c98
* Create a chrome_resources.vcproj that holds grd files that holdtc@google.com2009-02-122-2/+2
| | | | | | | | | | | | | | | | | | | | | non-string resources. Put browser_resources.grd into this vcproj. Port theme_resources.rc/theme_resources.h to theme_resources.grd and put it in the vcproj too. I did a find/replace on the theme_resources include line. Modify grit so header files go in grit_generated_resources/grit/ so the include path can be cleaner. I'll migrate the others in follow up patches. theme_resources.rc had a conditional include of distribution_resources.rc so I had to add support for preprocessor defines to visual studio. Review URL: http://codereview.chromium.org/20247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9631 0039d316-1c4b-4281-b951-d872f2087c98
* Re-check in some of my dynamic linking change.evan@chromium.org2009-02-103-23/+41
| | | | | | | | | | | | | We can't link in any more of these fixed .cc files because of a chain of dependencies: - temp_scaffolding_stubs defines the same symbols as these files - removing the scaffolding pulls in more source - pulling in that extra source breaks on Mac. I have resigned myself to checking in this small bit. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9448 0039d316-1c4b-4281-b951-d872f2087c98
* Revert basically everything I've done today as it fails mysteriouslyevan@chromium.org2009-02-103-41/+23
| | | | | | | and I lack the patience to diagnose why mac doesn't link in libjpeg. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9447 0039d316-1c4b-4281-b951-d872f2087c98
* Bring a bunch more headers into the non-Windows build:evan@chromium.org2009-02-103-23/+41
| | | | | | | | | | | | | - history - autocomplete - bookmarks These were all reviewed separately but turned out to be interdependent. :~( Review URL: http://codereview.chromium.org/21170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9444 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a bunch of header includes. I removed some unnecessary headers from abrettw@chromium.org2009-02-012-1/+7
| | | | | | | | variety of places and added ones in other files that were accidentally depending on them. Review URL: http://codereview.chromium.org/19742 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9022 0039d316-1c4b-4281-b951-d872f2087c98
* Remove most header file dependencies on the notification type list. It isbrettw@chromium.org2009-02-013-15/+19
| | | | | | | | | | | really painful to add more types, since lots of headers include the notification service to derive from the notification observer. This splits that out, so much less of the project should end up including notification_types.h ---Paths modified but not in any changelist: Review URL: http://codereview.chromium.org/19744 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9020 0039d316-1c4b-4281-b951-d872f2087c98
* Porting profiles to the Mac.avi@chromium.org2009-01-283-5/+7
| | | | | | Review URL: http://codereview.chromium.org/19623 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8831 0039d316-1c4b-4281-b951-d872f2087c98
* Change FileStream to use FilePath instead of wstring.erikkay@google.com2009-01-261-3/+5
| | | | | | Review URL: http://codereview.chromium.org/18764 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8663 0039d316-1c4b-4281-b951-d872f2087c98
* Small porting in chrome/phajdan.jr@chromium.org2009-01-261-0/+4
| | | | | | | | | This is actually http://codereview.chromium.org/18446 without process_watcher changes. Review URL: http://codereview.chromium.org/18724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8622 0039d316-1c4b-4281-b951-d872f2087c98
* Two things:ben@chromium.org2009-01-241-0/+1
| | | | | | | | | - remove views dependencies from browser by moving profile related dialog actions into BrowserWindow. - simplify the include dependencies in TabStripModel (making it easier to bring up on mac) by implementing more of its high level functionality in the delegate. Review URL: http://codereview.chromium.org/18736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@8606 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-01 05:47:43 +0000