summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Revert 38056 - Unfork BookmarkMenuGtk and BookmarkMenuController.chase@chromium.org2010-02-042-714/+0
| | | | | | | | | | | | | This is step 2 of 3. bookmark_context_menu_controller_gtk will eventually replace bookmark_context_menu_controller; for now it is separate because getting Windows to use it is another huge hassle. BUG=32830 TEST=manual + trybots Review URL: http://codereview.chromium.org/563017 TBR=estade@chromium.org Review URL: http://codereview.chromium.org/567041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38065 0039d316-1c4b-4281-b951-d872f2087c98
* Unfork BookmarkMenuGtk and BookmarkMenuController.estade@chromium.org2010-02-042-0/+714
| | | | | | | | | | This is step 2 of 3. bookmark_context_menu_controller_gtk will eventually replace bookmark_context_menu_controller; for now it is separate because getting Windows to use it is another huge hassle. BUG=32830 TEST=manual + trybots Review URL: http://codereview.chromium.org/563017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38056 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: middle click on a bookmark bar folder should open all in tabs.estade@chromium.org2010-02-031-0/+1
| | | | | | | | | BUG=34416 TEST=try it Review URL: http://codereview.chromium.org/569031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38003 0039d316-1c4b-4281-b951-d872f2087c98
* Support reordering of Browser Actions within the container. Currently does ↵finnur@chromium.org2010-02-032-25/+8
| | | | | | | | | | | | | | not support dragging to/from the chevron menu. Also fixed two bugs in the same code: - the container would be 0 width if a value for it hasn't been saved (part of bug 32101). - the default icon was not used when a tab specific icon was not found (bug 34317). BUG=http://crbug.com/26990, http://crbug.com/32101, http://crbug.com/34317 TEST=In both LTR and RTL locale, try reordering the browser actions and make sure to test dragging to the ends with and without a chevron visible. Install Send to Gmail extension and make sure it has an icon while in the overflow menu. Review URL: http://codereview.chromium.org/549224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37922 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/542006 for Thiago:sky@chromium.org2010-02-021-20/+18
| | | | | | | | | | | | | views: Add Cut/Copy/Paste items to the bookmark bar context menu. Based on this patch: http://codereview.chromium.org/536001/show BUG=32063 TEST=manually Review URL: http://codereview.chromium.org/563011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37881 0039d316-1c4b-4281-b951-d872f2087c98
* BSD port: chrome/app and chrome/browser ifdef cleaningpvalchev@google.com2010-02-011-6/+4
| | | | | | Review URL: http://codereview.chromium.org/548203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37714 0039d316-1c4b-4281-b951-d872f2087c98
* Makes it so deleting a bookmark from the context menu doesn't closesky@chromium.org2010-01-282-7/+20
| | | | | | | | | | | | | the bookmark menu. BUG=2469 TEST=click on a bookmark folder on the bookmark bar, right click on an item and chose delete. Make sure the folder stays up and still works correctly (and the item you deleted isn't there). Review URL: http://codereview.chromium.org/551178 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37424 0039d316-1c4b-4281-b951-d872f2087c98
* Add import/export extension apisfeldstein@chromium.org2010-01-283-0/+27
| | | | | | | | | | | This is a duplicate of 543094. That code review seems to have gotten corrupted as i can no longer publish anything from their web UI. It was LGTM'd+nits by arv, which i've fixed here. BUG=32194 TEST=Import and export bookmarks from the extension Review URL: http://codereview.chromium.org/548167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37351 0039d316-1c4b-4281-b951-d872f2087c98
* remove ICU includes from l10n_util.hevan@chromium.org2010-01-251-0/+1
| | | | | | | | | | | | | | | | 95% of users of l10n_util use it for some functions; the other 5% want some complicated templates that pull in a ton of ICU headers as well. Before this change, the average includer of l10n_util.h pulled in an additional 80 subheaders because of it. Additionally, #including ICU headers from a header makes the includee depend on having the ICU include path in the -I header. Review URL: http://codereview.chromium.org/515059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37032 0039d316-1c4b-4281-b951-d872f2087c98
* More bookmarks string1t work.munjal@chromium.org2010-01-217-62/+62
| | | | | | | | | TEST=exists BUG=32013 Review URL: http://codereview.chromium.org/546094 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36805 0039d316-1c4b-4281-b951-d872f2087c98
* Use string16 instead of wstring in bookmark data model.munjal@chromium.org2010-01-112-2/+87
| | | | | | | | | | | | | Add overloads to bookmark model for string16. Wrap wstring versions in #if !defined since string16 is just a typedef of wstring on windows. TEST=exist BUG=32013 Review URL: http://codereview.chromium.org/536013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35964 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/527033 for bryenug:sky@chromium.org2010-01-081-0/+4
| | | | | | | | | | | Allow URLs to be pasted as text. BUG=31776 TEST=see bug Review URL: http://codereview.chromium.org/529001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35825 0039d316-1c4b-4281-b951-d872f2087c98
* Make bookmarks manager search work for URLs containing uppercase characterskinuko@chromium.org2009-12-162-3/+20
| | | | | | | | | | BUG=30427 TEST=BookmarkUtilsTest.DoesBookmarkContainText TEST=Add a bookmark item for a URL containing upper case, open the bookmarks manager and type in the URL in the 'Search' form. Make sure the bookmark is found. Review URL: http://codereview.chromium.org/502011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34646 0039d316-1c4b-4281-b951-d872f2087c98
* Give classes with virtual methods virtual protected d'tors instead of ↵jamesr@chromium.org2009-12-162-2/+8
| | | | | | | | | | | | | | | | | | | | | non-virtual public implicit d'tors. Was originally: Replace public nonvirtual destructors in classes with virtual members with protected nonvirtual destructors where possible, and with public virtual destructors where destruction of a derived class occurs. (chrome/browser/[a-m]* only) (Part 4 of http://www.gotw.ca/publications/mill18.htm has a rationale for why public nonvirtual destructors in classes with virtual members is dangerous.) BUG=none TEST=base_unittests & app_unittests Review URL: http://codereview.chromium.org/201100 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34634 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/469009 for Thiago:sky@chromium.org2009-12-163-13/+13
| | | | | | | | | | | | bookmarks: Update parent (folder) modified time when we create a new bookmark node. BUG=none TEST=none Review URL: http://codereview.chromium.org/500005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34626 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-12-027-81/+86
| | | | | | Review URL: http://codereview.chromium.org/457025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33561 0039d316-1c4b-4281-b951-d872f2087c98
* Remove std::wstring from most of net/base/escape.h.darin@chromium.org2009-11-301-1/+1
| | | | | | | | | | | | | | | | | | | I left the one API because based on the comment, it should eventually be removed. Updated the callers to use UTF16ToWideHack until more work can be done to remove std::wstring. I also updated net/base/escape_unittest.cc to use the same hack until a proper solution can be coded. Original patch submission here: http://codereview.chromium.org/402085 Patch by Patrick Scott (phanna@android.com) R=darin BUG=23581 TEST=escape_unittest Review URL: http://codereview.chromium.org/452015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33326 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-1/+5
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33324 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 33301 and 33305 due to unit_tests breakage.maruel@chromium.org2009-11-302-5/+1
| | | | | | | | TBR=pawel Review URL: http://codereview.chromium.org/453007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33309 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2009-11-302-1/+5
| | | | | | | | | TEST=none BUG=none Review URL: http://codereview.chromium.org/454004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33301 0039d316-1c4b-4281-b951-d872f2087c98
* Many changes to DictionaryValues:pkasting@chromium.org2009-11-251-4/+4
| | | | | | | | | | | | | | | | | * Add support for keys with "." in them via new XXXWithoutPathExpansion() APIs. * Use these APIs with all key iterator usage. * SetXXX() calls cannot fail, so change them from bool to void. * Change GetSize() to size() since it's cheap, and add empty(). Other: * Use standard for loop format in more places (e.g. instead of while loops when they're really doing a for loop). * Shorten a few bits of code. BUG=567 TEST=none Review URL: http://codereview.chromium.org/441008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33109 0039d316-1c4b-4281-b951-d872f2087c98
* Use plain strings instead of wstrings for UMA actionsevan@chromium.org2009-11-171-12/+12
| | | | | | | | | | | | git grep 'RecordAction(L' | xargs sed -i -e s/RecordAction(L/RecordAction(/ This cuts more than 10k off my binary. Which is nothing compared to the size of the binary, but that's a whole lot of zero bytes! This is less code this way anyway. Review URL: http://codereview.chromium.org/399026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32194 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes almost all of the rest of lint errors in the chrome/ directory (minus ↵erg@google.com2009-11-131-1/+1
| | | | | | | | the really hard ones which will need actual review instead of rubber-stamping.) Review URL: http://codereview.chromium.org/386026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31932 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various problems with inline autocomplete and URLs that change length ↵pkasting@chromium.org2009-11-072-5/+4
| | | | | | | | | | | | | | | | | | | | during fixup: * URLs with http auth info, which gets stripped * URLs with IDN hosts * URLs with escaped values that get unescaped In cases like these, we'd inline autocomplete from the wrong locations, highlight the wrong portions of the URL as matches, and sometimes DCHECK() in debug mode. The fix is to track how fixup affects the offsets into the URL we care about. Plumbing this required an enormous number of additions :( There is also a fix here to the URL Fixer Upper, which was obviously modified at some point in the past to use the Parsed components, but without updating the comments or some of the functionality to match. Since this isn't supposed to "fix up" things that aren't simple typos, I removed some code to "fix" bogus ports, which was causing bizarre effects when typing HTTP auth URLs ("http://foo:bar" would be fixed to "http://foo" and then matched for inline autocompletion, which was clearly wrong). This is tested incidentally by one of the new History URL Provider tests (which is how I discovered it). BUG=4010 TEST=Covered by unittests Review URL: http://codereview.chromium.org/372017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31352 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Revert r31175 r31176 r31187"hclam@chromium.org2009-11-061-1/+4
| | | | | | | | | | | | The bustage seems to be a WebKit change upstream. It is not reverted in WebKit and merger. So bring the innocent change back in. TBR=jam TEST=green tree Review URL: http://codereview.chromium.org/375009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31214 0039d316-1c4b-4281-b951-d872f2087c98
* Rever r31175 r31176 r31187hclam@chromium.org2009-11-061-4/+1
| | | | | | | | | | | XP tests are failing, the guess is r31175 and r31176. TBR=beng TEST=XP tests go green Review URL: http://codereview.chromium.org/376008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31201 0039d316-1c4b-4281-b951-d872f2087c98
* Fifth patch in making destructors of refcounted objects private.jam@chromium.org2009-11-061-1/+4
| | | | | | | | BUG=26749 Review URL: http://codereview.chromium.org/361025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31175 0039d316-1c4b-4281-b951-d872f2087c98
* Enable localization of default downloaded filename.tony@chromium.org2009-11-041-1/+2
| | | | | | | | | | | | | | | Instead of localizing "download" string in net_util.cc, make a caller, download_manger, provide a localized string. BUG=25289 TEST=NetUtilTest.GetSuggestedFilename,DownloadManagerTest.TestDownloadFilename Original patch by hayato@google.com at: http://codereview.chromium.org/343014/show Review URL: http://codereview.chromium.org/367003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30971 0039d316-1c4b-4281-b951-d872f2087c98
* Unittest for fix to allow navigation when there is no history DB.pkasting@chromium.org2009-11-022-6/+6
| | | | | | | | BUG=25822 TEST=none Review URL: http://codereview.chromium.org/343067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30744 0039d316-1c4b-4281-b951-d872f2087c98
* Third patch in getting rid of caching MessageLoop pointers and always using ↵jam@chromium.org2009-11-0210-65/+70
| | | | | | | | | | ChromeThread instead. BUG=25354 Review URL: http://codereview.chromium.org/342068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30687 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for crash when a bookmark URL is an empty string tim@chromium.org2009-10-302-4/+6
| | | | | | | | | | | | BUG=19852 TEST=See repro steps of the bug Patch by Bruno Calvignac <BrunoCalvignac@gmail.com> Original CL http://codereview.chromium.org/282004 Review URL: http://codereview.chromium.org/342046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30540 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark html writer test to lookup string rather than hardsky@chromium.org2009-10-281-14/+9
| | | | | | | | | | | | coding. I can't think of a good reason why we were hard coding it before. BUG=17592 TEST=none Review URL: http://codereview.chromium.org/340009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30373 0039d316-1c4b-4281-b951-d872f2087c98
* Fix browser crash on startup.ukai@chromium.org2009-10-271-1/+1
| | | | | | | | | | | | | | | | | | > chrome.dll!`anonymous namespace'::OnNoMemory() Line 126 C++ chrome.dll!_invalid_parameter_noinfo() Line 99 + 0xc bytes C++ chrome.dll!RefCountedBytes::front() Line 67 + 0x1b bytes C++ chrome.dll!BookmarkModel::OnFavIconDataAvailable(int handle=8, bool know_favicon=true, scoped_refptr<RefCountedBytes> data={...}, bool expired=true, GURL icon_url={...}) Line 652 + 0x2b bytes C++ It seems RefCountedBytes data has no data. If data size is 0, accessing front of data would cause crash. By checking its size, fixes this crash. BUG=25803 TEST=no crash on startup Review URL: http://codereview.chromium.org/328037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30171 0039d316-1c4b-4281-b951-d872f2087c98
* Mark flaky tests as flaky:phajdan.jr@chromium.org2009-10-261-1/+2
| | | | | | | | | | | | BookmarkHTMLWriterTest.Test (suspected resource flakiness) LoginPromptTest.TestTwoAuths TEST=none BUG=17592, 25794 Review URL: http://codereview.chromium.org/332024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30087 0039d316-1c4b-4281-b951-d872f2087c98
* Move the json-related files into a separate json directory. This hopefully alsobrettw@chromium.org2009-10-231-1/+0
| | | | | | | | | | | makes the naming of string_escape more clear (it's actually JSON-specific). Move the files into the base namespace. TEST=none BUG=none Review URL: http://codereview.chromium.org/316016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29934 0039d316-1c4b-4281-b951-d872f2087c98
* Do some cleanup of file path name handling.brettw@chromium.org2009-10-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | This started trying to cleanup DownloadManager::GenerateFilename which asserts if your system locale isn't UTF-8 (I ran into this when mine got messed up). The solution is to have GetSuggestedFilename return a FilePath rather than calling FromWStringHack. The rest of the patch is a result of trying to write GetSuggestedFilename in a reasonable way. I changed ReplaceIllegalCharacters to work on a FilePath::StringType. Some places in the code calling these functions got cleaner, some got messier. I think overall the ones that got messier are the ones doing sketchy things with paths and the ones that got cleaner are the ones doing things more properly. The only code here that gets called a nontrivial number of times is the weburlloader, and I think the new code does about the same number of string conversions overall (though on certain platforms the number will be higher or lower). BUG=none TEST=none Review URL: http://codereview.chromium.org/271056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29832 0039d316-1c4b-4281-b951-d872f2087c98
* Make PNGCodec::Decode(...) not make an intermediary copy of the decoded data;erg@google.com2009-10-221-1/+1
| | | | | | | | | | | instead have it write directly to the returned SkBitmap. BUG=http://crbug.com/24493 TEST=Perf should get better. On the perf trybot, tab_complex_theme_cold got an average of ~40ms better. Review URL: http://codereview.chromium.org/305001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29780 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/272036 for Thiago:sky@chromium.org2009-10-195-25/+25
| | | | | | | | | | | | | | Rename GetType and SetType using the Unix style to match with the other usages in BookmarkNode. GetType -> type SetType -> set_type BUG=None TEST=None Review URL: http://codereview.chromium.org/297005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29443 0039d316-1c4b-4281-b951-d872f2087c98
* Support the Bookmark bar and Other bookmarks titles in titlecase.thomasvl@chromium.org2009-10-191-0/+6
| | | | | | | | TEST=the bookmark bubble menu should have title case items for the two. BUG=24912 Review URL: http://codereview.chromium.org/297004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29431 0039d316-1c4b-4281-b951-d872f2087c98
* Add NOTREACHED for someone trying to change the title on the bookmark bar ↵thomasvl@chromium.org2009-10-191-0/+5
| | | | | | | | | | folder or other bookmarks folders. TEST=none BUG=25067 Review URL: http://codereview.chromium.org/293006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29409 0039d316-1c4b-4281-b951-d872f2087c98
* Makes canceling 'bookmark all tabs' delete the folder. Or rather,sky@chromium.org2009-10-164-66/+124
| | | | | | | | | | | | | | | | | | | | | | | | makes it so that bookmark all tabs only creates the folder if the user presses ok. I wasn't happy adding another random arg to BookmarkEditor::Show, so I added in a structure an enum. This makes it clearer what Show should do. I also fixed the following: . On gtk we wouldn't always pick the right parent for nodes. . The context menu item is now enabled on views/gtk. And this now breaks the mac side. I'll straighten that out right after landing this. BUG=24367 TEST=Make sure 'bookmark all tabs' works, as well as the bookmark editor work. (get to the bookmark editor by creating a new bookmark, then clicking edit, or right clicking a bookmark on the bookmark bar and choosing edit). Review URL: http://codereview.chromium.org/271115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29343 0039d316-1c4b-4281-b951-d872f2087c98
* More style nits.erg@google.com2009-10-141-1/+1
| | | | | | | | (Working on cleaning chrome/ so hopefully we can lint it by default.) Review URL: http://codereview.chromium.org/274040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28971 0039d316-1c4b-4281-b951-d872f2087c98
* Converts some uses of native_view to native_window. This is necessitatedsky@chromium.org2009-10-125-12/+11
| | | | | | | | | | | | by wanting to parent bookmarkeditor to browserwindow, which returns a native_window. BUG=none TEST=none Review URL: http://codereview.chromium.org/270067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28728 0039d316-1c4b-4281-b951-d872f2087c98
* Move native_widget_types and gtk_native_view_id_manager from base/gfx tobrettw@chromium.org2009-10-114-4/+4
| | | | | | | | | | | | app/gfx in preparation for removing the base_gfx project. This also moves base/window_impl.cc to app/win/window_impl because this file shouldn't be in base. TEST=none BUG=none Review URL: http://codereview.chromium.org/273017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98
* Move more ICU-dependent stuff from base into base/i18n. Some test stuff alsobrettw@chromium.org2009-10-092-2/+2
| | | | | | | | | | | | depended on this, so to make the DEPS work out, I made a new base/test directory where I moved the testing-related files into a new directory base/test. TEST=none BUG=none Review URL: http://codereview.chromium.org/266038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28569 0039d316-1c4b-4281-b951-d872f2087c98
* Allow the NTP to be bookmarked.pkasting@chromium.org2009-10-092-16/+7
| | | | | | | | BUG=none TEST=Try to bookmark the NTP. Review URL: http://codereview.chromium.org/269028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28564 0039d316-1c4b-4281-b951-d872f2087c98
* * Add ctrl-shift-d to bookmark all tabs.pkasting@chromium.org2009-10-082-13/+12
| | | | | | | | | | | * Enable or disable bookmark commands based on whether we're actually going to be able to bookmark anything. * Rename IDC_STAR to IDC_BOOKMARK_PAGE, which is more obvious. BUG=2935 TEST=Hit ctrl-shift-d, make sure it bookmarks all tabs Review URL: http://codereview.chromium.org/266029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28480 0039d316-1c4b-4281-b951-d872f2087c98
* Add the ability to unload the HistoryBackend.pkasting@chromium.org2009-10-083-3/+3
| | | | | | | | | | A small number of places used accessors like in_memory_url_database() or backend_loaded() with the expectation that if they weren't already functional, the history system was in the process of making them so. I elected to make both of these functions that triggered lazy backend initialization. BUG=23400 TEST=none Review URL: http://codereview.chromium.org/267019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28461 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability to create a bookmark folder populated with a bookmarksky@chromium.org2009-10-083-7/+54
| | | | | | | | | | | | | | | for each open tab. I've currently wired this up on windows, will wire up rest of platforms in a separate cl. BUG=2935 TEST=on Windows open multiple tabs, right click on a tab and choose 'Bookmark all tabs'. You should then get the bookmark editor with no url field. Accepting the dialog should result in creating a new folder with a bookmark for each of the open tabs. Review URL: http://codereview.chromium.org/270021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28446 0039d316-1c4b-4281-b951-d872f2087c98
* Makes sure bookmark ids are unique on reading from file. If not uniquesky@chromium.org2009-10-073-8/+61
| | | | | | | | | | | | | | | we reassign them. The particular scenario that can lead to this is when migrating bookmarks out of the db we never reset the ids of the newly created nodes, so that we wrote all to the file with ids of 0. I'm not patching that code so that I have coverage of the unit test, and we'll handle fix up during reading anyway. BUG=24060 TEST=covered by unit tests Review URL: http://codereview.chromium.org/268001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28346 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 20:06:06 +0000