summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Fixes a handful of related bookmark manager bugs/requests:sky@google.com2008-12-111-2/+9
| | | | | | | | | | | | | | | . Adds a search field before the text field. . When the search node is selected and there are no results or no search text, a descriptive label is drawn on top of the table telling the user what's happening. . In the bookmark menus Edit... is now Rename... for folders. BUG=5272 5319 5273 4165 TEST=see individual bugs Review URL: http://codereview.chromium.org/13724 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6777 0039d316-1c4b-4281-b951-d872f2087c98
* Changes bookmark manager search to use contains vs starts with and tosky@google.com2008-12-104-25/+103
| | | | | | | | | | | | search urls. BUG=4065 TEST=create the URL foo.com and type 'foo.com' in the bookmark manager search box. Make sure the url you just typed shows up in the table. Review URL: http://codereview.chromium.org/13679 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6714 0039d316-1c4b-4281-b951-d872f2087c98
* Moves some utility functions out of bookmark model intosky@google.com2008-12-096-167/+172
| | | | | | | | | | | | bookmark_utils. In addition I've converted to using TreeNodeIterator. This doesn't contain any functionality changes. BUG=4065 TEST=none Review URL: http://codereview.chromium.org/13642 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6589 0039d316-1c4b-4281-b951-d872f2087c98
* Add error messages to JSONReader and friends. This required a bit of ↵aa@chromium.org2008-12-051-1/+1
| | | | | | | | refactoring to do cleanly. This CL doesn't actually use this capability anywhere except for unit tests. I will add that in a future CL. Review URL: http://codereview.chromium.org/13169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6459 0039d316-1c4b-4281-b951-d872f2087c98
* Port some files in chrome/browser/ - part 1.deanm@chromium.org2008-11-255-22/+24
| | | | | | | Review URL: http://codereview.chromium.org/11402 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6007 0039d316-1c4b-4281-b951-d872f2087c98
* Changes table_view to get position for context menu from the currentsky@google.com2008-11-251-2/+4
| | | | | | | | | | | | | | position of the mose. I've no idea why, but it seems when RTL the position passed to OnContextMenu is wrong in weird inconsistent ways. I thought it was interted, but that isn't always the case. I'm also changing the anchor position to top_right when RTL. BUG=4750 TEST=see bug Review URL: http://codereview.chromium.org/12447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5996 0039d316-1c4b-4281-b951-d872f2087c98
* Rename Container->Widgetben@chromium.org2008-11-211-1/+0
| | | | | | | | | R=erg review url = http://codereview.chromium.org/11348/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5849 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes crash when showing modal dialog from context menu. With thissky@google.com2008-11-192-5/+10
| | | | | | | | | | | | | | | | | | | | | sequence ContainerWin remains on the stack while the modal dialog is showing. Prior to this fix we would delete the ContainerWin, so that when the modal dialog closed control would return to a deleted object. The fix is to effectively delay deleting of the ConatinerWins used by menus. BUG=4580 TEST=This is the sequence that triggered the crash: open a folder on the bookmark bar, right child on a child folder that has more than 15 descendant URLs, click open all, a dialog should appear asking if you really want to open all, click cancel and make sure it doesn't crash. This is a subtle change to bookmark menus though, would be good to thoroughly exercise the menus in as many permutations as you can think of. Review URL: http://codereview.chromium.org/11289 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5724 0039d316-1c4b-4281-b951-d872f2087c98
* Land this change again now I've fixed the crash.ben@chromium.org2008-11-191-1/+1
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5669 0039d316-1c4b-4281-b951-d872f2087c98
* Revert change 5596 because it broke the buildnsylvain@chromium.org2008-11-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/11439 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5598 0039d316-1c4b-4281-b951-d872f2087c98
* Last couple of bits of new-frame related cleanup:ben@chromium.org2008-11-181-1/+1
| | | | | | | | | | | | | - Remove frame_util.cc, moving functions to BrowserList (endsession) and BrowserView (GetBrowserWindowForHWND) - Tidy up interface for TabIconView model. The model now sources only the information it needs (loading state and favicon). - Replace BrowserType class with an enum on Browser. http://crbug.com/2320 http://crbug.com/3363 Review URL: http://codereview.chromium.org/10786 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5596 0039d316-1c4b-4281-b951-d872f2087c98
* Makes opening a bookmark activate the window.sky@google.com2008-11-171-2/+4
| | | | | | | | | BUG=4447 TEST=see bug Review URL: http://codereview.chromium.org/10765 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5560 0039d316-1c4b-4281-b951-d872f2087c98
* Re-do the way browser windows are shown:ben@chromium.org2008-11-141-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | - Remove the path from WinMain to the Browser object passing the show_command. For the Browser object, this is a problem since this value isn't portable. For the code in general it involves a lot of ugly wiring. It's completely unnecessary since the value is obtainable via GetStartupInfo. - Remove show_command plumbing from all over the place (session restore, web app launcher, etc) Change the way browser windows are constructed: - The browser constructor now takes just a type and a profile, and simply initializes the object. - Some configuration that used to be part of the constructor that was only used in one or two use cases (initial bounds, maximized state, web app name) are split into separate setters. - Window creation is split out into a separate step to be called post configuration. - Assorted static helper functions added to Browser to make construction of common types easy. - Remove Browser::Show in favor of BrowserWindow::Show - Adjust all callers to use the new helpers. Change the way ChromeViews restores window placement: - Split restored size determination from restored maximized determination. They are needed by the code at different times. Size restoration happens when the window is constructed and Window::SetInitialBounds is called. Maximized state restoration happens when the window is shown for the first time and SW_SHOWMAXIMIZED or SW_SHOWNORMAL is needed. Thus, replace WindowDelegate::RestoreWindowPosition with WindowDelegate::RestoreWindowBounds and WindowDelegate::RestoreMaximizedState. - Window::SetInitialBounds calls WindowDelegate::RestoreWindowBounds - Window::Show calls WindowDelegate::RestoreMaximizedState - Adjusts all WindowDelegate implementations that override RestoreWindowPosition to implement these new methods instead. - Move "playback/record" mode window size setting from browser_init to Browser::RestoreWindowBounds. - Provide a virtual function on Window called GetShowState that determines the default show state to be used when Window::Show is called. For most windows and dialogs this is SW_SHOWNORMAL. AeroGlassFrame/OpaqueFrame (the browser window frames) override this since they're the app's main windows to return the value provided by GetStartupInfo which gives the value from the app shortcut. http://crbug.com/3557 Review URL: http://codereview.chromium.org/10896 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5417 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in adding bookmark groups. Adding wasn't setting thesky@google.com2008-11-131-0/+1
| | | | | | | | | | | | modified date, which meant newly added groups wouldn't show up in the combobox of the bookmark bubble. BUG=766 TEST=see bug Review URL: http://codereview.chromium.org/10709 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5400 0039d316-1c4b-4281-b951-d872f2087c98
* Adds cut/copy/paste support to the bookmark manager tree/table andsky@google.com2008-11-075-2/+117
| | | | | | | | | | | | context menus. BUG=4186 TEST=try cut/copy/paste from table/tree in the bookmark manager as well as context menus in bookmark manager. Review URL: http://codereview.chromium.org/9481 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4993 0039d316-1c4b-4281-b951-d872f2087c98
* Adds import/export of bookmarks to bookmarks.html file.sky@google.com2008-11-076-15/+513
| | | | | | | | | | | | BUG=1649 TEST=bring up bookmark manager and try out import/export from the tools menu. Note that import ALWAYS creates a new folder under the 'Other bookmarks folder' with the name of Imported (x). This is by design. Review URL: http://codereview.chromium.org/9471 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4968 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes two bookmark manager bugs:sky@google.com2008-11-053-4/+31
| | | | | | | | | | | | | | . Pressing enter when more than one folder is selected opens them all. . Show in folder is only enabled when it makes sense: you've selected a bookmark in the table and the table is showing recently bookmarked or search results. BUG=4034 4044 TEST=see bugs Review URL: http://codereview.chromium.org/9367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4780 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for autoscrolling on drag to bookmark tree/table.sky@google.com2008-11-044-11/+135
| | | | | | | | | BUG=674 TEST=none Review URL: http://codereview.chromium.org/9042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4625 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for models to provide addition icons to the tree. Updatessky@google.com2008-11-042-1/+24
| | | | | | | | | | | | the bookmarks folder tree model to return custom icons for search and recently bookmarked. BUG=674 TEST=none Review URL: http://codereview.chromium.org/9047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4556 0039d316-1c4b-4281-b951-d872f2087c98
* Miscellaneous bookmark manager polish:sky@google.com2008-11-033-114/+180
| | | | | | | | | | | | | | | | | | | | | | | . Adds a menu button on the bookmark manager. If I finish up import I'll add a second one for importing. . Creating new page/folder from menu items selects new item in table. . I changed around the FolderBookmarkTableModel to copy the contents into a vector (now extends VectorBackedTabledModel). This is necessitated by TableView not providing a moved notification. The problem with previous approach is that I sent out ModelChanged on any change, which loses selection and causes things to snap around. I considered adding a moved method to TableView, but it's too much work at this time. . Added persisting of divider location in bookmark manager. . When focus is on table pressing enter on a folder descends into the folder, and pressing backspace goes back up a folder. BUG=674 TEST=none Review URL: http://codereview.chromium.org/8967 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4512 0039d316-1c4b-4281-b951-d872f2087c98
* Adds the ability for ObserverList to not notify observers added duringsky@google.com2008-10-311-0/+1
| | | | | | | | | | | | | notification. I need this for bookmarks. If a new observer is added while the bookmark model is in the process of sending out notification the newly added observer gets confused. BUG=674 TEST=none Review URL: http://codereview.chromium.org/8919 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4267 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at the bookmark manager. There are still a fair number ofsky@google.com2008-10-297-98/+1106
| | | | | | | | | | | | | | | | | | | | | | | | | rough edges, but I'm at a good point where I want to land what I have. Here's what is left: . Flicker on show, likely the result of restoring window placement. . tree flickers when dragging splitter. . table/tree need to autoscroll when drop cursor held at bottom of view. . prompts for deleting. . When you move an item the table snaps to the top, this is because I'm sending out model changed. need a better notification. . Operations in menu to add need to change selection. . Remember split location. I would have preferred to split this up into a couple of reviews, but everything is intertwined now. Sorry. BUG=674 TEST=don't test the bookmark manager yet, but make sure bookmark bar still works. Review URL: http://codereview.chromium.org/8197 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4191 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so the user can't drag javascript: links to thetc@google.com2008-10-281-2/+8
| | | | | | | | | | | | desktop from web content or the bookmarks bar. Maintain the ability to drag javascript: links from web content to the bookmarks bar or to drag the javascript: link as plain text. BUG=3431 Review URL: http://codereview.chromium.org/8638 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4050 0039d316-1c4b-4281-b951-d872f2087c98
* Move Time, TimeDelta and TimeTicks into namespace base.dsh@google.com2008-10-275-7/+16
| | | | | | Review URL: http://codereview.chromium.org/7995 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@4022 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors some of the bookmark drag and drop code into a separatesky@google.com2008-10-244-2/+145
| | | | | | | | | | | | class that I can use in the bookmark manager. BUG=674 TEST=make sure drag and drop on the bookmark bar still works, especially when moving folders around. Review URL: http://codereview.chromium.org/8115 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3896 0039d316-1c4b-4281-b951-d872f2087c98
* Adds models needed by the bookmark manager. Specifically asky@google.com2008-10-238-5/+1188
| | | | | | | | | | | | | BookmarkTableModel, which will be used to show one of the following: the children of a folder, recently bookmarked or the results of a search. And the tree model implementation that shows the folders. BUG=674 TEST=covered by unit tests Review URL: http://codereview.chromium.org/8063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3814 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkDragData to allow for multiple nodes. I'm going tosky@google.com2008-10-173-124/+275
| | | | | | | | | | | | | | | | | need this for the bookmark manager, which will let you drag multiple nodes around. I didn't make the bookmark bar deal with multiple nodes though (it won't allow a drop of multiple nodes). I may add support for this at some point, but not in this patch. BUG=674 TEST=covered by unit tests, but make sure the aren't problems dragging around bookmarks on the bookmark bar, especially with folders. Review URL: http://codereview.chromium.org/7498 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3575 0039d316-1c4b-4281-b951-d872f2087c98
* Rename ChromeViews namespace to viewsben@chromium.org2008-10-162-2/+2
| | | | | | http://crbug.com/2188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3495 0039d316-1c4b-4281-b951-d872f2087c98
* Changes BookmarkModel to not grab the same lock twice.sky@google.com2008-10-092-5/+16
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/6391 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@3127 0039d316-1c4b-4281-b951-d872f2087c98
* Port some more of chrome/ to Linux.deanm@google.com2008-10-022-0/+2
| | | | | | | | Original review: http://codereview.chromium.org/4247 Patch from Pawel Hajdan Jr. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2793 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes a couple of bookmark bar bugs:sky@google.com2008-10-011-1/+1
| | | | | | | | | | | | | | | | | . The folders on the bookmark bar now fade in like urls. . You can now middle click on folders to open all URLs. . If you attempt to open a folder with more than 15 urls we'll prompt before openning. BUG=242 529 1295385 TEST=middle click on a folder on the bookmark bar and make sure it opens all tabs in the background. Try this with a folder containing more than 15 bookmarks and make sure you get a message box before asking if you really want to open them all. Review URL: http://codereview.chromium.org/6020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2756 0039d316-1c4b-4281-b951-d872f2087c98
* Changes the bookmark model to allow more than one bookmark tosky@google.com2008-09-197-94/+267
| | | | | | | | | | | | | | | | reference the same url. Clicking the star button edits the most recently added bookmark for the URL. Dragging a button/star always does a move, otherwise drops on the bookmark bar create a new bookmark. Also changed the add page context menu for the bookmark bar to remember where you invoked it from. BUG=1173228 1678 Review URL: http://codereview.chromium.org/3203 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2413 0039d316-1c4b-4281-b951-d872f2087c98
* Rename legacy methods that were in CamelCase to unix_hacker.erg@google.com2008-09-171-96/+96
| | | | | | | | | Required going through and modifying some of the code to solve name clashes. Review URL: http://codereview.chromium.org/2945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2337 0039d316-1c4b-4281-b951-d872f2087c98
* Adds logging of loading/saving bookmarks to help me diagnose why somesky@google.com2008-09-162-0/+18
| | | | | | | | | | | folks are having problems. BUG=none TEST=none Review URL: http://codereview.chromium.org/2914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2290 0039d316-1c4b-4281-b951-d872f2087c98
* Renames BoomarkBarModel to BookmarkModel.sky@google.com2008-09-1110-360/+353
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2057 0039d316-1c4b-4281-b951-d872f2087c98
* Moves bookmark related classes into bookmarks directory. There are nosky@google.com2008-09-0910-0/+2703
| | | | | | | | | | | | code changes here (other than converting to COPY_AND_BLAH_BLAH and updating include guards). BUG=none TEST=none Review URL: http://codereview.chromium.org/1868 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1944 0039d316-1c4b-4281-b951-d872f2087c98
* Makes deleting history no longer delete starred urls. Thiseffectively ↵sky@google.com2008-08-271-0/+61
reenables the code in ExpireHistoryBackend. I also madethe code consistent so that when we delete visits as the result ofhistory deletion we don't change the typed/visit count of theunderlying url.BUG=1214201 1256202TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1423 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-02 04:28:12 +0000