summaryrefslogtreecommitdiffstats
path: root/chrome/browser/bookmarks
Commit message (Collapse)AuthorAgeFilesLines
* Remove obviously unneeded forward declarations in chrome/browser/[abef]*/*.h.viettrungluu@chromium.org2010-08-056-11/+3
| | | | | | | | | BUG=none TEST=builds Review URL: http://codereview.chromium.org/3027041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55136 0039d316-1c4b-4281-b951-d872f2087c98
* Rename GetStringAsUTF16() to GetString() (and overload), etc.viettrungluu@chromium.org2010-08-042-25/+25
| | | | | | | | | | | | Also do some drive-by wstring/wchar_t -> string/char changes (in addition to the necessary ones). BUG=none TEST=builds and tests pass Review URL: http://codereview.chromium.org/3091005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54944 0039d316-1c4b-4281-b951-d872f2087c98
* Rename DictionaryValue's SetStringFromUTF16() to SetString() (and overload).viettrungluu@chromium.org2010-08-041-2/+2
| | | | | | | | | | | | | Also do a bunch of drive-by changes while I'm at it. Still to do: rename GetStringAsUTF16() to GetString(). BUG=none TEST=builds everywhere, tests pass Review URL: http://codereview.chromium.org/3033050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54915 0039d316-1c4b-4281-b951-d872f2087c98
* Add #include utf_string_conversions.h to all files that use ASCIIToWide andbrettw@chromium.org2010-08-032-0/+2
| | | | | | | | | | | | | | | ASCIIToUTF16. I removed string_util includes from a few places where it obviously wasn't needed. In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm going to do an even later pass to find the unnecessary string_util.h includes and remove them. TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3058027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98
* Convert more callers of the integer/string functions to usingbrettw@chromium.org2010-07-313-8/+15
| | | | | | | | | | string_number_conversions.h TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/3013046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54454 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bad license header under chrome/ directory.tfarina@chromium.org2010-07-311-28/+3
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/2847091 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54450 0039d316-1c4b-4281-b951-d872f2087c98
* Move the number conversions from string_util to a new file.brettw@chromium.org2010-07-303-11/+13
| | | | | | | | | | | | | Use the base namespace in the new file. Update callers. I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling. TEST=included unit tests BUG=none Review URL: http://codereview.chromium.org/3056029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove unneeded headers from app/thestig@chromium.org2010-07-292-3/+0
| | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/2819063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54102 0039d316-1c4b-4281-b951-d872f2087c98
* browser: Fix some presubmit errors.tfarina@chromium.org2010-07-281-4/+4
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3026031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54020 0039d316-1c4b-4281-b951-d872f2087c98
* Fix lines longer than 80 characters.tfarina@chromium.org2010-07-281-1/+2
| | | | | | | | | BUG=50266 TEST=None Review URL: http://codereview.chromium.org/3013038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53958 0039d316-1c4b-4281-b951-d872f2087c98
* `#pragma once` for app, base, chrome, gfx, ipc, net, skia, viewsthakis@chromium.org2010-07-2617-0/+17
| | | | | | | | | BUG=50273 TEST=everything still builds, build is 10% faster on windows, same speed on mac/linux TBR: erg git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53716 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: improve clipboard compatibility with firefox + evolution.estade@chromium.org2010-07-201-2/+5
| | | | | | | | | | BUG=48424 TEST=copying from the chrome bookmark manager into firefox should save the bookmark's title as well as url TEST=copying the address from the omnibox into evolution copies text, and doesn't create an attachment Review URL: http://codereview.chromium.org/3022004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52983 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes bug in pasting bookmarks from the context menu that could resultsky@chromium.org2010-07-011-1/+1
| | | | | | | | | | | in inserting into the wrong parent. BUG=40544 TEST=see bug Review URL: http://codereview.chromium.org/2856027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51408 0039d316-1c4b-4281-b951-d872f2087c98
* Make a new yes/no messagebox wrapper function, use it in the bookmark alert.avi@chromium.org2010-06-251-30/+6
| | | | | | | | | | | | | Recommitting of r46101. BUG=http://crbug.com/34481; http://crbug.com/40011 TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks, right click on one of those and click on Open all bookmarks. A confirmation dialog box should be shown. No other visible change. Review URL: http://codereview.chromium.org/1745024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50894 0039d316-1c4b-4281-b951-d872f2087c98
* Replace wstring with string16 in history. The only time wstring is used now ↵brettw@chromium.org2010-06-233-29/+41
| | | | | | | | | | | | in history is for bookmark-related stuff (the bookmarks system is still wstring-based). The substantial change here is in RTL to make a string16 variant of the functions and in changing the WordIterator to use string16 (this cleaned up some weird utf-32 code). TEST=none BUG=none Review URL: http://codereview.chromium.org/2808017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50597 0039d316-1c4b-4281-b951-d872f2087c98
* Split RecentlyUsedFolderComboModel into its own module, so we can share ittfarina@chromium.org2010-06-122-0/+114
| | | | | | | | | | | Views and Gtk. BUG=None TEST=manually Review URL: http://codereview.chromium.org/2673005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49633 0039d316-1c4b-4281-b951-d872f2087c98
* Cleanup: Remove some obsolete bookmark manager preferences.tfarina@chromium.org2010-06-042-17/+1
| | | | | | | | | BUG=None TEST=trybots Review URL: http://codereview.chromium.org/2631001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@48950 0039d316-1c4b-4281-b951-d872f2087c98
* Moved ImportantFileWriter to chrome/common in preparation of moving ↵sanjeevr@chromium.org2010-05-202-2/+3
| | | | | | | | | | | JsonPrefStore to chrome/common. BUG=None. TEST=Unit-tests moved and modified. Review URL: http://codereview.chromium.org/2128014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47818 0039d316-1c4b-4281-b951-d872f2087c98
* Implement drag from bookmark manager to bookmark bar or a folder thereof. ↵mrossetti@chromium.org2010-05-182-3/+10
| | | | | | | | | | | | | | | | | | | Implement drag of other bookmark and URL sources such as from the Desktop or a text selection. BUG=39884,44228 TEST=Note: For all drag operations verify that the appropriate drop indicator is presented while dragging. When dragging onto a bookmark bar folder the folder button should be highlighted and, after a short delay, open into a menu. When dragging between folders or on top of a non-folder bookmark an insertion bar (vertical when in the bookmark bar, horizontal when in a folder menu) should be presented. For 'copy' moves the drag image should be adorned with a plus sign in a green circle. A non-copy move should show no such tag. 1) Drag a non-folder bookmark from the bookmark manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the bookmark is moved to be on the bar just before the bookmark upon which is was dropped. 2) Drag a folder bookmark from the manager to the bookmark bar such that it falls on a non-folder bookmark. Verify that the folder (as a folder) is moved to be on the bar just before the bookmark upon which is was dropped. 3) Drag a bookmark from the manager to a folder on the bookmark bar. Verify that the bookmark is added to the folder at the end and removed from the old location in the manager. 4) Drag a bookmark from the manager to a folder on the bookmark bar and wait for the folder to open and then drag to within the folder. Verify that dropping places the bookmark and removes it from the old location in the manager. 5) Drag a bookmark from the bar to the manager and verify that the manager now shows the dragged bookmark. (Note that this should be a 'move' but is currently a 'copy'. See http://crbug.com/44039.) 6) Drag a bookmark clipping from the Finder Desktop to the bookmark bar. Verify that it is added to the bar as a new bookmark. 7) Drag a bookmark clipping from the Finder Desktop to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder as a new bookmark. 8) Create a URL in TextEdit or Stickies, select it and drag to the bookmark bar. Verify that it is added to the bar. 9) Create a URL in TextEdit or Stickies, select it and drag to a folder on the bookmark bar and drop it within the folder menu. Verify that it is added to the folder. Review URL: http://codereview.chromium.org/2066001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47523 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Null terminate text/html data we send to the clipboard. Change ↵thestig@chromium.org2010-05-171-3/+3
| | | | | | | | | | WriteHyperlink to take string16 anchor text. BUG=42624 TEST=none Review URL: http://codereview.chromium.org/2036013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@47432 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of some dead bookmark context menu code.viettrungluu@chromium.org2010-05-063-104/+38
| | | | | | | | | | | | | (Continuing fallout of native bookmark manager deletion.) More refactoring still to come. BUG=38908 TEST=bookmark bar context menu still works as before Review URL: http://codereview.chromium.org/1986003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46624 0039d316-1c4b-4281-b951-d872f2087c98
* Fix various uses of release() that did not check its valueestade@chromium.org2010-05-042-10/+8
| | | | | | | | | BUG=42904 TEST=compile, unit tests Review URL: http://codereview.chromium.org/1730024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46376 0039d316-1c4b-4281-b951-d872f2087c98
* Make PROFILE_DESTROYED notifications work with OTR profiles.mnissler@chromium.org2010-05-041-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/1848003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46335 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 46101 - Make a new yes/no messagebox wrapper function, use it in the ↵avi@chromium.org2010-04-301-4/+29
| | | | | | | | | | | | | | | | bookmark alert. BUG=http://crbug.com/34481; http://crbug.com/40011 TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks, right click on one of those and click on Open all bookmarks. An confirmation dialog box should be shown. No other visible change. Review URL: http://codereview.chromium.org/1687017 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/1783014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46108 0039d316-1c4b-4281-b951-d872f2087c98
* Make a new yes/no messagebox wrapper function, use it in the bookmark alert.avi@chromium.org2010-04-301-29/+4
| | | | | | | | | | | BUG=http://crbug.com/34481; http://crbug.com/40011 TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks, right click on one of those and click on Open all bookmarks. An confirmation dialog box should be shown. No other visible change. Review URL: http://codereview.chromium.org/1687017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@46101 0039d316-1c4b-4281-b951-d872f2087c98
* Add and implement cut/copy/paste to the bookmark bar and folder context ↵mrossetti@chromium.org2010-04-291-36/+11
| | | | | | | | | | | | | | | | | | | | | | | | | | | menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. Add test helpers for easing comparison of bookmark model changes. BUG=41217,36614,32064, 41404 Add and implement cut/copy/paste to the bookmark bar and folder context menus.Prevent dropping bookmark folders onto their children to avoid creating cycles and crashing. Keep folder menu windows open after a cut/copy/paste/delete and drop operation. TEST=1) Present the context menu for the bookmark bar in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 2) Present the context menu for a folder menu in various places and insure that the cut/copy/paste menu items are shown and properly enabled or disabled. 3) Perform cut/copy/paste/delete operations in a folder menu and subfolder menu and verify that the menu remains presented after the operation completes. 4) Drag a bookmark item from the bar to another location on the bar and verify that the button no longer shows up in the old location but does show up in the new location. 5) Drag a bookmark item from the bar to be within a folder located _after_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has shifted to the left so that it remains aligned with it corresponding bar folder indicator. 6) Drag a bookmark item from the bar to be within a folder located _before_ the item being dragged. Verify the bar no longer shows the bookmark item. Verify the folder does show the bookmark item. Verify that the folder window has _not_ shifted to the left and that it remains aligned with it corresponding bar folder indicator. 7) Drag a bookmark around within the same folder and verify that the folder window does not move. 8) Drag a bookmark item from a folder to the bar in a position _after_ the folder form which the item comes. The folder menu window should close. 9) Drag a bookmark item from a folder to a different folder and verify that the original folder closes and the new folder remains open. 10) Drag an item from a parent folder to a child folder and verify that both folders remain open. Verify that the subfolder remains aligned to its associated folder icon in the parent folder. 11) Drag an item from a child folder to a parent folder. Verify that the child folder closes and the parent folder remains open. 12) Try dragging a parent folder onto a child folder and verify that the drag is not allowed to complete. 13) Hover over a folder item in a folder menu window. Verify that the folder opens up a subview menu window. Now drag the original folder (the one being hovered over) and verify that its subfolder menu automatically closes. 14) Slowly shrink window width until "off the side" menu appears; make sure it appears as soon as the last button gets removed. Now slowly grow window and make sure it goes away at the right time. 15) Add enough bookmarks to the bookmark bar to nearly fill the width of the window. Verify that the off-the-side chevron is not showing. Slowly shrink the width of the window until the off-the-side-chevron appears. Verify that the right-most bookmark button has disappeared and does not draw over the top of the chevron. Continue to shrink the window and verify that bookmark buttons disappear. View the contents of the chevron and verify that the bookmark buttons which previously appeared on the bar now appear in the chevron. Slowly grow the window and verify that bookmark buttons reappear without drawing over the top of the chevron. Verify that those bookmark buttons no longer appear in the chevron when it is popped up. Continue growing the window until all bookmark buttons appear in the bar and the chevron disappears. 16) Shrink the window so that the off-the-side chevron appears and contains three or more bookmarks. Pop open the chevron. Drag bookmarks up and down in the chevron menu and verify that moves and copies are performed. Drag a bar bookmark into the chevron and verify that the chevron pops up and allows the drag. Verify that the bar and chevron contents rearrange such that buttons on the bar fill but do not overflow the bar. Drag a chevron bookmark out onto the bar. Once again verify that the bar and chevron buttons rearrange such that the bar is full but not overflowing. Review URL: http://codereview.chromium.org/1742003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45965 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BookmarkEditor::Handler entirely.viettrungluu@chromium.org2010-04-293-26/+9
| | | | | | | | | | | (Part of aftermath of eliminating the native bookmark managers.) BUG=38908 TEST=everything keeps working Review URL: http://codereview.chromium.org/1745021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45939 0039d316-1c4b-4281-b951-d872f2087c98
* Get rid of BookmarkEditor::Show()'s BookmarkEditor::Handler argument.viettrungluu@chromium.org2010-04-282-5/+3
| | | | | | | | | | | | Still to do: get rid of things which hang on to a handler just so they can pass it to Show(). BUG=38908 TEST=everything still works Review URL: http://codereview.chromium.org/1795007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45813 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: make tabbed bookmark manager compatible with more types of drops.estade@chromium.org2010-04-282-7/+23
| | | | | | | | | BUG=42466 TEST=see bug. Also, drags from firefox bookmark bar to tabbed bookmark manager should work. Review URL: http://codereview.chromium.org/1691018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45778 0039d316-1c4b-4281-b951-d872f2087c98
* Windows/Views: delete native bookmark manager code.viettrungluu@chromium.org2010-04-289-1495/+6
| | | | | | | | | | | | Context menu code still needs cleanup/refactoring. String resources still need to be deleted. BUG=38908 TEST=everything still works Review URL: http://codereview.chromium.org/1730015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45776 0039d316-1c4b-4281-b951-d872f2087c98
* Linux/GTK: delete native bookmark manager code.viettrungluu@chromium.org2010-04-263-14/+22
| | | | | | | | | | | Views code still to be deleted; some cleanup will take place then. BUG=38908 TEST=everything keeps working as before Review URL: http://codereview.chromium.org/1753009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45612 0039d316-1c4b-4281-b951-d872f2087c98
* Re-instate the temporary revert from r45267. That reverted certainshess@chromium.org2010-04-232-4/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Omnibox, toolbar, tab animations, and other UI changes for purposes of testing and merging into mstone-5. Additionally reverts these CLs to fix the earlier revert: r45271: [Mac] Image references missing from Omnibox revert. r45268: GTK fix merge failure in uber-revert. Additional revert which fixed a bug for the branch: r45381: [Mac] Omnibox popup icons and text lined up under toolbar. Slight merge conflict which should be good: r45322: GTK: Implement OnDragCanceled() for autocomplete... Also ++kThemePackVersion and regenerate the cached theme pak. Re-instated changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=People go back to complaining about missing http://. R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
* Temporarily revert certain Omnibox, toolbar, tab animations, and othershess@chromium.org2010-04-222-5/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | UI changes for purposes of testing and merging into mstone-5. Also ++kThemePackVersion and regenerate the cached theme pak. Reverted changes: r45213: GTK: Override cursor colors in chrome-theme mode. r45103: Support drawing nano tabs in the tabstrip. r45084: GTK: Position the EV certificate stuff inside a green bubble. r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon... r44957: GTK: Tint the geolocation icons in gtk mode. r44943: Changes FormatURL to not strip http if the host starts with ft... r44930: Remove an icon that is no longer used. r44929: SSL UI changes, Windows, code side (images are separate). r44859: SSL UI changes (icons). TBRed since trybots hate binary patches. r44822: GTK: Select better greens in the native omnibox popup. r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat... r44789: [Mac] Bookmark star missing on NTP and BMM. r44775: [Mac] Centralize hack to make tests work with AutocompleteClas... r44678: Display the SECURITY_WARNING status in the location bar for the r44648: [Mac] Add an arrow cursor rect for the location image. r44615: Revert r44611 because it may have broken "unit_tests" on "Vist... r44611: Display the SECURITY_WARNING status in the location bar for the r44577: Revert 44572 - [Mac] Update locationbar icon as user types. r44572: [Mac] Update location-bar icon as user types. r44555: GTK: Use correct button mask on reload button. r44545: [Mac] Omnibox text drag drag URL when select-all. r44523: GTK: Prevent inappropriate drag of location bar location icon. r44519: GTK: make the primary selection include the url's scheme when ... r44492: [Mac] Fix search icon in keyword search to be right-side-up. r44415: GTK: Update top padding on icons in the autocomplete popup. r44401: GTK: Tint omnibox icons in GTK mode differently. r44380: GTK: Move reload in gtk mode and fix omnibox popup location. r44282: Fixes crash in autocomplete when typing some URLs. The problem r44273: [Mac] PDF icons for omnibox nits. r44269: Fix build break due to bad merge resolve r44268: Shift omnibox dropdown in and up on Windows, and square off th... r44178: GTK: fix TTS padding. r44177: Round the top left and right edges of the toolbar. r44171: Images only checkin for try server goodness. r44163: GTK: fix padding of autocomplete popup. r44152: [Mac] PDF icons for omnibox. r44145: GTK: Theme the icons in the location bar and use GTK colors fo... r44140: Strips http from the omnibox r44131: Fixes bugs in new tab strip animations where they weren't doin... r44116: Change the default theme colors. r44117: Add newline to EOF to fix CrOS builder. r44115: Make the bottom edges of the opaque frame rounded. r44091: [Mac] No star icon or page actions in omnibox on popups. r44087: Don't allow drag or click on location icon when editing in omn... r44021: [GTK] Add TTS lens graphic to linux TTS box. r44008: [Mac] Tweak location icon spacing in omnibox. r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca... r43972: Make the firstrun bubble point at a better spot now that the l... r43971: [Mac] Location icon in omnibox as drag source. r43970: Make the star and page action icons not appear on popup windows. r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip: r43787: Allow location icon to be dragged & dropped. This also fixes ... r43759: Changes end cap of tab-to-search images. r43740: Change bookmark bar toggle to ctrl-shift-b. r43723: Show Page Info dialog on mouse up, not mouse down. r43677: Fix Mac build failure. r43676: Replace omnibox icons with new set that are all the same size ... r43596: Fix browser test TestStarButtonAccObj. r43593: Disables TestStarButtonAccObj. r43582: Changes tab strip to use BoundsAnimator for tab strip animatio... r43563: GTK: don't show reload button for popup/app windows. r43562: Star/reload shuffle, Windows version. r43540: [Mac] Magnifying glass in keyword-search bubble. r43482: Adds images needed for new tab animation. I'm separating this ... r43422: Add reload mask resource. r43392: GTK: make the location icon a drag source. r43376: [Mac] Move star button into page-actions area of omnibox. r43357: [Mac] Line up omnibox popup under field. r43290: gtk: fix display of icons in omnibox popup r43269: GTK: fix reload button. r43249: [Mac] Rearrange SSL status icon/label in omnibox. r43248: BrowserThemePack: Adds persistant ids for the reload endcaps. r43241: GTK: more location bar updates. r43191: Fix memory leak in BrowserThemePack. r43154: GTK: set the new star button's ID r43151: Fix bad conflict resolution for r43146. r43146: GTK: toolbar reload/star shuffle. r43025: Show the location bar icon (almost) all the time, and have its... r43023: Add new images for new reload button. No code change. r42782: Remove this icon, now that it's no longer used (due to my secu... r42502: Omnibox M5 work, part 1: Security changes r42245: Check in new icons for omnibox security changes alone, so that... BUG=none TEST=Eyjafjallajokull R=pkasting@chromium.org,beng@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/1649009/show from Thiago:sky@chromium.org2010-04-202-69/+6
| | | | | | | | | | | | | | Use BaseBookmarkModelObserver when all events funel into a single method. Using it, instead of BookmarkModelObserver, we can simplify the BookmarkContextMenuController. BUG=None TEST=everything should works as before. Review URL: http://codereview.chromium.org/1692001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45106 0039d316-1c4b-4281-b951-d872f2087c98
* Remove extra notification from BookmarkModel::Copy.skrul@chromium.org2010-04-161-3/+2
| | | | | | | | | | | | | This was causing duplicate bookmarks to be created in the sync database when a mac user uses option drag to duplicate a bookmark. I have not run this yet on a mac to make sure it works, but I am in progress of compiling on my macbook :) BUG=41398 TEST=unittest Review URL: http://codereview.chromium.org/1599035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44730 0039d316-1c4b-4281-b951-d872f2087c98
* Lands http://codereview.chromium.org/1600010/show for Thiago:sky@chromium.org2010-04-123-149/+176
| | | | | | | | | | | | Refactor EditFolderController into BookmarkFolderEditorController class. BUG=None TEST=Add and/or edit a bookmark folder. It should works as before. Review URL: http://codereview.chromium.org/1640007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44281 0039d316-1c4b-4281-b951-d872f2087c98
* Strips http from the omniboxsky@chromium.org2010-04-092-4/+5
| | | | | | | | BUG=none TEST=type in urls and make sure once loaded we don't show http. Make sure we do show https (and other schemes) though. Review URL: http://codereview.chromium.org/1513023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44140 0039d316-1c4b-4281-b951-d872f2087c98
* detect preferences errorserikkay@chromium.org2010-04-061-1/+1
| | | | | | | | | BUG=38352 TEST=none Review URL: http://codereview.chromium.org/1120006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43715 0039d316-1c4b-4281-b951-d872f2087c98
* Fix copying/dragging of empty folders in BMM on macfeldstein@chromium.org2010-04-021-0/+4
| | | | | | | | | | | | | The code was assuming there was at least one url. There is still a js error in the BMM on all platforms that I've run into a couple of times, but I want to check this in while I look into that. BUG=39229 TEST=Copy or drag an empty bookmarks folder Review URL: http://codereview.chromium.org/1456003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43510 0039d316-1c4b-4281-b951-d872f2087c98
* Remove bookmarks log message.dhollowa@chromium.org2010-04-021-2/+0
| | | | | | | | | BUG=NONE TEST=NONE Review URL: http://codereview.chromium.org/1524008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43421 0039d316-1c4b-4281-b951-d872f2087c98
* gtk: Show confirmation dialog while opening a lot of bookmarks.evan@chromium.org2010-03-311-1/+20
| | | | | | | | | | | | | BUG=34481, 35911 TEST=have at least 15 bookmarks on bookmarks bar or other bookmarks, right click on one of those and click on Open all bookmarks. An confirmation dialog box should be shown. Patch from Thiago Farina <thiago.farina@gmail.com> Review URL: http://codereview.chromium.org/1535001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43237 0039d316-1c4b-4281-b951-d872f2087c98
* Minor style fixes to bookmark_pasteboard_helper_mac.mm.viettrungluu@chromium.org2010-03-291-33/+38
| | | | | | | | | BUG=none TEST=the world keeps turning Review URL: http://codereview.chromium.org/1538001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42962 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the logic in extensions GetCurrentWindow:mpcomplete@chromium.org2010-03-261-1/+1
| | | | | | | | | | | | | | | - We try to find an associated window for the calling extension page. - If there is none (bg pages), fallback to the topmost browser window. - If the extension is enabled in incognito, include incognito windows in the search for "topmost". This fixes a bug where clicking a browser action in an incognito window might open a tab in a normal window, which is confusing. BUG=39113 Review URL: http://codereview.chromium.org/1422001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42848 0039d316-1c4b-4281-b951-d872f2087c98
* Makes adding a new folder from the bookmark context menu add thesky@chromium.org2010-03-254-27/+60
| | | | | | | | | | | | folder right after the selected item (when possible) rather than as the last element. BUG=9240 TEST=see bug Review URL: http://codereview.chromium.org/1253004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42628 0039d316-1c4b-4281-b951-d872f2087c98
* UMA cleanup. Replacing calls to RecordAction(char*) to use a new structure.evan@chromium.org2010-03-231-15/+28
| | | | | | | | | | | | That way it is easier to keep track of those constants in reporting tools. TEST=Covered with standard ui tests Patch by Frank Mantek <fmantek@google.com>. Review URL: http://codereview.chromium.org/811005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42362 0039d316-1c4b-4281-b951-d872f2087c98
* Move RTL related functions from app/l10n_util to base/i18n/rtlben@chromium.org2010-03-201-5/+6
| | | | | | | | | | TBR=darin BUG=none TEST=none Review URL: http://codereview.chromium.org/1073005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98
* GTK: implement extension bookmark manager drag api.estade@chromium.org2010-03-183-9/+32
| | | | | | | | | | | Also, cross-platform: eschew RenderViewHostDelegate:BookmarkDrag::DragData type in favor of BookmarkDragData. BUG=37702 TEST=manual Review URL: http://codereview.chromium.org/1029004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41959 0039d316-1c4b-4281-b951-d872f2087c98
* Move image codec stuff to toplevel gfx.ben@chromium.org2010-03-182-2/+2
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98
* Change so that the extension favicon is read on the UI thread since ↵arv@chromium.org2010-03-174-9/+9
| | | | | | | | | | | | | extension objects should only be accessed on the UI thread. This also fixes erg's todo to make favicons use RefCountedMemory instead of RefCountedBytes in all places. BUG=None TEST=None Review URL: http://codereview.chromium.org/1028001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41869 0039d316-1c4b-4281-b951-d872f2087c98
* Move some more files to toplevel gfx dir.ben@chromium.org2010-03-175-5/+5
| | | | | | | | | TBR=darin BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41812 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-12 10:49:38 +0000