| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Add a WindowDelegate::GetWindowAppIcon for BrowserView to expose an
icon to use as ICON_BIG;
- Add an app_icon_ memeber and accessor functions to TabContents;
- Update/Set the app_icon_ of TabContents when web app icon is
downloaded for converting a tab to app or for chrome web app shortcuts
update (this happens when chrome is opened as an app;
- Use the app icon as ICON_BIG in WindowWin::UpdateWindowIcon;
BUG=32039
TEST=Verify fix for issue 32039 and also Alt-Tab list on XP/Vista uses big icon.
Review URL: http://codereview.chromium.org/668265
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40962 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added Mac implementation of StatusIcon, and added a simple click callback that
displays the "extensions" tab when clicked on, to allow us to dogfood long-lived
extensions.
BUG=37375
Review URL: http://codereview.chromium.org/661454
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40847 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Adds ContentSettingImageModel to provide icon and tooltips for platform-specific ContentBlockedImageView.
(in preparation for:
http://codereview.chromium.org/650180/show
)
TEST=chrome/browser/content_setting_image_model_unittest.cc
Review URL: http://codereview.chromium.org/660279
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40732 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This fixes a regression appearing in revision 39455 by adding an additional NULL check.
TEST=Open Chromium, close all open windows, open bookmark manager, double click any bookmark. Chromium shouldn't crash.
BUG=37386
Review URL: http://codereview.chromium.org/669078
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40707 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Start with --enable-tabbed-bookmark-manager. This will show chrome://bookmarks in a tab instead of the old bookmark manager. However, to get the bookmark manager extension to show you need to use --load-extension=path_to_extension. The extension uses the chrome_url_override to show the extension instead of the bookmark manager.
BUG=4890
TEST=See description
Review URL: http://codereview.chromium.org/661019
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40468 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
window.
BUG=27365
TEST=none
Review URL: http://codereview.chromium.org/661187
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40386 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=Visit a page in a language other than the Chrome's language.
A translate infobar should be shown.
In the options/Under the Hood tab, unselect "Offer to translate
pages that aren't in a language I read". Navigate again to a
page in a non Chrome-UI language. No translate infobar should be
shown.
Review URL: http://codereview.chromium.org/661095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@40128 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
to further reduce bad dependencies on chrome/browser.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/652051
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39703 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now, to avoid "carpet bombing" (where a malicious site initiates multiple
downloads), opening an external URL is blocked after the first access until the
user somehow interacts with the page (for example by clicking somewhere).
This doesn't account for opening external links from bookmarks though.
This patch fixes that, by resetting the block state whenever an external URL is
opened by typing it or selecting it from bookmarks.
BUG=31021
TEST=Add a bookmark like mailto://user@hostname to the bookmarks bar and click on it
multiple times in a row (without clicking anywhere else on the page in
between). Depending on your settings, *every time* either a window should open
asking you if you want to open the URL with an external application or your
mail application itself should open.
Review URL: http://codereview.chromium.org/622002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39455 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Currently Linux-only, but the Mac/Win bits should now be trivial.
While I was add it, I tweaked a NavigationController function
that took a bare boolean into an enum to make the call sites more
explicit about what they're doing.
(In most places I added new functions that call into a shared
backing function; this is so I don't need to change every single
caller of e.g. Reload() to pass through an extra flag that will
be the same for almost every caller.)
BUG=1906
TEST=visit astronomy picture of the day; hit reload, picture pops
up quickly; hit shift-reload, picture loads slowly
Review URL: http://codereview.chromium.org/594063
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39430 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
to chrome/browser.
This is a part of an effort to remove bad dependency of chrome/common
on chrome/browser.
TEST=unit_tests and ui_tests, just moving code
BUG=none
Review URL: http://codereview.chromium.org/621004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=31638
TEST=Should be able to toggle fullscreen mode.
Review URL: http://codereview.chromium.org/567029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39144 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/593084
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
untitled tab/page. This will let us remove a couple of duplicate strings.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/604021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
pinning on views again as everything in place, except a couple of
bugs.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/598027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
They have served they purpose well, but now it's time to retire.
It's one of the things that draggen in the bad dependency of chrome/common
on chrome/browser, and is sufficiently small now to stub things out individually.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/593037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
the "show" function to work more like a number of our other dialogs (i.e. delcared in browser_dialogs.h), and adds a TabContentsDelegate function so the content blocked info bubbles can ask the appropriate window to show the dialog.
BUG=35084
TEST=Open the content settings dialog from either the options or a content blocked info bubble. Click its parent window. The dialog should stay on top of the parent.
Review URL: http://codereview.chromium.org/597009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38534 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Bug=chromiumos:1275
Test=There should be no "Create Application Shortcuts" menu item.
All others should be the same as Chrome, except that Print...
should be disabled. This is true for both the page menu and the
content area menu.
Review URL: http://codereview.chromium.org/596014
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38512 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
TEST=you can possibly break the tree, right?
BUG=none
Review URL: http://codereview.chromium.org/602002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38467 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=If it compiles it is perfect.
Review URL: http://codereview.chromium.org/585008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
a handful of things to resolve before I turn on pinning.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/579011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
does not have that infobar open but has another crashed extension's infobar hoses the browser. Phew.
BUG=34683
TEST=follow repro steps in bug. should not crash.
Review URL: http://codereview.chromium.org/572045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38285 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it. I'm now going with:
// . Mini-tab. Mini tabs are locked to the left side of the tab strip and
// rendered differently (small tabs with only a favicon). The model makes
// sure all mini-tabs are at the beginning of the tab strip. For example,
// if a non-mini tab is added it is forced to be with non-mini tabs. Requests
// to move tabs outside the range of the tab type are ignored. For example,
// a request to move a mini-tab after non-mini-tabs is ignored.
// You'll notice there is no explcit api for making a tab a mini-tab, rather
// there are two tab types that are implicitly mini-tabs:
// . App. Corresponds to an extension that wants an app tab. App tabs are
// identified by TabContents::is_app().
// . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed.
// Non-app tabs whose pinned state is changed are moved to be with other
// mini-tabs or non-mini tabs.
I'm going with a more neutral name like mini-tabs so that we can
change the meaning if we need to without changing around all the UI
code. I'll convert the UI code next.
BUG=32845
TEST=none
Review URL: http://codereview.chromium.org/570043
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38237 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This cl displays the filebrowse ui rather than download shelf for
downloads in chrom(e|ium) os. It conditionally replaces (with
preprocessor macros) the Browser::OnStartDownload method to do this.
The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument),
which opens the file browse ui and passes it the provided hash argument.
This is invoked directly from Browser::OnStartDownload. The
USBMountObserver code was changed to call this static method, rather
than open the popup by hand as it had been doing.
I'm not sure about ownership of the Browser* returned by OpenPopup, but
based on other code in the tree I assume chrome will deal with freeing
it when appropriate.
Before this change, USBMountObserver would add the window to registrar_
*before* showing it. Now that FileBrowseUI::OpenPopup returns a which
which is already visible, this is no longer the case. I assume this
won't be a problem.
Commit this for rginda.
Original review: http://codereview.chromium.org/555167
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/564022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Turn on the side tabstrip by default when --enable-vertical-tabs is specified, for ease of testing/debugging.
Adjust glass rendering in this mode.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/570029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38160 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BrowserView/etc and the specific active TabStrip implementation in use.
This simplifies things a lot. I don't need separate view IDs etc.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/571002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38110 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In this first step we
1) Create a new Browser::Type::TYPE_APP_PANEL which is observed in various places
2) Create an AppPanelBrowserFrame which is created in BrowserFrameWin when the TYPE_APP_PANEL is observed. AppPanelBrowserFrame draws itself per glen's mocks and will ultimately behave substantially different from regular browser windows.
3) Create a temporary command switch called --app-launch-as-panel which can be used until we implement actual app launching.
Note that there is still work to be done "bit-twiddling" to match glen's mocks and to implement the "inactive" look for these windows.
Steps 2 through N may include: different sizing behavior (based either on the content size or an api call), different min/maximize behavior, docking to the os taskbar, auto order & placement of app panels.
A screen capture of the current implementation is attached to the bug.
BUG=32361
Review URL: http://codereview.chromium.org/553143
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38107 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The option to enable the vertical tabstrip will appear when Chrome is run with:
--enable-vertical-tabs
and a pref is set. There is presently no UI to set this pref.
http://crbug.com/34509
TEST=none
Review URL: http://codereview.chromium.org/561004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38076 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
used or supported.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/566035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38034 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/560024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37936 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/564012
TBR=jochen@chromium.org
Review URL: http://codereview.chromium.org/564023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37915 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32719
TEST=none
Review URL: http://codereview.chromium.org/564012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37913 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
places where I left them using the variable with pinned when it should
be app because those places need to be radically whacked. I'll do that
next.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/555173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
whitelist.
Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it.
This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that.
There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what.
BUG=33314
TEST=Go visit some sites with popups and play with things
Review URL: http://codereview.chromium.org/562013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Also, do a better job of making sure we don't write useless default values to disk, and we force the in-memory copy of the default prefs to never say "DEFAULT" even if a caller provides that to SetDefaultContentSetting().
BUG=32719
TEST=unittests
Review URL: http://codereview.chromium.org/562003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37775 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
I renamed the method name in preparation of using this for opening the bookmark manager extension.
BUG=None
TEST=Open History. Do a search and open history again. We should not create a new tab but go to the existing one.
Review URL: http://codereview.chromium.org/553151
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37651 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Changes:
1- net::CookiePolicy becomes an interface.
2- Old implementaiton of CookiePolicy copied to StaticCookiePolicy.
3- ChromeULRRequestContext implements CookiePolicy.
4- HostContentSettingsMap gets a global "BlockThirdPartyCookies" pref.
R=pkasting
Review URL: http://codereview.chromium.org/556095
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37624 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
info bar telling the user that the extension has crashed should disappear in ALL windows should the user choose to hit the 'reload' button.
NOTE: If the user 'x's out the info bar, the bars in the other windows will remain.
BUG=33396
TEST=none
Review URL: http://codereview.chromium.org/548206
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37570 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
There was no LGTM, and there was still open discussion in the code review. See
http://codereview.chromium.org/554119. This was not ready to land.
TBR=pkasting
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553154
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37556 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=32782
TEST=none
Review URL: http://codereview.chromium.org/554119
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37535 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
all ToolbarModel methods const.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/556064
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37450 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=Cut/Copy/Paste items in page menu should work in both omnibox and web content.
Review URL: http://codereview.chromium.org/556016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37231 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
ChromeFrame. This was because
the ExternalTabContainer would close the underlying tab contents in its OnDestroy handler without invoking
unload handlers on the page if any. In Chrome the TabStripModel invokes the RunUnloadListenerBeforeClosing
on the delegate which is implemented by the browser. We need to mimic this in the external tab container.
To achieve this we now have a static helper function RunUnloadListenerBeforeClosingHelper in the browser
class which is called by the ExternalTabContainer and the Browser::RunUnloadListenerBeforeClosing function.
The ExternalTabContainer also needs to wait for the unload handlers on the page to return before it returns
control back to the host browser. To achieve this we enter a nested modal loop which is exited when the
underlying tab is closed.
Fixes bug http://code.google.com/p/chromium/issues/detail?id=31853
Bug=31853
Test=Covered by ChromeFrame unit test.
Review URL: http://codereview.chromium.org/543183
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37197 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This cleans up the interface for BrowserCreateForApp() which now longer takes a final argument of is_popup. The code has changed so that it is no caller is ever passing in true, so the code has been simplified.
BUG=5739
TEST=Ensure steps in bug report still no longer produce the bug.
Review URL: http://codereview.chromium.org/556024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37163 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/548152
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37155 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=18030
TEST=The Cut, Copy and Paste commands in page menu should work in both web content and location bar.
Review URL: http://codereview.chromium.org/552125
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36989 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* defined UIStyle enum
* fixed #if for compact navbar so that it's enabled only on chromeos
* Moved view initialization and layouts code from NormalExtender to chromeosBrowserView and ChromeosBrowsrViewLayoutManager respectively.
* Removed unnecessary extender code from BrowserView.
* no functional change
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/553059
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
it is closed, and effectively unloads the renderer and replaces it
with a new TabContents that loads when selected. A phantom tab is
currently rendered without a border. Phantom tabs do not prevent a
window from closing.
Long term only pinned app tabs will have the ability to be made
phantom, but this allows us to test the feature until app support is
all wired in.
BUG=32845
TEST=none yet
Review URL: http://codereview.chromium.org/553008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
direction for
the clear browsing data dialog.
TEST=none
BUG=none
Review URL: http://codereview.chromium.org/542126
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=32559
TEST=menu item should be disabled on mac, enabled on win/linux
Review URL: http://codereview.chromium.org/552070
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36695 0039d316-1c4b-4281-b951-d872f2087c98
|