| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3454028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60325 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:6591
TEST=manual: exter full screen, hit search key (left win key on desktop). it should exit full screen and show new tab page.
Review URL: http://codereview.chromium.org/3483007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60321 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=56598
TEST=none
Review URL: http://codereview.chromium.org/3419016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60318 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
showing and you pressed control-w.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3453016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60191 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3417011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=56152
TEST=out/Debug/chrome --enable-tabbed-options. Navigate to the Settings page,
it should works as before.
Review URL: http://codereview.chromium.org/3461010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60135 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3425009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes browser.h not depend on extension.h.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3399008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes MatchPreview owned by Browser rather than each TabContents.
. Makes MatchPreview dismiss when the omnibox closes.
. Supports the ability to send script to the page rather than
reloading on every keystroke.
. Supports receiving results from the page that drives the suggest
text in the omnbox.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3332022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54903
TEST=block cookies, go to almost any site, click little cookie in omnibox, manage cookies
Review URL: http://codereview.chromium.org/3323021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks.
To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage.
Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely.
BUG=52393
TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug.
Review URL: http://codereview.chromium.org/3325012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=54147
TEST=Verify that 'Clear Browsing Data' and 'Import' menu commands invoke the dom-ui options window.
Review URL: http://codereview.chromium.org/3319016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59294 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
On Chromium OS, instead of letting the browser exit directly, we want to
allow another process to trigger and watch shutdown, because otherwise we
have no way of dealing with chrome hanging on exit.
BUG=chromium-os:5395
TEST=Install chrome on a device, log in and log out. Look at /var/log/session_manager to determine that it triggered the browser exit.
Review URL: http://codereview.chromium.org/3112012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58757 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Use string16 instead.
BUG=23581
Review URL: http://codereview.chromium.org/3200010
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58545 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means browser.h no longer includes a large chunk of the tab restore
system. Now with fixes to chromeos.
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3296003
Review URL: http://codereview.chromium.org/3358005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to
chromeos compile fail.
TBR=akalin
Review URL: http://codereview.chromium.org/3340007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means browser.h no longer includes a large chunk of the tab restore
system.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3296003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53585
TEST=Open multiple tabs to a chrome-extension URL, then disable that extension. Tabs should close. See bug for details.
Review URL: http://codereview.chromium.org/3274012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58238 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
as launch event
BUG=44911
TEST=
Review URL: http://codereview.chromium.org/3358001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by Hajime Morita <morrita@google.com>.
Original review URL: http://codereview.chromium.org/3217007
BUG=23547
TEST=manual
Review URL: http://codereview.chromium.org/3225009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
It should not replace it. This patch modifications to the GTK and Cocoa ports to make the update chrome item appear when an update is available. On win/chromeos, the menu item is always there but disabled, since I'm having some problems figuring out the views custom menu implementation.
BUG=46221
TEST=The upgrade item should now appear under instead of replacing the about command.
Review URL: http://codereview.chromium.org/3143046
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58040 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Things done in this patch:
1. RemotingSetupMessageHandler is not leaked.
2. Logic of showing different pages is now in RemotingSetupFlow.
3. Better lifetime for RemotingSetupFlow.
4. RemotingSetupFlow doesn't need to be refcounted, instead we have a helper
class that we can detach when the dialog is closed.
BUG=52888
TEST=Run with --enable-remoting and start the remoting setup dialog
Review URL: http://codereview.chromium.org/3106036
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58037 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- On by default for apps, off by default for extensions.
- Split mode means "run incognito extensions in a separate process if the user
says OK, and the two processes can only see their own profile."
- Spanning mode is what we have now, and means "run a single extension process,
but allow it to access both profiles if the user says OK."
BUG=49232
BUG=49114
TEST=extensions still work in incognito when you check "Allow in Incognito".
Review URL: http://codereview.chromium.org/3210007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
string16 verison).
Still to do: Actually convert the code underlying FormatUrl().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3263005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57968 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3280008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57922 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=42447
TEST=Load an extension with app.launch.fullscreen, saw that it had no effect.
Review URL: http://codereview.chromium.org/3275003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57855 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This is the type of bubble now used in organic installs, i.e. all Linux installs.
BUG=49705
TEST=run with --first-run
Review URL: http://codereview.chromium.org/3203013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the HistoryAddPageArgs so that they can be cached and used later
on. Refactors some other code that interacts with history so that it
can be called separately as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3158029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Theory: pinned tabs are actually pretty ok, once the url
schenanigans are disabled and they don't have big ugly icons,
especially if we were to add something to the right-click menu
of the apps in the launcher like 'launch in a normal tab'.
Review URL: http://codereview.chromium.org/3152040
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57146 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Making window.focus()/blur() work only when there is a user gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
TBR=darin,sky
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3174030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Save the information that the setup of remoting has completed.
After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.
Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.
BUG=50244, 50242, 50243, 50249
Review URL: http://codereview.chromium.org/3153029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57120 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3201008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3191007
Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.
BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.
Review URL: http://codereview.chromium.org/3156035
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57033 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3061044
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57019 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.
Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.
In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.
BUG=52680
Review URL: http://codereview.chromium.org/3161037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes have already been removed.
Review URL: http://codereview.chromium.org/3149029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
- convert GetURLAndTitleToBookmark() and GetURLsForOpenTabs()
- convert BookmarkEditor::EditDetails
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3176024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switch and display the new DOM UI when it's used.
BUG=chromium-os:5522
TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings)
Review URL: http://codereview.chromium.org/3142020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
worked correctly.
I think there might still be a place for this, but it is in
Browser::AdjustWindowOpenDispositionForTab(), which is a much more
constrained use case, and also isn't working correctly, because
it lacks knowledge of apps.
BUG=52442
Review URL: http://codereview.chromium.org/3199004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56752 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Broke compile.
TBR=rkc
Review URL: http://codereview.chromium.org/3199006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56717 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51084
TEST=Run interactive_ui_tests and browser_tests.
New:
- sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en);
- Sidebar panel in Chrome browser view;
Original review=http://codereview.chromium.org/2836040/show
Patch by alekseys@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
TEST=Backend: Various reports submitted from Chrome OS and Windows builds
sent to the feedback test server. For Chromium OS, sent reports
with current screenshot and saved screenshots; verified all reports
for data accuracy and completion.
Frontend: Tested the UI features by excersizing various options; tested
not selecting any issue, tested switching between screenshot types.
Review URL: http://codereview.chromium.org/3181027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56708 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
| |
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56676 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Original CL: http://codereview.chromium.org/3122014
Initial change that allows to disable bookmarks in Chrome for Chrome OS
(BWSI mode). Added disable-bookmarks flag and disabled some UI elements.
BUG=chromium-os:4302
TEST=Run Chrome build for Chrome OS with --disable-bookmarks flag and
verify that the corresponding UI is disabled. Verify that BWSI mode runs
with this flag.
Review URL: http://codereview.chromium.org/3191007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start/stop service process when browser starts and stop
Save the information that the setup of remoting has completed.
After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.
Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.
Review URL: http://codereview.chromium.org/3185015
TBR=hclam@chromium.org
Review URL: http://codereview.chromium.org/3107024
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56610 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Save the information that the setup of remoting has completed.
After setup has been completed we start and stop service process when
--enable-remoting presents when browser starts.
Also save the information in the service process that host is registered
and ready to be used. Again start chromoting host automatically once
the host registration is done.
Review URL: http://codereview.chromium.org/3185015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56600 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Start by removing wstring versions of BookmarkModel::AddURLWithCreationTime()
and BookmarkModel::SetURLStarred().
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3111012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56488 0039d316-1c4b-4281-b951-d872f2087c98
|