summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.cc
Commit message (Collapse)AuthorAgeFilesLines
* DevToolsManager is a service in the browser process that manages all open ↵yurys@google.com2009-03-161-1/+2
| | | | | | | | | | | developer tools windows. It's supposed to route devtoools messages. Also it will notify DevToolsClient when inspected renderer crashes or when it's changes due to cross-site navigation. Currently when inspected tab is closed it will close devtools window as well. Devtools state moved from RenderViewHost and WebContentsView to the manager. Please look at devtools_manager.{h,cc} in the first place. Review URL: http://codereview.chromium.org/42076 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11727 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1), 2nd attempt.finnur@chromium.org2009-03-131-0/+3
| | | | | | | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/46055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11672 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 11640.finnur@chromium.org2009-03-131-3/+0
| | | | | | Reverting for now. Will try again later git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11645 0039d316-1c4b-4281-b951-d872f2087c98
* RSS feed support (part 1)finnur@chromium.org2009-03-131-0/+3
| | | | | | | | | | | | | | | | Part 1 is RSS feed auto-discovery. This will parse the web page header to find the feeds in the document and notify the browser to display the RSS icon in the toolbar. You can click on the icon, but it will just navigate to the first feed on the page, which (unless it has been designed to be browser friendly) will just dump XML as text on the user. For this reason I have disabled the code that makes the RSS icon appear and intend to enable it when we have a good landing page to display the XML. Review URL: http://codereview.chromium.org/43109 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11640 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the storing/restoring of the focus from TabContents to ↵jcampan@chromium.org2009-03-121-3/+3
| | | | | | | | | | | | WebContentsView. This makes TabContents less dependent on views. This requires few contortions with DOMUIs (NTP, history and downloads tab) as they still need to set the initial focus specifically. BUG=None TEST=Run the interactive tests. Review URL: http://codereview.chromium.org/39269 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11501 0039d316-1c4b-4281-b951-d872f2087c98
* First cut at the find bar.tc@google.com2009-03-101-4/+2
| | | | | | | | | | | | | Ctrl+F will display a box (pushing down the web contents) that typing into will cause webkit to highlight on the page. Esc will dismiss the box. I also changed the gtk_widget_show_all in browser window to be a regular gtk_widget_show. Child widgets need to manually show themselves now. Review URL: http://codereview.chromium.org/42026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11364 0039d316-1c4b-4281-b951-d872f2087c98
* If the flag is specified developer tools window will be opened instead of ↵yurys@google.com2009-03-101-6/+12
| | | | | | | | Console Debugger when user clicks Debug JavaScript. This is a temporary solution and we will get rid of this flag as well as of debugger console when developer tools implement all their functionality. Review URL: http://codereview.chromium.org/39259 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11321 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes session restore bug where we wouldn't necessarily correctlysky@google.com2009-03-091-3/+10
| | | | | | | | | | | | | | | restore the maximized state. The problem was we were using a boolean when we really needed three values: use the default, explicitly maximized or explicitly normal. I'm also removing a bogus DLOG in info_bubble. BUG=7930 TEST=see bug Review URL: http://codereview.chromium.org/40306 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11287 0039d316-1c4b-4281-b951-d872f2087c98
* hook up history and download menu itemstc@google.com2009-03-091-8/+12
| | | | | | | | | | Small fix to get them to display (need to include webkit strings in our language pak files). Review URL: http://codereview.chromium.org/39296 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11286 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes issue 8435 (http://code.google.com/p/chromium/issues/detail?id=8435)munjal@chromium.org2009-03-091-0/+3
| | | | | | Review URL: http://codereview.chromium.org/39303 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11274 0039d316-1c4b-4281-b951-d872f2087c98
* Make both Hebrew Visual (ISO-8859-8) and Hebrew Logical (ISO-8859-8-I)jungshik@google.com2009-03-071-0/+2
| | | | | | | | | | | | available in the encoding menu. Make windows-1255 come before ISO-8859-8* both in the full encoding list and in Hebew Chrome's static list. BUG=2927 Review URL: http://codereview.chromium.org/39248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11180 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the character encoding menu, zoom menu, and the help menu item.tc@google.com2009-03-061-4/+12
| | | | | | | | | | The character encoding menu is still broken in that it doesn't load the encoding names (sub-menu items), but auto detect might work. Review URL: http://codereview.chromium.org/39286 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11174 0039d316-1c4b-4281-b951-d872f2087c98
* Take two at hooking up title bar on linux.tc@google.com2009-03-041-23/+18
| | | | | | | | | | | | The only change from before is moving a method from a windows #ifdef section to outside it. TBR=evan Review URL: http://codereview.chromium.org/39158 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10937 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Hook up the app title to the page title."tc@google.com2009-03-041-3/+8
| | | | | | | | | This reverts commit 10923. Review URL: http://codereview.chromium.org/40130 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10924 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the app title to the page title.tc@google.com2009-03-041-8/+3
| | | | | | | Review URL: http://codereview.chromium.org/39114 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10923 0039d316-1c4b-4281-b951-d872f2087c98
* Take 2 at moving SupportsWindowFeature from BrowserViewtc@google.com2009-03-041-0/+15
| | | | | | | | | | | | | | | | | | to Browser. Turns out the test regression was actually caused by r10806 which removed an anonymous namespace causing the TestView class to collide with the same class in render_widget_host_unittest.cc. For now, fix by adding the TestView in the view unittest to the anon namespace. shess is going to try to re-add the namespace to render_widget_host_unittest.cc too. TBR=pkasting Review URL: http://codereview.chromium.org/40058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10873 0039d316-1c4b-4281-b951-d872f2087c98
* Convert NavigationEntry title to string16. TabContents::GetTitle no longer needsbrettw@chromium.org2009-03-041-2/+2
| | | | | | | | | | | | | | | to be virtual, either. This also changes how the display URL is computed. Instead of doing it preemptively, we now do so lazily. This allows us to do the URL formatting correctly using the elider so that we can do IDN and unescaping. I changed string_util's singleton functions. I was worried that other code might make a singleton of string, which would give you this same value as a non-const string. This would mean our empty strings might no longer be empty. Review URL: http://codereview.chromium.org/39022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10872 0039d316-1c4b-4281-b951-d872f2087c98
* Remove an include of a header that was removed in r10832.jhawkins@chromium.org2009-03-031-1/+0
| | | | | | | TBR=ben Review URL: http://codereview.chromium.org/39069 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10835 0039d316-1c4b-4281-b951-d872f2087c98
* Revert "Use grit to generate locale rc files and remove the old locale rc ↵tc@google.com2009-03-031-15/+0
| | | | | | | | | | | files from the tree." Revert "window_ is null during BrowserWindow creation. Assume full screen" Revert "Move SupportsWindowFeature from BrowserView to Browser so" git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10814 0039d316-1c4b-4281-b951-d872f2087c98
* window_ is null during BrowserWindow creation. Assume full screentc@google.com2009-03-031-1/+1
| | | | | | | | | | is false. TBR=pkasting Review URL: http://codereview.chromium.org/39023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10805 0039d316-1c4b-4281-b951-d872f2087c98
* Move SupportsWindowFeature from BrowserView to Browser sotc@google.com2009-03-031-0/+15
| | | | | | | | | | | we can share the code on all platforms. I still left a SupportsWindowFeature method in BrowserView that handles fullscreen mode which is (for now) a Windows specific feature. Review URL: http://codereview.chromium.org/27372 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10804 0039d316-1c4b-4281-b951-d872f2087c98
* Fixes regression where escape was not removing a newly bookmarkedsky@google.com2009-03-031-1/+2
| | | | | | | | | | | | | | page. BUG=none TEST=press the star button on a page you haven't bookmarked. The star should light up. Press escape, the bubble should close and the bookmark should be removed. Repeat with an existing bookmark and make sure pressing escape doesn't remove the bookmark. Review URL: http://codereview.chromium.org/40019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10803 0039d316-1c4b-4281-b951-d872f2087c98
* Remove more ifdefs where all platforms now share the implementation.pinkerton@chromium.org2009-03-031-4/+1
| | | | | | Review URL: http://codereview.chromium.org/39017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10797 0039d316-1c4b-4281-b951-d872f2087c98
* Make history and downloads open once per window unless the user modifies ↵glen@chromium.org2009-03-031-13/+5
| | | | | | | | | | | | their view. Also fix the back dropdown so that it opens the DOMUI version of History rather than the NativeUI version. BUG=8086,8297 Review URL: http://codereview.chromium.org/39002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10782 0039d316-1c4b-4281-b951-d872f2087c98
* Make it so that dropdown selects don't deactivate the main frame when opened ↵ben@chromium.org2009-03-031-0/+3
| | | | | | http://crbug.com/8247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10777 0039d316-1c4b-4281-b951-d872f2087c98
* Does two changes to appease chrome bot runs:sky@google.com2009-02-281-1/+5
| | | | | | | | | | | | | | | | | . Changes InfoBubble to properly initialize all fields in member initializer list and set the delegate before show on the off chance the bubble is deleted from show. This should no longer happen after the second change. . Only show the bookmark bubble if the browser window is active. I experimented with conditionally enabling the star and this turns out to be a bit error prone. BUG=none TEST=none Review URL: http://codereview.chromium.org/31016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10659 0039d316-1c4b-4281-b951-d872f2087c98
* When we open a popup window from an app window, we used to identify this ↵mad@chromium.org2009-02-271-15/+15
| | | | | | | | | | | | popup window as an app too. To not lose this functionality, yet fix bug 5739 about those app popup windows which would persist their window placement, I decided to add a new enum browser type item which is a bit combination of both popup and app so we can track those. bug= http://crbug.com/5739 Review URL: http://codereview.chromium.org/28271 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10636 0039d316-1c4b-4281-b951-d872f2087c98
* Back out r10487 toomark@chromium.org2009-02-261-2/+1
| | | | | | Review URL: http://codereview.chromium.org/28209 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10506 0039d316-1c4b-4281-b951-d872f2087c98
* This CL addresses several issues with focus in application mode:jcampan@chromium.org2009-02-261-0/+3
| | | | | | | | | | | | | - when started, the focus was not on the page (it was on the location bar, which is not shown) - ALT-F4 would not work at that point since the location bar was focused but not showing - since the location bar was focusable, tabbing through would focus it (causing the focus to go to the top window). BUG=8124,6046,8126 TEST=See bugs. R=sky Review URL: http://codereview.chromium.org/28202 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10504 0039d316-1c4b-4281-b951-d872f2087c98
* More URL constants replacement.brettw@chromium.org2009-02-261-1/+2
| | | | | | Review URL: http://codereview.chromium.org/28170 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10487 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: add splash screenagl@chromium.org2009-02-261-0/+3
| | | | | | | | In preparation for an internal launch, this adds a splash screen as the startup URL for Linux which has a few FAQs. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10442 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: fixes for tab contents switchingagl@chromium.org2009-02-261-0/+4
| | | | | | | | Previously, removing a view_ from its container destroyed it. We fix this by disabling GTK's auto reference stealing. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10440 0039d316-1c4b-4281-b951-d872f2087c98
* Hide profiles behind a command-line switch since the user-data-dir stuffmunjal@chromium.org2009-02-261-0/+6
| | | | | | | | | | wouldn't work on Mac. See bug http://code.google.com/p/chromium/issues/detail?id=7987 Review URL: http://codereview.chromium.org/28093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10432 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the ToolbarModel on Mac and Linux. Implement ChromeFont on Mac.pinkerton@chromium.org2009-02-251-1/+1
| | | | | | Review URL: http://codereview.chromium.org/28124 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10368 0039d316-1c4b-4281-b951-d872f2087c98
* Delete the ViewSourceTabContents.brettw@chromium.org2009-02-251-2/+4
| | | | | | | | | | | | | This removes all the tab contents type stuff for view source mode. The RenderViewHostManager now automatically switches RenderViews when we turn view source mode on or off to get the desired effect. I also moved some instances of hardcoded schemes into chrome_constants.h, and renamed RendererCreated/Ready/Gone to RenderViewCreated/Ready/Gone to reflect what they actually mean. Review URL: http://codereview.chromium.org/28089 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10346 0039d316-1c4b-4281-b951-d872f2087c98
* Enable history and downloads by default, port NewTabUI from DOMUIHost to DOMUI.glen@chromium.org2009-02-251-8/+12
| | | | | | | NewTabUI is only included on OS(WIN) because DOMUI doesn't appear to have been ported. Review URL: http://codereview.chromium.org/28104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10344 0039d316-1c4b-4281-b951-d872f2087c98
* Allow JS Debugger shortcut to work in fullscreen mode, since there's no ↵pkasting@chromium.org2009-02-251-5/+7
| | | | | | | | | reason not to. BUG=8023 Review URL: http://codereview.chromium.org/27110 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10338 0039d316-1c4b-4281-b951-d872f2087c98
* Get save page working on posix.estade@chromium.org2009-02-251-6/+6
| | | | | | | | | | * rearrange some IFDEFs * trim whitespace on suggest name Also fix a relatively new bug in DomSerializer. Review URL: http://codereview.chromium.org/27106 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10314 0039d316-1c4b-4281-b951-d872f2087c98
* The find bar should be owned and managed from the BrowserView, not the ↵finnur@google.com2009-02-241-34/+10
| | | | | | | | | | | | | | | | | | | | | | | | WebContentsView, since it's part of the "chrome". Design Doc: http://dev.chromium.org/developers/design-documents/find-bar Things done: - Pulled all of the find bar stuff out of WebContentsView* since it's no longer needed. - Moved OnFindReply delegate method from RenderViewHostDelegate::View to RenderViewHostDelegate, since it's no longer implemented on the view. - Moved find control methods to WebContents. - Added recent find result state to WebContents. - Updated the UI tests to accommodate the changes in the state that is broadcast when results are discovered. - Updated the find bar layout to obtain its bounding box from the BrowserView, which knows about toolbars, bookmark bars etc. - Updated the find bar itself to handle the fact that it can be displayed for multiple different tabs. - Moved the find bar manipulation methods for testing from TabProxy to BrowserProxy, since the find bar is now a feature of the window, not the tab. - view.h: Don't lay out child views again if they have a layout manager, it already updated them. TEST=Find box should work as before. BUG=3245 Review URL: http://codereview.chromium.org/27025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10231 0039d316-1c4b-4281-b951-d872f2087c98
* Super-simplistic status bubble on Linux.evan@chromium.org2009-02-191-1/+4
| | | | | | | | (I just want to see when pages are loading, y'know...) Review URL: http://codereview.chromium.org/21500 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10004 0039d316-1c4b-4281-b951-d872f2087c98
* Fix two problems with bookmarking and fullscreen mode:pkasting@chromium.org2009-02-181-3/+2
| | | | | | | | | | | * The bubble didn't close when toggling in/out of fullscreen mode. This was because we only ever closed on an activation change, rather than on a window move. Made the bubble close when the window moves. This required refactoring the bubble code to have a static instance; once I did that I also cleaned up the rest of the code a bit to not check if the bubble was already showing, and just let the bookmark bubble itself take care of this. * The bubble positioning was wrong in fullscreen mode. This was because the toolbar layout was in turn wrong in fullscreen mode. Made the toolbars able to handle being 0-height. BUG=534 TEST=Bookmark a page and hit F11. The bubble should disappear. Hit ctrl-D. The bubble should appear at the right spot, not floating in the middle of the screen. Hit F11 again. The bubble should disappear, and the toolbar button should be drawn undepressed. Review URL: http://codereview.chromium.org/21479 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9982 0039d316-1c4b-4281-b951-d872f2087c98
* Make interstitial_page.cc compile on Posix.jhawkins@chromium.org2009-02-181-1/+1
| | | | | | Review URL: http://codereview.chromium.org/21467 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9971 0039d316-1c4b-4281-b951-d872f2087c98
* Add locale_settings.grd to the build. This generatestc@google.com2009-02-181-4/+3
| | | | | | | | | | | | a locale_settings.h file that we use on all platforms. However, the rc generation isn't correct yet, so for now, use the existing locale_settings_*.rc files. Also go ahead and generate the en-US locale pak on linux. Review URL: http://codereview.chromium.org/20447 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9956 0039d316-1c4b-4281-b951-d872f2087c98
* Preliminary fullscreen mode support.pkasting@chromium.org2009-02-181-28/+45
| | | | | | | | | There is no UI for this (yet), just F11 to toggle in and out. BUG=534 Review URL: http://codereview.chromium.org/20423 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9950 0039d316-1c4b-4281-b951-d872f2087c98
* Take out common functionality from PluginProcessHost and move it to ↵jam@chromium.org2009-02-181-5/+3
| | | | | | | | ChildProcessHost. Review URL: http://codereview.chromium.org/21443 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9935 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContentsDelegate from scaffolding. Remove a large chunk of ifdef'd ↵pinkerton@chromium.org2009-02-171-18/+13
| | | | | | | | code from browser.cc to go along with it as well as enabling more functionality. Review URL: http://codereview.chromium.org/21424 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9908 0039d316-1c4b-4281-b951-d872f2087c98
* Unstub some more of the Browser object, including the part that sets it as ↵pinkerton@chromium.org2009-02-171-1/+8
| | | | | | | | the delegate of the TabContents object. That allows page-load notifications to make their way through the browser UI layer. Hook up notification to Mac tab strip to set the title as it's changed. Review URL: http://codereview.chromium.org/20429 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9892 0039d316-1c4b-4281-b951-d872f2087c98
* When internal functions try to focus the location bar, check whether it's ↵pkasting@chromium.org2009-02-171-4/+8
| | | | | | | | | focusable, and clear the focus if it's not. This shouldn't kick in in any cases today (I don't think), but it will matter in fullscreen mode, where creating a new tab should not attempt to focus the (unfocusable) location bar, but should not do nothing either, since these leaves focus in a hosed state. There are other choices here. I could make View::RequestFocus() try and clear the focus if the view is not focusable. That seems likely to cause side-effects unless I restore a lot of the calls to IsFocusable() that I previously removed. I also don't know whether sticking this on BrowserWindow was the right approach; if there's a better spot architecturally, speak up. Review URL: http://codereview.chromium.org/21368 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9882 0039d316-1c4b-4281-b951-d872f2087c98
* Have ChildProcessInfo contain a list of all running child processes (i.e. ↵jam@chromium.org2009-02-131-12/+10
| | | | | | | | instead of Service and other child process service maintain it). In a future change I'll start moving some of the code from PluginProcessHost to ChildProcessInfo. Review URL: http://codereview.chromium.org/24017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9804 0039d316-1c4b-4281-b951-d872f2087c98
* Porting in chrome/phajdan.jr@chromium.org2009-02-121-0/+1
| | | | | | | | | | | | | | - make following unit tests compile and pass on Linux: browser/history/expire_history_backend_unittest.cc browser/history/history_backend_unittest.cc browser/history/history_querying_unittest.cc browser/history/starred_url_database_unittest.cc - #include cleanup (less #ifdefs, more explicit deps) Review URL: http://codereview.chromium.org/21247 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@9671 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-03 12:50:56 +0000