summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.cc
Commit message (Collapse)AuthorAgeFilesLines
* Rolling back change 22245.chrome-bot@google.com2009-08-021-4/+0
| | | | | | | | | | | | Too much red :-( BUG=None TEST=None TBR=erikkay Review URL: http://codereview.chromium.org/159763 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22247 0039d316-1c4b-4281-b951-d872f2087c98
* mole expand/collapse API, callable from a toolstrip for manual operationerikkay@chromium.org2009-08-011-0/+4
| | | | | | Review URL: http://codereview.chromium.org/160276 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22245 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Autodetect whether the custom frame should be used.derat@chromium.org2009-07-311-1/+0
| | | | | | | | | | | | | | | | | | | | | | | Listing a bunch of strings from WMs' source sucks, but I can't think of any way to detect tiling WMs that don't support the EWMH (see the bug and the comment in this CL), so this seems safer. Tested with the following: - wiped out related prefs and started chrome under ion3; custom frame not used - quit and started under metacity; custom frame *was* used - toggled custom frame pref off and restarted under metacity again; custom frame not used - toggled it back on and restarted under ion3; custom frame was used BUG=15861 TEST=see above Review URL: http://codereview.chromium.org/160374 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22193 0039d316-1c4b-4281-b951-d872f2087c98
* Re-enable commands when coming out of full screen mode on linux.tc@google.com2009-07-301-28/+32
| | | | | | | | | | | | Since the call is async, we need to manually tell Browser that we're no longer in full screen mode. BUG=18104 Review URL: http://codereview.chromium.org/159670 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22120 0039d316-1c4b-4281-b951-d872f2087c98
* Force sizing of a new tab as soon as TabContents is created.japhet@chromium.org2009-07-291-0/+11
| | | | | | | | | | | BUG=619 BUG=15960 TEST=none Review URL: http://codereview.chromium.org/126290 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@22016 0039d316-1c4b-4281-b951-d872f2087c98
* Landing Thiago Farina's CL.jcampan@chromium.org2009-07-291-2/+2
| | | | | | | | | | | | | See http://codereview.chromium.org/159186 Renaming GetNormalBounds to GetRestoredBounds from browser_window.h. BUG=None TEST=None TBR=tfarina Review URL: http://codereview.chromium.org/160337 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21983 0039d316-1c4b-4281-b951-d872f2087c98
* The focus would be messed-up when reloading a crashed tab, also causing ↵jcampan@chromium.org2009-07-291-1/+2
| | | | | | | | | | | | accelerators to be broken. This CL also makes sure to keep the focus on the location bar when reloading the NTP. BUG=http://crbug.com/14954 TEST=See bug. Review URL: http://codereview.chromium.org/160206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21961 0039d316-1c4b-4281-b951-d872f2087c98
* Re-landing r21673 without re-enabling the BrowserTest, which apparently isbrettw@chromium.org2009-07-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | still failing. Make downloads not prevent tabs from closing. If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 Review URL: http://codereview.chromium.org/159426 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21685 0039d316-1c4b-4281-b951-d872f2087c98
* Revert of r21673 - which caused browser_test failure in ChromeURLAfterDownload.robertshield@chromium.org2009-07-271-2/+2
| | | | | | | TBR=brettw Review URL: http://codereview.chromium.org/160187 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21683 0039d316-1c4b-4281-b951-d872f2087c98
* Make downloads not prevent tabs from closing.brettw@chromium.org2009-07-271-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | If a download creates a cross-site transition (for example, if you click a link in Gmail that results in a download in a new tab), that tab will be stuck and you can't close it or the browser. This is the opposite problem with a similar cause as bug 16246. In both cases we were using some secondary signal to tell us if we're closing for a cross site transition or closing the tab, and that signal was wrong. In this case, we were running the onunload handler, but because there was a pending RenderViewHost, the RenderManager would think that the close was a cross-site one, and not forward the close message to actually close the tab. This patch adds a flag to the on unload handlers that indicates whether it's for a tab closure or a cross-site transition, so we can do the right thing unambiguously when the message returns. In this case I keep this information in the RenderView in case we send multiple close requests, we'll close the tab if any of them were for the entire tab, even if that particular one was dropped because we don't want to have more than one in flight at once. BUG=17560 TEST=none. Review URL: http://codereview.chromium.org/160122 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21673 0039d316-1c4b-4281-b951-d872f2087c98
* Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to ↵brg@chromium.com2009-07-251-0/+6
| | | | | | | | | | set the application id as a property on the shortcut As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar. However, they can not be pinned from the main application window nor can they be pinned from the shortcut. The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button. Instead in the latter case a web appliation will form a new group. Bug=7028 Test=None. (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly) Review URL: http://codereview.chromium.org/159336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a race condition where rapid back/forward clicks could close a tabbrettw@chromium.org2009-07-241-1/+1
| | | | | | | | | | | | | | | | | | | | | | | This can be triggered when you're on the new tab page, going to *two* other sites, then rapidly hitting back and forward randomly. If a cross-site transition was canceled before the original page responds with an "OK to close me" message, it will mistakenly categorize the close as not just for the RenderView (correspondong to one side of the cross-site transition) but for the entire tab. This change adds an explicit parameter on the messages indicating whether it's for interstials or for the tab so we don't have to rely on the request still being active. This also adds the "requesting process + route" in addition to the "new process + request" so we can be more clear about sending the messages to the correct place. The previous patch conbimed these in a confusing way. BUG=16246 TEST=none Review URL: http://codereview.chromium.org/159255 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21531 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds an infobar instructing users they can do search directly from ↵jcampan@chromium.org2009-07-231-0/+1
| | | | | | | | the location bar when they navigate to their default search engine.The infobar is dismissed and not shown again if the user does a search from the omnibox or dismiss the infobar.This is part of a UX experiment and is behind a switch.BUG=NoneTEST=Start Chrome with a fresh profile. Navigate to www.google.com. An info bar should be shown. Click the 'show me' button, the location bar should display a message explaining search can be made from it. Review URL: http://codereview.chromium.org/159242 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21438 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Rename JavaScript console action into Developer Tools.pfeldman@chromium.org2009-07-221-3/+3
| | | | | | Review URL: http://codereview.chromium.org/155914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21269 0039d316-1c4b-4281-b951-d872f2087c98
* o Modified the toolbar button handler so that the handler can revert its ↵yusukes@google.com2009-07-221-5/+0
| | | | | | | | | | | | | omnibox when the button pressed is RELOAD, FORWARD, or BACK. o Modified Browser::Reload(). Don't revert the bar when the user hit F5 or Ctrl-r. BUG=15464 TEST=see the comment #3 of issue 15464 Review URL: http://codereview.chromium.org/155908 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21267 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for the URL status bubble overlapping the download shelf.paul@chromium.org2009-07-211-2/+3
| | | | | | | | | | BUG=14662 (http://crbug.com/14662) TEST=Download something so that the shelf is visible and make sure that hovering over links on the page produce a status bubble above the download shelf. Review URL: http://codereview.chromium.org/155706 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21185 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: pass users' font settings through to renderer.agl@chromium.org2009-07-211-7/+8
| | | | | | | | | | | | The renderer doesn't give the settings to Skia yet -- that'll go in after agl's work on hinting and subpixel rendering in Skia. http://codereview.chromium.org/155787 (Patch by Dan Erat) git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21182 0039d316-1c4b-4281-b951-d872f2087c98
* Resurrect toolkit_views build.ben@chromium.org2009-07-211-3/+2
| | | | | | Review URL: http://codereview.chromium.org/155797 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21132 0039d316-1c4b-4281-b951-d872f2087c98
* Fix misleading name and comment of Browser::GetCurrentPageTitle.phajdan.jr@chromium.org2009-07-201-3/+3
| | | | | | | | | | | GetWindowTitleForCurrentTab more accurately describes what this function really does. TEST=none http://crbug.com/16231 Review URL: http://codereview.chromium.org/155534 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21114 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Store devtools split location on Linux.pfeldman@chromium.org2009-07-201-0/+1
| | | | | | Review URL: http://codereview.chromium.org/149748 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21070 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the the refactoring the page info to have a model.jcampan@chromium.org2009-07-191-0/+8
| | | | | | | | | BUG=None TEST=Make sure clicking the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. TBR=ben Review URL: http://codereview.chromium.org/155753 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21065 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 21032.jcampan@chromium.org2009-07-181-8/+0
| | | | | | | | | It breaks the release build on Windows. TBR=ben Review URL: http://codereview.chromium.org/155736 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21035 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring the page info to have a model.BUG=NoneTEST=Make sure clicking ↵jcampan@chromium.org2009-07-181-0/+8
| | | | | | | | the lock/warning icon when visiting a HTTPS page brings the page info and that it reports the correct info. Also check that the "Page/Frame info" right click menu works as well. Review URL: http://codereview.chromium.org/155336 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21032 0039d316-1c4b-4281-b951-d872f2087c98
* Wires up restoring pinned tabs for session and tab restoresky@chromium.org2009-07-141-10/+31
| | | | | | | | | | | services. And turns on pinned tabs by default on linux. BUG=16634 TEST=Currently this linux only. Try tab pinning and make sure it works. Review URL: http://codereview.chromium.org/149621 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20650 0039d316-1c4b-4281-b951-d872f2087c98
* Nukes the 3 arg TabMoved variant in favor of the 4 arg variant.sky@chromium.org2009-07-131-1/+2
| | | | | | | | | BUG=16634 TEST=none Review URL: http://codereview.chromium.org/155441 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20581 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Toggle docked devtools window on shortcut.pfeldman@chromium.org2009-07-131-3/+3
| | | | | | Review URL: http://codereview.chromium.org/149527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20479 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some stuff to string16 so the toolkit_views build can build againben@chromium.org2009-07-101-7/+7
| | | | | | Review URL: http://codereview.chromium.org/155334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20342 0039d316-1c4b-4281-b951-d872f2087c98
* Replace instances of LINUX2 with OS_CHROMEOS and linux2 with chromeos.brettw@chromium.org2009-07-081-4/+4
| | | | | | Review URL: http://codereview.chromium.org/149367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20210 0039d316-1c4b-4281-b951-d872f2087c98
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-071-0/+12
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* Hook up the prefs for the optional home buttons and page/wrench buttons. ↵pinkerton@chromium.org2009-07-071-0/+11
| | | | | | | | | | Move default registration of this pref out of platform code and into shared code to avoid having to do it in at least 3 places. Fix gradient buttons to not draw their borders unless asked. BUG=13151 TEST=showing/hiding home button and page/wrench buttons should work. Menus for page/wrench should work except for a few straggler items that aren't yet implemented even in the main menubar. Review URL: http://codereview.chromium.org/155151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20052 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a couple of keybindings.sky@chromium.org2009-07-071-0/+14
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
* Popup changesdavemoore@chromium.org2009-07-071-4/+4
| | | | | | Review URL: http://codereview.chromium.org/155075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20001 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-011-6/+0
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* Move render_view_host_manager* and site_instance* from tab_contents to ↵brettw@chromium.org2009-06-291-1/+1
| | | | | | | | renderer_host. Review URL: http://codereview.chromium.org/150011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19481 0039d316-1c4b-4281-b951-d872f2087c98
* Use regular notifications for theme changes.tc@google.com2009-06-261-0/+6
| | | | | | | | | | | | | This should have no impact on the current behavior. On linux, we'll want to get these notifications in a few places other than just the root browser windows so having it as a regular notification makes it easier for us to just listen for the event. Review URL: http://codereview.chromium.org/149032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19414 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: remove ShowJavaScriptConsole / InspectElementAt methods from ↵pfeldman@chromium.org2009-06-241-2/+2
| | | | | | | | render_view_host API. Review URL: http://codereview.chromium.org/146080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19112 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Nuke legacy debugger.pfeldman@chromium.org2009-06-241-31/+0
| | | | | | Review URL: http://codereview.chromium.org/146027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
* Rejiggers the keyword editor so that the UI is independent of the model ↵ben@chromium.org2009-06-231-20/+25
| | | | | | | | | | | rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword. BUG=none TEST=none Review URL: http://codereview.chromium.org/140054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
* Reorganize the way the task manager is constructed.ben@chromium.org2009-06-221-6/+1
| | | | | | | | | | | The BrowserWindow creates the task manager UI directly, which uses the TaskManager to populate itself. BUG=none TEST=none Review URL: http://codereview.chromium.org/140044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18975 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-191-0/+12
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* Initial download shelf on OS X.thakis@chromium.org2009-06-181-2/+0
| | | | | | | | | | | | | | | | | | | This has lots of missing stuff (e.g. a custom download item view that shows download progress, the popup is the same for in-progress and completed downloads, no animation, everything looks ugly, the info bubble overlaps the shelf when it's visible, no "open download manager page" link, etc), but the basic functionality is hooked up: The shelf appears when files are downloaded, and something ugly is added to the shelf for each download. The popup's "Reveral in Finder" even works. The shelf is per-window as it should be. BUG=12500 TEST=Download something and check the shelf appears. Click the close button and make sure it disappears again. Review URL: http://codereview.chromium.org/93129 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18757 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-131-0/+24
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-121-0/+4
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Do not allow URL drops on app windows to cause a navigation awaytc@google.com2009-06-101-0/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | from the currently loaded site. We are careful in this patch to continue to allow dropping URLs in text fields within the app window, and behavior for normal browser windows remains as before. There is a slight glitch when dragging a to an app window on the border of the window. Even though it is very brief, it is still disturbing. BUG=7171 TEST=Open Chrome (1), load google.com. Open Chrome (2), load yahoo.com. Drag a link from 1 to 2 and a link from 2 to 1 (both allowed). Create an app shortcut from 1, drag a link from 1 to 2 (allowed) and a link from 2 to 1 (denied). Verify that link scan be dragged to the omnibox and to text fields. Patch by Chase Phillips <chase@chromium.org> via http://codereview.chromium.org/119298 Review URL: http://codereview.chromium.org/121003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18100 0039d316-1c4b-4281-b951-d872f2087c98
* Refactors tab overview and gets the rest of the chunks working. I'vesky@chromium.org2009-06-101-1/+1
| | | | | | | | | | | | | | | | refactored it so that there is a clear object responsible for dragging and the controller now controls it all. There is some common code between TabOverviewDragController and DraggedTabController. I will try and share some code between these two later. BUG=none TEST=none Review URL: http://codereview.chromium.org/118513 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18089 0039d316-1c4b-4281-b951-d872f2087c98
* Null check render_view_host when processing unload events.ojan@chromium.org2009-06-101-2/+14
| | | | | | | | | | | | | I haven't been able to reproduce the crash, but I'm pretty sure this is the problem. I think this involves closing the browser while we're in the middle of a cross-process or interstitial page tab transition. TEST=none BUG=http://crbug.com/11493 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18086 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Remove old ifdefs around a DCHECK.willchan@chromium.org2009-06-091-4/+0
| | | | | | Review URL: http://codereview.chromium.org/119376 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17978 0039d316-1c4b-4281-b951-d872f2087c98
* Make Ctrl-Shift-J to work across platforms.mnaganov@chromium.org2009-06-091-4/+0
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/118427 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17936 0039d316-1c4b-4281-b951-d872f2087c98
* Move a few commands to the appropriate slot in the command order.pkasting@chromium.org2009-06-081-2/+6
| | | | | | Review URL: http://codereview.chromium.org/118311 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17879 0039d316-1c4b-4281-b951-d872f2087c98
* Second (and hopefully the final) fix for the issue 805:yusukes@google.com2009-06-061-1/+3
| | | | | | | | | | | | | | | | Killed (1) the "start download" (big arrow) animation and (2) fade and resize animation on NTP page, when the following conditions is met: (XP) Chromium is used over RDP. (Vista) "Turn off all unnecessary animations (when possible)" option in "Control Panel - Ease of Access Center - Make the computer easier to see" is checked. Note that the option automatically becomes checked when a user turns off the "Menu and window animation" option of a remote-desktop client. Review: http://codereview.chromium.org/115304 BUG=805 TEST=For (1), download a file and verify the arrow doesn't appear over RDP. For (2), set NTP as your homepage, start chromium on RDP session, verify fade animations on thumbnails are killed, then resize browser window, verify resize animations on thumbnails are also killed. Do the same thing with --new-new-tab-page command line flag. Review URL: http://codereview.chromium.org/118307 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17827 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-02-08 05:04:38 +0000