| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
| |
TBR=brettw
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4694002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65438 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
process.
BUG=http://crbug.com/51105, http://crbug.com/57239
TEST=Unit tests included.
Review URL: http://codereview.chromium.org/4524002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64960
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65075 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
TBR=jam@chromium.org
Review URL: http://codereview.chromium.org/4431001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=60211
Review URL: http://codereview.chromium.org/4222005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=28174
TEST=trybots
Review URL: http://codereview.chromium.org/4130012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64820 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4313002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64760 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=existing unittests. Also, test all places where new tabs and windows are opened from UI, e.g. links in options, new tab button, Ctrl+T, popup windows, etc.
Review URL: http://codereview.chromium.org/3834002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64745 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=61436
TEST=Open multiple unpinned tabs. In the rightmost new tab page, launch an application into a pinned tab. The application should launch in the new tab page, the tab should become pinned, move to the left of the unpinned tabs, and remain selected.
Review URL: http://codereview.chromium.org/4141012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64669 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
predictive results. More work is needed if we decide this is the direction to go, but it's good enough for us to play with.
BUG=61378
TEST=none
Review URL: http://codereview.chromium.org/4196009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64662 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
the private Pepper API).
BUG=61142
Review URL: http://codereview.chromium.org/4158013
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64528 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make ExtensionsService hold const Extension pointers only. This ensures that
extensions can't be modified after they're created, and lets us share them
between threads.
BUG=56558
TEST=no functional change
Review URL: http://codereview.chromium.org/4138006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds Ctrl-/ and Ctrl-Shift-/ (Ctrl-?) accelerators for
the help command in Views GTK, updates the help URL for
Chrome OS, and makes us print "/" explicitly in accelerator
descriptions instead of "slash" (the string we get from GDK).
BUG=chromium-os:7835
TEST=built and ran it
Review URL: http://codereview.chromium.org/4156004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64495 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
through, either because they were LOG_IF() (which I didn't search for) or they were added during the week I was changing things.
Plus a few misc. cleanup bits.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/4111002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63998 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This patch sets the "disallow IO" flag after the UI thread has
started, and then whitelists in the many places where we're
accidentally doing IO from the UI thread. (I've filed bugs
on all of those cases.)
BUG=59847,60630,60641,60211,60634,60643,24163,60825
Review URL: http://codereview.chromium.org/4146004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63986 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Patch by: Sadrul Chowdhury <sadrul@chromium.org>
BUG=59146
TEST=see bug
Review URL: http://codereview.chromium.org/4039007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63890 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=11321
TEST=Exercise the default zoom level setting in the 'Under the hood' panel.
Review URL: http://codereview.chromium.org/3807001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63702 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
is pressed.
ToggleFullscreenMode is asynchronous, so we need to wait for
next event cycle before creating new tab and set focus to omni box.
BUG=chromium-os:6591
TEST=manual: open non NTP page, go into fullscreen then hit search key. Result: omnibox should have focus.
Review URL: http://codereview.chromium.org/3956004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63532 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=49600
TEST=none
Review URL: http://codereview.chromium.org/3965003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63520 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
| |
BUG=59772
Review URL: http://codereview.chromium.org/4032002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63369 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the Search Engines settings rather than the overlay for editing a particular search engine (with no search engine selected).
BUG=58351
TEST=right click in the omnibox and select "Edit Search Engines..."
Verify that Settings page labeled "Basics > Search Engines" appears
rather than "Edit Search Engine" (with no parameters filled in).
Review URL: http://codereview.chromium.org/3955001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63304 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Data dialog
BUG=49128
TEST=none
Review URL: http://codereview.chromium.org/3807009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62997 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this since it's mostly a revert.
TBR=ben@chromium.org
BUG=59298
TEST=make sure instant isn't in preferences anymore.
Review URL: http://codereview.chromium.org/3809005
TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/3777009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62883 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
I'm TBRing this since it's mostly a revert.
TBR=ben@chromium.org
BUG=59298
TEST=make sure instant isn't in preferences anymore.
Review URL: http://codereview.chromium.org/3809005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62881 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also remove AppLauncher class (it's not used anymore).
BUG=56236,57371
TEST=build and ran it.
Review URL: http://codereview.chromium.org/3852001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62866 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Clear Browsing Data. Essentially a revert of r52258, though done by hand.
xib: Removed the link from the sync group, removed continuation array, resized everything else to close the gap.
BUG=59095
TEST=go into options, find no "go to Google Dashboard" link
Review URL: http://codereview.chromium.org/3761005
TBR=avi@chromium.org
Review URL: http://codereview.chromium.org/3799004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62778 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This adds a removeInfo object to the chrome.tabs.onRemoved callback that indicates if the tab's window is also closing.
BUG=56592
TEST=ExtensionApiTest
Review URL: http://codereview.chromium.org/3692004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62755 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58956
TEST=see bug
Review URL: http://codereview.chromium.org/3783005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62738 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Also makes Browser support browser::NavigatorDelegate.
BUG=none
TEST=BrowserNavigatorTest.Disposition_SingletonTab*
Review URL: http://codereview.chromium.org/3734003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62653 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Data. Essentially a revert of r52258, though done by hand.
xib: Removed the link from the sync group, removed continuation array, resized everything else to close the gap.
BUG=59095
TEST=go into options, find no "go to Google Dashboard" link
Review URL: http://codereview.chromium.org/3761005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62641 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Applications that are configured to be launched in a tab are now opened directly in the NTP, rather than opening a new tab and closing the NTP.
BUG=57476
TEST=Try launching an application from the new tab page. If it's set to open as a tab, a pinned tab, or full-screen, the application should launch directly into the existing new tab page. The new tab page should close when opening an application with panel launch type.
Review URL: http://codereview.chromium.org/3673006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62560 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
changed around BlockedPopupContainer so that it can handle any types
and made TabContents offer a mode to block all child content.
BUG=58927
TEST=enable instant, go to a site that would normally show a popup on
entering (or explicitly enable all popups). While typing in
the omnibox the popup shouldn't appear, but as soon as you
commit the instant result it should appear.
Review URL: http://codereview.chromium.org/3694005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
put them in the base namespace.
TEST=it compiles
BUG=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Stop processing incoming messages in BrowserRenderProcessHost when it is about
to be deleted. See comment 20 on the bug for details.
BUG=53991
TEST=handled by existing test
Review URL: http://codereview.chromium.org/3656005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62432 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7617
TEST=open chrome:settings, select cellular plan options, observer payment info being displayed at the top
Review URL: http://codereview.chromium.org/3762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58772
TEST=make sure that there is an entry in prefs for instant. See that
it works.
Review URL: http://codereview.chromium.org/3726002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
BUG=49084
TEST=Should automatically import the data on fresh install of Chrome.
Review URL: http://codereview.chromium.org/3367016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62232 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Document with the dialog: http://sites.google.com/a/chromium.org/dev/developers/design-documents/chromium-search-provider-js-support
BUG=38475
TEST=Used a custom html page which calls window.external.AddSearchProvider(url, true).
Review URL: http://codereview.chromium.org/3673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=38008
TEST=Manual
Review URL: http://codereview.chromium.org/3539017
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62157 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=58490
TEST=about:histograms/Extensions
Review URL: http://codereview.chromium.org/3640003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62023 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
also relax test when command-line is used to allow empty referrers
BUG=56795,54408
TEST=install an app from a /webstore URL
Review URL: http://codereview.chromium.org/3616009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61960 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
before sending down the instant script. If the page doesn't support
instant we fallback to reloading urls.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3608009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61743 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor Browser::BuildPopupWindow as Browser::CreatePopupWindow
and call it from ExtensionHost::ShowCreatedWindow.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7243
TEST=Test popup windows in general. See issue for specific test case.
Review URL: http://codereview.chromium.org/3532011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7336
TEST=see bug
Review URL: http://codereview.chromium.org/3620004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
contain any changes other than renaming/moving, as such I'm TBRing.
BUG=54833
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3602015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition)
-> A good many callsites just wanted a way to open a tab somewhere and select it.
- Browser::AddTabWithURL(AddTabWithURLParams* params)
-> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time.
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/3599006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessitated by needing to hold off on showing instant results until I
know if the server really supports instant.
This change is mostly refactoring to enable this. Most of what was
MatchPreview has been moved into MatchPreviewLoader. LoaderManager is
used to determine which MatchPreviewLoader to use as well as keeping
around a cache of them. MatchPreview for the most part delegates to
LoaderManager and MatchPreviewLoader now.
I'll rename all these classes to instant (and move into its own
directory) next.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3541008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move size based disposition override for ChromeOS from tab_container to browser.
* TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels.
* Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls.
* Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'.
* Added size limiting code to PanelBrowserView.
* Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166
TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps
More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I
!!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e
Review URL: http://codereview.chromium.org/3449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53617
TEST=see bug
Review URL: http://codereview.chromium.org/3550007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61311 0039d316-1c4b-4281-b951-d872f2087c98
|