summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.cc
Commit message (Collapse)AuthorAgeFilesLines
* Move win_util.h from common to app.ben@chromium.org2009-05-081-2/+1
| | | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/113169 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98
* Enable ctrl-shift-L for app/popup windows and fix a crash. Patch by Yusuke ↵pkasting@chromium.org2009-05-081-11/+15
| | | | | | | | Sato (see http://codereview.chromium.org/115050 ), r=me. BUG=8071,11559 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15671 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-081-5/+7
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Enable debugging of non-TabContents including extensions.pfeldman@chromium.org2009-05-071-8/+2
| | | | | | Review URL: http://codereview.chromium.org/115028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15526 0039d316-1c4b-4281-b951-d872f2087c98
* Create a separate UI surface for extensions (bottom shelf) and remove them ↵erikkay@google.com2009-05-061-2/+4
| | | | | | | | | | | | | | from the bookmarks bar (for now). The current implementation doesn't do anything new except for always appear when extensions are loaded. TEST=install an extension and see it show up in the new bottom bar TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar Review URL: http://codereview.chromium.org/112001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15417 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15399.maruel@chromium.org2009-05-061-4/+3
| | | | | | | broke purify Review URL: http://codereview.chromium.org/115026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15409 0039d316-1c4b-4281-b951-d872f2087c98
* Change Browser::GetIndexOfController to GetIndexOfTabContents. Now that webrettw@chromium.org2009-05-061-3/+4
| | | | | | | | don't have tab contents switching, identifying tabs by their controller is weird, so we should gradually move to only using TabContents*. Review URL: http://codereview.chromium.org/115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15399 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-061-16/+20
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Merge two TabContents::InvalidateTypes types and properly update tab ↵estade@chromium.org2009-05-061-19/+1
| | | | | | | | | | | | download icon. INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code. TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear. Review URL: http://codereview.chromium.org/109050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15387 0039d316-1c4b-4281-b951-d872f2087c98
* Move l10n_util to app/ben@chromium.org2009-05-051-1/+1
| | | | | | | http://crbug.com/11387 Review URL: http://codereview.chromium.org/109043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98
* Fix bug 9812: Remove current RSS code in favor of new more generalizedfinnur@chromium.org2009-05-041-3/+0
| | | | | | | | | | | | PageAction code that serves the same purpose (and more). BUG=9812 TEST=No test needed, this shouldn't result in any noticable difference since the RSS parsing was disabled. Review URL: http://codereview.chromium.org/100356 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15247 0039d316-1c4b-4281-b951-d872f2087c98
* Reset the omnibox contents when the user reloads the page. Patch by Yusuke ↵pkasting@chromium.org2009-05-041-0/+5
| | | | | | | | Sato (see http://codereview.chromium.org/100198 ), r=me. BUG=2985 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15211 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Wire existing shortcutto out of process devtools.pfeldman@chromium.org2009-05-041-16/+20
| | | | | | Review URL: http://codereview.chromium.org/99345 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15210 0039d316-1c4b-4281-b951-d872f2087c98
* Fix find in page. When fixing the conflict after updating, I accidentallybrettw@chromium.org2009-05-041-0/+5
| | | | | | | removed the code that updates the find in page commands. Review URL: http://codereview.chromium.org/100331 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15202 0039d316-1c4b-4281-b951-d872f2087c98
* Replace all occurrances of WebContents with TabContents.brettw@chromium.org2009-05-041-120/+86
| | | | | | Review URL: http://codereview.chromium.org/99177 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15194 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding the following CL (it was breaking the UI tests because ajcampan@chromium.org2009-05-021-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | NOTREACHED() would be triggered in that case). If Chrome is not the default browser, tell the user, unless: - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/100287 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15137 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15115, it sadly breaks the ui tests.jcampan@chromium.org2009-05-011-1/+0
| | | | | | | TBR=beng Review URL: http://codereview.chromium.org/100285 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15122 0039d316-1c4b-4281-b951-d872f2087c98
* If Chrome is not the default browser, tell the user, unless:jcampan@chromium.org2009-05-011-0/+1
| | | | | | | | | | | | | | | | | | | | | | - it is the first run - the user already said not to warn him/her about it - an info-bar is already showing. BUG=9049 TEST=Run a new install of chrome, proceed through the first run flow, don't make Chrome your default browser. No info-bar warning about Chrome not being the default browser should be shown. Restart Chrome, such an info-bar should be shown. Click the x on the info-bar to close it. Restart Chrome. The info-bar should be shown. Select "Set as default". Restart Chrome, the info-bar should not be shown. Start IE, make it your default browser (Tools menu, 'Internet option', Programs tab). Restart Chrome, it should show the default browser info-bar. Select "Don't ask me again". Restart Chrome, the info-bar should not be shown. Review URL: http://codereview.chromium.org/99301 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15115 0039d316-1c4b-4281-b951-d872f2087c98
* This is the first part of the PageAction implementation. More work is ↵finnur@chromium.org2009-05-011-0/+3
| | | | | | | | | | | | | | | | required, but this is a good checkpoint. Design doc: http://dev.chromium.org/developers/design-documents/extensions/page-actions-api This checkin only covers Tab scoped page actions (not type "permanent"). It works end to end (if you have an extension that supplies the page action info -- I created an RSS page action that links to Google Reader). Please note that TabIndex is hard coded to 0 until the extension system can provide the tab id to the extensions (which I understand is in progress). This means that page action(s) only show up for the first tab in the tabstrip. :) BUG=None TEST=There is a unit test for the API, but apart from that it is not possible to test this manually without writing an extension that adds a PageAction. My RSS page action is not ready to be checked in but I can provide it if there is interest in a sneak preview during review/QA. Review URL: http://codereview.chromium.org/99253 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15105 0039d316-1c4b-4281-b951-d872f2087c98
* Don't show popups before tabs have been added. Instead, prevent the ↵ben@chromium.org2009-04-301-8/+1
| | | | | | | | | | BrowserView from restoring focus to the tab if the window that contains it isn't visible. This prevents blur events from being fired incorrectly. http://crbug.com/7991 Review URL: http://codereview.chromium.org/99248 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14985 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this, it was missing the Mac unit-test change, that was breaking ↵jcampan@chromium.org2009-04-301-0/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | the build. TBR=ben Closing the last tab with a download in-progress would cause the tab to be closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/100210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14948.jcampan@chromium.org2009-04-301-9/+0
| | | | | | | | | Broke the Mac build. TBR=ben Review URL: http://codereview.chromium.org/99224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14949 0039d316-1c4b-4281-b951-d872f2087c98
* Closing the last tab with a download in-progress would cause the tab to bejcampan@chromium.org2009-04-301-0/+9
| | | | | | | | | | | | | | | | | | | | | | | closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/99195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14948 0039d316-1c4b-4281-b951-d872f2087c98
* Patch from <yuzo@google.com>:ben@chromium.org2009-04-291-2/+9
| | | | | | | | | | | | | Disable view-source if the page source is not viewable as text. For example, a page of content type application/x-shockwave-flash is not viewable. http://crbug.com/9562 Review URL: http://codereview.chromium.org/66061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14880 0039d316-1c4b-4281-b951-d872f2087c98
* Synchronously update the loading state when a load starts so that the UI willbrettw@chromium.org2009-04-281-4/+7
| | | | | | | | | | | | | be more responsive and the loading state won't be out-of-sync with anything else. This also removes the synchronous update to the throbber when we load a URL because this happens before the loda actually starts, giving a flash of the default favicon. The load start call made by RenderViewHost will cover this case after the load actually starts. BUG=11051 Review URL: http://codereview.chromium.org/100033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14718 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tabs.createWindow extension api call. Required: (a) new ↵rafaelw@chromium.org2009-04-281-2/+8
| | | | | | | | | | | RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h BUG=11092: R=aa,mpComplete,darin,pkasting Review URL: http://codereview.chromium.org/79070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14710 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we have file dialogs, we might as well hook up "Open File" on the Mac.avi@google.com2009-04-271-4/+0
| | | | | | Review URL: http://codereview.chromium.org/93145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14625 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a crash I introduced in r14053. It removed the setting of the controller inbrettw@chromium.org2009-04-251-6/+10
| | | | | | | | | one arm of an if statement. BUG=10930 Review URL: http://codereview.chromium.org/99003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14533 0039d316-1c4b-4281-b951-d872f2087c98
* Fix sudden termination after the latest WebKit merge.jam@chromium.org2009-04-251-1/+1
| | | | | | | | BUG=10927 Review URL: http://codereview.chromium.org/93104 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14517 0039d316-1c4b-4281-b951-d872f2087c98
* Create an about dialog for GTK Chromium.erg@google.com2009-04-241-2/+2
| | | | | | Review URL: http://codereview.chromium.org/93128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14462 0039d316-1c4b-4281-b951-d872f2087c98
* Move Browser implementation of callback interfaces into the private section.stoyan@chromium.org2009-04-231-0/+32
| | | | | | | Split TabContentsDelegate and PageNavigator. Review URL: http://codereview.chromium.org/88063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14375 0039d316-1c4b-4281-b951-d872f2087c98
* Browser Crash when opening urls with NEW_BACKGROUND_TAB dispositionhbono@chromium.org2009-04-231-3/+3
| | | | | | | | | | | | | | | | | | | When that disposition is used and no "normal" window is opened, it crashes. "normal" means non POPUP, non APPLICATION window type. This happens because background disposition doens't focus or activate the window unless selected. A crash happens because GetSelectedTabContents() is null since nothing initially there. This fix might have stopped it crash, but would be best to see if its a "good" approach. I fixed some lints such as, header file already exists, extra white space, etc) BUG=10591 ( http://crbug.com/10591 ) Original patch by Mohamed Mansour (see http://codereview.chromium.org/67205/show), r=me,pkasting Review URL: http://codereview.chromium.org/93058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14288 0039d316-1c4b-4281-b951-d872f2087c98
* Rename web_contents_view* files to tab_contents_view* to reflect my previousbrettw@chromium.org2009-04-211-2/+1
| | | | | | | rename of the classes. Review URL: http://codereview.chromium.org/87009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14083 0039d316-1c4b-4281-b951-d872f2087c98
* When restoring a closed tab using either ctrl-shift-T or the context menu, putpam@chromium.org2009-04-201-0/+2
| | | | | | | | | | | | | | | | | | | it back into the window it came from, at the tabstrip index it occupied before, and activate (select) both the window and the tab. Restoring a tab from the New Tab Page replaces the NTP, as before. If the window the tab was in no longer exists, put the tab at the end of the current window's tabstrip. This behavior may change in a later patch. BUG=5278 TEST=Open two windows, with >1 tabs each. Close a tab, not the one at the end, in one of the windows. Switch to the other window and choose "Undo Closed Tab" from the tabstrip context menu, or type ctrl-shift-T. The tab should be restored where it was, and activated (selected and brought to the front). Review URL: http://codereview.chromium.org/69015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14062 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-201-67/+56
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-181-56/+67
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-181-67/+56
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* Initial implementation of the FindBar on Mac.rohitrao@chromium.org2009-04-171-2/+0
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13969 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContnetsType from everywhere.brettw@chromium.org2009-04-151-32/+2
| | | | | | | | I also removed the notion of the "active" tab contents since there is only one per tab now, and all the messages to replace them. Review URL: http://codereview.chromium.org/67173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13808 0039d316-1c4b-4281-b951-d872f2087c98
* Allow users to hit ctrl-shift-delete ("clear browsing data") even in ↵pkasting@chromium.org2009-04-151-1/+2
| | | | | | | | | | | fullscreen mode. I elected not to continue to leave this disabled for app-mode windows since there's no menu entry for it. Not sure if that was the right call. BUG=9318 Review URL: http://codereview.chromium.org/67188 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13807 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression I introduced where Stop/Go button would toggle state ↵pkasting@chromium.org2009-04-151-4/+4
| | | | | | | | | | | instantly instead of having protections against accidental user actions while the mouse was hovering the button. I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple. BUG=9843 Review URL: http://codereview.chromium.org/67156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13761 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContentsType from the NavigationController external interface and inbrettw@chromium.org2009-04-151-7/+7
| | | | | | | some related areas. I removed all uses of this in the previous patch. Review URL: http://codereview.chromium.org/73057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13730 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the TestTabContents. This makes BrowserWithTestWindow use thebrettw@chromium.org2009-04-141-6/+2
| | | | | | | | | | | | | | | TestRenderViewHost instead. There are some changes to browser_commands_unittest to support this. Now that we're using proper TabContentes, I had to stub out a FocusManager call since there isn't a proper view hierarchy created. Remove TabContents collection and switching from the NavigationController. I tried to keep the same interface to the NavigationController since I tried that in a previous patch and the change blew up. Remove the TabContents factory. Callers now create a WebContents directly. Review URL: http://codereview.chromium.org/67113 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13707 0039d316-1c4b-4281-b951-d872f2087c98
* Added undo tab closing item to Tab menu.idanan@chromium.org2009-04-141-0/+5
| | | | | | Review URL: http://codereview.chromium.org/62151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13662 0039d316-1c4b-4281-b951-d872f2087c98
* Refactoring; switch the |filter| parameter into something that is more ↵avi@chromium.org2009-04-121-1/+1
| | | | | | | | | | amenable to cross-platform implementation. BUG=9852 Review URL: http://codereview.chromium.org/63093 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98
* Fix a flicker of the URL bar after you enter it. The codebrettw@chromium.org2009-04-091-4/+4
| | | | | | | | | | | | | inBrowser::OpenURLFromTab was not using the current tab when no source was specified. This means we didn't update the correct tab. This change uses the computed current URL for updating, and also clarifies the comments in the TabContentsDelegate about what NULL means. BUG=9799 Review URL: http://codereview.chromium.org/63125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13458 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a confirmation box when closing the browser with in-progress ↵jcampan@chromium.org2009-04-091-3/+73
| | | | | | | | | | downloads. BUG=1028 TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode. Review URL: http://codereview.chromium.org/62131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98
* Distributor logo and " - App Name" shouldn't be shown on app frame windows.ben@chromium.org2009-04-081-1/+10
| | | | | | | | http://crbug.com/6138 Review URL: http://codereview.chromium.org/62167 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13393 0039d316-1c4b-4281-b951-d872f2087c98
* Support the new popup and new window dispositions in the external tab ↵ananta@chromium.org2009-04-081-2/+17
| | | | | | | | | | | | | | | | container. Disabled the TRACK_HWND_DESTRUCTION macro in render_widget_host_view_win.cc as it fires consistently for the external tab container probably due to multiple WM_DESTROY messages received for the container, when the parent window is destroyed. Fixes bug http://b/issue?id=1747547 Bug=1747547 Review URL: http://codereview.chromium.org/63074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13326 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the findbar crash.tc@google.com2009-04-071-1/+1
| | | | | | | | | | | | | | | | FindBarController is no longer owned by the BrowserWindow, it is owned by Browser. So we can remove the FindBarController code in BrowserWindowGtk. Also, go ahead and implement BrowserWindow::CreateFindBar (which creates the gtk widget and adds it to the gtk widget hierarchy) and enable the code on linux. Since the widgets are created and added to the hierarchy later, we attach the signals after the widgets have been "realized". Review URL: http://codereview.chromium.org/62126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13310 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-22 18:30:54 +0000