summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.cc
Commit message (Collapse)AuthorAgeFilesLines
* Use TabContents::GetDefaultTitle() everywhere we need a title for an ↵pkasting@chromium.org2010-02-121-1/+1
| | | | | | | | | | untitled tab/page. This will let us remove a couple of duplicate strings. BUG=none TEST=none Review URL: http://codereview.chromium.org/604021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38902 0039d316-1c4b-4281-b951-d872f2087c98
* Adds code to restore application extensions. I'm also enabling tabsky@chromium.org2010-02-101-1/+20
| | | | | | | | | | | | pinning on views again as everything in place, except a couple of bugs. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/598027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38657 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the temporary scaffolding stubs.phajdan.jr@chromium.org2010-02-101-4/+1
| | | | | | | | | | | | | They have served they purpose well, but now it's time to retire. It's one of the things that draggen in the bad dependency of chrome/common on chrome/browser, and is sufficiently small now to stub things out individually. TEST=none BUG=none Review URL: http://codereview.chromium.org/593037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38639 0039d316-1c4b-4281-b951-d872f2087c98
* Make the content settings dialog dependent on its parent. This re-plumbs ↵pkasting@chromium.org2010-02-091-0/+4
| | | | | | | | | | the "show" function to work more like a number of our other dialogs (i.e. delcared in browser_dialogs.h), and adds a TabContentsDelegate function so the content blocked info bubbles can ask the appropriate window to show the dialog. BUG=35084 TEST=Open the content settings dialog from either the options or a content blocked info bubble. Click its parent window. The dialog should stay on top of the parent. Review URL: http://codereview.chromium.org/597009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38534 0039d316-1c4b-4281-b951-d872f2087c98
* Add back disabled menu itemsdavemoore@chromium.org2010-02-091-3/+4
| | | | | | | | | | | | Bug=chromiumos:1275 Test=There should be no "Create Application Shortcuts" menu item. All others should be the same as Chrome, except that Print... should be disabled. This is true for both the page menu and the content area menu. Review URL: http://codereview.chromium.org/596014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38512 0039d316-1c4b-4281-b951-d872f2087c98
* Do the remaining renames after http://codereview.chromium.org/585008phajdan.jr@chromium.org2010-02-091-2/+2
| | | | | | | | | | TBR=brettw TEST=you can possibly break the tree, right? BUG=none Review URL: http://codereview.chromium.org/602002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38467 0039d316-1c4b-4281-b951-d872f2087c98
* [GTTF] Reduce header dependencies in chrome.phajdan.jr@chromium.org2010-02-091-0/+1
| | | | | | | | | BUG=none TEST=If it compiles it is perfect. Review URL: http://codereview.chromium.org/585008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38463 0039d316-1c4b-4281-b951-d872f2087c98
* Makes mini-tabs work on the UI side (at least for views). I still havesky@chromium.org2010-02-061-1/+1
| | | | | | | | | | | a handful of things to resolve before I turn on pinning. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/579011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38287 0039d316-1c4b-4281-b951-d872f2087c98
* Fix for bug where reloading an extension from an infobar when another window ↵andybons@chromium.org2010-02-061-5/+6
| | | | | | | | | | | does not have that infobar open but has another crashed extension's infobar hoses the browser. Phew. BUG=34683 TEST=follow repro steps in bug. should not crash. Review URL: http://codereview.chromium.org/572045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38285 0039d316-1c4b-4281-b951-d872f2087c98
* Yet more tab strip model changes. I'm hoping this is the last ofsky@chromium.org2010-02-051-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | it. I'm now going with: // . Mini-tab. Mini tabs are locked to the left side of the tab strip and // rendered differently (small tabs with only a favicon). The model makes // sure all mini-tabs are at the beginning of the tab strip. For example, // if a non-mini tab is added it is forced to be with non-mini tabs. Requests // to move tabs outside the range of the tab type are ignored. For example, // a request to move a mini-tab after non-mini-tabs is ignored. // You'll notice there is no explcit api for making a tab a mini-tab, rather // there are two tab types that are implicitly mini-tabs: // . App. Corresponds to an extension that wants an app tab. App tabs are // identified by TabContents::is_app(). // . Pinned. Any tab can be pinned. A pinned tab is made phantom when closed. // Non-app tabs whose pinned state is changed are moved to be with other // mini-tabs or non-mini tabs. I'm going with a more neutral name like mini-tabs so that we can change the meaning if we need to without changing around all the UI code. I'll convert the UI code next. BUG=32845 TEST=none Review URL: http://codereview.chromium.org/570043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38237 0039d316-1c4b-4281-b951-d872f2087c98
* Show the filebrowse ui rather than the download shelf in chromeos.xiyuan@chromium.org2010-02-051-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This cl displays the filebrowse ui rather than download shelf for downloads in chrom(e|ium) os. It conditionally replaces (with preprocessor macros) the Browser::OnStartDownload method to do this. The cl adds a static FileBrowseUI::OpenPopup(profile, hashArgument), which opens the file browse ui and passes it the provided hash argument. This is invoked directly from Browser::OnStartDownload. The USBMountObserver code was changed to call this static method, rather than open the popup by hand as it had been doing. I'm not sure about ownership of the Browser* returned by OpenPopup, but based on other code in the tree I assume chrome will deal with freeing it when appropriate. Before this change, USBMountObserver would add the window to registrar_ *before* showing it. Now that FileBrowseUI::OpenPopup returns a which which is already visible, this is no longer the case. I assume this won't be a problem. Commit this for rginda. Original review: http://codereview.chromium.org/555167 BUG=none TEST=none Review URL: http://codereview.chromium.org/564022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38222 0039d316-1c4b-4281-b951-d872f2087c98
* Make the side tabstrip participate in the layout of the BrowserView.ben@chromium.org2010-02-051-1/+1
| | | | | | | | | | | | Turn on the side tabstrip by default when --enable-vertical-tabs is specified, for ease of testing/debugging. Adjust glass rendering in this mode. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/570029 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38160 0039d316-1c4b-4281-b951-d872f2087c98
* Create a new base class BaseTabStrip that is the intermediary between ↵ben@chromium.org2010-02-041-1/+1
| | | | | | | | | | | | | BrowserView/etc and the specific active TabStrip implementation in use. This simplifies things a lot. I don't need separate view IDs etc. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/571002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38110 0039d316-1c4b-4281-b951-d872f2087c98
* Step 1 in Implementing/Prototyping App Panels.rafaelw@chromium.org2010-02-041-6/+9
| | | | | | | | | | | | | | | | | | | | In this first step we 1) Create a new Browser::Type::TYPE_APP_PANEL which is observed in various places 2) Create an AppPanelBrowserFrame which is created in BrowserFrameWin when the TYPE_APP_PANEL is observed. AppPanelBrowserFrame draws itself per glen's mocks and will ultimately behave substantially different from regular browser windows. 3) Create a temporary command switch called --app-launch-as-panel which can be used until we implement actual app launching. Note that there is still work to be done "bit-twiddling" to match glen's mocks and to implement the "inactive" look for these windows. Steps 2 through N may include: different sizing behavior (based either on the content size or an api call), different min/maximize behavior, docking to the os taskbar, auto order & placement of app panels. A screen capture of the current implementation is attached to the bug. BUG=32361 Review URL: http://codereview.chromium.org/553143 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38107 0039d316-1c4b-4281-b951-d872f2087c98
* Start making a vertical tabstrip. Does nothing right now.ben@chromium.org2010-02-041-0/+1
| | | | | | | | | | | | | | | The option to enable the vertical tabstrip will appear when Chrome is run with: --enable-vertical-tabs and a pref is set. There is presently no UI to set this pref. http://crbug.com/34509 TEST=none Review URL: http://codereview.chromium.org/561004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38076 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the "On top" display mode of the extension shelf, it is no longer ↵ben@chromium.org2010-02-031-4/+0
| | | | | | | | | | | used or supported. BUG=none TEST=none Review URL: http://codereview.chromium.org/566035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@38034 0039d316-1c4b-4281-b951-d872f2087c98
* Reland 37913. Clear local state on exit.jochen@chromium.org2010-02-031-0/+1
| | | | | | | | | BUG=32719 TEST=none Review URL: http://codereview.chromium.org/560024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37936 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 37913 - Clear local state (cookies, databases, local storage) on exit.chase@chromium.org2010-02-031-1/+0
| | | | | | | | | | | | BUG=32719 TEST=none Review URL: http://codereview.chromium.org/564012 TBR=jochen@chromium.org Review URL: http://codereview.chromium.org/564023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37915 0039d316-1c4b-4281-b951-d872f2087c98
* Clear local state (cookies, databases, local storage) on exit.jochen@chromium.org2010-02-031-0/+1
| | | | | | | | | BUG=32719 TEST=none Review URL: http://codereview.chromium.org/564012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37913 0039d316-1c4b-4281-b951-d872f2087c98
* Adjusts tab strip model to deal with app tabs. There were a couple ofsky@chromium.org2010-02-021-3/+2
| | | | | | | | | | | | | places where I left them using the variable with pinned when it should be app because those places need to be radically whacked. I'll do that next. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/555173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37880 0039d316-1c4b-4281-b951-d872f2087c98
* Wire popup blocking UI to the new machinery and port over the user's old ↵pkasting@chromium.org2010-02-021-12/+5
| | | | | | | | | | | | | | | | whitelist. Notably, this removes the UI entirely for Mac and Linux. We need to rebuild it. This also guts the old system's testing, since most of it disappeared or changed radically. We should test the new stuff. I will file a followup bug for that. There are various tiny edge cases, like if you click the address bar icon really quickly, sometimes you'll get popups without any title yet, which makes them leave gaps in the bubble that appears. We can fix that sort of thing. The critical bit I tried to ensure was that we never try to open a dead popup or use a dead TabContents, no matter what. BUG=33314 TEST=Go visit some sites with popups and play with things Review URL: http://codereview.chromium.org/562013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37819 0039d316-1c4b-4281-b951-d872f2087c98
* Migrate old cookie setting to new system.pkasting@chromium.org2010-02-021-2/+0
| | | | | | | | | | Also, do a better job of making sure we don't write useless default values to disk, and we force the in-memory copy of the default prefs to never say "DEFAULT" even if a caller provides that to SetDefaultContentSetting(). BUG=32719 TEST=unittests Review URL: http://codereview.chromium.org/562003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37775 0039d316-1c4b-4281-b951-d872f2087c98
* Ignore ref (hash fragment) in URL when opening singleton tabs based on URLs.arv@chromium.org2010-01-311-6/+22
| | | | | | | | | | | I renamed the method name in preparation of using this for opening the bookmark manager extension. BUG=None TEST=Open History. Do a search and open history again. We should not create a new tab but go to the existing one. Review URL: http://codereview.chromium.org/553151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37651 0039d316-1c4b-4281-b951-d872f2087c98
* Changes to support new cookie policy.darin@chromium.org2010-01-301-2/+2
| | | | | | | | | | | | | | Changes: 1- net::CookiePolicy becomes an interface. 2- Old implementaiton of CookiePolicy copied to StaticCookiePolicy. 3- ChromeULRRequestContext implements CookiePolicy. 4- HostContentSettingsMap gets a global "BlockThirdPartyCookies" pref. R=pkasting Review URL: http://codereview.chromium.org/556095 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37624 0039d316-1c4b-4281-b951-d872f2087c98
* If an extension crashes or is killed by the task manager then reloaded, the ↵andybons@chromium.org2010-01-301-0/+23
| | | | | | | | | | | | info bar telling the user that the extension has crashed should disappear in ALL windows should the user choose to hit the 'reload' button. NOTE: If the user 'x's out the info bar, the bars in the other windows will remain. BUG=33396 TEST=none Review URL: http://codereview.chromium.org/548206 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37570 0039d316-1c4b-4281-b951-d872f2087c98
* Revert r37535.darin@chromium.org2010-01-291-0/+2
| | | | | | | | | | | | | There was no LGTM, and there was still open discussion in the code review. See http://codereview.chromium.org/554119. This was not ready to land. TBR=pkasting BUG=none TEST=none Review URL: http://codereview.chromium.org/553154 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37556 0039d316-1c4b-4281-b951-d872f2087c98
* Implement extended cookie controls.jochen@chromium.org2010-01-291-2/+0
| | | | | | | | | BUG=32782 TEST=none Review URL: http://codereview.chromium.org/554119 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37535 0039d316-1c4b-4281-b951-d872f2087c98
* Implement a TODO: Combine BrowserToolbarModel with ToolbarModel. Also make ↵pkasting@chromium.org2010-01-281-11/+0
| | | | | | | | | | all ToolbarModel methods const. BUG=none TEST=none Review URL: http://codereview.chromium.org/556064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37450 0039d316-1c4b-4281-b951-d872f2087c98
* [Mac]Implement Cut, Copy and Paste from page menusuzhe@chromium.org2010-01-271-4/+0
| | | | | | | | | BUG=none TEST=Cut/Copy/Paste items in page menu should work in both omnibox and web content. Review URL: http://codereview.chromium.org/556016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37231 0039d316-1c4b-4281-b951-d872f2087c98
* Unload and BeforeUnload handlers would not get invoked within pages inside ↵ananta@chromium.org2010-01-271-13/+18
| | | | | | | | | | | | | | | | | | | | | | | | ChromeFrame. This was because the ExternalTabContainer would close the underlying tab contents in its OnDestroy handler without invoking unload handlers on the page if any. In Chrome the TabStripModel invokes the RunUnloadListenerBeforeClosing on the delegate which is implemented by the browser. We need to mimic this in the external tab container. To achieve this we now have a static helper function RunUnloadListenerBeforeClosingHelper in the browser class which is called by the ExternalTabContainer and the Browser::RunUnloadListenerBeforeClosing function. The ExternalTabContainer also needs to wait for the unload handlers on the page to return before it returns control back to the host browser. To achieve this we enter a nested modal loop which is exited when the underlying tab is closed. Fixes bug http://code.google.com/p/chromium/issues/detail?id=31853 Bug=31853 Test=Covered by ChromeFrame unit test. Review URL: http://codereview.chromium.org/543183 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37197 0039d316-1c4b-4281-b951-d872f2087c98
* Code Cleanup: Browser::CreateForApp can no longer create TYPE_APP_POPUP windowsrafaelw@chromium.org2010-01-261-6/+6
| | | | | | | | | | | This cleans up the interface for BrowserCreateForApp() which now longer takes a final argument of is_popup. The code has changed so that it is no caller is ever passing in true, so the code has been simplified. BUG=5739 TEST=Ensure steps in bug report still no longer produce the bug. Review URL: http://codereview.chromium.org/556024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37163 0039d316-1c4b-4281-b951-d872f2087c98
* Split chromeos options page into system and internet.chocobo@chromium.org2010-01-261-6/+16
| | | | | | | | BUG=None TEST=None Review URL: http://codereview.chromium.org/548152 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@37155 0039d316-1c4b-4281-b951-d872f2087c98
* [Linux]Implement Cut, Copy and Paste from page menu.suzhe@chromium.org2010-01-251-27/+6
| | | | | | | | | BUG=18030 TEST=The Cut, Copy and Paste commands in page menu should work in both web content and location bar. Review URL: http://codereview.chromium.org/552125 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36989 0039d316-1c4b-4281-b951-d872f2087c98
* 3rd step to remove BrowserExtender and to refactor BrowerView for sidebar.oshima@chromium.org2010-01-221-3/+3
| | | | | | | | | | | | | | * defined UIStyle enum * fixed #if for compact navbar so that it's enabled only on chromeos * Moved view initialization and layouts code from NormalExtender to chromeosBrowserView and ChromeosBrowsrViewLayoutManager respectively. * Removed unnecessary extender code from BrowserView. * no functional change BUG=none TEST=none Review URL: http://codereview.chromium.org/553059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36922 0039d316-1c4b-4281-b951-d872f2087c98
* Adds support for phantom tabs. A pinned tab becomes a phantom tab whensky@chromium.org2010-01-221-17/+39
| | | | | | | | | | | | | | | | | it is closed, and effectively unloads the renderer and replaces it with a new TabContents that loads when selected. A phantom tab is currently rendered without a border. Phantom tabs do not prevent a window from closing. Long term only pinned app tabs will have the ability to be made phantom, but this allows us to test the feature until app support is all wired in. BUG=32845 TEST=none yet Review URL: http://codereview.chromium.org/553008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36815 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36098 because the UI team has decided on a different long-term ↵jorlow@chromium.org2010-01-211-1/+0
| | | | | | | | | | | | direction for the clear browsing data dialog. TEST=none BUG=none Review URL: http://codereview.chromium.org/542126 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36733 0039d316-1c4b-4281-b951-d872f2087c98
* Disable app mode in the model on Mac so it is disabled in the page menu.pinkerton@chromium.org2010-01-201-0/+8
| | | | | | | | BUG=32559 TEST=menu item should be disabled on mac, enabled on win/linux Review URL: http://codereview.chromium.org/552070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36695 0039d316-1c4b-4281-b951-d872f2087c98
* Moving the page contents message processing to the RenderViewHost.jcampan@chromium.org2010-01-181-2/+2
| | | | | | | | | | | | | | | | | | It was currently processed as a control message. This is an actual part of the previous CLD related CL: http://codereview.chromium.org/548057 It kept failing on the bots for some tests, I am not sure why yet and cannot repro locally. Hopefully splitting it will help pinpoint the issue. TEST=All unit-tests, ui tests should still work. Navigate to a page with some specific words in it, then go to the history tab and search for pages with these specific words. Make sure the page you navigated is shown in the results. TBR=brettw Review URL: http://codereview.chromium.org/553012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36490 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36442 - Still causing test failuresjcampan@chromium.org2010-01-161-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | 4th attempt at landing this. It caused several tests to fails previously. Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow). No code change. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. TBR=brettw Review URL: http://codereview.chromium.org/548057 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/536085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36447 0039d316-1c4b-4281-b951-d872f2087c98
* 4th attempt at landing this.jcampan@chromium.org2010-01-161-2/+2
| | | | | | | | | | | | | | | | | | | | | It caused several tests to fails previously. Cannot repro any of the failure. I am suspecting a clobber would have probably fixed it. (there is a change in one of the IPC messages that probably messed up the build somehow). No code change. Enabling language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. TBR=brettw Review URL: http://codereview.chromium.org/548057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36442 0039d316-1c4b-4281-b951-d872f2087c98
* Tab-modal dialog improvements:zelidrag@google.com2010-01-151-0/+9
| | | | | | | | | | | | | | | | - treat constrained dialogs as tab-modal - only one shows at the time - added visual indication (tab pulsing) to the tab strip when a tab is blocked by a tab-modal dialog - blocked all UI activity from rendrer host and forced refocusing on constrained (tab-modal) dialogs This CL reverts http://codereview.chromium.org/384113 and instead incorporates the changes from http://codereview.chromium.org/392018. BUG=456,27585,27620 TEST=Go to http://www/~thakis/cgi-bin/test.html, hit esc. Review URL: http://codereview.chromium.org/541056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36415 0039d316-1c4b-4281-b951-d872f2087c98
* Enable the context menu and developer menu "View source" items at the same time.brettw@chromium.org2010-01-151-6/+1
| | | | | | | | | | | This fixes issue 2028 which didn't enable the context menu item for new tabs. BUG=2028 TEST=Open a new tab and verify that the 'View page source' context menu is enabled. Original review: http://codereview.chromium.org/541016 Patch by Aaron Kemp git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36367 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 36362 - It breaks NACLTests and Chrome Frame Testsjcampan@chromium.org2010-01-151-2/+2
| | | | | | | | | | | | | | | | | | | | 3rd attempt at landing the language detection on page load. A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unittests. Review URL: http://codereview.chromium.org/518075 TBR=jcampan@chromium.org Review URL: http://codereview.chromium.org/546062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36364 0039d316-1c4b-4281-b951-d872f2087c98
* 3rd attempt at landing the language detection on page load.jcampan@chromium.org2010-01-151-2/+2
| | | | | | | | | | | | | | | | A memory error has been fixed in the CLD library in the meantime. This should hopefully fixes the crashers in the reliability tests. Note that this version is actually simpler than the original review since the detection is now performed in the renderer. (So the CLD code runs sandboxed.) Original review: http://codereview.chromium.org/492024/show BUG=30662 TEST=Run the unit-tests. Review URL: http://codereview.chromium.org/518075 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36362 0039d316-1c4b-4281-b951-d872f2087c98
* Adds "Delete Local Storage" option to "Clear Browsing Data" for Windows and ↵jorlow@chromium.org2010-01-131-0/+1
| | | | | | | | | | | | | | | | GTK. NOTE: This change does not contain src/chrome/app/nibs/ClearBrowsingData.xib. It'll be edited by someone who knows about Mac. BUG=none TEST=The clear browser data dialog box should have a new option: Delete local storage" Landing for Marcus Original CL: http://codereview.chromium.org/524026 Review URL: http://codereview.chromium.org/542048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36098 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: UI tweaks for task manager.thakis@chromium.org2010-01-131-4/+0
| | | | | | | | | | | | | | | | | | | | | | | Nib change: Reduce row height, make scrollbars smaller. Make text in task manager table slightly smaller. Show in decimal digit for %cpu. Show memory in KB/MB, not always in K. Change update frequency from 1s to 2s to match Activity Monitor's default. (all mac-only. ui team is fine with this.) Finally, turn taskman on. BUG=13156 TEST=Open task manager, look at it. Should look & feel similar to Activity Monitor. Review URL: http://codereview.chromium.org/536038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36096 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Add favicons to task manager.thakis@chromium.org2010-01-131-2/+2
| | | | | | | | | | | | | Pull NSImage cache out of search engine dialog into its own class, reuse that. Implement browser icon code in task_manager_resource_provider's browser resource provider. BUG=13156 TEST=Open task manager. You should see icons. Open search engine manager, should still show icons. Review URL: http://codereview.chromium.org/549021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36087 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35888 - Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-2/+2
| | | | | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Next try: Submitting to get perf numbers, will revert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883 Review URL: http://codereview.chromium.org/549002 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/536009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35890 0039d316-1c4b-4281-b951-d872f2087c98
* Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-2/+2
| | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proof-of-concept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Next try: Submitting to get perf numbers, will revert. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=35883 Review URL: http://codereview.chromium.org/549002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35888 0039d316-1c4b-4281-b951-d872f2087c98
* Revert 35883 - Mac: Other approach for IPCing child task_ts.thakis@chromium.org2010-01-101-2/+2
| | | | | | | | | | | | | | | Based on http://www.foldr.org/~michaelw/log/2009/03/13/ , right now in proofofconcept quality. Works for worker processes too and seems more reliable in general. Makes it impossible to call LaunchApp() concurrently though. Submitting to get perf numbers, will revert. Review URL: http://codereview.chromium.org/549002 TBR=thakis@chromium.org Review URL: http://codereview.chromium.org/544004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@35884 0039d316-1c4b-4281-b951-d872f2087c98
generated by cgit v1.1 at 2025-03-28 21:59:15 +0000