summaryrefslogtreecommitdiffstats
path: root/chrome/browser/browser.h
Commit message (Collapse)AuthorAgeFilesLines
* DevTools: Toggle docked devtools window on shortcut.pfeldman@chromium.org2009-07-131-1/+1
| | | | | | Review URL: http://codereview.chromium.org/149527 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20479 0039d316-1c4b-4281-b951-d872f2087c98
* Convert some stuff to string16 so the toolkit_views build can build againben@chromium.org2009-07-101-2/+2
| | | | | | Review URL: http://codereview.chromium.org/155334 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20342 0039d316-1c4b-4281-b951-d872f2087c98
* Replace instances of LINUX2 with OS_CHROMEOS and linux2 with chromeos.brettw@chromium.org2009-07-081-1/+1
| | | | | | Review URL: http://codereview.chromium.org/149367 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20210 0039d316-1c4b-4281-b951-d872f2087c98
* Basics of a new TabStrip.It's very, very rough, but I wanted to check it in ↵ben@chromium.org2009-07-071-0/+3
| | | | | | | | so I don't have to keep typing svn pset as I pass patches back and forth between machines.Behind a command line flag --enable-tabtastic2.I'm trying to split the TabContents specific stuff off of the TabStrip so it's more generic (and more easily mocked for unit testing of various layout conditions). Hence TabStrip vs. BrowserTabStrip. TabStrip may move into views/ once this process is complete.Animator is a utility that can be associated with a View that (at this point) animates that View's bounds from wherever it is now to somewhere else. The TabStrip uses this to do animations for individual Tabs that are independent of each other - a limitation of the old TabStrip is that only one animation is ever active at a time so its animations are a little jumpy compared to other products.Also, detached tab dragging shows the live contents, with all animations/video/etc.Like I said, this is really rough, but I didn't want it to grow any bigger. I will write up a design doc later.http://crbug.com/9032TEST=TBD... will finally be doing some for TabStrip layout! Review URL: http://codereview.chromium.org/42490 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20053 0039d316-1c4b-4281-b951-d872f2087c98
* Adds a couple of keybindings.sky@chromium.org2009-07-071-0/+3
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/155103 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20027 0039d316-1c4b-4281-b951-d872f2087c98
* In this episode, we implement the DOMUI interface for extension views that ↵aa@chromium.org2009-07-011-11/+1
| | | | | | | | | | are rendered in the main tab contents area. This gets us loaded and unloaded at the right place and removes many special cases for extensions from the RenderViewHost and RenderViewHostDelegate hierarchy. BUG=13936 Review URL: http://codereview.chromium.org/126137 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19717 0039d316-1c4b-4281-b951-d872f2087c98
* DevTools: Nuke legacy debugger.pfeldman@chromium.org2009-06-241-4/+0
| | | | | | Review URL: http://codereview.chromium.org/146027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19108 0039d316-1c4b-4281-b951-d872f2087c98
* Rejiggers the keyword editor so that the UI is independent of the model ↵ben@chromium.org2009-06-231-10/+8
| | | | | | | | | | | rather than being derived from it. This reduces the spaghetti somewhat. Also decouples the notion of a native view hierarchy from the location in TabContents::PageHasOSDD where the template URL fetcher is spawned. The Template URL Fetcher now simply retains a reference to the TabContents that created it. If the TabContents is destroyed before the fetch completes, we just discard the data retrieved without adding a keyword. BUG=none TEST=none Review URL: http://codereview.chromium.org/140054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@19003 0039d316-1c4b-4281-b951-d872f2087c98
* Implement restoring closed tab menu item. Reworked cross-platform code to ↵pinkerton@chromium.org2009-06-191-0/+3
| | | | | | | | | | handle the case of restoring when there are no browsers open by making window restore re-use a given browser if it has no tabs. Removed unit test that assumes it can pass a NULL Browser. Wrote a new UI test to cover the same area, but it's disabled until another bug is fixed, and I didn't want to hold up landing this feature. Added key shortcut for "open window in incognito mode". BUG=13758 TEST=restoring closed tabs with visible windows and with no windows remaining open. Review URL: http://codereview.chromium.org/125257 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18806 0039d316-1c4b-4281-b951-d872f2087c98
* Reduce header dependencies in browser/phajdan.jr@chromium.org2009-06-131-18/+9
| | | | | | | | | | | | - remove unneeded header includes - move implementation bits out of headers - more explicit header deps In my scan of headers I got up to (including) dom_ui. Review URL: http://codereview.chromium.org/126071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18353 0039d316-1c4b-4281-b951-d872f2087c98
* Changing the focus manager to not subclass HWNDs (but for the ↵jcampan@chromium.org2009-06-121-0/+1
| | | | | | | | top-windows).Components that have HWND now need to specifically let the FocusManager know when they get the native focus.This is the reason for the new GotFocus() notification on the RenderWidgetHostViewWin class.BUG=NoneTEST=Run the interactive tests, the unit-tests. Test that the focus is remembered correctly when switching windows, switching tabs. Test that focus traversal in the browser and in the option dialog works as expected. Review URL: http://codereview.chromium.org/122002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@18301 0039d316-1c4b-4281-b951-d872f2087c98
* Remove a bunch of #ifs in browser.h and browser.cc. These methods compiletc@google.com2009-06-051-8/+0
| | | | | | | | | | | fine on linux/mac. I disabled the ones that crash right now. Most of the methods just call into browser_window_{gtk,cocoa} and hit a NOTIMPLEMENTED. Review URL: http://codereview.chromium.org/119217 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17786 0039d316-1c4b-4281-b951-d872f2087c98
* Move download shelf from per-tab to per-window. Also disable auto-hiding ofthakis@chromium.org2009-06-041-1/+3
| | | | | | | | | | | | | | the shelf. BUG=9025 TEST=Download file in one tab, open new tab, and check that download shelf is still open. Also try the shelf's close button and the "show all downloads" link. When saving a file, the download animation should not show up. Review URL: http://codereview.chromium.org/115740 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17595 0039d316-1c4b-4281-b951-d872f2087c98
* Headers cleanup in chrome/browser/phajdan.jr@chromium.org2009-06-031-4/+2
| | | | | | | | | | | - reduce header dependencies - miscellanous cleanups (add missing includes for OS_ defines etc) Further changesets may follow. I was only looking at header files up to character_encoding.h. Review URL: http://codereview.chromium.org/118072 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17470 0039d316-1c4b-4281-b951-d872f2087c98
* Pasted links opened with alt-enter were opened next to the current tab ↵pkasting@chromium.org2009-06-021-15/+29
| | | | | | | | instead of at the end of the strip. This was because the LINK transition type triggered the TabStripModel to apply heuristics about where to open the URL, even though all URLs opened from the address bar should bypass these heuristics. There were already hooks on the low-level functions to bypass the heuristics, I just had to expose them one level higher. This meant an expansion to one of the TabContentsDelegate function's argument list, hence the number of files touched. (This seems like a good capability to expose anyway, though.)BUG=6797TEST=Have multiple tabs in your tab strip. Select the first tab, paste in a URL, and hit alt-enter. The newly opened tab should appear at the far end of the strip. Review URL: http://codereview.chromium.org/118038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17432 0039d316-1c4b-4281-b951-d872f2087c98
* Revert the Omnibox when changing tabs while its contents have been deleted.pkasting@chromium.org2009-05-291-0/+1
| | | | | | | | | To do this, I needed to add a new TabStripModelObserver call that fired before the tab had been changed, since when the Omnibox asks for the current permanent_text_ it gets it from the selected tab's navigation controller. BUG=6850 Review URL: http://codereview.chromium.org/113983 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17241 0039d316-1c4b-4281-b951-d872f2087c98
* Implement Clear Browser Data for Mac as an app modal dialog. Uses the ↵pinkerton@chromium.org2009-05-291-2/+0
| | | | | | | | | | profile of the given window or the default profile if run with no windows open. Add a setter to the throbber so it can be used in a nib file. BUG=none TEST=clear browser functionality (note that clearing passwords doesn't work) and checkbox persistance. Review URL: http://codereview.chromium.org/112065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17186 0039d316-1c4b-4281-b951-d872f2087c98
* This fixes the problem of the status bubble obscuring the download shelf.mirandac@chromium.org2009-05-271-0/+1
| | | | | | | | | | | | | BUG= http://crbug.com/6590 TEST=Cause the download shelf to appear by initiating a download. Hover over a link in the extreme lower left corner of the browser window. The status bubble should avoid your mouse by moving to the right, instead of moving down and obscuring the download shelf. Review URL: http://codereview.chromium.org/113671 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17025 0039d316-1c4b-4281-b951-d872f2087c98
* Remove the last bits leftover from my frame window experiment.brettw@chromium.org2009-05-261-1/+1
| | | | | | Review URL: http://codereview.chromium.org/113863 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16930 0039d316-1c4b-4281-b951-d872f2087c98
* Use a NotificationRegistrar to listen for notifications.pkasting@chromium.org2009-05-221-1/+3
| | | | | | | BUG=2381 Review URL: http://codereview.chromium.org/115673 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16777 0039d316-1c4b-4281-b951-d872f2087c98
* Move a bunch of dialog creation routines to browser_dialogs.h to break thebrettw@chromium.org2009-05-221-2/+2
| | | | | | | | | | | | | | dependency on the implementations of those views. This also moves that file into the browser:: namespace to avoid having all the functions in the global namespace. Rename the "parent" parameter to ShowHTMLDialog to a NativeWindow type to avoid nasty casting. I assume this argument was written before we had NativeWindow. Review URL: http://codereview.chromium.org/113728 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16743 0039d316-1c4b-4281-b951-d872f2087c98
* Implement clear browsing data dialog in linuxevan@chromium.org2009-05-221-2/+0
| | | | | | | | | | | | As well, refactored code on the windows side to reuse some functionality for the deletion range specified by its time period. BUG=11192 (http://crbug.com/11192) TEST=Looks pretty Review URL: http://codereview.chromium.org/113558 Patch from Mohamed Mansour <m0.interactive@gmail.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16694 0039d316-1c4b-4281-b951-d872f2087c98
* Linux: Take download shelf and infobar close animations into account during ↵estade@chromium.org2009-05-151-0/+1
| | | | | | | | | | render view sizing. http://crbug.com/11080 Review URL: http://codereview.chromium.org/113322 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16193 0039d316-1c4b-4281-b951-d872f2087c98
* Add GTK options window (no options actually configurable yet.)evan@chromium.org2009-05-141-0/+2
| | | | | | | | | BUG=11507 Review URL: http://codereview.chromium.org/113377 Patch from Matt Mueller <mattm@google.com>. git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16023 0039d316-1c4b-4281-b951-d872f2087c98
* This CL updates chrome to the latest version of skia, retrieved via DEPS, andsenorblanco@chromium.org2009-05-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | placed in third_party. All relevant skia changes (for all 3 platforms) have been upstreamed. Most of this CL is mind-numbingly repetitive. Things of interest are: skia.gyp (now points at third_party versions), DEPS, and SkUserConfig.h. stdint.h: Skia now requires C99 integer types, which MSVC doesn't support natively. I have put typedefs in config/win/stdint.h. Note that the new version of skia appears to render rects whose coordinates are "backwards" (ie., x2 < x1 or y2 < y1), which were formerly culled. There were a couple obvious instances of this in the code which I fixed, but there may be more. There were ~35 layout test failures due to minor pixel differences which I rebaselined on Windows and Linux, and 8 genuine failures related to masks and stroked text, which I have put in text_expectations.txt and assigned to myself. (There was another change which broke ~1700 tests on each platform, but I put that change behind an #ifdef for now). R=brettw Review URL: http://codereview.chromium.org/65012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15949 0039d316-1c4b-4281-b951-d872f2087c98
* Add import settings dialog on linux.kuchhal@chromium.org2009-05-111-1/+3
| | | | | | | | | | BUG=11191 TEST=Open Import Settings dialog from Chrome wrench menu on Linux and make sure it imports Firefox data as selected. Review URL: http://codereview.chromium.org/115133 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15815 0039d316-1c4b-4281-b951-d872f2087c98
* Various popup UI fixes:pkasting@chromium.org2009-05-081-0/+1
| | | | | | | | | | | | | * Remove "show popup notification" option, pref, and all associated machinery. * Toggling whitelisting on for a site no longer hides the "manage" button. * Toggling whitelisting off for a site re-blocks (not closes) its popups, and does not hide the "manage" button. Also rips the whitelist hooks out of TabContents in preparation for getting the whitelist values directly from the BlockedPopupContainer, since there was no reason to plumb everything through TabContents. BUG=11440 Review URL: http://codereview.chromium.org/115112 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15670 0039d316-1c4b-4281-b951-d872f2087c98
* Make background pages work more nicely with the tabs API.aa@chromium.org2009-05-071-1/+8
| | | | | | | | | | | | | | | Changed ExtensionHost so that it returns NULL if it doesn't have a browser, instead of getting the last active one. The problem is that if ExtensionHost returns the last active browser at the time it's constructed, it might be garbage by the time it is used. Changed tab functions to use more consistent logic to determine the 'current' browser to operate on. Review URL: http://codereview.chromium.org/115071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15587 0039d316-1c4b-4281-b951-d872f2087c98
* Create a separate UI surface for extensions (bottom shelf) and remove them ↵erikkay@google.com2009-05-061-1/+2
| | | | | | | | | | | | | | from the bookmarks bar (for now). The current implementation doesn't do anything new except for always appear when extensions are loaded. TEST=install an extension and see it show up in the new bottom bar TEST=unit_tests.exe --gtest_filter=ExtensionViewTest.BottomBar Review URL: http://codereview.chromium.org/112001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15417 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 15399.maruel@chromium.org2009-05-061-2/+2
| | | | | | | broke purify Review URL: http://codereview.chromium.org/115026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15409 0039d316-1c4b-4281-b951-d872f2087c98
* Change Browser::GetIndexOfController to GetIndexOfTabContents. Now that webrettw@chromium.org2009-05-061-2/+2
| | | | | | | | don't have tab contents switching, identifying tabs by their controller is weird, so we should gradually move to only using TabContents*. Review URL: http://codereview.chromium.org/115018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15399 0039d316-1c4b-4281-b951-d872f2087c98
* honor index in createTab()rafaelw@chromium.org2009-05-061-2/+4
| | | | | | | | | BUG=11200 R=brettw,beng Review URL: http://codereview.chromium.org/99300 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15392 0039d316-1c4b-4281-b951-d872f2087c98
* Merge two TabContents::InvalidateTypes types and properly update tab ↵estade@chromium.org2009-05-061-1/+0
| | | | | | | | | | | | download icon. INVALIDATE_FAVICON and INVALIDATE_TITLE become INVALIDATE_TAB. Also removed some dead code. TEST=starting a download in a tab should show the download icon. Closing the dshelf should make the icon disappear. Review URL: http://codereview.chromium.org/109050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15387 0039d316-1c4b-4281-b951-d872f2087c98
* Relanding this, it was missing the Mac unit-test change, that was breaking ↵jcampan@chromium.org2009-04-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | the build. TBR=ben Closing the last tab with a download in-progress would cause the tab to be closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/100210 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14952 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14948.jcampan@chromium.org2009-04-301-1/+0
| | | | | | | | | Broke the Mac build. TBR=ben Review URL: http://codereview.chromium.org/99224 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14949 0039d316-1c4b-4281-b951-d872f2087c98
* Closing the last tab with a download in-progress would cause the tab to bejcampan@chromium.org2009-04-301-0/+1
| | | | | | | | | | | | | | | | | | | | | | | closed and become unusable if the user decides not to proceed with the browser shutdown. This is because we check for in-progress downloads when the browser is closed, and the tab is closed before that, leaving the tab-strip in a bad state. This CL ensures we also bring-up the confirmation dialog when the last tab is closed. BUG=10680 TEST=Start downloading a big file. While the file is downloading, close all tabs. When closing the last tab, the in-progress download dialog should be shown. Select the 'Wait for downloads', the download tab should be shown and the previous tab should still be displayed and functional. Close all tabs again, this time select the 'Close and cancel downloads' option, the browser should be closed. Review URL: http://codereview.chromium.org/99195 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14948 0039d316-1c4b-4281-b951-d872f2087c98
* Implement tabs.createWindow extension api call. Required: (a) new ↵rafaelw@chromium.org2009-04-281-0/+3
| | | | | | | | | | | RVHDelegate & TabContentsDelegate method(s) CreateExtensionFunctionDispatcher() so that the dispatcher could be created with (an optional) browser attached to it, while avoiding having render_host depend on browser.h BUG=11092: R=aa,mpComplete,darin,pkasting Review URL: http://codereview.chromium.org/79070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14710 0039d316-1c4b-4281-b951-d872f2087c98
* Now that we have file dialogs, we might as well hook up "Open File" on the Mac.avi@google.com2009-04-271-2/+0
| | | | | | Review URL: http://codereview.chromium.org/93145 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14625 0039d316-1c4b-4281-b951-d872f2087c98
* Create an about dialog for GTK Chromium.erg@google.com2009-04-241-1/+1
| | | | | | Review URL: http://codereview.chromium.org/93128 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14462 0039d316-1c4b-4281-b951-d872f2087c98
* Move Browser implementation of callback interfaces into the private section.stoyan@chromium.org2009-04-231-9/+39
| | | | | | | Split TabContentsDelegate and PageNavigator. Review URL: http://codereview.chromium.org/88063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14375 0039d316-1c4b-4281-b951-d872f2087c98
* Re-land my change to clean up TabContents/WebContents ownership. Thisbrettw@chromium.org2009-04-201-15/+12
| | | | | | | | | | | | | | | | | | | | | | | | is the same except in tab_strip_model_unittest I fixed a leak by making a WebContents on the stack, I added a factory to the SiteInstance unittest to prevent another leak, and I re-added a NULL set to the external_tab_container. Fix the ownership model of TabContents and NavigationController. Previously the NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Previous review URL: http://codereview.chromium.org/69043 Review URL: http://codereview.chromium.org/67294 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14053 0039d316-1c4b-4281-b951-d872f2087c98
* Reverting 14005.brettw@chromium.org2009-04-181-12/+15
| | | | git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14006 0039d316-1c4b-4281-b951-d872f2087c98
* Fix the ownership model of TabContents and NavigationController. Previously thebrettw@chromium.org2009-04-181-15/+12
| | | | | | | | | | | | | | | | | NavigationController owned the TabContents, and there were extra steps required at creation and destruction to clean everything up properly. NavigationController is now a member of TabContents, and there is no setup or tear down necessary other than the constructor and destructor. I could remove the tab contents creation in the NavigationController, as well as all the weird destruction code in WebContents which got moved to the destructor. I made the controller getter return a reference since the ownership is clear and there is no possibility of NULL. This required changing a lot of tiles, but many of them were simplified since they no longer have to NULL check. Review URL: http://codereview.chromium.org/69043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14005 0039d316-1c4b-4281-b951-d872f2087c98
* Makes SupportsFeature virtual and adds a virtual destructor to Browser.sky@chromium.org2009-04-171-2/+2
| | | | | | | | | BUG=none TEST=none Review URL: http://codereview.chromium.org/69022 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13931 0039d316-1c4b-4281-b951-d872f2087c98
* Make Browser::set_window defined all the time, and adds the ability tosky@chromium.org2009-04-161-1/+3
| | | | | | | | | | | set the non client frame view. BUG=none TEST=none Review URL: http://codereview.chromium.org/67236 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13890 0039d316-1c4b-4281-b951-d872f2087c98
* Remove TabContnetsType from everywhere.brettw@chromium.org2009-04-151-1/+0
| | | | | | | | I also removed the notion of the "active" tab contents since there is only one per tab now, and all the messages to replace them. Review URL: http://codereview.chromium.org/67173 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13808 0039d316-1c4b-4281-b951-d872f2087c98
* Fix regression I introduced where Stop/Go button would toggle state ↵pkasting@chromium.org2009-04-151-3/+4
| | | | | | | | | | | instantly instead of having protections against accidental user actions while the mouse was hovering the button. I elected to condense ChangeMode() and ScheduleChangeMode() into one function, which as a result became pretty simple. BUG=9843 Review URL: http://codereview.chromium.org/67156 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13761 0039d316-1c4b-4281-b951-d872f2087c98
* Add a Cocoa file picker.avi@google.com2009-04-141-9/+1
| | | | | | Review URL: http://codereview.chromium.org/73044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13695 0039d316-1c4b-4281-b951-d872f2087c98
* Added undo tab closing item to Tab menu.idanan@chromium.org2009-04-141-0/+3
| | | | | | Review URL: http://codereview.chromium.org/62151 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13662 0039d316-1c4b-4281-b951-d872f2087c98
* This CL adds a confirmation box when closing the browser with in-progress ↵jcampan@chromium.org2009-04-091-0/+28
| | | | | | | | | | downloads. BUG=1028 TEST=Start several bug downloads, close the browser. A dialog shows up to warn you are about to lose the downloads. Try the wait and continue button. Try again with several windows, and in Incognito mode. Review URL: http://codereview.chromium.org/62131 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13453 0039d316-1c4b-4281-b951-d872f2087c98