| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
Review URL: http://codereview.chromium.org/3742002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62475 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7617
TEST=open chrome:settings, select cellular plan options, observer payment info being displayed at the top
Review URL: http://codereview.chromium.org/3762001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
BUG=58772
TEST=make sure that there is an entry in prefs for instant. See that
it works.
Review URL: http://codereview.chromium.org/3726002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62250 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Document with the dialog: http://sites.google.com/a/chromium.org/dev/developers/design-documents/chromium-search-provider-js-support
BUG=38475
TEST=Used a custom html page which calls window.external.AddSearchProvider(url, true).
Review URL: http://codereview.chromium.org/3673002
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62199 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Refactor Browser::BuildPopupWindow as Browser::CreatePopupWindow
and call it from ExtensionHost::ShowCreatedWindow.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=7243
TEST=Test popup windows in general. See issue for specific test case.
Review URL: http://codereview.chromium.org/3532011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61657 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=chromium-os:7336
TEST=see bug
Review URL: http://codereview.chromium.org/3620004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61628 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
contain any changes other than renaming/moving, as such I'm TBRing.
BUG=54833
TEST=none
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3602015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61553 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
- Browser::AddSelectedTabWithURL(const GURL& url, PageTransition::Type transition)
-> A good many callsites just wanted a way to open a tab somewhere and select it.
- Browser::AddTabWithURL(AddTabWithURLParams* params)
-> For the callsites with specialized needs, this new signature allows the parameter set to change as features are added without having to update a bunch of callers every time.
BUG=none
TEST=existing unit tests
Review URL: http://codereview.chromium.org/3599006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61517 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
necessitated by needing to hold off on showing instant results until I
know if the server really supports instant.
This change is mostly refactoring to enable this. Most of what was
MatchPreview has been moved into MatchPreviewLoader. LoaderManager is
used to determine which MatchPreviewLoader to use as well as keeping
around a cache of them. MatchPreview for the most part delegates to
LoaderManager and MatchPreviewLoader now.
I'll rename all these classes to instant (and move into its own
directory) next.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3541008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61441 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Move size based disposition override for ChromeOS from tab_container to browser.
* TYPE_APP_PANEL |= TYPE_POPUP so that special popup behavior applies to panels.
* Removed confusing BrowserFrameChromeos::IsPanel(), replaced with BrowserView::IsBrowserTypePopup() calls.
* Replaced now redundant checks against panel or popup types with 'browser->type() & Browser::TYPE_POPUP'.
* Added size limiting code to PanelBrowserView.
* Modified CreateWindowFunction::RunImpl() to create TYPE_APP_POPUP windows instead of TYPE_POPUP.
BUG=http://code.google.com/p/chromium-os/issues/detail?id=5166
TEST=Test spawning popups/panels/tabs from web pages (e.g. gmail), extensions (e.g. chat manager), and apps
More info: https://docs.google.com/document/edit?id=14nBjW6gHJW0kk44o8Z8vfDSnDi0ZT1sUU74Zc5wmwIQ&hl=en&authkey=CKT6-O8I
!!! This commit didn't go through !!! Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29fe99e
Review URL: http://codereview.chromium.org/3449007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61427 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=53617
TEST=see bug
Review URL: http://codereview.chromium.org/3550007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61311 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Make Chrome refuse to print if the preference kPrintingEnabled is set to false. In this case, the 'Print...' option in the wrench menu is disabled, and if printing is invoked from JavaScript, then Chrome reports that no printer is installed.
Changes to this preference after startup are also respected.
BUG=54380
TEST=manual
Review URL: http://codereview.chromium.org/3357011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61222 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
rest of Chrome. Allows plugins to have different zoom ranges, and also to update zoom on its own.
Review URL: http://codereview.chromium.org/3419023
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@61153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
| |
Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it.
BUG=none
TEST=existing unittests.
Review URL: http://codereview.chromium.org/3412041
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60860 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
from TabStripModel API.
Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it.
BUG=none
TEST=existing unittests.
Review URL: http://codereview.chromium.org/3447033
TBR=ben@chromium.org
Review URL: http://codereview.chromium.org/3423028
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60824 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Currently it's just a pass-through so everything still works while I begin to move stuff out of Browser down into it.
BUG=none
TEST=existing unittests.
Review URL: http://codereview.chromium.org/3447033
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60821 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
setup flow dialog modeless. Added a delegate to CloudPrintSetupFlow. Hooked up the expired token notifications handler to the CloudPrintSetupFlow dialog.
BUG=None
TEST=Test Cloud print proxy UI.
Review URL: http://codereview.chromium.org/3433027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60814 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3415026
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60692 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Based in the Under-the-Hood section of options, this UI allows mere mortals to turn on and off the cloud print proxy. Currently working on Windows only, behind a flag.
BUG=none
TEST=Open up the options, turn CPP on and off.
Review URL: http://codereview.chromium.org/3450021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60684 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
results. Also tweaks the delegate interface to be a bit more sensical.
BUG=54833
TEST=see bug
Review URL: http://codereview.chromium.org/3440025
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60479 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=55943
TEST=Manual.
Review URL: http://codereview.chromium.org/3418027
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60476 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3417011
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60153 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3425009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59733 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This makes browser.h not depend on extension.h.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3399008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59588 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
. Makes MatchPreview owned by Browser rather than each TabContents.
. Makes MatchPreview dismiss when the omnibox closes.
. Supports the ability to send script to the page rather than
reloading on every keystroke.
. Supports receiving results from the page that drives the suggest
text in the omnbox.
BUG=54833
TEST=none
Review URL: http://codereview.chromium.org/3332022
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59428 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
| |
BUG=54903
TEST=block cookies, go to almost any site, click little cookie in omnibox, manage cookies
Review URL: http://codereview.chromium.org/3323021
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59422 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Apparently the session storage code was pretty horribly broken. It didn't correctly handle tabs being restored, didn't have the proper lifetime (this was the issue exposed in the bug), and had many leaks.
To fix this, things had to be plumbed fairly differently. We need to pass session storage in on TabContents creation to ensure that the first RenderView will have the correct session storage id. When closing a tab, we need to save the session storage with the restoration service. When restoring a tab, we pass it back into the tab contents class. When duplicating a tab, we clone the storage.
Lifetimes are now handled by standard reference counting code. A SessionStorageNamespace object wraps an ID. When it's instantiated, it allocates an ID. When it's destroyed, it deletes the ID. IDs make this process very lightweight (the heavyweight stuff is allocated on first use of SessionStorage) and it seperates the more complex lifetimes of SessionStorage namespaces (where less deterministic shutdown is more tollerable) from the LocalStorage namespace which needs to shutdown very precisely.
BUG=52393
TEST=Set some variable on session storage; close the tab; re-open the tab; the variable should still be set. You can also run through the repro steps in the bug.
Review URL: http://codereview.chromium.org/3325012
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59350 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means browser.h no longer includes a large chunk of the tab restore
system. Now with fixes to chromeos.
BUG=none
TEST=compiles
First Review URL: http://codereview.chromium.org/3296003
Review URL: http://codereview.chromium.org/3358005
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58382 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to
chromeos compile fail.
TBR=akalin
Review URL: http://codereview.chromium.org/3340007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58271 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
This means browser.h no longer includes a large chunk of the tab restore
system.
BUG=none
TEST=compiles
Review URL: http://codereview.chromium.org/3296003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58256 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Patch contributed by Hajime Morita <morrita@google.com>.
Original review URL: http://codereview.chromium.org/3217007
BUG=23547
TEST=manual
Review URL: http://codereview.chromium.org/3225009
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58141 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
And now it seems to handle more automation messages than the original one.
TEST=ui_tests, chrome_frame_tests
BUG=52097
Review URL: http://codereview.chromium.org/3185030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57550 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
the HistoryAddPageArgs so that they can be cached and used later
on. Refactors some other code that interacts with history so that it
can be called separately as well.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3158029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57458 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Rename includes, resort header include order in places where the rename
changed the order.
BUG=50548
TEST=compiles
Review URL: http://codereview.chromium.org/3203008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57434 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Making window.focus()/blur() work only when there is a user gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
TBR=darin,sky
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3174030
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57124 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
gesture.
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/3201008
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57105 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also making window.focus() select tab if it is not visible.
The RenderViewHost now calls ActivateContent and the new DeactivateContent (instead of using the recently added TabContentsDelegate::Activate/Deactivate methods which have been removed).
BUG=29643,52346
TEST=Create a page with buttons that call window.focus()/blur() directly and with a timeout. When called directly, the calls should succeed (the browser should be activated/deactivated). When called with a timeout, nothing should happen. Also test that a popup calling window.opener.focus() cause the opening tab to become selected when it is not the current tab.
Review URL: http://codereview.chromium.org/3156016
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57094 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
targetting app tabs. I futzed with this a bit to try and
integrate installed apps extents, but it is complex.
Also, I looked over the original bug where this code was
added: crbug.com/29281. The issue there was that when you
click on a bookmark (presumably in the bookmark bar) the
pinned tab is unexpectedly overwritten. I can see that
complaint, but there is also the use case of clicking
a bookmark and intending it to overwrite the pinned tab.
In summary, I kinda feel like the expectations about
how navigation should work are too ingrained and we
shouldn't be meddling.
BUG=52680
Review URL: http://codereview.chromium.org/3161037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57002 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
| |
TBR=rafaelw@chromium.org
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56907 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
| |
changes have already been removed.
Review URL: http://codereview.chromium.org/3149029
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56902 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
switch and display the new DOM UI when it's used.
BUG=chromium-os:5522
TEST=make sure the new DOM UI option tab opens from status bar drop down menues (language, internet and system settings)
Review URL: http://codereview.chromium.org/3142020
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56816 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51084
TEST=Run interactive_ui_tests and browser_tests.
New:
- sidebar Extension API (design doc: https://docs.google.com/a/google.com/Doc?docid=0AV4Qg3xyZ8RQZGZtbWIydDJfNWc0eHJtbmRm&hl=en);
- Sidebar panel in Chrome browser view;
Original review=http://codereview.chromium.org/2836040/show
Patch by alekseys@google.com
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56716 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
http://codereview.chromium.org/2941001
Initial submit broke the chromeos build. This patch includes the original change, and fixes to compile ChromeOs properly.
BUG=None
TEST=None
Review URL: http://codereview.chromium.org/2819086
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55951 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
BUG=51703
BUG=30178
BUG=25106
TEST=none
Review URL: http://codereview.chromium.org/3129003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55921 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
pranvak@ is OOO so I'm submitting for him.
This patch will add a menu in wrench menu to start the chromoting
setup flow.
Submit for: pranvak@chromium.org
Reviewed: http://codereview.chromium.org/3075024/show
Review URL: http://codereview.chromium.org/3134003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55815 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
A patch on the WebKit side https://bugs.webkit.org/show_bug.cgi?id=43542
ensures we get the correct notification when window.focus()/blur() is called.
This CL makes the browser active/unactive in response to the focus/blur message.
BUG=29643
TEST=Visit gmail. Open an IM conversation window and pop-it out.
Focus the browser (so the IM window is in the back). Click on the person name in the IM section of gmail.
The conversation window should be brought back to the front.
Repeat but this time minimize the conversation window.
Review URL: http://codereview.chromium.org/3060045
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55678 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
| |
flag --enable-match-preview. There is still a lot of details to get it
working good enough, but this is a good point to check some stuff in.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3105004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55665 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
Much remains to be converted.
BUG=23581
TEST=builds and passes tests
Review URL: http://codereview.chromium.org/3076037
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55660 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
| |
so only one can be opened, and making it so that it expands on getting a new download.
BUG=chromium-os:4995
TEST=verify that all the above happens (tested on device)
Review URL: http://codereview.chromium.org/3094001
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55601 0039d316-1c4b-4281-b951-d872f2087c98
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Added a method to get the next node ID for bookmarks managed by the bookmark
model.
Added AppleScript support.
Added scripting definition file.
Added support for saving tab.
Added localization support.
Added consistent error nos/error messages.
(patch developed by v.a.shreyas@gmail.com)
BUG=27468
TEST=none
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55569 0039d316-1c4b-4281-b951-d872f2087c98
|